[tin 1.7.x] new snapshots

new snapshots at the usual place:
<ftp://ftp.tin.org/pub/news/clients/tin/unstable/snapshots/≥

only one change worth mentioning: Michael rewrote the keymap-rebinding
code. this needs some testing (any keys no longer working?).

urs
--

-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus

[tin 1.7.x] various fixes for the new keymap code

- 'o' print article was broken
- nrctbl.c keys didn't work
- THREAD_AUTOSELECT was disabled (instead of THREAD_KILL, which has
  the cursor-position problems).

-----------------------------------------------------------------------------
 Makefile          |    2 +-
 doc/CHANGES       |    5 +++--
 doc/TODO          |   11 +++++++++--
 doc/keymap.sample |    9 +--------
 doc/tin.5         |   11 +++--------
 include/keymap.h  |    7 +------
 include/version.h |    4 ++--
 src/feed.c        |    4 +++-
 src/keymap.c      |   36 +-----------------------------------
 src/nrctbl.c      |   29 +++++++++++++----------------
 src/thread.c      |   14 +++++---------
 src/version.c     |    7 +++++--
 12 files changed, 47 insertions(+), 92 deletions(-)
-----------------------------------------------------------------------------
diff -Nurp tin-1.7.8.snap/Makefile tin-1.7.8/Makefile
--- tin-1.7.8.snap/Makefile	2005-02-01 17:19:29.000000000 +0100
+++ tin-1.7.8/Makefile	2005-02-04 15:56:52.000000000 +0100
 <at>  <at>  -9,7 +9,7  <at>  <at>  LVER	= 1
 PVER	= 7
 SVER	= 8
 VER	= $(LVER).$(PVER).$(SVER)
-DVER	= 20050201

Re: [tin 1.7.x] various fixes for the new keymap code

On 2005-02-04 16:14:40 +0100, Urs Janßen wrote:
> - 'o' print article was broken
> - nrctbl.c keys didn't work
> - THREAD_AUTOSELECT was disabled (instead of THREAD_KILL, which has
>   the cursor-position problems).

The attached patch enables to rebind THREAD_AUTOSELECT through
ThreadAutoSel and adds ThreadKill and ThreadAutoSel to doc/tin.5

Michael

 doc/keymap.sample |    1 +
 doc/tin.5         |    2 ++
 src/keymap.c      |    5 +++++
 src/version.c     |    6 +++---
 4 files changed, 11 insertions(+), 3 deletions(-)
diff -Nurp tin-1.7.8/doc/keymap.sample tin-1.7.8.new/doc/keymap.sample
--- tin-1.7.8/doc/keymap.sample	2005-02-04 17:12:49.697608442 +0100
+++ tin-1.7.8.new/doc/keymap.sample	2005-02-04 17:31:46.476037835 +0100
 <at>  <at>  -240,6 +240,7  <at>  <at>  SelectMarkGrpUnread		z
 #####

 ThreadReadNextArtOrThread	TAB
+ThreadAutoSel			^A
 ThreadReadArt			^J
 ThreadKill			^K
 ThreadReadArt2			^M
diff -Nurp tin-1.7.8/doc/tin.5 tin-1.7.8.new/doc/tin.5
--- tin-1.7.8/doc/tin.5	2005-02-04 17:12:49.703607391 +0100

Re: Bug#293978: tin does not work with news.mozilla.org (freeze at the beginning)

On Mon, Feb 07, 2005 at 11:16:38AM +0100, Vincent Lefevre wrote:
> I've created an entry
> news.mozilla.org                .newsrc-mozilla mozilla
> in my .tin/newsrctable file. But "tin -ag mozilla" gives:
> 
> tin 1.7.6 release 20040906 ("Baleshare") [UNIX] (c) Copyright 1991-2004 Iain Lea.
> secnews.netscape.com Netscape-Collabra/3.52 03615 NNRP ready (posting ok).
> Your server does not have Xref: in its XOVER information.

there are several problems with that server, the first one is that the
Netscape-Collabra/3.52 server responbds with a different returncode
to a "list extensions" than e.g. inn does.

[Netscape]
| 215 Extensions supported by server.
| SEARCH
| SETGET
| OVER
| XPATTEXT
| XACTIVE
| LISTMOTD
| LISTSUBSCR
| LISTPNAMES
| .

[inn]
| 202 Supported NNTP extensions.
| AUTHINFO USER
| LISTGROUP
| .

Re: Bug#293978: tin does not work with news.mozilla.org (freeze at the beginning)

On 2005-02-07 14:32:47 +0100, Urs Janßen wrote:
> > Tin will try to use XHDR XREF instead (slows down things a bit).
> > Reading keymap file...
> > Reading input history file...
> > Reading mail active file... 
> > Try and save newsrc file again? (Y/n) Y
> > 
> > Then tin freezes.
> 
> for me (but this is with the lastest spanshot) it still accepts the 'n'
> answer. I didn't had a closer look at the code why it doesn't accept
> 'Y' here.

There is a tolower() missing in prompt.c:229:
	func = key_to_func(tolower(ch), prompt_keys);

Michael

Re: Bug#293978: tin does not work with news.mozilla.org (freeze at the beginning)

On Mon, Feb 07, 2005 at 04:49:21PM +0100, Urs Janßen wrote:
> > > LIST EXTENSION isn't specified by an RFC and it looks like that it
> > > will never be officially implemented (CAPABILITIES might be it's
> > > "replacement"). so officiall we can't blame the netscape server, but
> > > usualy INN is regarded as reference implementation so I'd say that
> > > expecting an 202 answer is the right thing and the server is
> > > 'buggy'. there is still tins problem with unexpected multiline
> > > responses and getting out of sync...
> > OK. However, in the absence of a specification by an RFC, tin should
> > support the Netscape answer.
> there is a draft wich 'defines' the responsecode:
> draft-ietf-nntpext-base-24.txt, section 5.3
> 
> | 5.3  LIST EXTENSIONS
> | 5.3.1  Usage
> |    This command is optional.
> |    Syntax
> |       LIST EXTENSIONS
> |    Responses
> |       202   Extension list follows (multiline)
> |       402   Server has no extensions
> 
> but as mentioned above the command might be replaced with the new
> CAPABILITIES command which might have a different returncode (looks
> like it will be 101 for success as stated in
> draft-ietf-nntpext-authinfo-06.txt and
> draft-ietf-nntpext-streaming-03.txt).

and in the upcomming draft-ietf-nntpext-base-25.txt draft which is not
yet released, but a preview is available at

Re: Bug#293978: tin does not work with news.mozilla.org (freeze at the beginning)

On Thu, Feb 10, 2005 at 02:30:25PM +0100, Urs Janßen wrote:
> anyway, attached is a diff against a plain tin-1.7.7er source which

next try...

urs
-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus

--- tin-1.7.7/src/nntplib.c	2004-11-15 18:44:25.000000000 +0100
+++ tin-1.7.7/src/nntplib.c	2005-02-10 14:17:41.000000000 +0100
 <at>  <at>  -51,7 +51,8  <at>  <at> 
 	static constext *xhdr_cmd = NULL;
 	static constext *xhdr_cmds = "XHDR";
 #	endif /* 0 */
-	static t_bool have_list_extensions = FALSE;
+	enum extension_type { NO, LIST_EXTENSIONS, CAPABILITIES };
+	static int have_list_extensions = NO;
 	/* Set so we don't reconnect just to QUIT */
 	static t_bool quitting = FALSE;
 #endif /* NNTP_ABLE */
 <at>  <at>  -952,14 +953,9  <at>  <at> 

 #ifdef NNTP_ABLE
 /*
- * Try and use LIST EXTENSIONS here. Get this list before issuing
- * other NNTP commands because the correct methods may be
- * mentioned in the list of extensions.

[PATCH] prompt_yn() accepts only keys from prompt_keys

Hello,

the attached patch makes prompt_yn() only accept keys listed in
prompt_keys. By default these are ESC (GLOBAL_ABORT), q (GLOBAL_QUIT),
y, Y (PROMPT_YES), n and N (PROMPT_NO).

IMHO it is a cleaner solution to add the uppercase keys of
PROMPT_{YES,NO} to the list of defined keys than to check for them
seperately in prompt_yn(). Remains the question how should they get
added to the list from a keymap file:
- should the keys for "PromptNo" and "PromptYes" also get added
  automatically as uppercase (current approach)
- or should they get added only when explicitly defined in the keymap
  file?

Changes to prompt_yn():
- accept only keys listed in prompt_keys
- drop the parameter line as it is constant (= cLINES)

Michael

 include/proto.h |    2 +-
 src/feed.c      |    2 +-
 src/group.c     |   18 +++++++++---------
 src/inews.c     |    4 ++--
 src/keymap.c    |   16 ++++++++++++++++
 src/misc.c      |    4 ++--
 src/nntplib.c   |    2 +-
 src/page.c      |    4 ++--

Re: Bug#294802: tin: line-wrap in German filter menu

On Fri, Feb 11, 2005 at 07:02:50PM +0100, Christian Garbs wrote:
> In the German filter menu (scoring for articles) the item
> "Wähle Msg-Id" has four values:
> 
>  * Nur
>  * Nein
>  * Voll
>  * Letzte
> 
> "Letzte" is too long and always wrapped around to the next line,
> regardless of screen width.  It looks to me like 5 characters are
> reserved for the option but 6 are needed.

quick and dirty fix: in filter.c:filter_menu() increase len by 3
(estonian values are even longer), e.g.:
        len = cCOLS - 33;
instead of
        len = cCOLS - 30;

right thing would be some dynamic space calculation depening on the
length of the longest translated value...

urs
--

-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus

Re: [PATCH] prompt_yn() accepts only keys from prompt_keys

On Fri, Feb 11, 2005 at 08:48:01PM +0100, Michael Bienia wrote:
> the attached patch makes prompt_yn() only accept keys listed in
> prompt_keys. By default these are ESC (GLOBAL_ABORT), q (GLOBAL_QUIT),
> y, Y (PROMPT_YES), n and N (PROMPT_NO).
> 
> IMHO it is a cleaner solution to add the uppercase keys of
> PROMPT_{YES,NO} to the list of defined keys than to check for them
> seperately in prompt_yn(). Remains the question how should they get
> added to the list from a keymap file:
> - should the keys for "PromptNo" and "PromptYes" also get added
>   automatically as uppercase (current approach)

sounds ok

> - or should they get added only when explicitly defined in the keymap
>   file?

this would be the cleaner approach, but then we should make
keymap.sample look like:
	PromptYes                       y	Y
	PromptNo                        n	N
and describle the possibillity of multiple keybindings (in tin.5) and
check the rest of the code where we (silently) allow uppercase
answers and ...

urs
--

-- 
"Only whimps use tape backup: _real_ men just upload their important stuff
 on ftp, and let the rest of the world mirror it ;)" - Linus