SourceForge.net | 3 Jun 2009 15:22
Picon
Favicon

[ libssh2-Bugs-2800496 ] libssh2_scp_recv() does not support files >4GB

Bugs item #2800496, was opened at 2009-06-03 13:22
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800496&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_scp_recv() does not support files >4GB

Initial Comment:
Invalid "scpsize_strtol" definition: should test "HAVE_STRTOLL" instead of "strtoll" (see attached patch).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800496&group_id=125852

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
(Continue reading)

SourceForge.net | 3 Jun 2009 15:55
Picon
Favicon

[ libssh2-Bugs-2800519 ] libssh2 library is not thread safe

Bugs item #2800519, was opened at 2009-06-03 13:55
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800519&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2 library is not thread safe

Initial Comment:
By default, there is no "-D_REENTRANT" flag passed to the C preprocessor (nor any -mt (Sun Studio) or
-pthreads (gcc) option to the C compiler).
Note: I'm using libssh2 on Solaris 9/10, using Sun Studio 12.

Referencing errno in many pieces of code makes the whole library not thread safe
(libssh2_session_startup() for example). There are many EAGAIN errors that are now thrown internally
(because of new non-blocking sockets in 1.1), but unfortunately, the errno value is not correctly
accessed, leading to undefined behaviour. This can be "easily" reproduced using something like
(compiled in a thread safe manner):
  Th.1: set errno
  Th.1: detach thread 2
(Continue reading)

SourceForge.net | 4 Jun 2009 00:37
Picon
Favicon

[ libssh2-Bugs-2800496 ] libssh2_scp_recv() does not support files >4GB

Bugs item #2800496, was opened at 2009-06-03 15:22
Message generated for change (Settings changed) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800496&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_scp_recv() does not support files >4GB

Initial Comment:
Invalid "scpsize_strtol" definition: should test "HAVE_STRTOLL" instead of "strtoll" (see attached patch).

----------------------------------------------------------------------

>Comment By: Daniel Stenberg (bagder)
Date: 2009-06-04 00:37

Message:
Thanks, applied.

----------------------------------------------------------------------
(Continue reading)

SourceForge.net | 4 Jun 2009 08:55
Picon
Favicon

[ libssh2-Bugs-2800519 ] libssh2 library is not thread safe

Bugs item #2800519, was opened at 2009-06-03 15:55
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800519&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: misc
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Daniel Stenberg (bagder)
Summary: libssh2 library is not thread safe

Initial Comment:
By default, there is no "-D_REENTRANT" flag passed to the C preprocessor (nor any -mt (Sun Studio) or
-pthreads (gcc) option to the C compiler).
Note: I'm using libssh2 on Solaris 9/10, using Sun Studio 12.

Referencing errno in many pieces of code makes the whole library not thread safe
(libssh2_session_startup() for example). There are many EAGAIN errors that are now thrown internally
(because of new non-blocking sockets in 1.1), but unfortunately, the errno value is not correctly
accessed, leading to undefined behaviour. This can be "easily" reproduced using something like
(compiled in a thread safe manner):
  Th.1: set errno
  Th.1: detach thread 2
(Continue reading)

SourceForge.net | 4 Jun 2009 10:59
Picon
Favicon

[ libssh2-Bugs-2800958 ] libssh2_scp_send() does not support files >4GB by default

Bugs item #2800958, was opened at 2009-06-04 10:59
Message generated for change (Tracker Item Submitted) made by p82420
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800958&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Gaëtan Buchetet (p82420)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_scp_send() does not support files >4GB by default

Initial Comment:
Note: I'm using Solaris 9/10, libssh2 1.1

The 4th parameter of libssh2_scp_send() is of type size_t. With the ILP32 (default) model, size_t is
32-bits wide. That makes impossible to transfer files larger than 4GB. I've not tested the LP64 model
(accessible with -m64 on Sun Studio and probably gcc), but that should work. Nevertheless, size_t is not
the appropriate C type for file sizes. POSIX uses off_t, which is either long long
(-D_FILE_OFFSET_BITS=64 or LP64 model) or long.

See attached patch (I've used the off_t C type, but fill free to use any 64-bit wide type).

Gaëtan
(Continue reading)

SourceForge.net | 4 Jun 2009 11:00
Picon
Favicon

[ libssh2-Bugs-2800958 ] libssh2_scp_send() does not support files >4GB

Bugs item #2800958, was opened at 2009-06-04 10:59
Message generated for change (Settings changed) made by p82420
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800958&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Gaëtan Buchetet (p82420)
Assigned to: Nobody/Anonymous (nobody)
>Summary: libssh2_scp_send() does not support files >4GB

Initial Comment:
Note: I'm using Solaris 9/10, libssh2 1.1

The 4th parameter of libssh2_scp_send() is of type size_t. With the ILP32 (default) model, size_t is
32-bits wide. That makes impossible to transfer files larger than 4GB. I've not tested the LP64 model
(accessible with -m64 on Sun Studio and probably gcc), but that should work. Nevertheless, size_t is not
the appropriate C type for file sizes. POSIX uses off_t, which is either long long
(-D_FILE_OFFSET_BITS=64 or LP64 model) or long.

See attached patch (I've used the off_t C type, but fill free to use any 64-bit wide type).

Gaëtan
(Continue reading)

SourceForge.net | 4 Jun 2009 14:52
Picon
Favicon

[ libssh2-Bugs-2800958 ] libssh2_scp_send() does not support files >4GB

Bugs item #2800958, was opened at 2009-06-04 10:59
Message generated for change (Settings changed) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800958&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: API
Group: None
>Status: Pending
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Gaëtan Buchetet (p82420)
>Assigned to: Daniel Stenberg (bagder)
Summary: libssh2_scp_send() does not support files >4GB

Initial Comment:
Note: I'm using Solaris 9/10, libssh2 1.1

The 4th parameter of libssh2_scp_send() is of type size_t. With the ILP32 (default) model, size_t is
32-bits wide. That makes impossible to transfer files larger than 4GB. I've not tested the LP64 model
(accessible with -m64 on Sun Studio and probably gcc), but that should work. Nevertheless, size_t is not
the appropriate C type for file sizes. POSIX uses off_t, which is either long long
(-D_FILE_OFFSET_BITS=64 or LP64 model) or long.

See attached patch (I've used the off_t C type, but fill free to use any 64-bit wide type).

Gaëtan
(Continue reading)

SourceForge.net | 4 Jun 2009 15:08
Picon
Favicon

[ libssh2-Bugs-2800958 ] libssh2_scp_send() does not support files >4GB

Bugs item #2800958, was opened at 2009-06-04 10:59
Message generated for change (Comment added) made by p82420
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800958&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
Status: Pending
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Gaëtan Buchetet (p82420)
Assigned to: Daniel Stenberg (bagder)
Summary: libssh2_scp_send() does not support files >4GB

Initial Comment:
Note: I'm using Solaris 9/10, libssh2 1.1

The 4th parameter of libssh2_scp_send() is of type size_t. With the ILP32 (default) model, size_t is
32-bits wide. That makes impossible to transfer files larger than 4GB. I've not tested the LP64 model
(accessible with -m64 on Sun Studio and probably gcc), but that should work. Nevertheless, size_t is not
the appropriate C type for file sizes. POSIX uses off_t, which is either long long
(-D_FILE_OFFSET_BITS=64 or LP64 model) or long.

See attached patch (I've used the off_t C type, but fill free to use any 64-bit wide type).

Gaëtan
(Continue reading)

Tor Arntsen | 4 Jun 2009 17:51
Picon
Favicon

[PATCH] Ignore generated files

Daniel,

This is mainly an experiment for sending a patch via email that can be
applied to a GIT repo, without having to go through 'git push'.

The idea is that the attachment could be applied directly with git-am
(or git am), i.e. git-am patchfile
I generated it from my own cloned repo (and from a local branch that
tracks origin/master) with git format-patch and some options.  There
are a number of other slightly different ways to achieve the same
thing.

As it's basically just a test, the patch only adds a number of
.gitignore files to let git ignore generated files in 'git status' and
the like.

Ok, here goes:

  Ignore generated files

 .gitignore                |   32 ++++++++++++++++++++++++++++++++
 example/simple/.gitignore |   18 ++++++++++++++++++
 m4/.gitignore             |    5 +++++
 src/.gitignore            |    3 +++
 tests/.gitignore          |    1 +
 5 files changed, 59 insertions(+), 0 deletions(-)
 create mode 100644 .gitignore
 create mode 100644 example/simple/.gitignore
 create mode 100644 m4/.gitignore
 create mode 100644 src/.gitignore
(Continue reading)

SourceForge.net | 4 Jun 2009 17:51
Picon
Favicon

[ libssh2-Bugs-2800958 ] libssh2_scp_send() does not support files >4GB

Bugs item #2800958, was opened at 2009-06-04 10:59
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=2800958&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
>Status: Open
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Gaëtan Buchetet (p82420)
Assigned to: Daniel Stenberg (bagder)
Summary: libssh2_scp_send() does not support files >4GB

Initial Comment:
Note: I'm using Solaris 9/10, libssh2 1.1

The 4th parameter of libssh2_scp_send() is of type size_t. With the ILP32 (default) model, size_t is
32-bits wide. That makes impossible to transfer files larger than 4GB. I've not tested the LP64 model
(accessible with -m64 on Sun Studio and probably gcc), but that should work. Nevertheless, size_t is not
the appropriate C type for file sizes. POSIX uses off_t, which is either long long
(-D_FILE_OFFSET_BITS=64 or LP64 model) or long.

See attached patch (I've used the off_t C type, but fill free to use any 64-bit wide type).

Gaëtan
(Continue reading)


Gmane