General development discussions about libssh2

SourceForge.net | 2 Jan 2008 15:46

Picon

[ libssh2-Bugs-1860989 ] libssh2_poll handles -1 timeout incorrectly

Bugs item #1860989, was opened at 2007-12-30 18:08
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1860989&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: jls (apjenkins)
>Assigned to: Daniel Stenberg (bagder)
Summary: libssh2_poll handles -1 timeout incorrectly

Initial Comment:
The documentation for libssh2_poll says the semantics are like poll(2).  However poll(2) accepts a -1
timeout, which means to wait indefinitely.  libssh2_poll  does not correctly handle a -1 timeout.  It seems
like the only way to indicate an indefinite wait is to pass a really large timeout to libssh2_poll.  I think
either the documentation should mention that libssh2_poll differs from poll(2) in this way, or a -1
timeout should be supported as meaning wait indefinitely.

Currently, if you look in libssh2_poll code, it performs arithmetic on timeout_remaining without first
checking to see if it's negative.  I can submit a patch to make libssh2_poll support -1 like poll(2) if you'd like.

----------------------------------------------------------------------

(Continue reading)

SourceForge.net | 2 Jan 2008 15:49

Picon

[ libssh2-Bugs-1841442 ] libssh2-0.18 session.c

Bugs item #1841442, was opened at 2007-11-30 05:56
Message generated for change (Comment added) made by bagder
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1841442&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: API
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Gary Miller (gmiller1018)
Assigned to: Daniel Stenberg (bagder)
Summary: libssh2-0.18 session.c

Initial Comment:
I have noticed an issue with libssh2_poll on my Linux machines.  I found that on my machines HAVE_POLL and
HAVE_SELECT are defined and the code that is executed in the poll code not the select.  I fixed this by just
undef'ing the HAVE_POLL.

The other issue here is when the select code is enabled the code in the libssh2_poll seems to be in error.  The
code as I fixed it is:
[code]
        if (sysret > 0) {
            for(i = 0; i < nfds; i++) {
                switch (fds[i].type) {
                case LIBSSH2_POLLFD_SOCKET:

(Continue reading)

SourceForge.net | 2 Jan 2008 22:28

Picon

[ libssh2-Bugs-1862722 ] libssh2_poll doesn't work on win32

Bugs item #1862722, was opened at 2008-01-02 13:28
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1862722&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_poll doesn't work on win32

Initial Comment:
Using libssh2 0.18, I found that libssh2_poll doesn't work on win32. It would always return 1, and the
revents field of the LIBSSH2_POLLFD object I passed in would be set to garbage.  

I found that the reason for this was that on WIN32, neither HAVE_SELECT nor HAVE_POLL get defined.  The way
libssh2_poll is written assumes that either the "ifdef HAVE_POLL" or "ifdef HAVE_SELECT" block of code
will get exected.  If neither executes then no packets ever actually get read, it it just returns garbage.

Since Win32 does provide select, I simply defined HAVE_SELECT in win32/libssh2_config.h, and also made a
small change to libssh2_priv.h so it won't try to include unix-only header files on windows.  This made
libssh2_poll work correctly on Windows.  I've tested this patch with VStudio 2003 on a win32 machine, and
VStudio 2005 on a win64 machine.

(Continue reading)

SourceForge.net | 2 Jan 2008 22:33

Picon

[ libssh2-Bugs-1862727 ] libssh2_poll doesn't work on win32

Bugs item #1862727, was opened at 2008-01-02 16:33
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1862727&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: jls (apjenkins)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_poll doesn't work on win32

Initial Comment:
[Sorry, this is a duplicate of bug 1862722, which I submitted anonymously by mistake]

Using libssh2 0.18, I found that libssh2_poll doesn't work on win32. It would always return 1, and the
revents field of the LIBSSH2_POLLFD object I passed in would be set to garbage.

I found that the reason for this was that on WIN32, neither HAVE_SELECT nor HAVE_POLL get defined. The way
libssh2_poll is written assumes that either the "ifdef HAVE_POLL" or "ifdef HAVE_SELECT" block of code
will get
exected. If neither executes then no packets ever actually get read, it it just returns garbage.

Since Win32 does provide select, I simply defined HAVE_SELECT in win32/libssh2_config.h, and also made a

(Continue reading)

SourceForge.net | 3 Jan 2008 14:26

Picon

[ libssh2-Bugs-1863153 ] debugging output left in channel.c in 0.18

Bugs item #1863153, was opened at 2008-01-03 05:26
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1863153&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: debugging output left in channel.c in 0.18 

Initial Comment:
In release 0.18 on line 1417 of channel.c the debugging output:
fprintf(stderr, "return rc = %d\n", rc);
has been left in the release.

Low priority and not really important I know... ;)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1863153&group_id=125852

(Continue reading)

SourceForge.net | 3 Jan 2008 14:30

Picon

[ libssh2-Feature Requests-1863154 ] Only private key should be needed by libssh2_userauth_public

Feature Requests item #1863154, was opened at 2008-01-03 05:30
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703945&aid=1863154&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Only private key should be needed by libssh2_userauth_public

Initial Comment:
The current API allows you to authenticate using a public key authentication using the
libssh2_userauth_publickey_fromfile call.

However, this means having the private and public key saved to disk. The public key can always be created
from the private key so this parameter isn't really needed and would make the library slightly easier to
use and any applications based on it easier to configure.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703945&aid=1863154&group_id=125852

(Continue reading)

Paul Thomas | 3 Jan 2008 17:27

Picon

Feature Request (code included)

Developers,

Vincent Jaulin gave me a function that isn't in your library. It lets
the open shell session receive resize hints. Would you add it to the
library please? Here's the code and I can verify that it works.

Thanks,
Paul Thomas

code
----------------------------------

LIBSSH2_API int
libssh2_channel_request_pty_size(LIBSSH2_CHANNEL * channel, int width,
int height,
                             int width_px, int height_px)
{
  LIBSSH2_SESSION *session = channel->session;
  unsigned char *s, *data;
  static const unsigned char reply_codes[3] =
      { SSH_MSG_CHANNEL_SUCCESS, SSH_MSG_CHANNEL_FAILURE, 0 };
  unsigned long data_len;
  int rc;

  if (channel->reqPTY_state == libssh2_NB_state_idle) {
      /* 41 = packet_type(1) + channel(4) + pty_req_len(4) +
"window-change"(13) +
       * want_reply(1) + width(4) + height(4) + width_px(4) +
       * height_px(4)  */
      channel->reqPTY_packet_len = 39;

(Continue reading)

SourceForge.net | 3 Jan 2008 20:13

Picon

[ libssh2-Bugs-1863153 ] debugging output left in channel.c in 0.18

Bugs item #1863153, was opened at 2008-01-03 05:26
Message generated for change (Comment added) made by dfandrich
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1863153&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: misc
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Dan Fandrich (dfandrich)
Summary: debugging output left in channel.c in 0.18 

Initial Comment:
In release 0.18 on line 1417 of channel.c the debugging output:
fprintf(stderr, "return rc = %d\n", rc);
has been left in the release.

Low priority and not really important I know... ;)

----------------------------------------------------------------------

>Comment By: Dan Fandrich (dfandrich)
Date: 2008-01-03 11:13

(Continue reading)

SourceForge.net | 3 Jan 2008 20:15

Picon

[ libssh2-Bugs-1862722 ] libssh2_poll doesn't work on win32

Bugs item #1862722, was opened at 2008-01-02 13:28
Message generated for change (Comment added) made by dfandrich
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=703942&aid=1862722&group_id=125852

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: misc
Group: None
>Status: Closed
>Resolution: Duplicate
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: libssh2_poll doesn't work on win32

Initial Comment:
Using libssh2 0.18, I found that libssh2_poll doesn't work on win32. It would always return 1, and the
revents field of the LIBSSH2_POLLFD object I passed in would be set to garbage.  

I found that the reason for this was that on WIN32, neither HAVE_SELECT nor HAVE_POLL get defined.  The way
libssh2_poll is written assumes that either the "ifdef HAVE_POLL" or "ifdef HAVE_SELECT" block of code
will get exected.  If neither executes then no packets ever actually get read, it it just returns garbage.

Since Win32 does provide select, I simply defined HAVE_SELECT in win32/libssh2_config.h, and also made a
small change to libssh2_priv.h so it won't try to include unix-only header files on windows.  This made
libssh2_poll work correctly on Windows.  I've tested this patch with VStudio 2003 on a win32 machine, and
VStudio 2005 on a win64 machine.

(Continue reading)

Daniel Stenberg | 3 Jan 2008 22:39

Picon

Re: Feature Request (code included)

On Jan 3, 2008 5:27 PM, Paul Thomas <thomaspu@...> wrote:

> Vincent Jaulin gave me a function that isn't in your library. It lets
> the open shell session receive resize hints. Would you add it to the
> library please? Here's the code and I can verify that it works.

So he allows you to submit it to us? If so, can you please make an
actual patch of it and resend together with at least some basic docs?
Oh, and please don't use // for commenting the code as it breaks
(older) compiles.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

Group

gmane.network.ssh.libssh2.devel.

Project Web Page

General development discussions about libssh2

Search Archive

Page

1 | 2 | 3 | 4

Articles in period: 35

January 2008

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH] knownhost.c: use LIBSSH2_FREE macro instead of free (18 May 2013)
#265: agent_disconnect_unix closes stdin on Solaris 10 x64 (17 May 2013)
[PATCH] libcrypt.c: Fixed typo in function parameter type (9 May 2013)
#264: SCP send not properly setting mtime or atime (29 Apr 2013)
libssh2_userauth_password return value (17 Apr 2013)
proper use of non-blocking read (10 Apr 2013)
#263: libssh2_channel_read for exec ends unpredictably (10 Apr 2013)
[PATCH] sftp: Add support for fsync (OpenSSH extension). (9 Apr 2013)
[PATCH] sftp: statvfs: Along error path, reset the correct 'state' var (8 Apr 2013)
Transfering files (3 Apr 2013)
#262: libssh2_userauth_publickey_fromfile_ex declaration in man missis (28 Mar 2013)
[PATCH] sftp: seek: Don't flush buffers if the requested offset is the (26 Mar 2013)
sftp_read/write returning LIBSSH2_ERROR_TIMEOUT (21 Mar 2013)
#261: buildconf fails with recent automake (21 Mar 2013)
Bug in libssh2 - missing data on reading (19 Mar 2013)
Multiple direct_tcp_ip_channel (14 Mar 2013)
[Retrieved]troubleshooting connection failure (14 Mar 2013)
RouterOS Handshake problem (12 Mar 2013)
troubleshooting connection failure (9 Mar 2013)
Need help with libssh2_userauth_keyboard_interactive method. (28 Feb 2013)
Keepalive Issue (28 Feb 2013)

Archives

8	May 2013
39	April 2013
24	March 2013
42	February 2013
14	January 2013
9	December 2012
24	November 2012
71	October 2012
53	September 2012
34	August 2012
25	July 2012
75	June 2012
126	May 2012
106	April 2012
147	March 2012
100	February 2012
29	January 2012
43	December 2011
54	November 2011
85	October 2011
145	September 2011
115	August 2011
16	July 2011
41	June 2011
64	May 2011
44	April 2011
74	March 2011
41	February 2011
65	January 2011
98	December 2010
135	November 2010
145	October 2010
89	September 2010
129	August 2010
124	July 2010
258	June 2010
60	May 2010
165	April 2010
234	March 2010
167	February 2010
193	January 2010
193	December 2009
76	November 2009
159	October 2009
354	September 2009
90	August 2009
99	July 2009
93	June 2009
142	May 2009
97	April 2009
259	March 2009
54	February 2009
39	January 2009
68	December 2008
70	November 2008
32	October 2008
70	September 2008
8	August 2008
18	July 2008
6	June 2008
5	May 2008
11	April 2008
24	March 2008
17	February 2008
35	January 2008
32	December 2007
71	November 2007
24	October 2007
35	September 2007
72	August 2007
125	July 2007
98	June 2007
26	May 2007
66	April 2007
66	March 2007
36	February 2007
85	January 2007
23	December 2006
43	November 2006

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template