headers
Andrew Bartlett | 1 Aug 2012 01:11
Picon
Favicon

-Werror=format in developer builds (was: Re: No longer supported on FC13?)

On Tue, 2012-07-31 at 14:39 -0400, Charles Tryon wrote:
> I've been building Samba4 on an older Fc13 box for a long time now, and I
> just started running into a problem where I can't build there.  I've gone
> to the point of cleanly removing the samba-master directory and rebuilding
> the git repository from scratch, and I'm still getting the same error.
> 
> ...
> [2496/3924] Compiling source4/heimdal/lib/com_err/error.c
> ../source4/heimdal/lib/com_err/error.c: In function ‘com_right_r’:
> ../source4/heimdal/lib/com_err/error.c:68: error: format ‘%d’ expects type
> ‘int’, but argument 4 has type ‘long int’
> ../source4/heimdal/lib/com_err/error.c:68: error: format ‘%d’ expects type
> ‘int’, but argument 4 has type ‘long int’
> 
> I'm wondering... is the build no longer supported on Fc13?  I have to
> admit, it IS pretty ragged around the edges...
> 
> If not, then I will try to move the test domain I've had there to another
> (CentOS?) box and see if it works there.  (Currently, that box is still
> able to build and run the quicktest.)

I have added -Werror=format to the default configure line in developer
builds (also applies to recursive builds of smbtorture4 from the
autoconf build until I change that again). 

This asserts that this particular warning should never happen in the
build, because it is really important to find and fix these errors.
These warnings (now errors) are not hard to fix, we just need to correct
the error and sync it back upstream with Heimdal.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Christof Schmitt | 1 Aug 2012 01:21
Picon
Favicon

[PATCH] s3-winbindd: Store schannel credentials in secrets.tdb

This fixes a failure from the base.bench-torture test. The test can
fail when multiple netlogon connections to the same domain controller
are established. The domain controller only keeps one set of
credentials for schannel connections, and the discussion in bz #8599
suggested to store the credentials in a tdb.

The patch stores the netlogon credentials per domain controller in
secrets.tdb. If there are already credentials before establishing a
netlogon session, those credentials are reused. If the reused
credentials are no longer valid, they are deleted and the netlogon
session is established with new credentials.

Regards,

Christof Schmitt || IBM || SONAS System Development || Tucson, AZ
christof.schmitt <at> us.ibm.com  ||  +1-520-799-2469  (T/L: 321-2469)
Attachment (0001-s3-winbindd-Store-schannel-credentials-in-secrets.td.patch): application/octet-stream, 9 KiB
Permalink | Reply | 23 comments |
headers
Andrew Bartlett | 1 Aug 2012 01:37
Picon
Favicon

Re: [PATCH] s3-winbindd: Store schannel credentials in secrets.tdb

On Tue, 2012-07-31 at 17:21 -0600, Christof Schmitt wrote:
> This fixes a failure from the base.bench-torture test. The test can
> fail when multiple netlogon connections to the same domain controller
> are established. The domain controller only keeps one set of
> credentials for schannel connections, and the discussion in bz #8599
> suggested to store the credentials in a tdb.
> 
> The patch stores the netlogon credentials per domain controller in
> secrets.tdb. If there are already credentials before establishing a
> netlogon session, those credentials are reused. If the reused
> credentials are no longer valid, they are deleted and the netlogon
> session is established with new credentials.

This seems to duplicate the code in libcli/auth/schannel_state_tdb.c
which is used for the same task on the server side.  

I know it might mean sorting this out to be dbwrap aware, but I would
really like to reduce the duplication in this area. 

Andrew Bartlett

--

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Permalink | Reply | 22 comments |
headers
Learner Study | 1 Aug 2012 02:03
Picon

Ques on smb-3.5.12

Hi,

I'd like to use recvfile with samba 3-5.12 release with latest Fedora
core 17 (kernel 3.3.4). However, this kernel release doesn't support
recvfile. Hence performance is really bad if I enable recvfile option
in samba config.

I tried to check old samba archives and found following relevant:
http://samba.2283325.n4.nabble.com/recvfile-by-linux-splice-td2474663.html
http://samba.2283325.n4.nabble.com/Socket-draining-for-sys-recvfile-patch-for-reverse-sendfile-td4225013.html

#2 above, recvfile should work with 3.5.x kernel and 3.5.11+
samba...is that correct?

Could someone please provide some performance improvement numbers w/
and w/o recvfile?

Thanks!
Permalink | Reply | 0 comments |
headers
Richard Sharpe | 1 Aug 2012 05:07
Picon

Why am I seeing these build failures in master?

This is what I see. Should I be using waf these days?

Compiling smbd/smbXsrv_session.c
smbd/smbXsrv_session.c: In function ‘smbXsrv_session_table_init’:
smbd/smbXsrv_session.c:211:11: error: ‘MSG_SMBXSRV_SESSION_CLOSE’
undeclared (first use in this function)
smbd/smbXsrv_session.c:211:11: note: each undeclared identifier is
reported only once for each function it appears in
smbd/smbXsrv_session.c: In function ‘smb2srv_session_close_previous_check’:
smbd/smbXsrv_session.c:1020:5: error: ‘MSG_SMBXSRV_SESSION_CLOSE’
undeclared (first use in this function)

--

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)
Permalink | Reply | 1 comment |
headers
Matthieu Patou | 1 Aug 2012 05:52

Re: Samba 4 insufficientAccessRights when modifying Configuration

On 07/31/2012 07:18 AM, Brian C. Huffman wrote:
> Unfortunately I can run it as Administrator but it appears that 
> programatically it still tries to install as the machine account.  I 
> did some research and it turns out that the vendor intends you to run 
> it on the AD server itself (which won't be possible for Samba).
>
I suspect they expect you to run it on one of the DC, in this case the 
computer account is member of the domain controllers that have a lot of 
rights !

> However while trying to work around this, I found a difference between 
> Samba and a Windows 2008 AD server.  With the Win2k8 AD server, I'm 
> able to add the machine account, with inherited write permissions to 
> CN=DisplaySpecifiers,CN=Configuration and then the installer 
> succeeds.  When I try to do the same with Samba, it doesn't give me 
> any warnings, but it silently refuses to add the permissions to the 
> descendants of DisplaySpecifiers.  Is this known / intended behavior?
>
As nadya said we now this "issue" the way to do it for you is to add the 
machine account via ADSI or ldbedit to the domain admins group, it 
should do the job. Once the installation is finished, remove it from 
this group.

Matthieu.
Permalink | Reply | 10 comments |
headers
Richard Sharpe | 1 Aug 2012 05:53
Picon

What is this problem with 'waf configure'?

Fedora 14, reasonably up to date.

  File "/home/rsharpe/samba/samba.master/dynconfig/wscript", line 329,
in configure
    value = EXPAND_VARIABLES(conf, dyn_vars[varname])
  File "./buildtools/wafsamba/samba_utils.py", line 362, in EXPAND_VARIABLES
    ret = SUBST_VARS_RECURSIVE(ret, ctx.env)
  File "./buildtools/wafsamba/samba_utils.py", line 329, in SUBST_VARS_RECURSIVE
    string = subst_vars_error(string, env)
  File "./buildtools/wafsamba/samba_utils.py", line 238, in subst_vars_error
    raise KeyError("Failed to find variable %s in %s" % (vname, string))
KeyError: 'Failed to find variable PYTHONARCHDIR in ${PYTHONARCHDIR}'

--

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)
Permalink | Reply | 0 comments |
headers
Stefan (metze) Metzmacher | 1 Aug 2012 08:00
Picon
Favicon

Re: Why am I seeing these build failures in master?

Hi Richard,

> This is what I see. Should I be using waf these days?
> 
> Compiling smbd/smbXsrv_session.c
> smbd/smbXsrv_session.c: In function ‘smbXsrv_session_table_init’:
> smbd/smbXsrv_session.c:211:11: error: ‘MSG_SMBXSRV_SESSION_CLOSE’
> undeclared (first use in this function)
> smbd/smbXsrv_session.c:211:11: note: each undeclared identifier is
> reported only once for each function it appears in
> smbd/smbXsrv_session.c: In function ‘smb2srv_session_close_previous_check’:
> smbd/smbXsrv_session.c:1020:5: error: ‘MSG_SMBXSRV_SESSION_CLOSE’
> undeclared (first use in this function)

Because you might have an old
source3/librpc/gen_ndr/messaging.h
from an old autoconf build.

In new autoconf builds create generated files in an autoconf subdirectory,
to hide them from waf.

metze
Permalink | Reply | 0 comments |
headers
Andreas Oster | 1 Aug 2012 13:30
Picon
Favicon

Re: Need urgent help with samba4 DC re-join

Am 18.07.2012 08:03, schrieb Andrew Bartlett:
> On Wed, 2012-07-18 at 07:10 +0200, Andreas Oster wrote:
> 
>> Hello Andrew,
>>
>> unfortunately dbcheck did not work. The following error messages showed up:
>>
>> ERROR: wrong instanceType 11 on DC=DomainDnsZones,DC=novanetwork,DC=loc,
>> should be 13
>> ERROR(<type 'exceptions.AttributeError'>): uncaught exception -
>> 'dbcheck' object has no attribute 'modify_instancetype'
>>   File
> 
> Thanks.  I've updated my branch with what I hope will be a fix.  This
> time I've modified a local DB to replicate your error condition, and
> confirmed it all works.
> 
> However, it will only allow the instanceType to be changed, the
> objectClass can't be fixed yet.  But if you can confirm what I have so
> far works for you, I'll see what I can do about the rest.
> 
> Thanks,
> 
> Andrew Bartlett
> 
Hello Andrew,

any news regarding adding some code to dbcheck to fix the objectClass
issue in my samba4 setup ?
(Continue reading)

Permalink | Reply | 12 comments |
headers
steve | 1 Aug 2012 14:19
Favicon

Samba4, latest build fails: wrong int and long int casts

Ubuntu 12.04

[2493/4244] Compiling source4/heimdal/lib/com_err/error.c
../source4/heimdal/lib/com_err/error.c: In function ‘com_right_r’:
../source4/heimdal/lib/com_err/error.c:68:6: error: format ‘%d’ expects 
argument of type ‘int’, but argument 4 has type ‘long int’ [-Werror=format]
../source4/heimdal/lib/com_err/error.c:68:6: error: format ‘%d’ expects 
argument of type ‘int’, but argument 4 has type ‘long int’ [-Werror=format]
cc1: some warnings being treated as errors
Waf: Leaving directory `/home/steve/samba-master/bin'
Build failed: -> task failed (err #1):
{task: cc error.c -> error_128.o}
make: *** [install] Error 1

Cheers,
Steve
Permalink | Reply | 8 comments |

Gmane