1 Sep 2010 01:01
Re: Samba build is broken
Brad Hards <bradh <at> frogmouth.net>
2010-08-31 23:01:52 GMT
2010-08-31 23:01:52 GMT
On Wednesday, September 01, 2010 07:07:00 am Björn JACKE wrote: > On 2010-08-31 at 17:08 +0300 Zahari Zahariev sent off: > > http://pastebin.com/h6zzQg1g > > > > Can you fix that? > > didn't see that here, sorry for the breakage. I've reverted it for now. There appears to be more problems. OpenChange uses a standalone build of ldb (i.e. we use it outside of the samba server), and the build for that is broken in ldbtest.c [58/74] Compiling tools/ldbtest.c ../tools/ldbtest.c: In function ‘_start_timer’: ../tools/ldbtest.c:48: error: implicit declaration of function ‘clock_gettime_mono’ Waf: Leaving directory `/home/buildslave1/buildbot/everything/build/samba4/source4/lib/ldb/bin' Build failed: -> task failed (err #1): {task: cc ldbtest.c -> ldbtest_35.o} make: *** [all] Error 1 Fixing the declaration is easy, but I'm not sure how to link to the appropriate subsystem (LIBSAMBA-UTIL) in a standalone build. I tried this: index a885b80..8c4f377 100644 --- a/source4/lib/ldb/tools/ldbtest.c +++ b/source4/lib/ldb/tools/ldbtest.c <at> <at> -39,6 +39,7 <at> <at>(Continue reading)
> >
> > I would like to hold off pushing the introduction of the
> > wrappers until I have gone over the callers in detail, if
> > that's ok for you.
>
> I very much agree. The call change to lp_load_initial_only() in
> libsmbclient is indeed a bug - sorry about that. In the first
> generation of this patch I had incorrectly assumed it was equivalent to
> what I later added as lp_load_for_client(), before I re-read your mail.
>
> I've just pushed 'loadparm-changes-lp-set-cmdline' to my git repo, in
> case you want to work from there. I agree it's really hard to stare
> more than a dozen simple replacements and remain convinced that there
> isn't a typo or behaviour change in there, or on the other hand to find
RSS Feed