Stefan (metze) Metzmacher | 1 Nov 11:18 2009
Picon

LIBREPLACE_LIBS in s3 (Re: [SCM] Samba Shared Repository - branch master updated)

Hi Björn.

> - Log -----------------------------------------------------------------
> commit a80a0b7728de21e992f8f0b3e31b600441a6535d
> Author: Björn Jacke <bj <at> sernet.de>
> Date:   Sat Oct 31 10:37:44 2009 +0100
> 
>     s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient

I think talloc and tdb should not get LIBREPLACE_NETWORK_LIBS
linked in... they don't include "system/network.h" from libreplace.
And the standalone builds also doesn't use LIBREPLACE_NETWORK at all.

I think it's a bit confusing to have LIBREPLACE_LIBS as the same
as LIBREPLACE_NETWORK_LIBS.

Jeff Layton | 1 Nov 12:27 2009
Picon

Re: mount.cifs - "Const" warnings patch

On Fri, 30 Oct 2009 10:28:26 +0000 (GMT)
Matthias Dieter Wallnöfer <mdw <at> samba.org> wrote:

> Dear mount.cifs maintainers,
> 
> we at the s4 side get always a "const" warning when compiling the "mount.cifs" tool. With this patch I
substituted the existing "CONST_DISCARD" macro with the newer and better "discard_const_p" one
developed by s4. When applying this one to the particular code line the warning goes away.
> 

There was no patch in this mail. Could you resend?

Thanks,
--

-- 
Jeff Layton <jlayton <at> samba.org>

Björn Jacke | 1 Nov 21:53 2009
Picon

Re: LIBREPLACE_LIBS in s3 (Re: [SCM] Samba Shared Repository - branch master updated)

On 2009-11-01 at 11:18 +0100 Stefan (metze) Metzmacher sent off:
> I think talloc and tdb should not get LIBREPLACE_NETWORK_LIBS
> linked in... they don't include "system/network.h" from libreplace.
> And the standalone builds also doesn't use LIBREPLACE_NETWORK at all.

even if unused, linking in object files that have unresolved symbols is bad
manner. I think we could eliminate the dependency the clean way by splitting up
LIBREPLACE_OBJ so that for example the libreplace network object files are only
linked in when needed. But is it really worth doing that?

> I think it's a bit confusing to have LIBREPLACE_LIBS as the same
> as LIBREPLACE_NETWORK_LIBS.

that's because the LIBREPLACE_NETWORK_LIBS are the only libs currently required
by any part of libreplace. Using LIBREPLACE_LIBS inside samba's Makefle is
straigt forward as long as we just have one single LIBREPLACE_OBJ blob. I think
if the object files would be split up the old LIBREPLACE_NETWORK_LIBS would make
ore sense again.

Cheers
Björn
Andrew Bartlett | 1 Nov 23:40 2009
Picon

Re: [s4] Patches for password handling

On Fri, 2009-10-30 at 09:59 +0000, Matthias Dieter Wallnöfer wrote:
> s4:password_hash - Various (mostly cosmetic) prework
> 
> - Enhance comments
> - Remove (now) unnecessary code for single valued attribute checking

Matthias,

I'm not sure that this is the case.  The single-value checks on
userPassword are important, because we intercept, but don't store, that
value.  

Also, while clearTextPassword is not normally an externally set
attribute, we have to check it's validity because we don't currently
have a control on that. 

Even for the other attributes, while they may be checked for
single-value status later, I think it's too late. 

Andrew Bartlett

--

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

Vladimir Aliokhin | 2 Nov 11:05 2009

Re: winbindd_cache.tdb size issue in 3.2.15

Hello.

On Fri, Oct 30, 2009 at 7:39 PM, Jeremy Allison <jra <at> samba.org> wrote:

> The increase in size is by design as it helps prevent fragmentation
> in the tdb files. Why is the increased size causing a problem for you ?

It is connected with our system volume which has only 1GB.This system
volume store tdb files and for 65000 users became overflow.We have to
think about resize this volume but it is big change (problem with
compatibility).

--

-- 
Vladimir Aliokhin

Jan Blunck | 2 Nov 11:04 2009
Picon

[PATCH 01/27] BKL: Push down BKL from do_new_mount() to the filesystems get_sb/fill_super operation

I've read through all the code formerly covered by the BKL inside
do_kern_mount() and have satisfied myself that it doesn't need the BKL
any more.

do_kern_mount() is already called without the BKL when mounting the rootfs
and in nfsctl. do_kern_mount() calls vfs_kern_mount(), which is called
from various places without BKL: simple_pin_fs(), nfs_do_clone_mount()
through nfs_follow_mountpoint(), afs_mntpt_do_automount() through
afs_mntpt_follow_link(). Both later functions are actually the filesystems
follow_link inode operation. vfs_kern_mount() is calling the specified
get_sb function and lets the filesystem do its job by calling the given
fill_super function.

Therefore I think it is safe to push down the BKL from the VFS to the
low-level filesystems get_sb/fill_super operation.

Signed-off-by: Jan Blunck <jblunck <at> suse.de>
Cc: Matthew Wilcox <matthew <at> wil.cx>
---
 fs/9p/vfs_super.c            |    9 ++++++++-
 fs/adfs/super.c              |    8 +++++++-
 fs/affs/super.c              |    9 ++++++++-
 fs/afs/super.c               |    5 +++++
 fs/autofs4/inode.c           |    4 ++++
 fs/befs/linuxvfs.c           |    4 ++++
 fs/bfs/inode.c               |    9 ++++++++-
 fs/binfmt_misc.c             |    6 +++++-
 fs/btrfs/super.c             |    8 +++++++-
 fs/cifs/cifsfs.c             |   12 ++++++++++--
 fs/coda/inode.c              |    8 +++++++-
(Continue reading)

Endi Sukma Dewata | 2 Nov 18:24 2009
Picon

Re: [IPA] SID allocation using DNA plugin

Hi Andrew,

I noticed that the patches have been applied to the master branch,
thank you very much. However, when I tried to test it I found that
the provisioning tool failed with the following error:

Traceback (most recent call last):
  File "./setup/provision", line 213, in <module>
    nosync=opts.nosync,ldap_dryrun_mode=opts.ldap_dryrun_mode)
  File "bin/python/samba/provision.py", line 1195, in provision
    domainsid=domainsid)
  File "bin/python/samba/provisionbackend.py", line 184, in __init__
    domainsid=domainsid)
  File "bin/python/samba/provisionbackend.py", line 579, in provision_fds_backend
    retcode = subprocess.call([setup_ds_path, "--silent", "--file", result.paths.fedoradsinf],
close_fds=True, shell=False)
NameError: global name 'subprocess' is not defined

Are you still in the middle of restructuring the provisioning tool?
Please let me know if there's anything I could help. Thanks!

--
Endi S. Dewata

----- "Andrew Bartlett" <abartlet <at> samba.org> wrote:

> On Wed, 2009-10-28 at 17:00 -0400, Endi Sukma Dewata wrote:
> > Andrew,
> > 
> > Please take a look at the attached patches.
(Continue reading)

Matthias Dieter Wallnöfer | 2 Nov 21:36 2009
Picon

Re: mount.cifs - "Const" warnings patch

Hi Jeff,

sorry, sorry - sometimes I forget the attachments.

Now it should be okay.

Matthias

Jeff Layton wrote:
> On Fri, 30 Oct 2009 10:28:26 +0000 (GMT)
> Matthias Dieter Wallnöfer<mdw <at> samba.org>  wrote:
>
>    
>> Dear mount.cifs maintainers,
>>
>> we at the s4 side get always a "const" warning when compiling the "mount.cifs" tool. With this patch I
substituted the existing "CONST_DISCARD" macro with the newer and better "discard_const_p" one
developed by s4. When applying this one to the particular code line the warning goes away.
>>
>>      
> There was no patch in this mail. Could you resend?
>
> Thanks,
>    

Thomas Bork | 2 Nov 23:01 2009
Picon

Re: [Samba] [Announce] Samba 3.4.3 Available for Download

Karolin Seeger wrote:

> This is the latest stable release of Samba 3.4.
> Major enhancements in Samba 3.4.3 include:

While configuring:
checking for TALLOC... ./configure: line 10910: xauto: command not found

While compiling:
Compiling rpc_client/cli_netlogon.c
rpc_client/cli_netlogon.c: In function `rpccli_netlogon_set_trust_password':
rpc_client/cli_netlogon.c:606: warning: passing arg 2 of 
`des_crypt112_16' discards qualifiers from pointer target type

--

-- 
der tom

Andrew Bartlett | 2 Nov 23:26 2009
Picon

Re: [IPA] SID allocation using DNA plugin

On Mon, 2009-11-02 at 12:24 -0500, Endi Sukma Dewata wrote:
> Hi Andrew,
> 
> I noticed that the patches have been applied to the master branch,
> thank you very much. However, when I tried to test it I found that
> the provisioning tool failed with the following error:
> 
> Traceback (most recent call last):
>   File "./setup/provision", line 213, in <module>
>     nosync=opts.nosync,ldap_dryrun_mode=opts.ldap_dryrun_mode)
>   File "bin/python/samba/provision.py", line 1195, in provision
>     domainsid=domainsid)
>   File "bin/python/samba/provisionbackend.py", line 184, in __init__
>     domainsid=domainsid)
>   File "bin/python/samba/provisionbackend.py", line 579, in provision_fds_backend
>     retcode = subprocess.call([setup_ds_path, "--silent", "--file", result.paths.fedoradsinf],
close_fds=True, shell=False)
> NameError: global name 'subprocess' is not defined
> 
> Are you still in the middle of restructuring the provisioning tool?
> Please let me know if there's anything I could help. Thanks!

What I really need is 'make test' expanded to have tests with the LDAP
backend run on any compatible host.  Until we do that, mistakes such as
the one I made here will continue to happen. 

(See the environments in selftest/target/Samba4.pm)

Patches to fix up my latest stuff-up most welcome, otherwise I'll look
at it later today. 
(Continue reading)


Gmane