headers
Jelmer Vernooij | 1 Aug 2009 02:45
Picon
Favicon

Re: Remove gen_ndr/* from master?

Stefan (metze) Metzmacher wrote:
> Andrew Bartlett schrieb:
>   
>> On Tue, 2009-06-30 at 14:47 +1000, Andrew Bartlett wrote:
>>     
>>> I'm wondering if, given we now have a combined tree, including PIDL, if
>>> we could start removing the gen_ndr/* files from master.
>>>
>>> Having them in the tree creates a large degree of noise and churn in
>>> GIT, and the potential for partial commits (so that you need to use PIDL
>>> anyway).
>>>
>>> I'm sure there is some more history to this than I've recalled.  Is
>>> there any particular reason these files need to be committed into GIT?
>>>       
>> Does anyone have any views on this?
>>     
>
> I often find it useful to see the diff of the generated code, when I
> change pidl.
>   
You should be able to keep a copy of the old generated code around from
before you made the change and diff against the newly generated code. If
you're relying on "git diff" you don't see all the changes, since not
all of the generated code is checked in.

Cheers,

Jelmer
(Continue reading)

Permalink | Reply | 0 comments |
headers
Volker Lendecke | 2 Aug 2009 20:16
Picon
Favicon

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-760-g20d93b5

On Sun, Aug 02, 2009 at 12:33:12PM -0500, Alexander Bokovoy wrote:
> The branch, master has been updated
>        via  20d93b5b604da8a81d6435983fe2e3c33673b06c (commit)
>       from  4f147388c0512fc291cc53764c017d7117154afc (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 20d93b5b604da8a81d6435983fe2e3c33673b06c
> Author: Alexander Bokovoy <ab <at> samba.org>
> Date:   Sun Aug 2 17:42:49 2009 +0300
> 
>     Fix breakage for connect function after API change (connect -> connect_fn)

Thanks, Alexander!

Volker
Permalink | Reply | 0 comments |
headers
Michael Brown | 2 Aug 2009 23:01
Picon
Favicon
Gravatar

Re: talloc -- Eureka*

On Thursday 30 July 2009 03:04:17 Rusty Russell wrote:
> How about: talloc_attach/detach or talloc_connect/disconnect?
>
> A completely new namespace is far clearer, esp. if we're going to deprecate
> the old ones.

+1

The names talloc_get() and talloc_put() would give you naming consistency with 
reference counting APIs used in the Linux kernel, if that's any 
consideration.

If I were facing the pain of trying to make this kind of change, I would be 
tempted to:

- introduce a completely new API pair e.g. talloc_get()/talloc_put() which 
count references sanely, and are completely orthogonal (and invisible) to 
users of talloc()/talloc_zero()/talloc_steal()/talloc_free().

- mark talloc_reference() as __attribute__((deprecated)).

- provide a wrapper talloc_old_reference() for talloc_reference() which is not 
marked as deprecated, and just calls talloc_reference().

- do a global search/replace on the suspect code (samba4?) to replace 
talloc_reference() with talloc_old_reference(), to avoid the huge noise 
of "deprecated function" warnings.

- add "reviewing and replacing code that calls talloc_old_reference()" to a 
very long-term TODO list
(Continue reading)

Permalink | Reply | 0 comments |
headers
boyang | 3 Aug 2009 07:12
Picon
Favicon

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-337-g73e9693

boyang wrote:
> Hi, Jeremy:
>      I have finished the patch as your suggestion. Using poll-style
> method to do this, and it can work. I didn't add the user share
> directory to lp_file_list_changed, the reason is if only usershare was
> changed, call reload_services() with lp_file_list_changed() evaluated to
> false is expensive. It will reload all services, including printers,
> somehow slow.
>
>      Once the team decide to add reload_services() to child's main loop
> [smbd_serever_connection_loop_once()], we can call
> load_usershare_shares(true) within reload_services() to include
> usershare. load_usershare_shares(false) is the original
> load_usershare_shares(void).
>
>      I didn't do the registry part.  The message register part  is easy.
> I have to figure out  where  should we send  the message from.
> I am not familiar with that part. :-) need to browse the code.
>
>      Please review the patch in the attachment. If it is ok, I'll clean
> comments and log messages and then commit. Which won't bother you
> reverting it, again. :-) heihei
>   
Hi, Jeremy:
     Is the patch functionally ok? If it is, I'll clean up the comments
and fix the code style, and then commit it.
     Thanks for reviewing it! ;-)
>      Thanks!
>
(Continue reading)

Permalink | Reply | 6 comments |
headers
Volker Lendecke | 3 Aug 2009 07:51
Picon
Favicon

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-337-g73e9693

Hi!

On Mon, Aug 03, 2009 at 01:12:57PM +0800, boyang wrote:
> Hi, Jeremy:
>      Is the patch functionally ok? If it is, I'll clean up the comments
> and fix the code style, and then commit it.
>      Thanks for reviewing it! ;-)

If this is again about the patch that changes existing
connections, can you please write the torture test I asked
for in the bug report? We need to see this behaviour on
Windows with such a torture test first.

Volker
Permalink | Reply | 5 comments |
headers
boyang | 3 Aug 2009 13:52
Picon
Favicon

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-337-g73e9693

Volker Lendecke wrote:
> Hi!
>
> On Mon, Aug 03, 2009 at 01:12:57PM +0800, boyang wrote:
>   
>> Hi, Jeremy:
>>      Is the patch functionally ok? If it is, I'll clean up the comments
>> and fix the code style, and then commit it.
>>      Thanks for reviewing it! ;-)
>>     
>
> If this is again about the patch that changes existing
> connections, can you please write the torture test I asked
> for in the bug report? We need to see this behaviour on
> Windows with such a torture test first.
>   
Do you mean a test include in torture/torture.c or a separately
independent piece of code? I'll do it.
> Volker
>   

--

-- 
Bo Yang, Software Engineer, Suse Labs
GPG-key-ID   538C4C1A
Samba Team   boyang <at> samba.org    http://www.samba.org/
SUSE Linux   boyang <at> suse.de      http://www.novell.com/
Permalink | Reply | 4 comments |
headers
karthikeyan.chetty | 3 Aug 2009 13:55

Windows 7 Support.

Dear Team,

Some of the samba functionality is not working in Windows 7, Is that
Latest samba supporting windows 7 OS ?

Any planning from Samba team for new release to support Windows 7 OS.

Thanks,

S. Karthikeyan

Please do not print this email unless it is absolutely necessary. 

The information contained in this electronic message and any attachments to this message are intended for
the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged
information. If you are not the intended recipient, you should not disseminate, distribute or copy this
e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. 

WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any
attachments for the presence of viruses. The company accepts no liability for any damage caused by any
virus transmitted by this email. 

www.wipro.com
Permalink | Reply | 1 comment |
headers
Andrew Bartlett | 3 Aug 2009 14:39
Picon
Favicon

Re: Python scripts on SAMBA4 - Alpha 8

On Wed, 2009-07-29 at 14:33 -0500, MICHAEL BROWN wrote: 
> > I do have some other questions, if you don't mind:
> > 
> > *) Is it possible, at this time, to compile SAMBA 4 to use SSL binding for LDAP calls to AD?
> 
> >>That should work fine.  I'll shortly remove an unnecessary restriction
> >>avoiding GnuTLS > 2.6. 
> 
> What are the specific compile options within SAMBA 4 - alpha 8 to get this compiled for SSL?

Try --enable-gnutls

> > *) How is the SAMBA team progressing on back-end replication for SAMBA 4 AD?
> 
> >>This can be answered in two different ways, depending on what you are
> >>after:
> 
> >>We can use OpenLDAP for replication.  This makes the whole replication
> >>problem 'someone else's problem'.  The downside is that we are not as
> >>closely tied to our database, and so some aspects of the operation are
> >>not emulated as well (in particular we don't have transactions, so if
> >>things go wrong, we can't assume an auto-cleanup). 
> 
> >>We are also working on DRSUAPI replication, to replicate against
> >>windows.  We have an inbound 'vampire' working for a demo, but there is
> >>still work to do.
> 
> Is the DRSUAPI portion a separate piece of code outside of the SAMBA code base?  Meaning, is this a
compilable option
> available in the existing, or somewhere, to test possible SAMBA 4 to SAMBA 4 replica at this time?
(Continue reading)

Permalink | Reply | 0 comments |
headers
Volker Lendecke | 3 Aug 2009 15:20
Picon
Favicon

Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-337-g73e9693

On Mon, Aug 03, 2009 at 07:52:55PM +0800, boyang wrote:
> Do you mean a test include in torture/torture.c or a separately
> independent piece of code? I'll do it.

A test in torture/torture.c or in source4/torture/basic/, as
you like it.

Volker
Permalink | Reply | 3 comments |
headers
Matthias Dieter Wallnöfer | 3 Aug 2009 16:10
Picon
Favicon

Move "operational" LDB module



commit f82659e9ce9dd08829cc6d80de7844830c0db85e
Author: Matthias Dieter Wallnöfer <mwallnoefer <at> yahoo.de>
Date:   Mon Aug 3 16:07:26 2009 +0200

    s4: Move "operational" LDB module to "SAMDB" since it contains only AD-related stuff

diff --git a/source4/dsdb/samdb/ldb_modules/config.mk b/source4/dsdb/samdb/ldb_modules/config.mk
index c039dda..295d6b5 100644
--- a/source4/dsdb/samdb/ldb_modules/config.mk
+++ b/source4/dsdb/samdb/ldb_modules/config.mk
 <at>  <at>  -323,3 +323,15  <at>  <at>  SUBSYSTEM = LIBLDB

 ldb_instancetype_OBJ_FILES = $(dsdbsrcdir)/samdb/ldb_modules/instancetype.o

+################################################
+# Start MODULE ldb_operational
+[MODULE::ldb_operational]
+SUBSYSTEM = LIBLDB
+CFLAGS = -Ilib/ldb/include
+PRIVATE_DEPENDENCIES = LIBTALLOC LIBTEVENT
+INIT_FUNCTION = LDB_MODULE(operational)
+# End MODULE ldb_operational
+################################################
+
+ldb_operational_OBJ_FILES = $(dsdbsrcdir)/samdb/ldb_modules/operational.o
+
diff --git a/source4/dsdb/samdb/ldb_modules/operational.c b/source4/dsdb/samdb/ldb_modules/operational.c
(Continue reading)

Permalink | Reply | 0 comments |

Gmane