headers
Brad Hards | 1 Oct 2007 12:41

[patch] install attr.h header

G'day,

Samba 4 installs a range of headers, including %prefix/include/util.h.

That header (around line 36) includes util/attr.h, which isn't installed.

This patch just makes sure that util/attr.h is installed. Please apply.

Brad

Index: source/lib/util/config.mk
===================================================================
--- source/lib/util/config.mk   (revision 25440)
+++ source/lib/util/config.mk   (working copy)
 <at>  <at>  -3,6 +3,7  <at>  <at> 
 #SO_VERSION = 0
 #DESCRIPTION = Generic utility functions
 PUBLIC_HEADERS = util.h \
+                                attr.h \
                                 byteorder.h \
                                 data_blob.h \
                                 debug.h \
Index: source/headermap.txt
===================================================================
--- source/headermap.txt        (revision 25440)
+++ source/headermap.txt        (working copy)
 <at>  <at>  -4,6 +4,7  <at>  <at> 
 lib/util/util.h: util.h
 lib/util/debug.h: util/debug.h
 lib/util/mutex.h: util/mutex.h
(Continue reading)

Permalink | Reply | 1 comment |
headers
alvar | 1 Oct 2007 17:36
Picon

Is wbinfo & winbind working?

I've tried to test my  samba 4 domain with wbinfo, but no luck.
Is wbinfo working?
pinging winbind with wbinfo -p no working also.

Alexander Varfolomeev
Permalink | Reply | 1 comment |
headers
Jelmer Vernooij | 1 Oct 2007 20:57
Picon
Favicon

Re: [patch] install attr.h header

Hi Brad,

Am Montag, den 01.10.2007, 20:41 +1000 schrieb Brad Hards:
> Samba 4 installs a range of headers, including %prefix/include/util.h.
> 
> That header (around line 36) includes util/attr.h, which isn't installed.
> 
> This patch just makes sure that util/attr.h is installed. Please apply.
Applied, thanks.

Cheers,

Jelmer
--

-- 
Jelmer Vernooij <jelmer <at> samba.org> - http://samba.org/~jelmer/
Jabber: jelmer <at> jabber.fsfe.org
Permalink | Reply | 0 comments |
headers
Andrew Bartlett | 1 Oct 2007 23:02
Picon
Favicon

Re: svn commit: samba r25448 - in branches/SAMBA_4_0: . source/build/smb_build source/lib/replace source/libcli/util source/librpc/ndr

On Mon, 2007-10-01 at 19:30 +0000, jelmer <at> samba.org wrote:
> Author: jelmer
> Date: 2007-10-01 19:30:27 +0000 (Mon, 01 Oct 2007)
> New Revision: 25448
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25448
> 
> Log:
> Remove IMMEDIATE_STRUCTURES define, which was used for splint. 
> Newer versions of splint support immediate structures just fine.

splint may be fine, but what about all the C compilers?  Split was just
an extra case, where the C compiler didn't support this. 

> Modified: branches/SAMBA_4_0/source/lib/replace/libreplace_cc.m4
> ===================================================================
> --- branches/SAMBA_4_0/source/lib/replace/libreplace_cc.m4	2007-10-01 18:58:38 UTC (rev 25447)
> +++ branches/SAMBA_4_0/source/lib/replace/libreplace_cc.m4	2007-10-01 19:30:27 UTC (rev 25448)
>  <at>  <at>  -159,8 +159,8  <at>  <at> 
>  	libreplace_cv_immediate_structures=no,
>  	libreplace_cv_immediate_structures=cross)
>  ])
> -if test x"$libreplace_cv_immediate_structures" = x"yes"; then
> -	AC_DEFINE(HAVE_IMMEDIATE_STRUCTURES,1,[Whether the compiler supports immediate structures])
> +if test x"$libreplace_cv_immediate_structures" = x"no"; then
> +	AC_MSG_ERROR([compiler does not support immediate structures])
>  fi
>  
>  AC__LIBREPLACE_ONLY_CC_CHECKS_END
>
(Continue reading)

Permalink | Reply | 3 comments |
headers
Jelmer Vernooij | 1 Oct 2007 23:09
Picon
Favicon

Re: svn commit: samba r25448 - in branches/SAMBA_4_0: . source/build/smb_build source/lib/replace source/libcli/util source/librpc/ndr

Am Montag, den 01.10.2007, 14:02 -0700 schrieb Andrew Bartlett:
> On Mon, 2007-10-01 at 19:30 +0000, jelmer <at> samba.org wrote:
> > Author: jelmer
> > Date: 2007-10-01 19:30:27 +0000 (Mon, 01 Oct 2007)
> > New Revision: 25448
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25448
> > 
> > Log:
> > Remove IMMEDIATE_STRUCTURES define, which was used for splint. 
> > Newer versions of splint support immediate structures just fine.
> 
> splint may be fine, but what about all the C compilers?  Split was just
> an extra case, where the C compiler didn't support this. 
The comment said splint was the reason. Immediate structures are pretty
common in C code so it would surprise me if any C compilers didn't
support it yet.

I did leave the check for immediate structures in, so if there really is
a compiler out there that supports C99-style structure initialization
but not immediate structures, we'll know soon from the buildfarm.

Cheers,

Jelmer

--

-- 
Jelmer Vernooij <jelmer <at> samba.org> - http://samba.org/~jelmer/
Jabber: jelmer <at> jabber.fsfe.org
(Continue reading)

Permalink | Reply | 2 comments |
headers
Andrew Bartlett | 1 Oct 2007 23:16
Picon
Favicon

Re: svn commit: samba r25448 - in branches/SAMBA_4_0: . source/build/smb_build source/lib/replace source/libcli/util source/librpc/ndr

On Mon, 2007-10-01 at 23:09 +0200, Jelmer Vernooij wrote:
> Am Montag, den 01.10.2007, 14:02 -0700 schrieb Andrew Bartlett:
> > On Mon, 2007-10-01 at 19:30 +0000, jelmer <at> samba.org wrote:
> > > Author: jelmer
> > > Date: 2007-10-01 19:30:27 +0000 (Mon, 01 Oct 2007)
> > > New Revision: 25448
> > > 
> > > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25448
> > > 
> > > Log:
> > > Remove IMMEDIATE_STRUCTURES define, which was used for splint. 
> > > Newer versions of splint support immediate structures just fine.
> > 
> > splint may be fine, but what about all the C compilers?  Split was just
> > an extra case, where the C compiler didn't support this. 
> The comment said splint was the reason. 

Split was the reason for allowing a manual override, because we don't
'configure' with splint.  

> Immediate structures are pretty
> common in C code so it would surprise me if any C compilers didn't
> support it yet.

When we added this (2001), they were not. :-)

Andrew Bartlett
--

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
(Continue reading)

Permalink | Reply | 0 comments |
headers
Julien Kerihuel | 1 Oct 2007 23:19
Favicon
Gravatar

patch: pidl fix - remove reference to core/nterr.h

The following patch removes reference to #include <core/nterr.h> from
pidl auto generated files.

--

-- 
Julien Kerihuel
j.kerihuel <at> openchange.org
OpenChange Project Manager

GPG Fingerprint: 0B55 783D A781 6329 108A  B609 7EF6 FE11 A35F 1F79
Attachment (pidl_nterr.diff): text/x-patch, 977 bytes
Permalink | Reply | 1 comment |
headers
Jelmer Vernooij | 1 Oct 2007 23:34
Picon

Re: patch: pidl fix - remove reference to core/nterr.h

Am Montag, den 01.10.2007, 23:19 +0200 schrieb Julien Kerihuel:
> The following patch removes reference to #include <core/nterr.h> from
> pidl auto generated files.
We need this include - I've just fixed pidl to use the renamed version.

Cheers,

Jelmer
Permalink | Reply | 0 comments |
headers
Andrew Bartlett | 2 Oct 2007 02:29
Picon
Favicon

Re: svn commit: samba r25456 - in branches/SAMBA_4_0: . source/lib/charset source/param

On Mon, 2007-10-01 at 23:26 +0000, jelmer <at> samba.org wrote:
> Author: jelmer
> Date: 2007-10-01 23:26:37 +0000 (Mon, 01 Oct 2007)
> New Revision: 25456
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25456
> 
> Log:
> Avoid externs for charsets for now - it breaks openchange.
> Modified:
>    branches/SAMBA_4_0/
>    branches/SAMBA_4_0/source/lib/charset/charcnv.c
>    branches/SAMBA_4_0/source/lib/charset/charset.h
>    branches/SAMBA_4_0/source/param/loadparm.c

> Modified: branches/SAMBA_4_0/source/lib/charset/charset.h
> ===================================================================
> --- branches/SAMBA_4_0/source/lib/charset/charset.h	2007-10-01 23:18:26 UTC (rev 25455)
> +++ branches/SAMBA_4_0/source/lib/charset/charset.h	2007-10-01 23:26:37 UTC (rev 25456)
>  <at>  <at>  -77,9 +77,4  <at>  <at> 
>  #define strlower(s) strlower_m(s)
>  #define strupper(s) strupper_m(s)
>  
> -/* from lib/charset */
> -extern char *dos_charset;
> -extern char *unix_charset;
> -extern char *display_charset;
> -
>  #endif /* __CHARSET_H__ */
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Jelmer Vernooij | 2 Oct 2007 02:37
Picon
Favicon

Re: svn commit: samba r25456 - in branches/SAMBA_4_0: . source/lib/charset source/param

Am Montag, den 01.10.2007, 17:29 -0700 schrieb Andrew Bartlett:
> On Mon, 2007-10-01 at 23:26 +0000, jelmer <at> samba.org wrote:
> > Author: jelmer
> > Date: 2007-10-01 23:26:37 +0000 (Mon, 01 Oct 2007)
> > New Revision: 25456
> > 
> > WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=25456
> > 
> > Log:
> > Avoid externs for charsets for now - it breaks openchange.
> > Modified:
> >    branches/SAMBA_4_0/
> >    branches/SAMBA_4_0/source/lib/charset/charcnv.c
> >    branches/SAMBA_4_0/source/lib/charset/charset.h
> >    branches/SAMBA_4_0/source/param/loadparm.c
> 
> > Modified: branches/SAMBA_4_0/source/lib/charset/charset.h
> > ===================================================================
> > --- branches/SAMBA_4_0/source/lib/charset/charset.h	2007-10-01 23:18:26 UTC (rev 25455)
> > +++ branches/SAMBA_4_0/source/lib/charset/charset.h	2007-10-01 23:26:37 UTC (rev 25456)
> >  <at>  <at>  -77,9 +77,4  <at>  <at> 
> >  #define strlower(s) strlower_m(s)
> >  #define strupper(s) strupper_m(s)
> >  
> > -/* from lib/charset */
> > -extern char *dos_charset;
> > -extern char *unix_charset;
> > -extern char *display_charset;
> > -
> >  #endif /* __CHARSET_H__ */
(Continue reading)

Permalink | Reply | 0 comments |

Gmane