Re: svn commit: samba r21991 - in branches/SAMBA_3_0/source: include lib libsmb smbd

On Saturday 31 March 2007 20:33, Jeremy Allison wrote:

Hi Jeremy,

> >
> > PS: If you want, I can get you the code that produced these traces.
>
> Yes please, the code would help so I can match
> the data flows with the calls.

here is the code that produced the trace. It should compile cleanly on an 
MSVC6 compiler. Be warned that it's code I hacked up quickly to do some 
testing and I never got around to really clean it up. It's not exactly clean 
or pretty.

Cheers,
Kai

--

-- 
Kai Blin, <kai Dot blin At gmail Dot com>
WorldForge developer    http://www.worldforge.org/
Wine developer          http://wiki.winehq.org/KaiBlin/
--
Will code for cotton.

Re: svn commit: samba r21991 - in branches/SAMBA_3_0/source: include lib libsmb smbd

On Sun, Apr 01, 2007 at 10:16:50AM +0200, Kai Blin wrote:
> On Saturday 31 March 2007 20:33, Jeremy Allison wrote:
> 
> Hi Jeremy,
> 
> > >
> > > PS: If you want, I can get you the code that produced these traces.
> >
> > Yes please, the code would help so I can match
> > the data flows with the calls.
> 
> here is the code that produced the trace. It should compile cleanly on an 
> MSVC6 compiler. Be warned that it's code I hacked up quickly to do some 
> testing and I never got around to really clean it up. It's not exactly clean 
> or pretty.
> 

Thanks a *lot* - this will help in testing compatibility
possibilities.

Jeremy.

Re: svn commit: samba r22020 - in branches/SAMBA_3_0/source: auth include lib smbd

On Mon, Apr 02, 2007 at 03:46:14AM +0000, abartlet <at> samba.org wrote:
> Author: abartlet
> Date: 2007-04-02 03:46:13 +0000 (Mon, 02 Apr 2007)
> New Revision: 22020
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22020
> 
> Log:
> Make it more clear that both the vuser struct and it's contents are
> talloc_free()'ed at the end of a session.
> 
> Rework the passwd cache code to use talloc_unlink and
> talloc_reference, to more carefully manage the cache.

Ok, I want to go over this with you to ensure I
understand what you're doing here. I'm nervous
about replacing a straight copy with talloc_steal/
reference - a direct copy is much clearer code IMHO
and I don't yet understand the talloc heirarchy
you're creating here. And I need to .

Can I call you tomorrow afternoon (my time) ?

Thanks,

	Jeremy.

Quotas with AIX 5.3

Hi,

Since AIX 5.3 has introduced quotas on jfs2 filesystems, the calls to 
quotactl have been changed. Attached is a patch against 3.0.24 to 
reflect this changes. I have done tests with jfs and jfs2 and it 
works OK.

Thanks for your good work.

cheers

Heinrich Mislik
--

-- 
Heinrich Mislik
Zentraler Informatikdienst der Universitaet Wien
A-1010 Wien, Universitaetsstrasse 7
Tel.: (+43 1) 4277-14056, Fax: (+43 1) 4277-9140

The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any other MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.

   ---- File information -----------
     File:  quota.patch
     Date:  2 Apr 2007, 14:42
     Size:  1720 bytes.

Re: svn commit: samba r22020 - in branches/SAMBA_3_0/source: auth include lib smbd

abartlet <at> samba.org wrote:
> Author: abartlet
> Date: 2007-04-02 03:46:13 +0000 (Mon, 02 Apr 2007)
> New Revision: 22020
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22020
> 
> Log:
> Make it more clear that both the vuser struct and it's contents are
> talloc_free()'ed at the end of a session.
> 
> Rework the passwd cache code to use talloc_unlink and
> talloc_reference, to more carefully manage the cache.

Are the calls to talloc_steal(), et. al really a good idea?
Would you mind justifying why they are needed rather than
the easier to debug dup() calls.  We've had discussions on
list about avoiding them if possible in the Samba 3 tree.

cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian

PLAN: global configuration options from registry

Hi Folks,

as posted here earlier, I am working on the samba registry
configuration code of SAMBA_3_0. My work can be looked at at

http://www.samba.sernet.de/ma/bzr/SAMBA_3_0-registry.bzr/

Up to now, I have been working on a "net conf" utility to
locally edit (and view) the KEY_SMBCONF portion of the
registry. The current set of subcommands is
list, listshares, showshare, addshare, delshare, setparm, 
getparm, delparm, import.
The newest, import allows to import a service or a complete
smb.conf file to the registry.

Despite only the registry shares being functional at this
time, I have designed the net conf utility to work for global
options as well. 

(One open design question here is, whether it is better to 
store the global options in a subkey "global" of KEY_SMBCONF or
as values directly inside KEY_SMBCONF. Currently I store
them directly, but I am not quite decided if I should switch
that as long as it is not too late...)

My next target is to "activate" the global options stored
inside the registry. An _how_ this should be achieved best 
is what I would like to put up for discussion here.

One idea of mine is to introduce a new global smb.conf parameter

Re: [PATCH][SAMBA4] allow separate source and build directories

On Mar 29, 2007, at 12:11 AM, Stefan (metze) Metzmacher wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James Peach schrieb:
>> Hi all,
>>
>> Attached is my patch to allow separate build and source directories  
>> for
>> building Samba 4 updated to the Samba4 build system of a few days  
>> ago.
>> Note that this changes only the build, not the test suite.
>>
>> The use case for this is a build script along the lines of this:
>
> Hi James,
>
> Would it be possible if you commit that step by step.
> Basicly go through the patch and decide for each hunk if it's possible
> to commit it alone with out breaking something. ( I assume 5-7 commits
> would be fine here)

Done. I'm just going to wait for the build farm to settle a bit, then  
I'm going to do an experimental checking to erplace $* with $< just to  
find out which platforms break. I'll back it out once I get the build  
breakage mail.

> about the $*.c vs. $< I'd like to use somthing like this:

Re: svn commit: samba r22037 - in branches/SAMBA_4_0/source/build/smb_build: .

jpeach <at> samba.org schrieb:
> Author: jpeach
> Date: 2007-04-02 17:29:03 +0000 (Mon, 02 Apr 2007)
> New Revision: 22037
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22037
> 
> Log:
> Make sure STATICDIR exists before linking a static archive.

Hi James,

thanks for splitting up this commit

have you thought about the $< vs.*.c yet?

metze

Re: svn commit: samba r22043 - in branches: SAMBA_3_0/source/smbd SAMBA_3_0_25/source/smbd

On Mon, Apr 02, 2007 at 07:46:27PM +0000, vlendec <at> samba.org wrote:
> Author: vlendec
> Date: 2007-04-02 19:46:27 +0000 (Mon, 02 Apr 2007)
> New Revision: 22043
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22043
> 
> Log:
> Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
> easier to review! Damn close to what I had in my tree, just the fn names were
> slightly different.
> 
> This removes one unnecessary dupe.
> 
> Next thing is to get rid of the parameter "n" of skip_string, there is only
> one (!) caller that does not pass in 1....

Ok, I'll take care of that - thanks for pointing it out ! Should
make our code cleaner.

Jeremy.

Re: svn commit: samba r22037 - in branches/SAMBA_4_0/source/build/smb_build: .

On Apr 2, 2007, at 11:13 AM, Stefan (metze) Metzmacher wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> jpeach <at> samba.org schrieb:
>> Author: jpeach
>> Date: 2007-04-02 17:29:03 +0000 (Mon, 02 Apr 2007)
>> New Revision: 22037
>>
>> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22037
>>
>> Log:
>> Make sure STATICDIR exists before linking a static archive.
>
> Hi James,
>
> thanks for splitting up this commit
>
> have you thought about the $< vs.*.c yet?

I think the right thing might be to require GNU Make for $srcdir !=  
$builddir. If you search the automake mailing list, there are claims  
that GNU Make is the only make that implements VPATH "correctly".

So the trick is to actually implement this. Since configure doesn't do  
substitutions on main.mk AFAICT, probably the best thing to do is to  
have the perl build tools emit the default build rules somewhere.

--