Martin Schwenke | 23 Sep 09:19 2014

[PATCHES] lib/util - cleanups, build restructuring, charset compatibility

Clean up includes for 8 files in lib/util. Then:

* Break out a subset of samba-util (above 8 files, plus 1 more) into a
  new samba-util-core subsystem.  Build samba-util itself and other
  subsystems not needed by samba-util-core when SAMBA_UTIL_CORE_ONLY is
  *not* defined.  This avoids building everything else (with resulting
  dependency explosion) when doing a standalone CTDB build (see
  ctdb-build branch below).

* If SAMBA_UTIL_CORE_ONLY is defined then include new charset_compat.h
  instead of charset/charset.h in the above (and samba_util.h).  This
  is a hack but, as the commit message says, I think it is the most
  honest hack that avoids unnecessarily pulling in charset and then

Apart from cleanups, without SAMBA_UTIL_CORE_ONLY defined this is
intended to cause no change in a Samba build.

Please review and push if OK.

These patches are in my samba-build branch:;a=shortlog;h=refs/heads/samba-build

For context, there are 2 other branches that follow from this branch:

* ctdb-build

  Changes required for a CTDB standalone build against Samba's lib/util
  (subset) and tdb-wrap.  We'd like to keep doing standalone builds
(Continue reading)

David Disseldorp | 22 Sep 19:48 2014

[PATCH] WHATSNEW: Mention smbclient archival improvements

Aurélien Aptel implemented this feature for Google Summer of Code 2013.

Cc: Aurélien Aptel <aurelien.aptel <at>>
Signed-off-by: David Disseldorp <ddiss <at>>
 WHATSNEW.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 295cbb6..10a97d4 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
 <at>  <at>  -138,6 +138,16  <at>  <at>  use the following steps:
   $ make
   # make install

+smbclient archival improvements
+Archive creation and extraction support in smbclient has been rewritten
+to use libarchive. This fixes a number of outstanding bugs in Samba's
+previous custom tar implementation and also adds support for the
+extraction of zipped archives.
+smbclient archive support can be enabled or disabled at build time with
+corresponding --with[out]-libarchive configure parameters.


(Continue reading)

Andreas Schneider | 22 Sep 17:35 2014

[PATCH] Improve guessing of the kerberos service principal


attached find a patch to improve guessing of the kerberos service principal. 
This fixes 'net ads' if you provide a long hostname with the -S option. If it 
is longer than a netbios name we should construct a FQDN with it.

Please review and push if ok.


	-- andreas


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn <at>
Martin Schwenke | 22 Sep 08:42 2014

[PATCHES] CTDB test cleanups

Some cleanups for CTDB tests that check correctness of IP assignments.
One patch removes a dependency on the CTDB log ringbuffer.

Please review and push if OK.

peace & happiness,
Attachment (ctdb.patches): application/octet-stream, 51 KiB
Andreas Schneider | 22 Sep 08:20 2014

[PATCH] fix smbclient segfault


attached find a patch to fix a segfault in smbclient.

	-- andreas


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn <at>
Ata E Husain Bohra | 22 Sep 06:59 2014


Hi All,

I'm new to samba development; with the current assignment I want to trap
SAMBA calls by introducing a custom VFS module and pass it to a custom

I've followed "Writing VFS module" by Richard and implemented a skeleton
vfs module. I hooked the module to the build process and can observe my
module getting compiled. For initial setup, I installed samba on a Centos
6.4 VM and exported a local directory (created under '/') as a share. I'm
using "smbclient" to access the share ( access URL is //localhost/≤name of
share>), my smb.conf looks like:

        workgroup = CORP
        server string = Samba Server Version %v
        netbios name = <machine-name>

;       netbios name = MYSERVER

;       interfaces = lo eth0
        hosts allow = 127.

        # logs split per machine
        log file = /var/log/samba/log.%m
        log level = 10
        # max 50KB per log file, then rotate
        max log size = 50

(Continue reading)

Karel Lang AFD | 22 Sep 06:32 2014

samba 3.6.9-164 - is "kernel oplocks = no" option viable on purely Samba shared FS?

anyone tried to speed up samba file transfer over the network by turning 
off the kernel opportunity locking - the so called:
"kernel oplocks = no" on production server, if yes, were the results 
safe enough (in regards of data consistency)?

2 questions:

In scenario, where you have purely data storage filesystem (no apps, no 
databases anything), shared only over Samba and accessed by windows 
client workstations - would it be OK to use the "kernel oplocks = no" 

is the "kernel oplocks = no" still Global option??
it used to be a global option, but i read somewhere that devs wanted to 
code it as 'Share' option - which would be great for testing ..

I'm asking this because i found out some 2years old discussion from 
list, where Christian Ambach was doing something about it. But i can't 
find more 'fresh' info and official 'Samba 3 howto' documentations lists 
the 'kernel oplocks' as 'Global' option..

I tried to post this question to regular 'general' samba forums, but as 
noone replied there, i figgured this could be the right place to ask ..

thank you

(Continue reading)

Michael Adam | 22 Sep 03:39 2014

[PATCHES] tests and smbtorture3


attached find three small patches.

The first one lets the LOCAL-* smbtorture3 tests
run not against the s3dc environment but against
the "none" env. These tests don't need any server running.

The second and third patche improve the help message
of smbtorture3.

Review/push/comment appreciated.

Thanks - Michael
From a9fe1f69587de827283dd0c92812d1943bfb161c Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox <at>>
Date: Mon, 22 Sep 2014 01:24:49 +0200
Subject: [PATCH 1/3] selftst: run the smbtorture3 local tests in the "none"

Signed-off-by: Michael Adam <obnox <at>>
 source3/selftest/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/selftest/ b/source3/selftest/
index 126c26c..f3ecdff 100755
--- a/source3/selftest/
(Continue reading)

Brad Hards | 22 Sep 00:51 2014


On Mon, 22 Sep 2014 12:24:49 AM Volker Lendecke wrote:
> On Mon, Sep 22, 2014 at 07:44:53AM +1000, Brad Hards wrote:
> > On Sat, 20 Sep 2014 05:39:56 PM Volker Lendecke wrote:
> > > Hi!
> > > 
> > > Please review&push!
> > 
> > Minor suggestion:
> > Replace:
> > Tdb has furthermore improved to manage its file space more efficiently.
> > with:
> > Tdb file space management has also been made more efficient.
> Submit that as a patch, I'll ack it :-)
OK. See attached.
Since I had to clone the whole repo, I threw in some additional fixes to make 
it worth the effort...

Attachment (whatsnew-2014-09-22.patch): text/x-patch, 2385 bytes
Karolin Seeger | 21 Sep 20:10 2014

[PATCH] WHATSNEW: Fix typos.


please find attached a patch to fix 2 typos in the release notes.
Feel free to push.





Volker Lendecke | 20 Sep 17:39 2014



Please review&push!



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen, mailto:kontakt <at>
From 7e7745e4a0936a07de9b1c646f87eefc6cb792a1 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl <at>>
Date: Sat, 20 Sep 2014 17:16:49 +0200
Subject: [PATCH 1/2] WHATSNEW: Mention tdb mutexes

Signed-off-by: Volker Lendecke <vl <at>>
 WHATSNEW.txt |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index e9a5627..a474d7e 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
 <at>  <at>  -95,6 +95,22  <at>  <at>  systematized and subcommands for reading and writing the autorid idmap
(Continue reading)