[PATCH] Optimisation for readdir using fstatat.

Ira (and others of course ,

This is the complete proposed patch to improve
directory performance for deep directory trees.
Can you test and review +1 if you're ok with it.

Cheers,

	Jeremy.

From a1044b693603e24c86efb5384172abb7727abd3a Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra <at> samba.org>
Date: Fri, 24 May 2013 10:33:16 -0700
Subject: [PATCH 1/2] Add HAVE_DIRFD to waf/autoconf. Detect fstatat.

Signed-off-by: Jeremy Allison <jra <at> samba.org>
---
 source3/configure.in | 6 ++++++
 source3/wscript      | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/source3/configure.in b/source3/configure.in
index 0e2f126..b7a9620 100644
--- a/source3/configure.in
+++ b/source3/configure.in
 <at>  <at>  -834,9 +834,15  <at>  <at>  fi

 AC_CHECK_FUNCS(dirfd)
 if test x"$ac_cv_func_dirfd" = x"yes"; then

[PATCH] winbind: Print error code on connection error in ping_dc

For debugging, it is useful to include the error code in the message.
---
 source3/winbindd/winbindd_dual_srv.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
index 744e251..e23d048 100644
--- a/source3/winbindd/winbindd_dual_srv.c
+++ b/source3/winbindd/winbindd_dual_srv.c
 <at>  <at>  -690,7 +690,8  <at>  <at>  NTSTATUS _wbint_PingDc(struct pipes_struct *p, struct wbint_PingDc *r)
 	status = cm_connect_netlogon(domain, &netlogon_pipe);
 	reset_cm_connection_on_error(domain, status);
         if (!NT_STATUS_IS_OK(status)) {
-                DEBUG(3, ("could not open handle to NETLOGON pipe\n"));
+		DEBUG(3, ("could not open handle to NETLOGON pipe: %s\n",
+			  nt_errstr(status)));
 		return status;
         }

--

-- 
1.7.1

[PATCH] pmda: handle new ctdb_statistics format

From: David Disseldorp <ddiss <at> samba.org>

The ctdb_statistics structure was recently changed. Update the PMDA to
dereference the new structure member names.

Signed-off-by: David Disseldorp <ddiss <at> samba.org>
---
 utils/pmda/pmda_ctdb.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/utils/pmda/pmda_ctdb.c b/utils/pmda/pmda_ctdb.c
index c8983ef..e8033be 100644
--- a/utils/pmda/pmda_ctdb.c
+++ b/utils/pmda/pmda_ctdb.c
 <at>  <at>  -121,10 +121,10  <at>  <at>  static pmdaMetric metrictab[] = {
 	/* pending_calls */
 	{ NULL, { PMDA_PMID(14,25), PM_TYPE_U32, PM_INDOM_NULL, PM_SEM_INSTANT,
 		PMDA_PMUNITS(0,0,0,0,0,0) }, },
-	/* lockwait_calls */
+	/* locks.num_calls */
 	{ NULL, { PMDA_PMID(15,27), PM_TYPE_U32, PM_INDOM_NULL, PM_SEM_COUNTER,
 		PMDA_PMUNITS(0,0,1,0,0,PM_COUNT_ONE) }, },
-	/* pending_lockwait_calls */
+	/* locks.pending_calls */
 	{ NULL, { PMDA_PMID(16,27), PM_TYPE_U32, PM_INDOM_NULL, PM_SEM_INSTANT,
 		PMDA_PMUNITS(0,0,0,0,0,0) }, },
 	/* childwrite_calls */
 <at>  <at>  -148,10 +148,10  <at>  <at>  static pmdaMetric metrictab[] = {
 	/* max_call_latency */
 	{ NULL, { PMDA_PMID(23,34), PM_TYPE_DOUBLE, PM_INDOM_NULL, PM_SEM_INSTANT,

[PATCH 3/3 v5] vfs_glusterfs: Samba VFS module for glusterfs

Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
This is a "bottom" vfs plugin (not something to be stacked on top of
another module), and translates (most) calls into closest actions
on gfapi.

Signed-off-by: Anand Avati <avati <at> redhat.com>
---
 source3/Makefile.in             |    5 +
 source3/configure.in            |   11 +
 source3/modules/vfs_glusterfs.c | 1237 +++++++++++++++++++++++++++++++++++++++
 source3/modules/wscript_build   |    9 +
 source3/wscript                 |    6 +
 5 files changed, 1268 insertions(+), 0 deletions(-)
 create mode 100644 source3/modules/vfs_glusterfs.c

diff --git a/source3/Makefile.in b/source3/Makefile.in
index efe0694..a12887d 100644
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
 <at>  <at>  -915,6 +915,7  <at>  <at>  VFS_TIME_AUDIT_OBJ = modules/vfs_time_audit.o
 VFS_MEDIA_HARMONY_OBJ = modules/vfs_media_harmony.o
 VFS_BTRFS_OBJ = modules/vfs_btrfs.o
 VFS_CEPH_OBJ = modules/vfs_ceph.o
+VFS_GLUSTERFS_OBJ = modules/vfs_glusterfs.o

 PAM_ERRORS_OBJ = ../libcli/auth/pam_errors.o
 PLAINTEXT_AUTH_OBJ = auth/pampass.o auth/pass_check.o $(PAM_ERRORS_OBJ)
 <at>  <at>  -2963,6 +2964,10  <at>  <at>  bin/ceph. <at> SHLIBEXT <at> : $(BINARY_PREREQS) $(VFS_CEPH_OBJ)
 	 <at> echo "Building plugin $ <at> "
 	 <at> $(SHLD_MODULE) $(VFS_CEPH_OBJ)

Max number of ACEs in an SD ...

Hi folks,

It seems that the IDL for SDs limits the number of ACEs to 1,000. It
also seems that Windows maxes out at around 1,820 ACEs.

That is a ridiculous number of ACEs, but has anyone tried anything
larger than 1,000?

--

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)

[PATCH 3/3 v4] vfs_glusterfs: Samba VFS module for glusterfs

Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
This is a "bottom" vfs plugin (not something to be stacked on top of
another module), and translates (most) calls into closest actions
on gfapi.

Signed-off-by: Anand Avati <avati <at> redhat.com>
---
 source3/Makefile.in             |    5 +
 source3/configure.in            |   11 +
 source3/modules/vfs_glusterfs.c | 1237 +++++++++++++++++++++++++++++++++++++++
 source3/modules/wscript_build   |    9 +
 source3/wscript                 |    6 +
 5 files changed, 1268 insertions(+), 0 deletions(-)
 create mode 100644 source3/modules/vfs_glusterfs.c

diff --git a/source3/Makefile.in b/source3/Makefile.in
index efe0694..a12887d 100644
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
 <at>  <at>  -915,6 +915,7  <at>  <at>  VFS_TIME_AUDIT_OBJ = modules/vfs_time_audit.o
 VFS_MEDIA_HARMONY_OBJ = modules/vfs_media_harmony.o
 VFS_BTRFS_OBJ = modules/vfs_btrfs.o
 VFS_CEPH_OBJ = modules/vfs_ceph.o
+VFS_GLUSTERFS_OBJ = modules/vfs_glusterfs.o

 PAM_ERRORS_OBJ = ../libcli/auth/pam_errors.o
 PLAINTEXT_AUTH_OBJ = auth/pampass.o auth/pass_check.o $(PAM_ERRORS_OBJ)
 <at>  <at>  -2963,6 +2964,10  <at>  <at>  bin/ceph. <at> SHLIBEXT <at> : $(BINARY_PREREQS) $(VFS_CEPH_OBJ)
 	 <at> echo "Building plugin $ <at> "
 	 <at> $(SHLD_MODULE) $(VFS_CEPH_OBJ)

[PATCH 2/3 v4] vfs_posixacl: expose acl_t <--> smb_acl_t converter functions

These converters are used in vfs_glusterfs for storing posix acls
as xattrs (where acl_set_file does not work)

Signed-off-by: Anand Avati <avati <at> redhat.com>
---
 source3/modules/vfs_posixacl.c |    7 ++-----
 source3/modules/vfs_posixacl.h |    3 +++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/source3/modules/vfs_posixacl.c b/source3/modules/vfs_posixacl.c
index 6963aae..7733832 100644
--- a/source3/modules/vfs_posixacl.c
+++ b/source3/modules/vfs_posixacl.c
 <at>  <at>  -26,10 +26,7  <at>  <at> 

 static bool smb_ace_to_internal(acl_entry_t posix_ace,
 				struct smb_acl_entry *ace);
-static struct smb_acl_t *smb_acl_to_internal(acl_t acl, TALLOC_CTX *mem_ctx);
 static int smb_acl_set_mode(acl_entry_t entry, SMB_ACL_PERM_T perm);
-static acl_t smb_acl_to_posix(const struct smb_acl_t *acl);
-

 /* public functions - the api */

 <at>  <at>  -213,7 +210,7  <at>  <at>  static bool smb_ace_to_internal(acl_entry_t posix_ace,
 	return True;
 }

-static struct smb_acl_t *smb_acl_to_internal(acl_t acl, TALLOC_CTX *mem_ctx)
+struct smb_acl_t *smb_acl_to_internal(acl_t acl, TALLOC_CTX *mem_ctx)

[PATCH 1/3 v4] samba.spec.tmpl: fix typo

building RPMs on RHEL fail because of a typo.

Signed-off-by: Anand Avati <avati <at> redhat.com>
---
 packaging/RHEL/samba.spec.tmpl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/packaging/RHEL/samba.spec.tmpl b/packaging/RHEL/samba.spec.tmpl
index 7df7cb5..05e46e1 100644
--- a/packaging/RHEL/samba.spec.tmpl
+++ b/packaging/RHEL/samba.spec.tmpl
 <at>  <at>  -2,7 +2,7  <at>  <at> 
 %define auth %(test -f /etc/pam.d/system-auth && echo /etc/pam.d/system-auth || echo)
 %define this_is_redhat  %(test -e /etc/redhat-release && echo 1 || echo 0)
 %if %{this_is_redhat} > 0
-%define rhel_ver %(grep "release" /etc/redhat-release | sed %"s/^[^0-9]*\\([0-9]*\\).*/\\1/g")
+%define rhel_ver %(grep "release" /etc/redhat-release | sed "s/^[^0-9]*\\([0-9]*\\).*/\\1/g")
 %else
 %define rhel_ver 0
 %endif
--

-- 
1.7.1

tdb questions

Hi list,
I'm looking for tdb docs and examples. In the wiki there is the sources to download and I'm reading them but I
have some questions and I'm sure you can answer.

Which is the difference between using or not mmap? Is it suggested the use of mmap and if not available there
is the fallback or are there other things to take in account when making the choice?

From what I know, tdb is a persistent db. The application I'working on would work on a system which can loose
power so which would be the best practices to avoid corruptions?

Any help would be greately appreciated.

Regards,
Daniele. 

SE_RESTORE_PRIVILEGE, BACKUP_INTENT and W2K08R2

Hi folks,

I had always assumed that SE_BACKUP_PRIVILEGE and SE_RESTORE_PRIVILEGE
could only be invoked in the context of a CREATE when the CREATE
OPTIONS included BACKUP_INTENT.

However, I have a capture against Windows where this seems not to be
the case. If the requester has SE_RESTORE_PRIVILEGE it seems that
Windows will allow them to change the owner on a file to anything they
want.

Is this what people see as well?

--

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)

Re: Patch vs upgrade

What is the case of running the patch then? Is the patch just a dirty fast upgrade fix, so you don't wait to
compile the full thing?

------Original Message------
From: Richard Sharpe
To: Eu
Cc: samba-technical <at> lists.samba.org
Subject: Re: Patch vs upgrade
Sent: May 23, 2013 9:21 AM

On Thu, May 23, 2013 at 8:14 AM, Bogdan Bartos <admin <at> blackpenguin.org> wrote:
> I downloaded the 4.0.6 and compiled from source. I did not run the patch.

OK, since you downloaded the 4.0.6 source and built and installed
that, you do not need to apply the patch that would take you from the
4.0.5 source to the 4.0.6 source.

> ------Original Message------
> From: Richard Sharpe
> To: Eu
> Cc: samba-technical <at> lists.samba.org
> Subject: Re: Patch vs upgrade
> Sent: May 23, 2013 9:11 AM
>
> On Thu, May 23, 2013 at 7:56 AM, bogdan_bartos <admin <at> blackpenguin.org> wrote:
>> Hi all,
>>
>> I have samba 4.0.6 and I upgraded from 4.0.5 by doing ./configure, make,
>> make install. I did not install any patch for samba 4.0.5. Should the old
>> versions be patched prior to upgrade? Should the patch be run before or