Günter Kukkukk | 18 Apr 17:06 2014

configure.developer does not find some xfs related include files

Hi all,

probably one of the WAF gurus might want to have a look.

When running ./configure.developer on opensuse-13.1 i noticed some missing
XFS related include files.
The xfs-devel package is installed.

1.) "Use xfs.h rather than libxfs.h"

2.) xfs/xqm.h is there, but the included file uuid.h cannot be found
Checking for header xfs/xqm.h
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <stdlib.h>
#include <stddef.h>
#include <memory.h>
#include <string.h>
#include <strings.h>
#include <inttypes.h>
#include <stdint.h>
#include <unistd.h>
#include <ctype.h>
#include <stdbool.h>
#include <stdarg.h>
#include <xfs/xqm.h>
(Continue reading)

Christof Schmitt | 17 Apr 22:52 2014

[PATCH] vfs_gpfs: Avoid warnings in developer build

From 99d17843fc2481d2baa39368a8b1704e8ec4323c Mon Sep 17 00:00:00 2001
From: Christof Schmitt <cs <at> samba.org>
Date: Thu, 17 Apr 2014 13:43:53 -0700
Subject: [PATCH] vfs_gpfs: Avoid warnings in developer build

Remove an unused variable and use discard_const_p.

Signed-off-by: Christof Schmitt <cs <at> samba.org>
 source3/modules/vfs_gpfs.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index edbc885..a56af8f 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
 <at>  <at>  -327,7 +327,7  <at>  <at>  again:
 	*len = size;

 	errno = 0;
-	ret = smbd_gpfs_getacl((char *)fname, flags, aclbuf);
+	ret = smbd_gpfs_getacl(discard_const_p(char, fname), flags, aclbuf);
 	if ((ret != 0) && (errno == ENOSPC)) {
 		 * get the size needed to accommodate the complete buffer
 <at>  <at>  -1127,7 +1127,8  <at>  <at>  static int gpfsacl_sys_acl_set_file(vfs_handle_struct *handle,
 		return -1;

-	result = smbd_gpfs_putacl((char *)name, GPFS_PUTACL_STRUCT | GPFS_ACL_SAMBA, gpfs_acl);
(Continue reading)

Christof Schmitt | 17 Apr 22:51 2014

[PATCH] smbd: Remove unused code for dos attributes in stat struct

From fba9c5c47c650e20848bedab350bd7184e734f69 Mon Sep 17 00:00:00 2001
From: Christof Schmitt <cs <at> samba.org>
Date: Thu, 17 Apr 2014 13:46:38 -0700
Subject: [PATCH] smbd: Remove unused code for dos attributes in stat struct

This code is unused since the move to the waf build system.

Signed-off-by: Christof Schmitt <cs <at> samba.org>
 source3/smbd/dosmode.c |  139 ++----------------------------------------------
 1 files changed, 4 insertions(+), 135 deletions(-)

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index 831f6d0..9d0efce 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
 <at>  <at>  -541,115 +541,6  <at>  <at>  uint32 dos_mode_msdfs(connection_struct *conn,

- Convert dos attributes (FILE_ATTRIBUTE_*) to dos stat flags (UF_*)
-int dos_attributes_to_stat_dos_flags(uint32_t dosmode)
-	uint32_t dos_stat_flags = 0;
(Continue reading)

Jeremy Allison | 17 Apr 18:10 2014

Re: [PATCH] Fix bug 9412 - SMB2 server doesn't support recvfile.

On Thu, Apr 17, 2014 at 02:29:46PM +0800, Jones wrote:
> 2014-04-17 3:28 GMT+08:00 Jeremy Allison <jra <at> samba.org>:
>      Once the input socket is set to blocking
>      mode, then the only way splice() can
>      return EAGAIN is if the flag SPLICE_F_NONBLOCK
>      is passed into splice - which we don't
>      do.
>      So I can't currently see any way that
>      splice can return EAGAIN once the
>      input socket is set to blocking mode.
>      Are you using a custom splice() call ?
>      If not, what kernel are you using so
>      I can look at exactly the source code
>      you have ?
> Hello Jeremy,
> Yes! Im using a custom splice call,
> not just the normal kernel splice.
> Look at the sys_recvfile, 
> the flag SPLICE_F_NONBLOCK is not passed into splice,
> but the EAGAIN still returned on my testing.
> Hmm maybe this is because the custom kernel part did it,
> i would try to dig further,
> thanks you.
(Continue reading)

Andrew Bartlett | 17 Apr 12:52 2014

[PATCH] Remove talloc_reference of event context in samba_dsdb stack and smb_krb5_init_context

Given the Team's dislike for both nested event loops and
talloc_reference, it seems fitting that my 'modest proposal' for
limiting one gives the opportunity to find and remove the the latter.

This patch uses the fact that the dsdb modules do not need to talk over
the network, so no event context need be specified or handled over to
talloc_reference, based on the messages my test of the patch in

Then I follow up by removing the parameter entirely, as it just isn't

Please review/push

Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

Karolin Seeger | 17 Apr 11:36 2014

[Release Planning 4.1] Samba 4.1.8 on June 3


Samba 4.1.8 is scheduled for Tuesday, June 3.
has been updated.

That means, the release branches will be frozen on Tuesday, May 27.



Samba			http://www.samba.org
SerNet			http://www.sernet.de
sambaXP			http://www.sambaxp.org

Jones | 17 Apr 09:19 2014

Re: [PATCH] Fix bug 9412 - SMB2 server doesn't support recvfile.

Hello list,

Excuse me to resend this mail,
looks like the size of attached file is too big,
hence put it to alternative link:



2014-04-17 13:15 GMT+08:00 Jones <jones.kstw <at> gmail.com>:

> 2014-04-17 5:34 GMT+08:00 Jeremy Allison <jra <at> samba.org>:
> Can you give me more details as to
>> how you're reproducing this problem ?
> Hello Jeremy,
> Sure!
> The attached picture is what I reproduce the EAGAIN,
> hmm hope following description is not too chatter.
> Over a normal LAN which owned RTT is always <1ms,
> cannot easily see splice returned -1 with EAGAIN.
> Hence try to increase the RTT through the WANem,
(Continue reading)

Andrew Bartlett | 17 Apr 06:05 2014

A Modest Proposal for Preventing the Event loops of Samba DCs From Being a Burthen to Their Implementers or Users, and for Making Them Beneficial to the Publick

I have a modest proposal that I think might just reduce the instances of
DRS corruption and replication deadlocks we have been seeing recently,
and move us one step closer the goal of not using nested event loops in

In debugging a recent case of a DRS deadlock, we found the DC running
and looping while in a transaction.  Indeed, it isn't at all clear that
the memory context it was using are valid, as it enters code that should
be skipped due to having 'relax' set.

In any case, running other arbitrary things under a transaction can lead
to quite strange errors, such as claiming the successful write of data
that is then discarded when the transaction is cancelled.

(Transactions are rarely cancelled in Samba, which is why we got away
with this for so long).

Anyway, what I propose is that when we we are in a transaction, that a
new event context is created, and that this operates until the
transaction is over.  That way, only internal ldb events should fire.
(We never did define how non-nested transactions and async ldb would
work in any case.) 

Other than LDB, the only other things using events at this point would
be the irpc handler, which needs to be able to send messages to other
parts of Samba.  Currently this uses it's own event context (an issue
that will need to be fixed as we work to make that code common anyway),
so this isn't affected/protected.

We could, and perhaps should, totally remove the use of an external
(Continue reading)

Stuart Naylor | 16 Apr 21:24 2014

RE:Samba 4.0.17 Available for Download

Great news.

Just wondered if you guys had a good reference point for compiling for the noob?

I will have to google again to tag the version in git as my memory is generally vague.

The only things I generally get confused on is how to change the output folders so they are distro specific.

I have just been disabling apparmor and selinux but if anybody has some sample profiles it would be great.

Basically I have been using the Sernet binaries as my compile skills are not great.

If its a make or make install then great but I sort of struggle from that point.

If there was a little bit more info on distro specific compiles then perhaps I would compile and report back
more often.

I think I will stick with the Sernet Binaries as I am expecting the compile to be good so that is I get any bugs
then I am not reporting compile mistakes, conflicts....

Many thanks Sernet Guys as I will wait for 4.0.17 and I presume 4.1.17 will be soon?

With the Sernet binaries are you going to release a repo that has all the logging turned upto the max?

It would be great if others provided other binaries for a point of reference. I think I can get involved in
noob feedback and staying away from compiling will make my input of higher quality.


(Continue reading)

Jeff Layton | 16 Apr 20:57 2014

should we change the name/macros of file-private locks?

Sorry to spam so many lists, but I think this needs widespread
distribution and consensus.

File-private locks have been merged into Linux for v3.15, and *now*
people are commenting that the name and macro definitions for the new
file-private locks suck.

...and I can't even disagree. They do suck.

We're going to have to live with these for a long time, so it's
important that we be happy with the names before we're stuck with them.

Michael Kerrisk suggested several names but I think the only one that
doesn't have other issues is "file-associated locks", which can be
distinguished against "process-associated" locks (aka classic POSIX

At the same time, he suggested that we rename the command macros since
the 'P' suffix would no longer be relevant. He suggested something like


That would also make them more visually distinguishable from the
classic F_GETLK/F_SETLK/F_SETLKW commands. I like that change in
particular, as the original macros names would be easy to typo.

I think we'd also need to rename how these are reported in /proc/locks.
(Continue reading)

Andreas Schneider | 15 Apr 10:13 2014

Re: Remove dead code from plaintext auth case (impacting on AFS, DCE/DFS, OSF1, HP-UX and others)

On Monday 14 April 2014 20:46:35 you wrote:
> The fake-kaserver code was never part of this patch set, and it is at
> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortl
> og;h=refs/heads/plaintext-auth-dead-code

Thanks Andrew,

I've pushed it to autobuild!

	-- andreas


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn <at> samba.org