headers
Andrew Bartlett | 1 Jul 2011 03:55
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  f3c3768 s4-dsdb guard principalName parse for invalid inputs
       via  f1b1a66 s4-dsdb Allow a servicePrincipalName of machine$
      from  1053a24 Part of fix for bug 8276 - FD_SET out of bounds access crash.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit f3c3768d30410de8b0cc8b2ef078640bdc0864d4
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Thu Jun 30 14:21:51 2011 +1000

    s4-dsdb guard principalName parse for invalid inputs

    We need to ensure that if this parses name.name_string as just one
    val, then we don't read uninitialised and possibly unallocated memory.
    Found by Adam Thorn <alt36 <at> cam.ac.uk>

    While we are checking that, we need to fix the strncasecmp() check to
    first check if the string is the expected length, then check for a
    match against sAMAccountName-without-doller, as otherwise we will
    permit a string such as machinefoo to match a sAMAccountName of
    machine.

    Andrew Bartlett

    Autobuild-User: Andrew Bartlett <abartlet <at> samba.org>
    Autobuild-Date: Fri Jul  1 03:55:00 CEST 2011 on sn-devel-104

commit f1b1a66615bfceb4d53c11140aceba2412d0ec37
(Continue reading)

Permalink | Reply | 0 comments |
headers
Stefan (metze) Metzmacher | 1 Jul 2011 08:46
Picon
Favicon

nmbd FD_SET change for master/3.6

Hi Jeremy,

> diff --git a/source3/nmbd/nmbd_packets.c b/source3/nmbd/nmbd_packets.c
> index a89f49c..0324c9d 100644
> --- a/source3/nmbd/nmbd_packets.c
> +++ b/source3/nmbd/nmbd_packets.c
>  <at>  <at>  -1698,7 +1698,12  <at>  <at>  static bool create_listen_pollfds(struct pollfd **pfds,
>  	for (subrec = FIRST_SUBNET;
>  	     subrec != NULL;
>  	     subrec = NEXT_SUBNET_EXCLUDING_UNICAST(subrec)) {
> -		count += 2;	/* nmb_sock and dgram_sock */
> +		if (subrec->nmb_sock != -1) {
> +			count += 1;
> +		}
> +		if (subrec->dgram_sock != -1) {
> +			count += 1;
> +		}
>  		if (subrec->nmb_bcast != -1) {
>  			count += 1;
>  		}

Can you please explain me where this can happen? I think
nmb_sock and dgram_sock are always valid.

metze
Permalink | Reply | 1 comment |
headers
Stefan Metzmacher | 1 Jul 2011 12:38
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  1765833 s3:smbldap: make smbldap_connect_system self contained
       via  6aff8b1 s3:smbldap: add a destructor to smbldap_state, just in case
       via  796c7ab s3:smbldap: let smbldap_free_struct do what it claims to
       via  7eb9c70 s3:smbldap: free the idle event scheduled in smbldap_open in smbldap_close
       via  343ef46 s3:smbldap: use smbldap_state as memory context for idle event
      from  f3c3768 s4-dsdb guard principalName parse for invalid inputs

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit 1765833481ca441429bdf8dd167b729a24edbfa2
Author: Gregor Beck <gbeck <at> sernet.de>
Date:   Tue Jun 21 08:16:56 2011 +0200

    s3:smbldap: make smbldap_connect_system self contained

    Signed-off-by: Stefan Metzmacher <metze <at> samba.org>

    Autobuild-User: Stefan Metzmacher <metze <at> samba.org>
    Autobuild-Date: Fri Jul  1 12:37:50 CEST 2011 on sn-devel-104

commit 6aff8b19fcdbf694cc8dbd388f87e55cce475939
Author: Gregor Beck <gbeck <at> sernet.de>
Date:   Tue Jun 21 08:06:28 2011 +0200

    s3:smbldap: add a destructor to smbldap_state, just in case

    Signed-off-by: Stefan Metzmacher <metze <at> samba.org>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Günther Deschner | 1 Jul 2011 17:58
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  bafd721 s3-net: use printing_migrate library, and eliminate duplicate code.
       via  e02abd6 s3-printing: split out printing migration code into a smaller library.
      from  1765833 s3:smbldap: make smbldap_connect_system self contained

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit bafd7212eb4c82e86874b2f80ddf5c04b2d180b9
Author: Günther Deschner <gd <at> samba.org>
Date:   Fri Jul 1 15:02:26 2011 +0200

    s3-net: use printing_migrate library, and eliminate duplicate code.

    Guenther

    Autobuild-User: Günther Deschner <gd <at> samba.org>
    Autobuild-Date: Fri Jul  1 17:57:09 CEST 2011 on sn-devel-104

commit e02abd6c83708f297b1985bb1bdc7d5dfbc924b2
Author: Günther Deschner <gd <at> samba.org>
Date:   Fri Jul 1 14:57:32 2011 +0200

    s3-printing: split out printing migration code into a smaller library.

    Guenther

-----------------------------------------------------------------------

Summary of changes:
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Bartlett | 2 Jul 2011 05:43
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  7e52436 s4-param Remove unused 'announce version'
       via  2240ac9 s3-param Remove #defines already in common loadparm.h
       via  4f3a155 s3-param Generate parameter tables
       via  d4ef70a param: Finish conversion from lp_wins_support() -> lp_we_are_a_wins_server()
       via  6d8cc41 s3-param remove unused bIdmapReadOnly
       via  b459a6d s3-param Remove unused bUpdateEncrypt
      from  bafd721 s3-net: use printing_migrate library, and eliminate duplicate code.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit 7e52436673402095811eb081a0c036427fd31f84
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Fri Jul 1 16:02:54 2011 +1000

    s4-param Remove unused 'announce version'

    Autobuild-User: Andrew Bartlett <abartlet <at> samba.org>
    Autobuild-Date: Sat Jul  2 05:42:37 CEST 2011 on sn-devel-104

commit 2240ac96c1dc328e8a57342a7cdc7766b972e2bc
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Fri Jul 1 16:01:28 2011 +1000

    s3-param Remove #defines already in common loadparm.h

commit 4f3a155fb5e348abb76c5608dc7c765ef61a7781
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Fri Jul 1 14:36:25 2011 +1000
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Bartlett | 3 Jul 2011 10:34
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  4a83575 s3-build Require fully defined modules by default
       via  a3c9dd3 s3-build Prepare to require fully defined modules
      from  7e52436 s4-param Remove unused 'announce version'

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit 4a83575ae67c47ea76ce9b0998be8f099d001d8a
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Sun Jul 3 09:20:09 2011 +0200

    s3-build Require fully defined modules by default

    Autobuild-User: Andrew Bartlett <abartlet <at> samba.org>
    Autobuild-Date: Sun Jul  3 10:33:44 CEST 2011 on sn-devel-104

commit a3c9dd3d48a97bf7c1c7731f0e52b72cc019fb1b
Author: Andrew Bartlett <abartlet <at> samba.org>
Date:   Sun Jul 3 09:20:02 2011 +0200

    s3-build Prepare to require fully defined modules

    This specifies some more deps for our modules, and ensures that the
    subsystem that it links against is in fact a library, which will avoid
    issues with introducing duplicate symbols.

    Andrew Bartlett

-----------------------------------------------------------------------
(Continue reading)

Permalink | Reply | 0 comments |
headers
Volker Lendecke | 3 Jul 2011 12:44
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  e5ad524 s3: Remove two uses of cli_errstr
       via  c3a6e9b s3: RAP errors are WERROR
       via  c0d1683 s3: Remove some bogus error mappings
       via  d2b1671 s3: Remove a use of cli_errstr
       via  c318712 s3: Allow NULL for arg pwritten in cli_write_andx
       via  25df2fe S3: Fix some nonempty blank lines
       via  e2498b1 s3: Read symlink information in smbclient "allinfo"
       via  79d27e2 s3: Fix symlink_reparse_buffer_parse
       via  c1094a8 s3: Add cli_readlink
       via  61d0afe s3: Add STATUS_STOPPED_ON_SYMLINK error code
      from  4a83575 s3-build Require fully defined modules by default

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit e5ad52490276dfec03a7a439c33384a442565a0d
Author: Volker Lendecke <vl <at> samba.org>
Date:   Sun Jul 3 11:27:53 2011 +0200

    s3: Remove two uses of cli_errstr

    Autobuild-User: Volker Lendecke <vlendec <at> samba.org>
    Autobuild-Date: Sun Jul  3 12:43:32 CEST 2011 on sn-devel-104

commit c3a6e9b7cea4f48bcb5a9de1fad26e3da3b53f7c
Author: Volker Lendecke <vl <at> samba.org>
Date:   Sun Jul 3 11:21:50 2011 +0200

    s3: RAP errors are WERROR
(Continue reading)

Permalink | Reply | 0 comments |
headers
Volker Lendecke | 3 Jul 2011 23:58
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  8083849 s3: Make cli_cm_open return NTSTATUS
       via  714e101 s3: Make cli_cm_connect return NTSTATUS
       via  7ca63fb s3: Make "do_connect" return NTSTATUS
       via  3414182 s3: Remove a use of cli_errstr
       via  4569a3a s3: Remove a use of cli_errstr
       via  8238d89 s3: Remove a use of cli_errstr
       via  cfbd339 s3: Remove a use of cli_errstr
      from  e5ad524 s3: Remove two uses of cli_errstr

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit 80838491e6ac9f4299daccfc5506b3e1e79fab38
Author: Volker Lendecke <vl <at> samba.org>
Date:   Sun Jul 3 19:59:37 2011 +0200

    s3: Make cli_cm_open return NTSTATUS

    Autobuild-User: Volker Lendecke <vlendec <at> samba.org>
    Autobuild-Date: Sun Jul  3 23:57:53 CEST 2011 on sn-devel-104

commit 714e1014c59979d9a7a7c12f21185fdf7bcab818
Author: Volker Lendecke <vl <at> samba.org>
Date:   Sun Jul 3 12:12:45 2011 +0200

    s3: Make cli_cm_connect return NTSTATUS

commit 7ca63fb8fe17ccbfa5400c2b6d465a21096cb8fc
Author: Volker Lendecke <vl <at> samba.org>
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Bartlett | 4 Jul 2011 12:25
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  0ac4f64 s3-build link passdb modules against libpassdb
       via  6b97a3b s3-build allow_undefined_symbols=False is the default now
       via  5d4b197 s3-auth libauth no longer requires undefined symbols
       via  c599d07 s3-lib Move event_add_idle() to source3/lib/events.c
       via  b8b504a s3-samr Send IP address only to PAM remote hostname hook on password set
       via  2a01842 s3: RIP 'struct client_address'.
       via  2bcbeea s3-rpc_server: Remove client_id and server_id from pipes struct.
       via  aee04ef s3-smbd: Remove client_address from smbd_server_connection struct.
       via  b2511a2 s3-smbd: Remove obsolete smbd_set_server_fd().
       via  cbec251 s3-vfs: Replace client_id in exand msdfs.
       via  c0f1c17 s3-vfs: Replace client_id in smbta.
       via  2f92ffb s3-smbd: Replace client_id in smbd session setup.
       via  ea2917c s3-smbd: Replace client_id in smbd session.
       via  73d2891 s3-smbd: Replace client_id in smbd service.
       via  ae05a7a s3-smbd: Replace client_id in smbd reply.
       via  ad0f765 s3-smbd: Exit cleanly if we can't create an address string.
       via  d99acd2 s3-smbd: Replace client_id in smbd connection.
       via  a513086 s3-smbd: Replace client_id in smbd process.
       via  726b6c6 s3-epmapper: Replace server_id in the epmapper.
       via  784035f s3-spoolss: Replace client_id in the spoolss server.
       via  5f228ff s3-samr: Replace client_id in samr server.
       via  f036192 s3-rpc_server: Replace client_id in dcerpc gssapi server.
       via  7acaf40 s3-rpc_server: Remove unused client_id in srv_pipe.c.
       via  66badc1 s3-auth: Remove global smbd_server_conn from auth_unix.c.
       via  7e46a84 s3-auth: Pass the remote_address down to user_info.
       via  45f70db s3-auth: Added remote_address to ntlmssp server.
       via  541f3cf s3-rpc_server: Migrate rpc function to tsocket_address.
       via  6ac68a8 s3-rpc_server: Add local and remote address to pipes struct.
       via  c663dff s3-util: Add a get_remote_hostname() function.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Günther Deschner | 4 Jul 2011 15:07
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated

The branch, master has been updated
       via  ff94539 s3-printing: open up a winreg pipe handle for the migration code.
      from  0ac4f64 s3-build link passdb modules against libpassdb

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit ff94539f276bdef73bd12c67bff1f34e697ccbfc
Author: Günther Deschner <gd <at> samba.org>
Date:   Fri Jul 1 15:39:11 2011 +0200

    s3-printing: open up a winreg pipe handle for the migration code.

    Guenther

    Autobuild-User: Günther Deschner <gd <at> samba.org>
    Autobuild-Date: Mon Jul  4 15:06:41 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/printing/nt_printing_migrate.c          |    4 +++
 source3/printing/nt_printing_migrate.h          |    4 +++
 source3/printing/nt_printing_migrate_internal.c |   28 +++++++++++++++++++---
 source3/utils/net_printing.c                    |   16 +++++++++++++
 4 files changed, 48 insertions(+), 4 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source3/printing/nt_printing_migrate.c b/source3/printing/nt_printing_migrate.c
(Continue reading)

Permalink | Reply | 0 comments |

Gmane