1 Mar 2009 01:00
Build status as of Sun Mar 1 00:00:02 2009
<build <at> samba.org>
2009-03-01 00:00:14 GMT
2009-03-01 00:00:14 GMT
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-02-28 00:00:25.000000000 +0000 +++ /home/build/master/cache/broken_results.txt 2009-03-01 00:00:14.000000000 +0000 <at> <at> -1,4 +1,4 <at> <at> -Build status as of Sat Feb 28 00:00:02 2009 +Build status as of Sun Mar 1 00:00:02 2009 Build counts: Tree Total Broken Panic <at> <at> -6,18 +6,18 <at> <at> ccache 28 5 0 ctdb 0 0 0 distcc 0 0 0 -ldb 27 28 0 +ldb 29 28 0 libreplace 29 11 0 lorikeet-heimdal 26 14 0 pidl 20 3 0 ppp 12 0 0 -rsync 29 8 0 +rsync 28 8 0 samba-docs 0 0 0 samba-gtk 5 5 0 -samba_3_X_devel 28 25 2 +samba_3_X_devel 28 25 0 samba_3_X_test 27 27 3 -samba_4_0_test 29 28 2 +samba_4_0_test 29 28 1 smb-build 28 6 0(Continue reading)
Another one of the little micro-optimizations that I just came across: If you
allocate a variable in a sub-block like the "fstring sharename" in
write_file(), gcc even with -O3 will allocate this variable unconditionally on
the stack at the beginning of the routine. So with eliminating this fstring we
cut 256 bytes of stack in a very hot code path writing to a file. It might make
us a bit more cache-friendly.
This would probably not be worth a second look if it involved larger code
changes, but this one was just too simple to let it pass
RSS Feed