headers
build | 1 Apr 2005 02:00
Picon
Favicon

Build status as of Fri Apr 1 00:00:01 2005

URL: http://build.samba.org/

--- /home/build/master/cache/broken_results.txt.old	2005-03-31 00:00:18.000000000 +0000
+++ /home/build/master/cache/broken_results.txt	2005-04-01 00:00:17.000000000 +0000
 <at>  <at>  -1,4 +1,4  <at>  <at> 
-Build status as of Thu Mar 31 00:00:02 2005
+Build status as of Fri Apr  1 00:00:01 2005

 Build counts:
 Tree         Total  Broken Panic 
 <at>  <at>  -8,19 +8,17  <at>  <at> 
 rsync        38     4      0     
 samba        1      1      1     
 samba-docs   0      0      0     
-samba4       43     18     0     
-samba_3_0    39     9      0     
+samba4       43     14     0     
+samba_3_0    39     8      0     

 Currently broken builds:
 Host               Tree         Compiler   Status    
-aix1               samba4       gcc        ok/ 2/?/? 
 cyberone           samba4       gcc        ok/ 2/?/? 
 fusberta           samba4       gcc        ok/ 2/?/? 
 samba-s390         samba4       gcc        ok/ 2/?/? 
 rhonwyn            samba4       gcc-4.0    ok/ 2/?/? 
 rhonwyn            samba_3_0    gcc-4.0    ok/ 2/?/? 
 rhonwyn            samba4       tcc        ok/ 2/?/? 
-aretnap            samba_3_0    gcc        ok/ok/ok/ 1
 aretnap            ccache       icc        ok/ok/ok/ 1
(Continue reading)

Permalink | Reply | 0 comments |
headers
jra | 1 Apr 2005 02:21
Picon
Favicon

svn commit: samba r6161 - in trunk/source/smbd: .

Author: jra
Date: 2005-04-01 00:21:56 +0000 (Fri, 01 Apr 2005)
New Revision: 6161

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6161

Log:
Ensure allocation size is correctly returned for OpenX. Only set allocation
on create/truncate for nttrans.
Jeremy.

Modified:
   trunk/source/smbd/nttrans.c
   trunk/source/smbd/reply.c

Changeset:
Modified: trunk/source/smbd/nttrans.c
===================================================================
--- trunk/source/smbd/nttrans.c	2005-04-01 00:21:55 UTC (rev 6160)
+++ trunk/source/smbd/nttrans.c	2005-04-01 00:21:56 UTC (rev 6161)
 <at>  <at>  -588,7 +588,6  <at>  <at> 
 	uint32 create_disposition = IVAL(inbuf,smb_ntcreate_CreateDisposition);
 	uint32 create_options = IVAL(inbuf,smb_ntcreate_CreateOptions);
 	uint16 root_dir_fid = (uint16)IVAL(inbuf,smb_ntcreate_RootDirectoryFid);
-	SMB_BIG_UINT allocation_size = 0;
 	int smb_ofun;
 	int smb_open_mode;
 	/* Breakout the oplock request bits so we can set the
 <at>  <at>  -931,25 +930,27  <at>  <at> 
 	}
(Continue reading)

Permalink | Reply | 0 comments |
headers
jra | 1 Apr 2005 02:21
Picon
Favicon

svn commit: samba r6160 - in branches/SAMBA_3_0/source/smbd: .

Author: jra
Date: 2005-04-01 00:21:55 +0000 (Fri, 01 Apr 2005)
New Revision: 6160

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6160

Log:
Ensure allocation size is correctly returned for OpenX. Only set allocation
on create/truncate for nttrans.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/smbd/nttrans.c
   branches/SAMBA_3_0/source/smbd/reply.c

Changeset:
Modified: branches/SAMBA_3_0/source/smbd/nttrans.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/nttrans.c	2005-03-31 22:50:28 UTC (rev 6159)
+++ branches/SAMBA_3_0/source/smbd/nttrans.c	2005-04-01 00:21:55 UTC (rev 6160)
 <at>  <at>  -588,7 +588,6  <at>  <at> 
 	uint32 create_disposition = IVAL(inbuf,smb_ntcreate_CreateDisposition);
 	uint32 create_options = IVAL(inbuf,smb_ntcreate_CreateOptions);
 	uint16 root_dir_fid = (uint16)IVAL(inbuf,smb_ntcreate_RootDirectoryFid);
-	SMB_BIG_UINT allocation_size = 0;
 	int smb_ofun;
 	int smb_open_mode;
 	/* Breakout the oplock request bits so we can set the
 <at>  <at>  -931,25 +930,27  <at>  <at> 
 	}
(Continue reading)

Permalink | Reply | 0 comments |
headers
jra | 1 Apr 2005 02:54
Picon
Favicon

svn commit: samba r6163 - in branches/SAMBA_3_0/source/smbd: .

Author: jra
Date: 2005-04-01 00:54:55 +0000 (Fri, 01 Apr 2005)
New Revision: 6163

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6163

Log:
Well I never, all this time the t2open code was incorrectly decting
oplock requests and no one noticed. Hmmm. Don't think this is a commonly
used codepath :-).
Jeremy.

Modified:
   branches/SAMBA_3_0/source/smbd/trans2.c

Changeset:
Modified: branches/SAMBA_3_0/source/smbd/trans2.c
===================================================================
--- branches/SAMBA_3_0/source/smbd/trans2.c	2005-04-01 00:54:54 UTC (rev 6162)
+++ branches/SAMBA_3_0/source/smbd/trans2.c	2005-04-01 00:54:55 UTC (rev 6163)
 <at>  <at>  -744,7 +744,11  <at>  <at> 

 	open_mode = SVAL(params, 2);
 	open_attr = SVAL(params,6);
-	oplock_request = (((SVAL(params,0)|(1<<1))>>1) | ((SVAL(params,0)|(1<<2))>>1));
+        oplock_request = (SVAL(params,0) & REQUEST_OPLOCK) ? EXCLUSIVE_OPLOCK : 0;
+        if (oplock_request) {
+                oplock_request |= (SVAL(params,0) & REQUEST_BATCH_OPLOCK) ? BATCH_OPLOCK : 0;
+        }
+
(Continue reading)

Permalink | Reply | 0 comments |
headers
jra | 1 Apr 2005 02:54
Picon
Favicon

svn commit: samba r6162 - in trunk/source/smbd: .

Author: jra
Date: 2005-04-01 00:54:54 +0000 (Fri, 01 Apr 2005)
New Revision: 6162

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6162

Log:
Well I never, all this time the t2open code was incorrectly decting
oplock requests and no one noticed. Hmmm. Don't think this is a commonly
used codepath :-).
Jeremy.

Modified:
   trunk/source/smbd/trans2.c

Changeset:
Modified: trunk/source/smbd/trans2.c
===================================================================
--- trunk/source/smbd/trans2.c	2005-04-01 00:21:56 UTC (rev 6161)
+++ trunk/source/smbd/trans2.c	2005-04-01 00:54:54 UTC (rev 6162)
 <at>  <at>  -744,7 +744,11  <at>  <at> 

 	open_mode = SVAL(params, 2);
 	open_attr = SVAL(params,6);
-	oplock_request = (((SVAL(params,0)|(1<<1))>>1) | ((SVAL(params,0)|(1<<2))>>1));
+        oplock_request = (SVAL(params,0) & REQUEST_OPLOCK) ? EXCLUSIVE_OPLOCK : 0;
+        if (oplock_request) {
+                oplock_request |= (SVAL(params,0) & REQUEST_BATCH_OPLOCK) ? BATCH_OPLOCK : 0;
+        }
+
(Continue reading)

Permalink | Reply | 0 comments |
headers
mimir | 1 Apr 2005 10:14
Picon
Favicon

svn commit: samba r6164 - in branches/SAMBA_4_0/source/libnet: .

Author: mimir
Date: 2005-04-01 08:14:57 +0000 (Fri, 01 Apr 2005)
New Revision: 6164

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6164

Log:
More comments in the code.

rafal

Modified:
   branches/SAMBA_4_0/source/libnet/userinfo.c

Changeset:
Modified: branches/SAMBA_4_0/source/libnet/userinfo.c
===================================================================
--- branches/SAMBA_4_0/source/libnet/userinfo.c	2005-04-01 00:54:55 UTC (rev 6163)
+++ branches/SAMBA_4_0/source/libnet/userinfo.c	2005-04-01 08:14:57 UTC (rev 6164)
 <at>  <at>  -31,6 +31,10  <at>  <at> 
 static void userinfo_handler(struct rpc_request *req);

 
+/**
+ * Stage 1: Open user policy handle in SAM server.
+ */
+
 static NTSTATUS userinfo_openuser(struct composite_context *c,
 				  struct rpc_composite_userinfo *io)
 {
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Apr 2005 13:24
Picon
Favicon
Gravatar

svn commit: samba r6165 - in branches/SAMBA_4_0/source: libnet torture/libnet

Author: tridge
Date: 2005-04-01 11:24:52 +0000 (Fri, 01 Apr 2005)
New Revision: 6165

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6165

Log:
fixed up the userinfo composite code. Fixes include:

- talloc should always be done in the right context. For example, when creating
  the userinfo_state structure, place it inside the composite
  structure, not directly on the pipe. If this isn't done then
  correct cleanup can't happen on errors (as cleanup destroys the top
  level composite context only)

- define private structures like userinfo_state in the userinfo.c
  code, not in the public header

- only keep the parameters we need in the state structure. For
  example, the domain_handle is only needed in the first call, so we
  don't need to keep it around in the state structure, but the level is
  needed in later calls, so we need to keep it

- always initialise [out,ref] parameters in RPC calls. The [ref] part
  means that the call assumes the pointer it has been given is
  valid. If you don't initialise it then you will get a segv on
  recv. This is why the code was dying.

- don't use internal strucrure elements like the pipe
  pipe->conn->pending outside of the internal rpc implementation. That
(Continue reading)

Permalink | Reply | 2 comments |
headers
gd | 1 Apr 2005 15:12
Picon
Favicon

svn commit: samba r6166 - in branches/SAMBA_3_0/source/lib: .

Author: gd
Date: 2005-04-01 13:12:51 +0000 (Fri, 01 Apr 2005)
New Revision: 6166

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6166

Log:
Derell, I'm reverting this part of -r4917 because it modifies the keys
to search in tdbs in a way that is not upgrade-safe and somewhat weird
to use: Users have to modify policies like

        pdbedit -P "maximum password policies (seconds since 1970)"

The value-description should better go into the manpage.

Guenther

Modified:
   branches/SAMBA_3_0/source/lib/account_pol.c

Changeset:
Modified: branches/SAMBA_3_0/source/lib/account_pol.c
===================================================================
--- branches/SAMBA_3_0/source/lib/account_pol.c	2005-04-01 11:24:52 UTC (rev 6165)
+++ branches/SAMBA_3_0/source/lib/account_pol.c	2005-04-01 13:12:51 UTC (rev 6166)
 <at>  <at>  -118,8 +118,8  <at>  <at> 
 	{AP_MIN_PASSWORD_LEN, "min password length"},
 	{AP_PASSWORD_HISTORY, "password history"},
 	{AP_USER_MUST_LOGON_TO_CHG_PASS, "user must logon to change password"},
-	{AP_MAX_PASSWORD_AGE, "maximum password age (seconds since 1970)"},
(Continue reading)

Permalink | Reply | 0 comments |
headers
Rafal Szczesniak | 1 Apr 2005 13:47
Picon
Favicon

Re: svn commit: samba r6165 - in branches/SAMBA_4_0/source: libnet torture/libnet

On Fri, Apr 01, 2005 at 11:24:52AM +0000, tridge <at> samba.org wrote:
> Author: tridge
> Date: 2005-04-01 11:24:52 +0000 (Fri, 01 Apr 2005)
> New Revision: 6165
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6165
> 
> Log:
> fixed up the userinfo composite code. Fixes include:
> 
[...]
> Mimir, please look at the diff carefully for more detailed info on the fixes

Thanks a lot! I'll study it tonight.

cheers,
--

-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org
Permalink | Reply | 0 comments |
headers
sfrench | 1 Apr 2005 20:14
Picon
Favicon

svn commit: samba r6167 - in branches/SAMBA_3_0/source/include: .

Author: sfrench
Date: 2005-04-01 18:14:24 +0000 (Fri, 01 Apr 2005)
New Revision: 6167

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=6167

Log:
Add more defines for POSIX extensions to match the newly added
client implementation

Modified:
   branches/SAMBA_3_0/source/include/trans2.h

Changeset:
Modified: branches/SAMBA_3_0/source/include/trans2.h
===================================================================
--- branches/SAMBA_3_0/source/include/trans2.h	2005-04-01 13:12:51 UTC (rev 6166)
+++ branches/SAMBA_3_0/source/include/trans2.h	2005-04-01 18:14:24 UTC (rev 6167)
 <at>  <at>  -440,6 +440,9  <at>  <at> 
 #define SMB_QUERY_XATTR                0x205 /* need for non-user XATTRs */
 #define SMB_QUERY_ATTR_FLAGS           0x206 /* chflags, chattr */
 #define SMB_SET_ATTR_FLAGS             0x206 
+#define SMB_QUERY_POSIX_PERMISSION     0x207
+#define SMB_QUERY_POSIX_LOCK	       0x208
+#define SMB_SET_POSIX_LOCK	       0x208

 /* Transact 2 Find First levels */
 #define SMB_FIND_FILE_UNIX             0x202
 <at>  <at>  -464,6 +467,13  <at>  <at>
(Continue reading)

Permalink | Reply | 0 comments |

Gmane