headers
tpot | 1 Sep 2004 01:57
Picon
Favicon

svn commit: samba r2154 - in branches/SAMBA_4_0/source/lib/tdb/common: .

Author: tpot
Date: 2004-08-31 23:57:14 +0000 (Tue, 31 Aug 2004)
New Revision: 2154

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source/lib/tdb/common&rev=2154&nolog=1

Log:
Merge of Jim's format string fixup in r2130:2131

Modified:
   branches/SAMBA_4_0/source/lib/tdb/common/tdb.c

Changeset:
Modified: branches/SAMBA_4_0/source/lib/tdb/common/tdb.c
===================================================================
--- branches/SAMBA_4_0/source/lib/tdb/common/tdb.c	2004-08-31 22:52:11 UTC (rev 2153)
+++ branches/SAMBA_4_0/source/lib/tdb/common/tdb.c	2004-08-31 23:57:14 UTC (rev 2154)
 <at>  <at>  -490,7 +490,7  <at>  <at> 
 	if (rec->magic == TDB_MAGIC) {
 		/* this happens when a app is showdown while deleting a record - we should
 		   not completely fail when this happens */
-		TDB_LOG((tdb, 0,"rec_free_read non-free magic at offset=%d - fixing\n", 
+		TDB_LOG((tdb, 0,"rec_free_read non-free magic 0x%x at offset=%d - fixing\n", 
 			 rec->magic, off));
 		rec->magic = TDB_FREE_MAGIC;
 		if (tdb_write(tdb, off, rec, sizeof(*rec)) == -1)
Permalink | Reply | 0 comments |
headers
jra | 1 Sep 2004 03:33
Picon
Favicon

svn commit: samba r2155 - in branches/SAMBA_3_0/source/lib: .

Author: jra
Date: 2004-09-01 01:33:55 +0000 (Wed, 01 Sep 2004)
New Revision: 2155

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/lib&rev=2155&nolog=1

Log:
Reformat, plus steal from Samba4 :-).
tridge:
the lp_use_mmap() in map_file() is inappropriate for 2 reasons, so I have removed it.

 - lp_use_mmap() is really meant to cope with systems that have broken
   mmap coherence, but map_file() doesn't need coherence, as its maps
   read only

 - map_file() is used to map the charset files before loadparm has
   loaded, so lp_use_mmap() is always returning false for the major
   use of map_file()

Jeremy.

Modified:
   branches/SAMBA_3_0/source/lib/util_file.c

Changeset:
Sorry, the patch is too large (802 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/lib&rev=2155&nolog=1
Permalink | Reply | 0 comments |
headers
jra | 1 Sep 2004 03:34
Picon
Favicon

svn commit: samba r2156 - in trunk/source/lib: .

Author: jra
Date: 2004-09-01 01:34:00 +0000 (Wed, 01 Sep 2004)
New Revision: 2156

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/trunk/source/lib&rev=2156&nolog=1

Log:
Reformat, plus steal from Samba4 :-).
tridge:
the lp_use_mmap() in map_file() is inappropriate for 2 reasons, so I have removed it.

 - lp_use_mmap() is really meant to cope with systems that have broken
   mmap coherence, but map_file() doesn't need coherence, as its maps
   read only

 - map_file() is used to map the charset files before loadparm has
   loaded, so lp_use_mmap() is always returning false for the major
   use of map_file()

Jeremy.

Modified:
   trunk/source/lib/util_file.c

Changeset:
Sorry, the patch is too large (802 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/trunk/source/lib&rev=2156&nolog=1
Permalink | Reply | 0 comments |
headers
abartlet | 1 Sep 2004 04:13
Picon
Favicon

svn commit: samba r2157 - in branches/SAMBA_3_0/source/param: .

Author: abartlet
Date: 2004-09-01 02:13:48 +0000 (Wed, 01 Sep 2004)
New Revision: 2157

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/param&rev=2157&nolog=1

Log:
This parameter in loadparm appears compleatly unused.

Andrew Bartlett

Modified:
   branches/SAMBA_3_0/source/param/loadparm.c

Changeset:
Modified: branches/SAMBA_3_0/source/param/loadparm.c
===================================================================
--- branches/SAMBA_3_0/source/param/loadparm.c	2004-09-01 01:34:00 UTC (rev 2156)
+++ branches/SAMBA_3_0/source/param/loadparm.c	2004-09-01 02:13:48 UTC (rev 2157)
 <at>  <at>  -200,7 +200,6  <at>  <at> 
 	int lpqcachetime;
 	int iMaxSmbdProcesses;
 	BOOL bDisableSpoolss;
-	int iTotalPrintJobs;
 	int syslog;
 	int os_level;
 	int enhanced_browsing;
 <at>  <at>  -1374,7 +1373,6  <at>  <at> 
 	Globals.lpqcachetime = 10;
 	Globals.bDisableSpoolss = False;
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 06:31
Picon
Favicon
Gravatar

svn commit: samba r2158 - in branches/SAMBA_4_0/source/librpc/idl: .

Author: tridge
Date: 2004-09-01 04:31:15 +0000 (Wed, 01 Sep 2004)
New Revision: 2158

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source/librpc/idl&rev=2158&nolog=1

Log:
removed a misleading comment (the extra uint16 is just padding)

Modified:
   branches/SAMBA_4_0/source/librpc/idl/lsa.idl

Changeset:
Modified: branches/SAMBA_4_0/source/librpc/idl/lsa.idl
===================================================================
--- branches/SAMBA_4_0/source/librpc/idl/lsa.idl	2004-09-01 02:13:48 UTC (rev 2157)
+++ branches/SAMBA_4_0/source/librpc/idl/lsa.idl	2004-09-01 04:31:15 UTC (rev 2158)
 <at>  <at>  -455,9 +455,6  <at>  <at> 

 	/*******************/
 	/* Function:  0x21 */
-	/* in [out] there is a uin16 field
-	   which is not always present.
-	   its value varies */
 	NTSTATUS lsa_LookupPrivDisplayName (
 		[in,ref]     policy_handle *handle,
 		[in,ref]     lsa_Name *name,
 <at>  <at>  -465,7 +462,6  <at>  <at> 
 		[in]         uint16 unknown2,    /* 0x0409 */
 		[out]        lsa_Name *disp_name,
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 06:39
Picon
Favicon
Gravatar

svn commit: samba r2159 - in branches/SAMBA_4_0/source: include lib libcli/raw librpc/ndr smb_server torture torture/basic torture/local

Author: tridge
Date: 2004-09-01 04:39:06 +0000 (Wed, 01 Sep 2004)
New Revision: 2159

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source&rev=2159&nolog=1

Log:
converted samba4 over to UTF-16. 

I had previously thought this was unnecessary, as windows doesn't use
standards compliant UTF-16, and for filesystem operations treats bytes
as UCS-2, but Bjoern Jacke has pointed out to me that this means we
don't correctly store extended UTF-16 characters as UTF-8 on
disk. This can be seen with (for example) the gothic characters with
codepoints above 64k.

This commit also adds a LOCAL-ICONV torture test that tests the first
1 million codepoints against the system iconv library, and tests 5
million random UTF-16LE buffers for identical error handling to the
system iconv library.

the lib/iconv.c changes need backporting to samba3

Added:
   branches/SAMBA_4_0/source/torture/local/
   branches/SAMBA_4_0/source/torture/local/iconv.c
Modified:
   branches/SAMBA_4_0/source/include/charset.h
   branches/SAMBA_4_0/source/lib/charcnv.c
   branches/SAMBA_4_0/source/lib/iconv.c
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 06:46
Picon
Favicon
Gravatar

svn commit: samba r2160 - in branches/SAMBA_3_0/source/lib: .

Author: tridge
Date: 2004-09-01 04:46:15 +0000 (Wed, 01 Sep 2004)
New Revision: 2160

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/lib&rev=2160&nolog=1

Log:
fixed the uuid pack/unpack routines (they could go past the end of the UUID structure)

Modified:
   branches/SAMBA_3_0/source/lib/util_uuid.c

Changeset:
Modified: branches/SAMBA_3_0/source/lib/util_uuid.c
===================================================================
--- branches/SAMBA_3_0/source/lib/util_uuid.c	2004-09-01 04:39:06 UTC (rev 2159)
+++ branches/SAMBA_3_0/source/lib/util_uuid.c	2004-09-01 04:46:15 UTC (rev 2160)
 <at>  <at>  -29,11 +29,11  <at>  <at> 

 void smb_uuid_pack(const struct uuid uu, UUID_FLAT *ptr)
 {
-	SIVAL(ptr, 0, uu.time_low);
-	SSVAL(ptr, 4, uu.time_mid);
-	SSVAL(ptr, 6, uu.time_hi_and_version);
-	memcpy(ptr+8, uu.clock_seq, 2);
-	memcpy(ptr+10, uu.node, 6);
+	SIVAL(ptr->info, 0, uu.time_low);
+	SSVAL(ptr->info, 4, uu.time_mid);
+	SSVAL(ptr->info, 6, uu.time_hi_and_version);
+	memcpy(ptr->info+8, uu.clock_seq, 2);
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 06:50
Picon
Favicon
Gravatar

svn commit: samba r2161 - in trunk/source/lib: .

Author: tridge
Date: 2004-09-01 04:50:55 +0000 (Wed, 01 Sep 2004)
New Revision: 2161

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/trunk/source/lib&rev=2161&nolog=1

Log:
fixed the uuid pack/unpack routines (they could go past the end of the UUID structure)

Modified:
   trunk/source/lib/util_uuid.c

Changeset:
Modified: trunk/source/lib/util_uuid.c
===================================================================
--- trunk/source/lib/util_uuid.c	2004-09-01 04:46:15 UTC (rev 2160)
+++ trunk/source/lib/util_uuid.c	2004-09-01 04:50:55 UTC (rev 2161)
 <at>  <at>  -29,11 +29,11  <at>  <at> 

 void smb_uuid_pack(const struct uuid uu, UUID_FLAT *ptr)
 {
-	SIVAL(ptr, 0, uu.time_low);
-	SSVAL(ptr, 4, uu.time_mid);
-	SSVAL(ptr, 6, uu.time_hi_and_version);
-	memcpy(ptr+8, uu.clock_seq, 2);
-	memcpy(ptr+10, uu.node, 6);
+	SIVAL(ptr->info, 0, uu.time_low);
+	SSVAL(ptr->info, 4, uu.time_mid);
+	SSVAL(ptr->info, 6, uu.time_hi_and_version);
+	memcpy(ptr->info+8, uu.clock_seq, 2);
(Continue reading)

Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 06:57
Picon
Favicon
Gravatar

svn commit: samba r2162 - in trunk/source/lib: .

Author: tridge
Date: 2004-09-01 04:57:27 +0000 (Wed, 01 Sep 2004)
New Revision: 2162

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/trunk/source/lib&rev=2162&nolog=1

Log:
switched trunk over to the new utf-8 routines

Modified:
   trunk/source/lib/iconv.c

Changeset:
Sorry, the patch is too large (301 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/trunk/source/lib&rev=2162&nolog=1
Permalink | Reply | 0 comments |
headers
tridge | 1 Sep 2004 07:17
Picon
Favicon
Gravatar

svn commit: samba r2163 - in branches/SAMBA_3_0/source/lib: .

Author: tridge
Date: 2004-09-01 05:17:40 +0000 (Wed, 01 Sep 2004)
New Revision: 2163

WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/lib&rev=2163&nolog=1

Log:
converted samba3 to use the new utf-16 aware iconv code. Also changed
iconv to recognise UCS-2LE and UTF-16LE as synonyms, which means this
change should be more robust when applied in trees that treat UCS-2LE
or UTF-16LE as correct.

Modified:
   branches/SAMBA_3_0/source/lib/iconv.c

Changeset:
Sorry, the patch is too large (367 lines) to include; please use WebSVN to see it!
WebSVN: http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_3_0/source/lib&rev=2163&nolog=1
Permalink | Reply | 0 comments |

Gmane