elrond | 30 Apr 2011 15:30

cvs commit: tng/source/smbd connection.c server.c

elrond      2011/04/30 15:30:51 CEST

Modified files:
   source/smbd            connection.c server.c 
Log:
connections-db: Handle disconnects better

smbd keeps a db of the currently connected
hosts/shares/users. If people disconnect from a share, this
is handled. But if the host finally closes the connection
and the smbd shuts down, this is not handled. Fix this.

Also minimal update to the sqlite backend version (not yet
ready for prime time).

Revision  Changes                              Path
1.19      +6 -3;  commitid: onOUio7QdHaxiRhv;  tng/source/smbd/connection.c
1.51      +1 -0;  commitid: onOUio7QdHaxiRhv;  tng/source/smbd/server.c

elrond | 30 Apr 2011 15:24

cvs commit: tng/source/smbd pipe-proxy.c

elrond      2011/04/30 15:24:04 CEST

Modified files:
   source/smbd            pipe-proxy.c 
Log:
Fix dereference before check for NULL

Found in a usual audit session.

Revision  Changes                              Path
1.11      +4 -4;  commitid: d9FoNnC7IaaPgRhv;  tng/source/smbd/pipe-proxy.c

elrond | 12 Feb 2011 18:44

cvs commit: tng/source/groupdb groupdb.c tng/source/lib charcnv.c daemon.c messages.c time.c util_sock.c tng/source/libsmb smbencrypt.c util_smb_packet.c tng/source/locking locking.c tng/source/passdb ldap.c sampassdb.c tng/source/rpc_server srv_pipe_netsec.c tng/source/rpcclient ...

elrond      2011/02/12 18:44:13 CET

Modified files:
   source/groupdb         groupdb.c 
   source/lib             charcnv.c daemon.c messages.c time.c 
                          util_sock.c 
   source/libsmb          smbencrypt.c util_smb_packet.c 
   source/locking         locking.c 
   source/passdb          ldap.c sampassdb.c 
   source/rpc_server      srv_pipe_netsec.c 
   source/rpcclient       cmd_reg.c 
   source/smbd            filename.c vfs.c 
Log:
Lots of doxygen related comment updates

From time to time I have enhanced the comments to be more
doxygen friendly, or even added new comments to document
existing stuff. I do this mostly in a private tree. So I'm
now commiting a big bunch of this stuff.

Revision  Changes                               Path
1.23      +1 -1;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/groupdb/groupdb.c
1.33      +24 -0;  commitid: ToaXr8D0GQFoaZ7v;  tng/source/lib/charcnv.c
1.5       +6 -2;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/daemon.c
1.15      +1 -1;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/messages.c
1.17      +3 -4;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/time.c
1.43      +5 -3;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/lib/util_sock.c
1.30      +3 -5;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/libsmb/smbencrypt.c
1.24      +1 -0;  commitid: ToaXr8D0GQFoaZ7v;   tng/source/libsmb/util_smb_packet.c
1.35      +15 -6;  commitid: ToaXr8D0GQFoaZ7v;  tng/source/locking/locking.c
(Continue reading)

elrond | 12 Feb 2011 19:29

cvs commit: tng/source configure.in

elrond      2011/02/12 19:29:35 CET

Modified files:
   source                 configure.in 
Log:
Fix ldap deprecation warnings

openldap in its current version deprecates a bunch of
functions by just not declaring them by default. This
includes standard functions like ldap_open and some
functions that really might be replaced by better ones. We
still use a bunch of those functions. To get the
declarations back, add -DLDAP_DEPRECATED to CPPFLAGS, if
needed.

Revision  Changes                              Path
1.110     +5 -1;  commitid: zIIHKBtwHRcuqZ7v;  tng/source/configure.in

elrond | 12 Feb 2011 18:33

cvs commit: tng/source/include byteorder.h tng_misc.h

elrond      2011/02/12 18:33:35 CET

Modified files:
   source/include         byteorder.h tng_misc.h 
Log:
Fix strict aliasing warnings: STRIP_CONST and byteorder macros

gcc 4.4 gives us a lot of warnings about strict aliasing
issues. Most of them are due to two things:

1) the byteorder macros (SIVAL for example), which partly
   use very tricky casts to create optimized code on i386.
   Until we have new optimized code, we'll use the generic
   code everywhere.

2) STRIP_CONST needs to do tricky casts anyway.
   I have rewritten it to use uintptr_t (an integer large
   enough to hold a pointer).

   It's not yet exactly clear, where we want to go with
   stdint.h portability (which is needed for uintptr_t).
   Currently we use a gnulib autoconf library to create a
   local wrapping "sambatng-int.h".

This fixes most of the new warnings.

Revision  Changes                              Path
1.7       +0 -6;  commitid: INiJDFpH5QzY5Z7v;  tng/source/include/byteorder.h
1.11      +4 -9;  commitid: INiJDFpH5QzY5Z7v;  tng/source/include/tng_misc.h

(Continue reading)

elrond | 25 Jul 2010 21:36

cvs commit: tng/source/lib passcheck.c tng/source/libsmb smbencrypt.c tng/source/rpc_client cli_login.c msrpc_samr.c tng/source/rpc_parse parse_samr.c tng/source/rpcclient cmd_samr.c

elrond      2010/07/25 21:36:57 CEST

Modified files:
   source/lib             passcheck.c 
   source/libsmb          smbencrypt.c 
   source/rpc_client      cli_login.c msrpc_samr.c 
   source/rpc_parse       parse_samr.c 
   source/rpcclient       cmd_samr.c 
Log:
DEBUG: netlogon; Signedness: samr, netlogon

Enhance some DBEUGs:
- smb_password_ok()
- cli_net_req_chal()

Fix up signedness in some places:
- decode_pw_buffer(), encode_pw_buffer()
  and some callers
- make_sam_user_info24()
- cli_nt_login_network()

Revision  Changes                              Path
1.8       +3 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/lib/passcheck.c
1.29      +2 -2;  commitid: jF4JCp31ybrTh2Iu;  tng/source/libsmb/smbencrypt.c
1.17      +7 -4;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_client/cli_login.c
1.18      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_client/msrpc_samr.c
1.52      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpc_parse/parse_samr.c
1.44      +1 -1;  commitid: jF4JCp31ybrTh2Iu;  tng/source/rpcclient/cmd_samr.c

(Continue reading)

elrond | 25 Jul 2010 14:50

cvs commit: tng NEWS

elrond      2010/07/25 14:50:22 CEST

Modified files:
   .                      NEWS 
Log:
Little update to NEWS file for 0.5

+ "Invalid packet length!" issue
+ 'max xmit': Obsolete, will be removed soon

Revision  Changes                              Path
1.28      +3 -0;  commitid: HPcAiqr6Wnl030Iu;  tng/NEWS

elrond | 25 Jul 2010 14:45

cvs commit: tng/source/include smbd.h tng/source/libsmb util_smb_packet.c tng/source/param loadparm.c tng/source/smbd negprot.c process.c reply.c

elrond      2010/07/25 14:45:37 CEST

Modified files:
   source/include         smbd.h 
   source/libsmb          util_smb_packet.c 
   source/param           loadparm.c 
   source/smbd            negprot.c process.c reply.c 
Log:
Fix "Invalid packet length!" issue

When Windows sends a very large packet (writing a large
file on the file server), sometimes the "Invalid packet
length!" could happen.

Problem was: We announced 4 bytes too much space to the
client for the receive buffer. This only turned up lately,
because we now have much better buffer overflow checks in
place.

Announce the correct space.

In this change, I dropped the complete support for "max
xmit". So this parameter is now officially "obsolete".

Thanks to Simon for reporting and testing!

Internal-Name: smbd_invalid_packet_size-1.diff

Revision  Changes                              Path
1.23      +2 -0;  commitid: TEMtQSRISjNh00Iu;  tng/source/include/smbd.h
(Continue reading)

elrond | 11 Jul 2010 19:37

cvs commit: tng/source/lib passcheck.c tng/source/libsmb credentials.c

elrond      2010/07/11 19:37:17 CEST

Modified files:
   source/lib             passcheck.c 
   source/libsmb          credentials.c 
Log:
DEBUG; Signess: cred_session_key, smb_pwd_check_ntlmv2

Use "BYTE" more in cred_session_key and
smb_pwd_check_ntlmv2.

And put lib/passcheck.c in the "AUTH" debug class.

Revision  Changes                              Path
1.7       +4 -1;  commitid: Tv0L1crKfwxq5eGu;  tng/source/lib/passcheck.c
1.12      +2 -2;  commitid: Tv0L1crKfwxq5eGu;  tng/source/libsmb/credentials.c

elrond | 11 Jul 2010 19:12

cvs commit: tng/source/netlogond netlogond.c tng/source/rpc_client msrpc_netlogon.c tng/source/samrd samrd.c tng/source/smbd server.c tng/source/tdb tdbutil.c

elrond      2010/07/11 19:12:22 CEST

Modified files:
   source/netlogond       netlogond.c 
   source/rpc_client      msrpc_netlogon.c 
   source/samrd           samrd.c 
   source/smbd            server.c 
   source/tdb             tdbutil.c 
Log:
netlogon client serialization

Our netlogon client code needs to talk serialized to one
server. This is mostly important when talking to our own
netlogond: If two smbds want to authenticate users at the
same time, they need to wait on each other. Reason: the
netlogon credentials are "per client", not "per
connection".

The current implementation uses a tdb as backend, but this
is all contained in a few lines of code and can quickly be
replaced with something better.

Internal-Name: netlogon-lock-1.diff

Revision  Changes                                Path
1.17      +3 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/netlogond/netlogond.c
1.15      +41 -0;  commitid: wlkiADUG6gFWUdGu;   tng/source/rpc_client/msrpc_netlogon.c
1.16      +3 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/samrd/samrd.c
1.50      +2 -0;  commitid: wlkiADUG6gFWUdGu;    tng/source/smbd/server.c
1.19      +13 -12;  commitid: wlkiADUG6gFWUdGu;  tng/source/tdb/tdbutil.c
(Continue reading)

elrond | 9 Mar 2010 22:35

cvs commit: tng/source/lib util_sid.c tng/source/rpcclient cmd_lsarpc.c

elrond      2010/03/09 22:35:51 CET

Modified files:
   source/lib             util_sid.c 
   source/rpcclient       cmd_lsarpc.c 
Log:
valgrind: memleak in enumprivs, nicer sid_equal

rpcclient's enumprivs had a memleak. Fixed it.

sid_equal sometimes reads unset mem. It's not a bug,
because the final "fail" would have happened later anyway.
Just reordered things a little to calm down valgrind.

Revision  Changes                              Path
1.15      +7 -7;  commitid: t8c5LCXfWyI1ojqu;  tng/source/lib/util_sid.c
1.22      +3 -0;  commitid: t8c5LCXfWyI1ojqu;  tng/source/rpcclient/cmd_lsarpc.c


Gmane