[quagga-dev 9041] Committing New Features to Master Branch?

Quagga maintainers,

Would it be possible to commit new features to the master branch at the 
same time as (or before) committing them to the RE-testing branch? 
Having new features initially only in RE-testing limits their testing 
exposure and may keep people who run the master branch from discovering 
bugs earlier, before releases. I understand that maintainer time is 
limited, but if a patch for RE-testing also applies cleanly to master, 
can it just be committed to both branches?

Part of the reason I am asking is that I also use some extensions to 
Quagga that are developed externally:
  - OSPFv3 MDR (http://cs.itd.nrl.navy.mil/work/ospf-manet/)
  - PIM SM (http://www.nongnu.org/qpimd/)

These external branches are based off of master, not RE-testing, which 
makes sense as they are experimental in nature. As a researcher, I would 
like to be able to, for example, try out the Babel routing protocol 
alongside OSPFv3 MDR in wireless networks. However, Babel is in 
RE-testing and not master, and trying to integrate the code bases in 
order to build one copy of Quagga gets unnecessarily difficult because 
of this.

(Of course, it would be ideal if the above extensions could make their 
way into the mainline Quagga at some point... I'm not sure what the 
right timing or process would be for something like that, and I am not 
their maintainer.)

At the moment, the following patch groups have been applied to 
RE-testing-0.99 but not to master:

[quagga-dev 9039] quagga-0.99.20mr2.1 release

An updated version of Quagga with extensions for mobile routing is available from:
http://downloads.pf.itd.nrl.navy.mil/ospf-manet/quagga-0.99.20mr2.1/ .

This release contains several bug fixes and other improvements including better alignment with RFC 5614. 
http://downloads.pf.itd.nrl.navy.mil/ospf-manet/quagga-0.99.20mr2.1/RELEASE_NOTES.MobileRouting
includes a more detailed list of changes.

  Tom

[quagga-dev 9036] SeqNumberMismatch

We have gotten a few OSPF trouble reposte from the field with the following log:

2012/01/23 16:06:55 OSPF: NSM[p2-6-21-6-22:172.28.64.169:172.28.64.181]: Full (HelloReceived)
2012/01/23 16:06:55 OSPF: NSM[p2-6-21-6-22:172.28.64.169:172.28.64.181]: Full (2-WayReceived)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (HelloReceived)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (2-WayReceived)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (SeqNumberMismatch)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: State change Full ->
ExStart (SeqNumberMismatch)
2012/01/23 16:06:55 OSPF: nsm_change_state(172.28.64.137, Full -> ExStart): scheduling new
router-LSA origination
2012/01/23 16:06:55 OSPF: Packet[DD]: Neighbor 172.28.64.137 Negotiation done (Master).
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: ExStart (NegotiationDone)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: State change ExStart ->
Exchange (NegotiationDone)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Exchange (ExchangeDone)
2012/01/23 16:06:55 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: State change Exchange ->
Full (ExchangeDone)
2012/01/23 16:06:55 OSPF: nsm_change_state(172.28.64.137, Exchange -> Full): scheduling new
router-LSA origination
2012/01/23 16:07:05 OSPF: NSM[p2-6-21-6-22:172.28.64.169:172.28.64.181]: Full (HelloReceived)
2012/01/23 16:07:05 OSPF: NSM[p2-6-21-6-22:172.28.64.169:172.28.64.181]: Full (2-WayReceived)
2012/01/23 16:07:05 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (HelloReceived)
2012/01/23 16:07:05 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (2-WayReceived)
2012/01/23 16:07:05 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: Full (SeqNumberMismatch)
2012/01/23 16:07:05 OSPF: NSM[p1-8-21-8-22:172.28.64.169:172.28.64.137]: State change Full ->
ExStart (SeqNumberMismatch)
2012/01/23 16:07:05 OSPF: nsm_change_state(172.28.64.137, Full -> ExStart): scheduling new
router-LSA origination

[quagga-dev 9034] MP-BGP patchset is now in master branch

Hello, list.

The work contributed earlier by Balaji is now in the master branch. The problem used to be, I could not help
Balaji besides fixing the regressions introduced by his commits. Without any real use case for the new
code I did not see any reasons for distributing it further. As soon as David Lamparter is going to base his
work on MP-BGP, I mark this development story as finished and rely on his expertise in this regard. Cheers!

--

-- 
    Denis Ovsienko

[quagga-dev 9033] Is there an ospf6d doctor in the house ?

Help !

I am puzzled by code in debug_ospf6_lsa_type() in ospf6_lsa.c... in
particular the handling of the ls type value.

The code allows for unknown types to be specified as hex numbers, eg
0x20f0.  So:

  debug ospf6 lsa 0x20f0

will turn on debugging for that unknown type, and add a 'struct
ospfd_lsa_handler' to the ospf6d_handler_vector.  The type entry in
that struct is set to 0x20f0.

The problem I have is that the index for the vector is the type masked
down by OSPF6_LSTYPE_FCODE_MASK == 0x1fff.  So, that:

  debug ospf6 lsa 0x00f0

creates a new 'struct ospfd_lsa_handler', and overwrites the entry in
the ospf6d_handler_vector -- which doesn't seem right ?

Furthermore, the following:

  debug ospf6 lsa 0x0001

wipes out the entry in the ospf6d_handler_vector for
OSPF6_LSTYPE_ROUTER (0x2001), which is one of the standard ls types --
some mistake, Shirley ?

[quagga-dev 9022] [PATCH] Fix spacing issue in perl command parser of vtysh

Adding new commands failed on vtysh, but worked on telnet version of daemon. 
This is due to the regular expression in extract.pl.in of vtysh that failed 
to take into account of spacing issue. This patch fixes this issue.

---
diff --git a/vtysh/extract.pl.in b/vtysh/extract.pl.in
index 0b9ee51..1b2a4c0 100755
--- a/vtysh/extract.pl.in
+++ b/vtysh/extract.pl.in
@@ -68,7 +68,7 @@ foreach (@ARGV) {
     close (FH);

     @defun = ($line =~ /(?:DEFUN|ALIAS)\s*\((.+?)\);?\s?\s?\n/sg);
-    @install = ($line =~ /install_element \(\s*[0-9A-Z_]+,\s*&[^;]*;\s*\n/sg);
+    @install = ($line =~ /install_element\s*\(\s*[0-9A-Z_]+,\s*&[^;]*;\s*\n/sg);

     # DEFUN process
     foreach (@defun) {

[quagga-dev 9021] [PATCH] Save blackhole (reject) routes correctly Resubmit of patch already submited Mon Apr 11 15:38:19 IST 2011

From: Ingo Flaschberger <if <at> xip.at>

---
 zebra/zebra_vty.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c
index 05485a1..fd36140 100644
--- a/zebra/zebra_vty.c
+++ b/zebra/zebra_vty.c
@@ -1142,7 +1142,11 @@ static_config_ipv4 (struct vty *vty)
               vty_out (vty, " %s", si->gate.ifname);
               break;
             case STATIC_IPV4_BLACKHOLE:
-              vty_out (vty, " Null0");
+              if (CHECK_FLAG(si->flags, ZEBRA_FLAG_REJECT)) {
+                vty_out (vty, " %s", "reject");
+              } else {
+                vty_out (vty, " Null0");
+              }
               break;
           }

--

-- 
1.7.1.1

[quagga-dev 9011] uRPF?

IOS has it.  JUNOS has it.  I was wondering if and when Quagga will have 
uRPF support.

Thanks,
Hank

[quagga-dev 9005] Quagga project news

Hello, all.

Some of you may be interested in Quagga release 0.99.17.6, which was made today from RE-stable-0.99 branch
I have been driving during last months. Its difference from the previous "RE" release 0.99.17.5 is as follows:

Release 0.99.17.6 fixes the following bugs:

* #350 nexthop-local unchanged in BGP
* #480 detect inactive interfaces in ND RA
* #487 connected route management
* #548 IPv6 update-source in BGP
* #622 fix crash in "bgpd --dry-run"
* #674, #677, #680 improved BGP attribute flag checks
* #685 verbose LSA checksum error message

Some of the other improvements, which have no associated bug ID, are:

* automatic RIB GC after a zclient
* ospf6d: implement 'match interface' for route-maps
* bgpd: implement 'match probability' in route-maps
* IPv6 transport class suppport
* assorted fixes by Stephen Hemminger and David Lamparter
* new "-z" command-line option
* optimized IP prefix processing
* spelling and documentation updates
* some compilation warnings addressed

This work was done by several developers, authorship of each particular git commit is available in the
public git repository. My role with regard to this release in particular and RE-stable-0.99 branch in
general was to keep bad commits out, i.e. to enforce the discipline initially declared within the release

[quagga-dev 9004] [PATCH] bgpd: fix leak from soft reconfig

When soft-reconfig is used the advertised routes are stored and
never cleared when session is lost. This means peer still has reference
and all other memory is held as well.
---
 bgpd/bgp_fsm.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

--- a/bgpd/bgp_fsm.c	2011-10-10 08:32:32.384321044 -0700
+++ b/bgpd/bgp_fsm.c	2012-01-05 09:30:16.955532576 -0800
@@ -546,6 +546,10 @@ bgp_stop (struct peer *peer)
         /* ORF received prefix-filter pnt */
         sprintf (orf_name, "%s.%d.%d", peer->host, afi, safi);
         prefix_bgp_orf_remove_all (orf_name);
+
+	/* Drop soft reconfig info */
+	if (CHECK_FLAG (peer->af_flags[afi][safi], PEER_FLAG_SOFT_RECONFIG))
+	  bgp_clear_adj_in (peer, afi, safi);
       }

   /* Reset keepalive and holdtime */

[quagga-dev 9000] Extended Community attribute????