Hendrik Sattler | 1 Jul 20:11 2011
Picon

Re: [PATCH 1/8] Use (void) when prototyping functions with no arguments

Am Donnerstag, 30. Juni 2011, 22:39:33 schrieb plunky <at> netbsd.org:
> From: Iain Hibbert <plunky <at> rya-online.net>

I pushed all 8 patches to my repository...

Thanks :-)

HS

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Iain Hibbert | 2 Jul 13:13 2011
Picon

Re: [PATCH 1/8] Use (void) when prototyping functions with no arguments

On Fri, 1 Jul 2011, Hendrik Sattler wrote:

> Am Donnerstag, 30. Juni 2011, 22:39:33 schrieb plunky <at> netbsd.org:
> > From: Iain Hibbert <plunky <at> rya-online.net>
>
> I pushed all 8 patches to my repository...

ok thanks, at least it is outside my hard disk :)

there may be one more issue, with the change I proposed to openobex wrt
the bt_addr_t definition and the BtOBEX_ prototypes - apps/obexftpd uses
BtOBEX_ServerRegister() directly, so <obexftp/bt_kit.h> would need to be
included before <openobex/obex.h> as per below, but will leave that for
later..

regards,
iain

--- apps/obexftpd.c.orig
+++ apps/obexftpd.c
 <at>  <at>  -56,6 +56,8  <at>  <at> 
 #include <netdb.h>
 #endif

+#include <obexftp/bt_kit.h>
+
 /* just until there is a server layer in obexftp */
 #include <openobex/obex.h>

------------------------------------------------------------------------------
(Continue reading)

Hendrik Sattler | 2 Jul 16:45 2011
Picon

Re: [PATCH 1/8] Use (void) when prototyping functions with no arguments

Am Samstag, 2. Juli 2011, 13:13:31 schrieb Iain Hibbert:
> On Fri, 1 Jul 2011, Hendrik Sattler wrote:
> > Am Donnerstag, 30. Juni 2011, 22:39:33 schrieb plunky <at> netbsd.org:
> > > From: Iain Hibbert <plunky <at> rya-online.net>
> > 
> > I pushed all 8 patches to my repository...
> 
> ok thanks, at least it is outside my hard disk :)
> 
> there may be one more issue, with the change I proposed to openobex wrt
> the bt_addr_t definition and the BtOBEX_ prototypes - apps/obexftpd uses
> BtOBEX_ServerRegister() directly, so <obexftp/bt_kit.h> would need to be
> included before <openobex/obex.h> as per below, but will leave that for
> later..
> 
> regards,
> iain
> 
> --- apps/obexftpd.c.orig
> +++ apps/obexftpd.c
>  <at>  <at>  -56,6 +56,8  <at>  <at> 
>  #include <netdb.h>
>  #endif
> 
> +#include <obexftp/bt_kit.h>
> +
>  /* just until there is a server layer in obexftp */
>  #include <openobex/obex.h>

That's ok because the previous solution did hide this bug. Can you post that 
(Continue reading)

plunky | 2 Jul 18:36 2011
Picon

[PATCH] Include <obexftp/bt_kit.h> to get bluetooth definitions

From: Iain Hibbert <plunky <at> netbsd.org>

---
 apps/obexftpd.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/apps/obexftpd.c b/apps/obexftpd.c
index 8833ad0..3b268f6 100644
--- a/apps/obexftpd.c
+++ b/apps/obexftpd.c
 <at>  <at>  -56,6 +56,8  <at>  <at> 
 #include <netdb.h>
 #endif

+#include <obexftp/bt_kit.h>
+
 /* just until there is a server layer in obexftp */
 #include <openobex/obex.h>

--

-- 
1.7.4.1

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Johan Hedberg | 5 Jul 11:45 2011
Picon

Re: [PATCH 1/3] Add transport format member in fdobex_data struct

Hi Nami,

On Tue, Jul 05, 2011, Li, Nami wrote:
>  How do you think these patches? Do you agree obex over l2cap using
>  SEQPACKET?

Yes, I think the patches (like most others pending on this right now)
should be fine. I haven't done any upstream OBEX patch processing
(neither OpenOBEX nor obexd) for the past few weeks, but I hope to get
around to that soon (hopefully this week).

Johan

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Hendrik Sattler | 15 Jul 18:45 2011
Picon

Summary of all current patches

Hi,

this is a list of all the patches pending on my side. It also include Iain's
patches to make it easier.

You can find all of these patches in my gitorious repository in the "testing"
branch.

The first 11 patches are strictly needed.

Patches 22-45 are the rework of the state machine. These are not fully tested
(some test app adaptions are still needed) but show the direction it is going.
The intention is to utilize non-blocking sockets and remove a lot of internal
hacks (e.g. the current abort and resume code).

HS

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
Hendrik Sattler | 15 Jul 18:45 2011
Picon

[PATCH 01/46] Use bt_addr_t type consistently for BtOBEX_ functions

From: Iain Hibbert <plunky <at> netbsd.org>

---
 lib/obex.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/obex.c b/lib/obex.c
index 165fcb8..5e5fb31 100644
--- a/lib/obex.c
+++ b/lib/obex.c
 <at>  <at>  -1058,7 +1058,7  <at>  <at>  int CALLAPI IrOBEX_TransportConnect(obex_t *self, const char *service)
 	An easier server function to use for Bluetooth (Bluetooth OBEX) only.
  */
 LIB_SYMBOL
-int CALLAPI BtOBEX_ServerRegister(obex_t *self, bdaddr_t *src, uint8_t channel)
+int CALLAPI BtOBEX_ServerRegister(obex_t *self, bt_addr_t *src, uint8_t channel)
 {
 	DEBUG(3, "\n");

 <at>  <at>  -1085,8 +1085,8  <at>  <at>  int CALLAPI BtOBEX_ServerRegister(obex_t *self, bdaddr_t *src, uint8_t channel)
 	An easier connect function to use for Bluetooth (Bluetooth OBEX) only.
  */
 LIB_SYMBOL
-int CALLAPI BtOBEX_TransportConnect(obex_t *self, bdaddr_t *src,
-					bdaddr_t *dst, uint8_t channel)
+int CALLAPI BtOBEX_TransportConnect(obex_t *self, bt_addr_t *src,
+					bt_addr_t *dst, uint8_t channel)
 {
 	DEBUG(4, "\n");

(Continue reading)

Hendrik Sattler | 15 Jul 18:45 2011
Picon

[PATCH 02/46] Use const for bt_addr_t in BtOBEX_ functions

From: Iain Hibbert <plunky <at> netbsd.org>

(For NetBSD at least, the BDADDR_ANY that is passed to
these functions is defined as a const)
---
 include/openobex/obex.h |    4 ++--
 lib/obex.c              |    6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/openobex/obex.h b/include/openobex/obex.h
index f948113..1e9e0d7 100644
--- a/include/openobex/obex.h
+++ b/include/openobex/obex.h
 <at>  <at>  -141,8 +141,8  <at>  <at>  OPENOBEX_SYMBOL(int) IrOBEX_TransportConnect(obex_t *self, const char *service);
 #    define bt_addr_t unsigned long
 #  endif
 #endif
-OPENOBEX_SYMBOL(int) BtOBEX_ServerRegister(obex_t *self, bt_addr_t *src, uint8_t channel);
-OPENOBEX_SYMBOL(int) BtOBEX_TransportConnect(obex_t *self, bt_addr_t *src, bt_addr_t *dst,
uint8_t channel);
+OPENOBEX_SYMBOL(int) BtOBEX_ServerRegister(obex_t *self, const bt_addr_t *src, uint8_t channel);
+OPENOBEX_SYMBOL(int) BtOBEX_TransportConnect(obex_t *self, const bt_addr_t *src, const bt_addr_t
*dst, uint8_t channel);

 /*
  * OBEX File API
diff --git a/lib/obex.c b/lib/obex.c
index 5e5fb31..874cfcd 100644
--- a/lib/obex.c
+++ b/lib/obex.c
(Continue reading)

Hendrik Sattler | 15 Jul 18:45 2011
Picon

[PATCH 03/46] Fix up bt_addr_t definition

From: Iain Hibbert <plunky <at> netbsd.org>

We need to detect the presence of "Bluetooth Device Address" type
in order to provide the BtOBEX_ function prototypes, which needs
to be from a header included prior to <openobex/obex.h>
---
 include/openobex/obex.h |   21 ++++++++++++++-------
 1 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/include/openobex/obex.h b/include/openobex/obex.h
index 1e9e0d7..6dda861 100644
--- a/include/openobex/obex.h
+++ b/include/openobex/obex.h
 <at>  <at>  -131,18 +131,25  <at>  <at>  OPENOBEX_SYMBOL(int) IrOBEX_TransportConnect(obex_t *self, const char *service);
  * Bluetooth OBEX API
  */
 #if !defined(bt_addr_t)
-#  if defined(SOL_RFCOMM)
-#    if defined(_WIN32) /* Windows */
-#      define bt_addr_t BTH_ADDR
-#    else /* Linux, FreeBSD, NetBSD */
-#      define bt_addr_t bdaddr_t
+#  if defined(_WIN32)
+#    if defined(BTH_ADDR_NULL)
+#      define bt_addr_t	BTH_ADDR
+#    endif
+#  elif defined(__FreeBSD__)
+#    if defined(NG_HCI_BDADDR_ANY)
+#      define bt_addr_t	bdaddr_t
+#    endif
(Continue reading)

Hendrik Sattler | 15 Jul 18:45 2011
Picon

[PATCH 04/46] Remove spurious ;

From: Iain Hibbert <plunky <at> netbsd.org>

---
 lib/customtrans.c |    2 +-
 lib/inobex.c      |    2 +-
 lib/irobex.c      |    2 +-
 lib/obex_object.c |    2 +-
 lib/usb1obex.c    |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/customtrans.c b/lib/customtrans.c
index 0040550..20e264c 100644
--- a/lib/customtrans.c
+++ b/lib/customtrans.c
 <at>  <at>  -115,4 +115,4  <at>  <at>  int custom_register(obex_t *self, const obex_ctrans_t *in)
 void custom_get_ops(struct obex_transport_ops* ops)
 {
 	ops->clone = &custom_clone;
-};
+}
diff --git a/lib/inobex.c b/lib/inobex.c
index d7a450a..4ae2b61 100644
--- a/lib/inobex.c
+++ b/lib/inobex.c
 <at>  <at>  -410,4 +410,4  <at>  <at>  void inobex_get_ops(struct obex_transport_ops* ops)
 	ops->server.disconnect = &inobex_disconnect_server;
 	ops->client.connect = &inobex_connect_request;
 	ops->client.disconnect = &inobex_disconnect_request;
-};
+}
(Continue reading)


Gmane