the openobex users mailing list

Luiz Augusto von Dentz | 1 Jun 2011 12:32

Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Hi Hendrik,

On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler
<post <at> hendrik-sattler.de> wrote:
> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
>> > Note that those are build warnings, not build errors (except when using
>> > maintainer mode).
>>
>> Which is the whole point to force fixing and not just ignore them.
>
> Your commit message is wrong, that's what I meant!

I did rebase your changes on top of my build fixes here:
git://gitorious.org/~vudentz/openobex/vudentz-clone.git

If you are ok, I will resend my 2 build fixes again. I also did a
quick review on the other changes and noticed at least one use of c++
comment style '//' and missing note about action command support on
ChangeLog, can you fix those? And please lets be more careful with
codestyle, there are some files with space mixed with tabs and a lot
of empty likes with tabs.

If those issues are fixed we can do 2.0 release.

--

-- 
Luiz Augusto von Dentz
Computer Engineer

------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.

(Continue reading)

Hendrik Sattler | 1 Jun 2011 13:11

Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:

> Hi Hendrik,
>
> On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler
> <post <at> hendrik-sattler.de> wrote:
>> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
>>> > Note that those are build warnings, not build errors (except when using
>>> > maintainer mode).
>>>
>>> Which is the whole point to force fixing and not just ignore them.
>>
>> Your commit message is wrong, that's what I meant!
>
> I did rebase your changes on top of my build fixes here:
> git://gitorious.org/~vudentz/openobex/vudentz-clone.git
>
> If you are ok, I will resend my 2 build fixes again. I also did a
> quick review on the other changes and noticed at least one use of c++
> comment style '//'

Citing from the ISO 9899-1999 (C99) standard:
"6.4.9 Comments
1 Except within a character constant, a string literal, or a comment,  
the characters /* introduce a comment. The contents of such a comment  
are examined only to identify multibyte characters and to find the  
characters */ that terminate it.

2 Except within a character constant, a string literal, or a comment,  
the characters // introduce a comment that includes all multibyte

(Continue reading)

Luiz Augusto von Dentz | 2 Jun 2011 16:42

Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Hi Hendrik,

On Wed, Jun 1, 2011 at 2:11 PM, Hendrik Sattler <post <at> hendrik-sattler.de> wrote:
> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
>
>> Hi Hendrik,
>>
>> On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler
>> <post <at> hendrik-sattler.de> wrote:
>>> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
>>>> > Note that those are build warnings, not build errors (except when using
>>>> > maintainer mode).
>>>>
>>>> Which is the whole point to force fixing and not just ignore them.
>>>
>>> Your commit message is wrong, that's what I meant!
>>
>> I did rebase your changes on top of my build fixes here:
>> git://gitorious.org/~vudentz/openobex/vudentz-clone.git
>>
>> If you are ok, I will resend my 2 build fixes again. I also did a
>> quick review on the other changes and noticed at least one use of c++
>> comment style '//'
>
> Citing from the ISO 9899-1999 (C99) standard:
> "6.4.9 Comments
> 1 Except within a character constant, a string literal, or a comment,
> the characters /* introduce a comment. The contents of such a comment
> are examined only to identify multibyte characters and to find the
> characters */ that terminate it.

(Continue reading)

Luiz Augusto von Dentz | 2 Jun 2011 16:44

Picon

[PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

obex_test_client.c: In function ‘push_client’:
obex_test_client.c:229:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘put_client’:
obex_test_client.c:290:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘get_client’:
obex_test_client.c:347:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘setpath_client’:
obex_test_client.c:418:6: error: variable ‘num’ set but not used
cc1: all warnings being treated as errors
---
 apps/obex_test/obex_test_client.c |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/apps/obex_test/obex_test_client.c b/apps/obex_test/obex_test_client.c
index 0bf5d42..739f04a 100644
--- a/apps/obex_test/obex_test_client.c
+++ b/apps/obex_test/obex_test_client.c
 <at>  <at>  -234,7 +234,13  <at>  <at>  void push_client(obex_t *handle)
 	int file_size;

 	printf("PUSH filename> ");
-	num = scanf("%s", fname);
+	memset(fname, 0, sizeof(fname));
+	num = scanf("%199c", fname);
+	if (num != 1) {
+		perror("scanf");
+		return;
+	}

(Continue reading)

Luiz Augusto von Dentz | 2 Jun 2011 16:44

Picon

[PATCH 2/2] Fix build errors on ircp tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:303:1: error: ISO C90 forbids mixed declarations and code
ircp_server.c: In function ‘ircp_srv_recv’:
ircp_server.c:346:6: error: variable ‘err’ set but not used
ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:369:1: error: expected declaration or statement at end of input
ircp_server.c:369:1: error: control reaches end of non-void function
cc1: all warnings being treated as errors
---
 apps/ircp/ircp_client.c |    5 +++++
 apps/ircp/ircp_server.c |   11 +++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/apps/ircp/ircp_client.c b/apps/ircp/ircp_client.c
index 7f10d0c..1acd4a8 100644
--- a/apps/ircp/ircp_client.c
+++ b/apps/ircp/ircp_client.c
 <at>  <at>  -395,6 +395,11  <at>  <at>  int ircp_put(ircp_client_t *cli, char *name)
 		char *dirname;
 		
 		err = chdir(name);
+		if (err < 0) {
+			perror("chdir:");
+			return -1;
+		}
+
 		name = ".";

(Continue reading)

Luiz Augusto von Dentz | 3 Jun 2011 09:24

Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Hi Hendrik,

On Thu, Jun 2, 2011 at 5:42 PM, Luiz Augusto von Dentz
<luiz.dentz <at> gmail.com> wrote:
> Hi Hendrik,
>
> On Wed, Jun 1, 2011 at 2:11 PM, Hendrik Sattler <post <at> hendrik-sattler.de> wrote:
>> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
>>
>>> Hi Hendrik,
>>>
>>> On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler
>>> <post <at> hendrik-sattler.de> wrote:
>>>> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
>>>>> > Note that those are build warnings, not build errors (except when using
>>>>> > maintainer mode).
>>>>>
>>>>> Which is the whole point to force fixing and not just ignore them.
>>>>
>>>> Your commit message is wrong, that's what I meant!
>>>
>>> I did rebase your changes on top of my build fixes here:
>>> git://gitorious.org/~vudentz/openobex/vudentz-clone.git
>>>
>>> If you are ok, I will resend my 2 build fixes again. I also did a
>>> quick review on the other changes and noticed at least one use of c++
>>> comment style '//'
>>
>> Citing from the ISO 9899-1999 (C99) standard:
>> "6.4.9 Comments

(Continue reading)

Hendrik Sattler | 5 Jun 2011 10:55

Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Am Freitag, 3. Juni 2011, 09:24:21 schrieb Luiz Augusto von Dentz:
> Hi Hendrik,
> 
> On Thu, Jun 2, 2011 at 5:42 PM, Luiz Augusto von Dentz
> 
> <luiz.dentz <at> gmail.com> wrote:
> > Hi Hendrik,
> > 
> > On Wed, Jun 1, 2011 at 2:11 PM, Hendrik Sattler <post <at> hendrik-sattler.de> 
wrote:
> >> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
> >>> Hi Hendrik,
> >>> 
> >>> On Fri, May 27, 2011 at 2:04 PM, Hendrik Sattler
> >>> 
> >>> <post <at> hendrik-sattler.de> wrote:
> >>>> Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
> >>>>> > Note that those are build warnings, not build errors (except when
> >>>>> > using maintainer mode).
> >>>>> 
> >>>>> Which is the whole point to force fixing and not just ignore them.
> >>>> 
> >>>> Your commit message is wrong, that's what I meant!
> >>> 
> >>> I did rebase your changes on top of my build fixes here:
> >>> git://gitorious.org/~vudentz/openobex/vudentz-clone.git
> >>> 
> >>> If you are ok, I will resend my 2 build fixes again. I also did a
> >>> quick review on the other changes and noticed at least one use of c++
> >>> comment style '//'

(Continue reading)

Hendrik Sattler | 5 Jun 2011 17:38

Picon

Collection of fixes

These are rather simple fixes of all kind. The fix 7 even fixes a long-standing
bug.

------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Discover what all the cheering's about.
Get your free trial download today. 
http://p.sf.net/sfu/quest-dev2dev2

Hendrik Sattler | 5 Jun 2011 17:38

Picon

[PATCH 1/8] Fix build errors on obex_test tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

obex_test_client.c: In function ‘push_client’:
obex_test_client.c:229:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘put_client’:
obex_test_client.c:290:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘get_client’:
obex_test_client.c:347:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘setpath_client’:
obex_test_client.c:418:6: error: variable ‘num’ set but not used
cc1: all warnings being treated as errors
---
 apps/obex_test/obex_test_client.c |   31 +++++++++++++++++++++++++++----
 1 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/apps/obex_test/obex_test_client.c b/apps/obex_test/obex_test_client.c
index 0bf5d42..739f04a 100644
--- a/apps/obex_test/obex_test_client.c
+++ b/apps/obex_test/obex_test_client.c
 <at>  <at>  -234,7 +234,13  <at>  <at>  void push_client(obex_t *handle)
 	int file_size;

 	printf("PUSH filename> ");
-	num = scanf("%s", fname);
+	memset(fname, 0, sizeof(fname));
+	num = scanf("%199c", fname);
+	if (num != 1) {
+		perror("scanf");
+		return;
+	}

(Continue reading)

Hendrik Sattler | 5 Jun 2011 17:38

Picon

[PATCH 2/8] Fix build errors on ircp tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:303:1: error: ISO C90 forbids mixed declarations and code
ircp_server.c: In function ‘ircp_srv_recv’:
ircp_server.c:346:6: error: variable ‘err’ set but not used
ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:369:1: error: expected declaration or statement at end of input
ircp_server.c:369:1: error: control reaches end of non-void function
cc1: all warnings being treated as errors
---
 apps/ircp/ircp_client.c |    5 +++++
 apps/ircp/ircp_server.c |   11 +++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/apps/ircp/ircp_client.c b/apps/ircp/ircp_client.c
index 7f10d0c..1acd4a8 100644
--- a/apps/ircp/ircp_client.c
+++ b/apps/ircp/ircp_client.c
 <at>  <at>  -395,6 +395,11  <at>  <at>  int ircp_put(ircp_client_t *cli, char *name)
 		char *dirname;
 		
 		err = chdir(name);
+		if (err < 0) {
+			perror("chdir:");
+			return -1;
+		}
+
 		name = ".";

(Continue reading)

Group

gmane.network.protocols.obex.openobex.user.

Project Web Page

the openobex users mailing list

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 17

Articles in period: 160

June 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Your Photos (26 Mar 2013)
New releases: OpenOBEX-1.7 and ObexFTP-0.24 (5 Mar 2013)
Your patches for OpenOBEX (27 Feb 2013)
Fwd: Your NY Photos (14 Jan 2013)
Fwd: Your Photos (14 Dec 2012)
勇 (5 Sep 2012)
Your Photos (6 Aug 2012)
Fwd: Your Photos (31 Jul 2012)
debug output question (26 Jul 2012)
status of OpenOBEX? (9 Mar 2012)
[obexftp] code for accessing cell phone in bluetooth (19 Dec 2011)
Соберем для Вас по сети интернет базу � (27 Sep 2011)
胡東英 (20 Sep 2011)
Summary of all current patches (27 Jul 2011)
[PATCH] Fix improper handling of CONTINUE in a response (19 Jul 2011)
Summary of all current patches (15 Jul 2011)
[PATCH 1/3] Add transport format member in fdobex_data struct (5 Jul 2011)
Several fixes for issues previous mentioned on this list (30 Jun 2011)
[PATCH 1/8] Use (void) when prototyping functions with no arguments (30 Jun 2011)
API changes vs obexftp (29 Jun 2011)
[PATCH 1/6] Use bt_addr_t type consistently for BtOBEX_ functions (29 Jun 2011)

Archives

3	March 2013
1	February 2013
1	January 2013
1	December 2012
1	September 2012
1	August 2012
5	July 2012
11	March 2012
5	December 2011
2	September 2011
118	July 2011
159	June 2011
6	May 2011
31	April 2011
5	March 2011
10	February 2011
23	January 2011
17	December 2010
47	November 2010
28	October 2010
10	September 2010
10	August 2010
16	July 2010
8	June 2010
1	April 2010
22	March 2010
8	February 2010
1	January 2010
1	November 2009
10	October 2009
2	September 2009
15	August 2009
18	July 2009
14	June 2009
52	May 2009
2	April 2009
17	March 2009
42	February 2009
35	January 2009
42	December 2008
66	November 2008
33	October 2008
23	September 2008
12	August 2008
1	July 2008
14	June 2008
25	May 2008
6	April 2008
26	March 2008
30	February 2008
17	January 2008
21	December 2007
27	November 2007
27	October 2007
22	September 2007
8	August 2007
30	July 2007
50	June 2007
75	May 2007
22	April 2007
16	March 2007
3	February 2007
49	January 2007
15	December 2006
53	November 2006
154	October 2006
42	September 2006
56	August 2006
16	July 2006
3	June 2006
25	May 2006
31	April 2006
16	March 2006
39	February 2006
85	January 2006

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template