Luiz Augusto von Dentz | 25 May 11:21 2011
Picon

[PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

make[3]: Entering directory `/home/vudentz/git/openobex/apps/obex_test'
  CC     obex_test_client.o
obex_test_client.c: In function ‘push_client’:
obex_test_client.c:229:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘put_client’:
obex_test_client.c:290:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘get_client’:
obex_test_client.c:347:6: error: variable ‘num’ set but not used
obex_test_client.c: In function ‘setpath_client’:
obex_test_client.c:418:6: error: variable ‘num’ set but not used
cc1: all warnings being treated as errors
---
 apps/obex_test/obex_test_client.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/apps/obex_test/obex_test_client.c b/apps/obex_test/obex_test_client.c
index 0bf5d42..fc54e20 100644
--- a/apps/obex_test/obex_test_client.c
+++ b/apps/obex_test/obex_test_client.c
 <at>  <at>  -235,6 +235,11  <at>  <at>  void push_client(obex_t *handle)

 	printf("PUSH filename> ");
 	num = scanf("%s", fname);
+	if (num != 1) {
+		perror("scanf");
+		return;
+	}
+
(Continue reading)

Luiz Augusto von Dentz | 25 May 11:21 2011
Picon

[PATCH 2/2] Fix build errors on ircp tool when using gcc 4.6

From: Luiz Augusto von Dentz <luiz.von.dentz <at> intel.com>

make[3]: Entering directory `/home/vudentz/git/openobex/apps/ircp'
  CC     ircp_server.o
  CC     ircp_client.o
ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:303:1: error: ISO C90 forbids mixed declarations and code
ircp_server.c: In function ‘ircp_srv_recv’:
ircp_server.c:346:6: error: variable ‘err’ set but not used
ircp_server.c: In function ‘ircp_srv_receive’:
ircp_server.c:369:1: error: expected declaration or statement at end of input
ircp_server.c:369:1: error: control reaches end of non-void function
cc1: all warnings being treated as errors
---
 apps/ircp/ircp_client.c |    5 +++++
 apps/ircp/ircp_server.c |   11 +++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/apps/ircp/ircp_client.c b/apps/ircp/ircp_client.c
index 7f10d0c..1acd4a8 100644
--- a/apps/ircp/ircp_client.c
+++ b/apps/ircp/ircp_client.c
 <at>  <at>  -395,6 +395,11  <at>  <at>  int ircp_put(ircp_client_t *cli, char *name)
 		char *dirname;
 		
 		err = chdir(name);
+		if (err < 0) {
+			perror("chdir:");
+			return -1;
+		}
(Continue reading)

Hendrik Sattler | 25 May 11:33 2011
Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
[...]

Both of those are already fixed in my releasing-2.0 tree, see
https://gitorious.org/openobex/mainline/commit/a862b3d3eec7c0008ebcfcf8a75150f8a3f3bc19

I already posted them here. Except one mail from Johan, nothing  
happened. I admit that you did clean up ircp better than I did, though  
:)
Do you want to rebase the second patch on my tree, basically on-top of
https://gitorious.org/openobex/mainline/commits/ebc1dc31734bec3a2d8b172cf959b3844a29a3d9

Note that those are build warnings, not build errors (except when  
using maintainer mode).

HS

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
Luiz Augusto von Dentz | 27 May 09:54 2011
Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Hi Hendrik,

On Wed, May 25, 2011 at 12:33 PM, Hendrik Sattler
<post <at> hendrik-sattler.de> wrote:
> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
> [...]
>
> Both of those are already fixed in my releasing-2.0 tree, see
> https://gitorious.org/openobex/mainline/commit/a862b3d3eec7c0008ebcfcf8a75150f8a3f3bc19
>
> I already posted them here. Except one mail from Johan, nothing happened. I
> admit that you did clean up ircp better than I did, though :)
> Do you want to rebase the second patch on my tree, basically on-top of
> https://gitorious.org/openobex/mainline/commits/ebc1dc31734bec3a2d8b172cf959b3844a29a3d9

Well in that case why you don't rebase your tree, my patches seems to
fix just the issues with GCC 4.6 while yours fixes some other things
so it might be clearer to just have them split meaning that you should
rework your patches anyway. I know this sound inconvenient because you
have posted similar changes before, but they are not upstream, besides
that if I do rebase we will have a commit to fix another commit not
upstream (e.g. handling scanf return correctly), which IMO is not good
for sake of repository history. This fixes should go in as soon as
possible.

> Note that those are build warnings, not build errors (except when using
> maintainer mode).

Which is the whole point to force fixing and not just ignore them.

(Continue reading)

Hendrik Sattler | 27 May 13:00 2011
Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
> Hi Hendrik,
> 
> On Wed, May 25, 2011 at 12:33 PM, Hendrik Sattler
> 
> <post <at> hendrik-sattler.de> wrote:
> > Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
> > [...]
> > 
> > Both of those are already fixed in my releasing-2.0 tree, see
> > https://gitorious.org/openobex/mainline/commit/a862b3d3eec7c0008ebcfcf8a7
> > 5150f8a3f3bc19
> > 
> > I already posted them here. Except one mail from Johan, nothing happened.
> > I admit that you did clean up ircp better than I did, though :)
> > Do you want to rebase the second patch on my tree, basically on-top of
> > https://gitorious.org/openobex/mainline/commits/ebc1dc31734bec3a2d8b172cf
> > 959b3844a29a3d9
> 
> Well in that case why you don't rebase your tree, my patches seems to
> fix just the issues with GCC 4.6 while yours fixes some other things
> so it might be clearer to just have them split meaning that you should
> rework your patches anyway. I know this sound inconvenient because you
> have posted similar changes before, but they are not upstream, besides
> that if I do rebase we will have a commit to fix another commit not
> upstream (e.g. handling scanf return correctly), which IMO is not good
> for sake of repository history. This fixes should go in as soon as
> possible.

I'm sick of the current situation, so I don't care anymore.
(Continue reading)

Hendrik Sattler | 27 May 13:04 2011
Picon

Re: [PATCH 1/2] Fix build errors on obex_test tool when using gcc 4.6

Am Freitag, 27. Mai 2011, 09:54:13 schrieb Luiz Augusto von Dentz:
> > Note that those are build warnings, not build errors (except when using
> > maintainer mode).
> 
> Which is the whole point to force fixing and not just ignore them.

Your commit message is wrong, that's what I meant!

HS

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1

Gmane