headers
Vinicius Costa Gomes | 3 Jul 2010 01:26

[PATCH] Fix final bit not being set on a resumed request

In the server case the final bit of the opcode must always be set.
When resuming a request that would take more than one packet, it was
not set.
---
 lib/obex_object.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/obex_object.c b/lib/obex_object.c
index 6b2ed5d..6bfeabd 100644
--- a/lib/obex_object.c
+++ b/lib/obex_object.c
 <at>  <at>  -924,7 +924,7  <at>  <at>  int obex_object_resume(obex_t *self, obex_object_t *object)
 	cmd = (self->state & MODE_SRV) ? object->cmd :
 						object->opcode & ~OBEX_FINAL;

-	ret = obex_object_send(self, object, TRUE, FALSE);
+	ret = obex_object_send(self, object, TRUE, self->state & MODE_SRV);

 	if (ret < 0) {
 		obex_deliver_event(self, OBEX_EV_LINKERR, cmd, 0, TRUE);
--

-- 
1.7.1.1

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
Permalink | Reply | 1 comment |
headers
Hendrik Sattler | 3 Jul 2010 09:14
Picon

Please pull patches from gitorious repository

Hi,

All my changes since commit 3b293983338985d2d0f43451dcc4e07a91506c97:

  Remove alread removed function from documentation (2010-03-01 14:57:08 -0300)

are available in the git repository at:
  git://gitorious.org/openobex/mainline.git updates

The changelog is not here at purpose, please see the chronological one at
  http://www.gitorious.org/openobex/mainline/commits/updates
instead.

 .gitignore                              |    2 +-
 CMakeLists.txt                          |    5 +-
 CMakeModules/FindLibUSB.cmake           |   18 +-
 Makefile.am                             |    2 +-
 acinclude.m4                            |    3 +-
 apps/CMakeLists.txt                     |   45 +--
 apps/Makefile.am                        |   25 +-
 {ircp => apps/ircp}/CMakeLists.txt      |    0
 {ircp => apps/ircp}/ChangeLog           |    0
 {ircp => apps/ircp}/Makefile.am         |   12 +-
 {ircp => apps/ircp}/debug.h             |    0
 {ircp => apps/ircp}/dirtraverse.c       |    0
 {ircp => apps/ircp}/dirtraverse.h       |    0
 {ircp => apps/ircp}/ircp.c              |    0
 {ircp => apps/ircp}/ircp.h              |    0
 {ircp => apps/ircp}/ircp_client.c       |    0
 {ircp => apps/ircp}/ircp_client.h       |    0
(Continue reading)

Permalink | Reply | 13 comments |
headers
Johan Hedberg | 3 Jul 2010 14:54
Picon
Gravatar

Re: Please pull patches from gitorious repository

Hi Hendrik,

On Sat, Jul 03, 2010, Hendrik Sattler wrote:
> All my changes since commit 3b293983338985d2d0f43451dcc4e07a91506c97:
> 
>   Remove alread removed function from documentation (2010-03-01 14:57:08 -0300)
> 
> are available in the git repository at:
>   git://gitorious.org/openobex/mainline.git updates
> 
> The changelog is not here at purpose, please see the chronological one at
>   http://www.gitorious.org/openobex/mainline/commits/updates
> instead.

Your tree seems to contain lots of good stuff. Any reason why you
haven't requested an upstream merge earlier? The changes span from early
march to the end of june so it seems this would have been possible a
long time ago. Now the change set is quite huge and will take a long
time to properly review. After a quick skim though I didn't find
anything really critical, but there seem to be plenty of white space
issues that'd be nice to get fixed. Also, please keep your commit
message width at max 72 characters so they're readable with git log on
80 character terminals.

The whitespace issues I noticed fall mainly into the following
categories:

- over 80-character line (ok if the existing code had that issue too)
- white space at the end of line before line terminator
- mixed tabs and spaces for indentation
(Continue reading)

Permalink | Reply | 10 comments |
headers
Hendrik Sattler | 5 Jul 2010 06:47
Picon

Re: Please pull patches from gitorious repository

Am Samstag 03 Juli 2010, 14:54:55 schrieb Johan Hedberg:
> Your tree seems to contain lots of good stuff. Any reason why you
> haven't requested an upstream merge earlier? The changes span from early
> march to the end of june so it seems this would have been possible a
> long time ago. Now the change set is quite huge and will take a long
> time to properly review. After a quick skim though I didn't find
> anything really critical, but there seem to be plenty of white space
> issues that'd be nice to get fixed. Also, please keep your commit
> message width at max 72 characters so they're readable with git log on
> 80 character terminals.
> 
> The whitespace issues I noticed fall mainly into the following
> categories:
> - over 80-character line (ok if the existing code had that issue too)
> - white space at the end of line before line terminator
> - some empty lines not being really empty but containing tabs or spaces

Those are OK to fix.

> - mixed tabs and spaces for indentation
> - more than one consecutive empty line
> - space between function name and opening (

These are pure coding rules that are defined by personal preference. There are 
no clearly defined coding rules for the openobex code base.
Can we stick to whatever git complains about?

To enforce coding rules later, we may add vim and/or emacs instruction 
footers/headers.
(Continue reading)

Permalink | Reply | 9 comments |
headers
Fauerbach Maestri | 7 Jul 2010 23:29
Picon

As the possibility of getting something to do for t

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Openobex-users mailing list
Openobex-users <at> lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users
Permalink | Reply | 0 comments |
headers
Hendrik Sattler | 20 Jul 2010 20:26
Picon

Re: Please pull patches from gitorious repository

Am Montag 05 Juli 2010, 06:47:01 schrieb Hendrik Sattler:
> Am Samstag 03 Juli 2010, 14:54:55 schrieb Johan Hedberg:
> > Your tree seems to contain lots of good stuff. Any reason why you
> > haven't requested an upstream merge earlier? The changes span from early
> > march to the end of june so it seems this would have been possible a
> > long time ago. Now the change set is quite huge and will take a long
> > time to properly review. After a quick skim though I didn't find
> > anything really critical, but there seem to be plenty of white space
> > issues that'd be nice to get fixed. Also, please keep your commit
> > message width at max 72 characters so they're readable with git log on
> > 80 character terminals.
> > 
> > The whitespace issues I noticed fall mainly into the following
> > categories:
> > - over 80-character line (ok if the existing code had that issue too)
> > - white space at the end of line before line terminator
> > - some empty lines not being really empty but containing tabs or spaces
> 
> Those are OK to fix.

I reorganized the patches quite a bit. Please pull from
  git://gitorious.org/openobex/mainline.git for-mainline

> > - mixed tabs and spaces for indentation
> > - more than one consecutive empty line
> > - space between function name and opening (
> 
> These are pure coding rules that are defined by personal preference. There
> are no clearly defined coding rules for the openobex code base.
> Can we stick to whatever git complains about?
> 
> To enforce coding rules later, we may add vim and/or emacs instruction
> footers/headers.
> 
> Note: all versions of git that I used so far complain about whitespace
> issues for files that have \r\n line endings :-( We have such files in
> OpenOBEX.

This still applies! All changes to cmake files will cause git to complain about 
white-space errors. Some are resolved with --keep-cr but it still fails to get 
this right in other places :-/

HS

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
Permalink | Reply | 8 comments |
headers
Luiz Augusto von Dentz | 20 Jul 2010 22:16
Picon

Re: Please pull patches from gitorious repository

Hi,

On Tue, Jul 20, 2010 at 9:26 PM, Hendrik Sattler
<post <at> hendrik-sattler.de> wrote:
> Am Montag 05 Juli 2010, 06:47:01 schrieb Hendrik Sattler:
>> Am Samstag 03 Juli 2010, 14:54:55 schrieb Johan Hedberg:
>> > Your tree seems to contain lots of good stuff. Any reason why you
>> > haven't requested an upstream merge earlier? The changes span from early
>> > march to the end of june so it seems this would have been possible a
>> > long time ago. Now the change set is quite huge and will take a long
>> > time to properly review. After a quick skim though I didn't find
>> > anything really critical, but there seem to be plenty of white space
>> > issues that'd be nice to get fixed. Also, please keep your commit
>> > message width at max 72 characters so they're readable with git log on
>> > 80 character terminals.
>> >
>> > The whitespace issues I noticed fall mainly into the following
>> > categories:
>> > - over 80-character line (ok if the existing code had that issue too)
>> > - white space at the end of line before line terminator
>> > - some empty lines not being really empty but containing tabs or spaces
>>
>> Those are OK to fix.
>
> I reorganized the patches quite a bit. Please pull from
>  git://gitorious.org/openobex/mainline.git for-mainline
>
>> > - mixed tabs and spaces for indentation
>> > - more than one consecutive empty line
>> > - space between function name and opening (
>>
>> These are pure coding rules that are defined by personal preference. There
>> are no clearly defined coding rules for the openobex code base.
>> Can we stick to whatever git complains about?
>>
>> To enforce coding rules later, we may add vim and/or emacs instruction
>> footers/headers.
>>
>> Note: all versions of git that I used so far complain about whitespace
>> issues for files that have \r\n line endings :-( We have such files in
>> OpenOBEX.
>
> This still applies! All changes to cmake files will cause git to complain about
> white-space errors. Some are resolved with --keep-cr but it still fails to get
> this right in other places :-/

The build is broken when using autotools.

--

-- 
Luiz Augusto von Dentz
Computer Engineer

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
Permalink | Reply | 7 comments |
headers
Hendrik Sattler | 21 Jul 2010 08:31
Picon

Re: Please pull patches from gitorious repository

Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
> The build is broken when using autotools.

Did you run "autoreconf -f"?
I will try autotools-build tonight.

I saw that you also have some patches available. Welcome to the  
openobex team :)

HS

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
Permalink | Reply | 6 comments |
headers
Hendrik Sattler | 21 Jul 2010 18:53
Picon

Re: Please pull patches from gitorious repository

Am Mittwoch 21 Juli 2010, 08:31:12 schrieb Hendrik Sattler:
> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
> > The build is broken when using autotools.
> 
> Did you run "autoreconf -f"?
> I will try autotools-build tonight.

Works here just fine.

autoreconf -f -i
mkdir build
cd build
../configure --enable-apps --enable-maintainer-mode
make
make install DESTDIR=$(pwd)/local

HS

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
Permalink | Reply | 5 comments |
headers
Luiz Augusto von Dentz | 21 Jul 2010 19:12
Picon

Re: Please pull patches from gitorious repository

Hi,

On Wed, Jul 21, 2010 at 7:53 PM, Hendrik Sattler
<post <at> hendrik-sattler.de> wrote:
> Am Mittwoch 21 Juli 2010, 08:31:12 schrieb Hendrik Sattler:
>> Zitat von Luiz Augusto von Dentz <luiz.dentz <at> gmail.com>:
>> > The build is broken when using autotools.
>>
>> Did you run "autoreconf -f"?
>> I will try autotools-build tonight.
>
> Works here just fine.
>
> autoreconf -f -i
> mkdir build
> cd build
> ../configure --enable-apps --enable-maintainer-mode
> make
> make install DESTDIR=$(pwd)/local

I haven't tried it outside the source tree like you did with build,
but inside it seems pretty broken see the attachment.

--

-- 
Luiz Augusto von Dentz
Computer Engineer
Attachment (build.log): text/x-log, 30 KiB
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Openobex-users mailing list
Openobex-users <at> lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/openobex-users
Permalink | Reply | 4 comments |

Gmane