Sorin Vinturis | 2 Sep 18:44 2015

[PATCH v2] datapath-windows: Add corresponding tag for tunnel context allocations

Signed-off-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin <at> vmware.com>
---
 datapath-windows/ovsext/Vport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 6b74ec2..cdb434c 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
 <at>  <at>  -1267,7 +1267,8  <at>  <at>  OvsRemoveTunnelVport(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
     POVS_TUNFLT_INIT_CONTEXT tunnelContext = NULL;
     PIRP irp = NULL;

-    tunnelContext = OvsAllocateMemory(sizeof(*tunnelContext));
+    tunnelContext = OvsAllocateMemoryWithTag(sizeof(*tunnelContext),
+                                             OVS_VPORT_POOL_TAG);
     if (tunnelContext == NULL) {
         return STATUS_INSUFFICIENT_RESOURCES;
     }
--

-- 
1.9.0.msysgit.0
_______________________________________________
dev mailing list
dev <at> openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sorin Vinturis | 2 Sep 18:44 2015

[PATCH v2] datapath-windows: New tag for tunnel filter pool allocations

All memory allocations within tunnel filter code have 'WSVO' pool tag.

Signed-off-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin <at> vmware.com>
---
 datapath-windows/ovsext/TunnelFilter.c | 4 +++-
 datapath-windows/ovsext/Util.h         | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-windows/ovsext/TunnelFilter.c
index a359cac..8bff27a 100644
--- a/datapath-windows/ovsext/TunnelFilter.c
+++ b/datapath-windows/ovsext/TunnelFilter.c
 <at>  <at>  -1446,7 +1446,9  <at>  <at>  OvsTunnelFilterQueueRequest(PIRP irp,
             break;
         }

-        request = (POVS_TUNFLT_REQUEST) OvsAllocateMemory(sizeof(*request));
+        request = (POVS_TUNFLT_REQUEST)
+            OvsAllocateMemoryWithTag(sizeof(*request),
+                                     OVS_TUNFLT_POOL_TAG);
         if (NULL == request) {
             OVS_LOG_ERROR("Failed to allocate list item.");
             status = STATUS_INSUFFICIENT_RESOURCES;
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h
index e3f9ede..0bbc52b 100644
--- a/datapath-windows/ovsext/Util.h
+++ b/datapath-windows/ovsext/Util.h
 <at>  <at>  -34,6 +34,7  <at>  <at> 
 #define OVS_USER_POOL_TAG               'USVO'
(Continue reading)

Sorin Vinturis | 2 Sep 18:30 2015

[PATCH] datapath-windows: Tunnel filter initialization check

Verify if the tunnel filter is initialized before submitting requests.

Signed-off-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
Reported-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/100
---
 datapath-windows/ovsext/TunnelFilter.c | 71 +++++++++++++++++++++++-----------
 1 file changed, 48 insertions(+), 23 deletions(-)

diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-windows/ovsext/TunnelFilter.c
index a359cac..46f756e 100644
--- a/datapath-windows/ovsext/TunnelFilter.c
+++ b/datapath-windows/ovsext/TunnelFilter.c
 <at>  <at>  -121,7 +121,7  <at>  <at>  typedef struct _OVS_TUNFLT_REQUEST {
         UINT64                  delID;
         /* Pointer used to return filter ID to the caller on filter creation. */
         PUINT64                 addID;
-    }filterID;
+    } filterID;
     /* Requested operation to be performed. */
     OVS_TUNFLT_OPERATION    operation;
     /* Current I/O request to be completed when requested
 <at>  <at>  -147,6 +147,8  <at>  <at>  typedef struct _OVS_TUNFLT_REQUEST_LIST {
 typedef struct _OVS_TUNFLT_THREAD_CONTEXT {
     /* Thread identification. */
     UINT                    threadID;
+    /* Thread initialization flag. */
+    UINT32                  isInitialized;
     /* Thread's engine session handle. */
     HANDLE                  engineSession;
(Continue reading)

Sorin Vinturis | 2 Sep 15:37 2015

[PATCH] datapath-windows: Add corresponding tag for tunnel context allocations

Signed-off-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
---
 datapath-windows/ovsext/Vport.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 6b74ec2..38cf878 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
 <at>  <at>  -1267,7 +1267,9  <at>  <at>  OvsRemoveTunnelVport(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
     POVS_TUNFLT_INIT_CONTEXT tunnelContext = NULL;
     PIRP irp = NULL;

-    tunnelContext = OvsAllocateMemory(sizeof(*tunnelContext));
+    tunnelContext = (POVS_TUNFLT_INIT_CONTEXT)
+        OvsAllocateMemoryWithTag(sizeof(*tunnelContext),
+                                 OVS_VPORT_POOL_TAG);
     if (tunnelContext == NULL) {
         return STATUS_INSUFFICIENT_RESOURCES;
     }
--

-- 
1.9.0.msysgit.0
_______________________________________________
dev mailing list
dev <at> openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Sorin Vinturis | 2 Sep 15:37 2015

[PATCH] datapath-windows: New tag for tunnel filter pool allocations

All memory allocations within tunnel filter code have 'WSVO' pool tag.

Signed-off-by: Sorin Vinturis <svinturis <at> cloudbasesolutions.com>
---
 datapath-windows/ovsext/TunnelFilter.c | 4 +++-
 datapath-windows/ovsext/Util.h         | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/datapath-windows/ovsext/TunnelFilter.c b/datapath-windows/ovsext/TunnelFilter.c
index a359cac..8bff27a 100644
--- a/datapath-windows/ovsext/TunnelFilter.c
+++ b/datapath-windows/ovsext/TunnelFilter.c
 <at>  <at>  -1446,7 +1446,9  <at>  <at>  OvsTunnelFilterQueueRequest(PIRP irp,
             break;
         }

-        request = (POVS_TUNFLT_REQUEST) OvsAllocateMemory(sizeof(*request));
+        request = (POVS_TUNFLT_REQUEST)
+            OvsAllocateMemoryWithTag(sizeof(*request),
+                                     OVS_TUNFLT_POOL_TAG);
         if (NULL == request) {
             OVS_LOG_ERROR("Failed to allocate list item.");
             status = STATUS_INSUFFICIENT_RESOURCES;
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h
index e3f9ede..0bbc52b 100644
--- a/datapath-windows/ovsext/Util.h
+++ b/datapath-windows/ovsext/Util.h
 <at>  <at>  -34,6 +34,7  <at>  <at> 
 #define OVS_USER_POOL_TAG               'USVO'
 #define OVS_VPORT_POOL_TAG              'PSVO'
(Continue reading)

Ilya Maximets | 2 Sep 13:44 2015

[PATCH v4] dpif-netdev: proper tx queue id

Currently tx_qid is equal to pmd->core_id. This leads to unexpected
behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/',
e.g. if core_ids are not sequential, or doesn't start from 0, or both.

Example:
	starting 2 pmd threads with 1 port, 2 rxqs per port,
	pmd-cpu-mask = 00000014 and let dev->real_n_txq = 2

	It that case pmd_1->tx_qid = 2, pmd_2->tx_qid = 4 and
	txq_needs_locking = true (if device hasn't ovs_numa_get_n_cores()+1
	queues).

	In that case, after truncating in netdev_dpdk_send__():
		'qid = qid % dev->real_n_txq;'
	pmd_1: qid = 2 % 2 = 0
	pmd_2: qid = 4 % 2 = 0

	So, both threads will call dpdk_queue_pkts() with same qid = 0.
	This is unexpected behavior if there is 2 tx queues in device.
	Queue #1 will not be used and both threads will lock queue #0
	on each send.

Fix that by introducing per pmd thread hash map 'tx_queues', where will
be stored all available tx queues for that pmd thread with
port_no as a key(hash). All tx_qid-s will be unique per port and
sequential to prevent described unexpected mapping after truncating.

Implemented infrastructure can be used in the future to choose
between all tx queues available for that pmd thread.

(Continue reading)

Jhie Tejada | 2 Sep 13:39 2015
Picon

Job Contracting and Against Labor-only Contracting - Oct. 1


--------------------------------------------------------------------------------
This email newsletter was sent to you in graphical HTML format.
If you're seeing this version, your email program prefers plain text emails.
You can read the original version online:
http://ymlp182.com/zduRnl
--------------------------------------------------------------------------------

Part I. JOB CONTRACTING AND SUB-CONTRACTING

1. The Labor Code Provisions on Legitimate Job Contracting

2. The Law Against Labor-only Contracting

3. Four (4) Labor Code provisions enunciating the rules on
contractualization, to wit:

A.  Article 106 – Contractor or Subcontractor;
B.  Article 107 – Indirect Employer;
C.  Article 108 – Posting of Bond; and
D.  Article 109 – Solidary Liability.

4. The Framework of Trilateral Relationship in
Contracting/Sub-contracting

A. Parties to Trilateral Relationship

a. Principal
b. Contractor/Subcontractor (Agency)
c. Contractual Employer
(Continue reading)

Timo Puha | 2 Sep 13:14 2015
Picon

[PATCH v2] dpdk: add support for v2.1.0

Update relevant artifacts to add support for DPDK v2.1.0
 - INSTALL.DPDK.md
 - acinclude.m4: Change DPDK library name
 - netdev-dpdk: Limit minimum mbuf size to to adapt to DPDK bug fix that
   changes the treatment of the requested mbuf size
 - build.sh: Change DPDK version number

Note that this breaks compatibility with DPDK v2.0.0 although only
for the library name change.

Note that throughput for vhost ports with mergeable buffers is reduced
about 10% due to a necessary bug fix in DPDK vhost code.

Signed-off-by: Mark Kavanagh <mark.b.kavanagh <at> intel.com>
Signed-off-by: Michal Weglicki <michalx.weglicki <at> intel.com>
Signed-off-by: Timo Puha <timox.puha <at> intel.com>
---
 .travis/build.sh  |  2 +-
 INSTALL.DPDK.md   | 17 ++++++-----------
 acinclude.m4      |  2 +-
 lib/netdev-dpdk.c | 12 +++++++++---
 4 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/.travis/build.sh b/.travis/build.sh
index e90f4d0..3cadbf0 100755
--- a/.travis/build.sh
+++ b/.travis/build.sh
 <at>  <at>  -71,7 +71,7  <at>  <at>  fi

 if [ "$DPDK" ]; then
(Continue reading)

Mark Kavanagh | 2 Sep 11:02 2015
Picon

[PATCH] netdev-dpdk: refactor for struct eth_addr

Commit 74ff329 introduces 'struct eth_addr'; this breaks compilation
for netdev-dpdk.c.

Refactor any affected code to resolve.

Signed-off-by: Mark Kavanagh <mark.b.kavanagh <at> intel.com>
---
 lib/netdev-dpdk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 4ce0a1e..ebcc289 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
 <at>  <at>  -523,10 +523,10  <at>  <at>  dpdk_eth_dev_init(struct netdev_dpdk *dev) OVS_REQUIRES(dpdk_mutex)

     memset(&eth_addr, 0x0, sizeof(eth_addr));
     rte_eth_macaddr_get(dev->port_id, &eth_addr);
+    memcpy(dev->hwaddr.ea, eth_addr.addr_bytes, ETH_ADDR_LEN);
     VLOG_INFO_RL(&rl, "Port %d: "ETH_ADDR_FMT"",
-                    dev->port_id, ETH_ADDR_ARGS(eth_addr.addr_bytes));
+                    dev->port_id, ETH_ADDR_ARGS(dev->hwaddr));

-    memcpy(dev->hwaddr, eth_addr.addr_bytes, ETH_ADDR_LEN);
     rte_eth_link_get_nowait(dev->port_id, &dev->link);

     mbp_priv = rte_mempool_get_priv(dev->dpdk_mp->mp);
--

-- 
1.9.3

(Continue reading)

Ben Pfaff | 2 Sep 08:42 2015

[PATCH 1/6] tests: Automatically initialize OVS_*DIR vars when tests begin.

A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc.
variables to point to the directory in which the tests run.  Until now,
each of them has had to do this individually, which is redundant.  This
commit starts to do this automatically.

Signed-off-by: Ben Pfaff <blp <at> nicira.com>
---
 tests/jsonrpc-py.at          |  3 ---
 tests/jsonrpc.at             |  3 ---
 tests/library.at             |  1 -
 tests/ofproto-macros.at      |  8 +-------
 tests/ovn-controller-vtep.at |  5 -----
 tests/ovn-sbctl.at           |  7 +------
 tests/ovs-macros.at          | 18 ++++++++++++++++++
 tests/ovs-monitor-ipsec.at   |  3 ---
 tests/ovs-vsctl.at           |  2 --
 tests/ovs-vswitchd.at        |  4 ----
 tests/ovs-xapi-sync.at       |  3 ---
 tests/ovsdb-execution.at     |  1 -
 tests/ovsdb-idl.at           |  8 --------
 tests/ovsdb-macros.at        |  3 +--
 tests/ovsdb-monitor.at       |  1 -
 tests/ovsdb-server.at        | 33 ---------------------------------
 tests/ovsdb-tool.at          |  4 ----
 tests/unixctl-py.at          |  6 ------
 tests/vconn.at               |  1 -
 tests/vlog.at                | 24 ------------------------
 tests/vtep-ctl.at            |  3 +--
 21 files changed, 22 insertions(+), 119 deletions(-)

(Continue reading)

Justin Pettit | 2 Sep 02:21 2015

[PATCH 1/3] ovn-architecture: Fix capitalization of a title.

Signed-off-by: Justin Pettit <jpettit <at> nicira.com>
---
 ovn/ovn-architecture.7.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ovn/ovn-architecture.7.xml b/ovn/ovn-architecture.7.xml
index c9ac597..85a74a9 100644
--- a/ovn/ovn-architecture.7.xml
+++ b/ovn/ovn-architecture.7.xml
 <at>  <at>  -457,7 +457,7  <at>  <at> 
     </li>
   </ol>

-  <h2>Life Cycle of a container interface inside a VM</h2>
+  <h2>Life Cycle of a Container Interface Inside a VM</h2>

   <p>
     OVN provides virtual network abstractions by converting information
--

-- 
1.7.5.4

_______________________________________________
dev mailing list
dev <at> openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Gmane