OSLR development (code, porting, etc.)

Ferry Huberts | 6 Dec 2011 10:15

[PATCH 4/4] smart gateway: remove useless code in smartgw_tunnel_monitor

From: Ferry Huberts <f.huberts <at> mindef.nl>

Signed-off-by: Ferry Huberts <f.huberts <at> mindef.nl>
---
 src/gateway.c |   19 +------------------
 1 files changed, 1 insertions(+), 18 deletions(-)

diff --git a/src/gateway.c b/src/gateway.c
index 31a63ab..e3c4a56 100644
--- a/src/gateway.c
+++ b/src/gateway.c
 <at>  <at>  -82,24 +82,7  <at>  <at>  serialize_gw_speed(uint32_t speed) {
  */
 static void smartgw_tunnel_monitor (int if_index,
     struct interface *ifh __attribute__ ((unused)), enum olsr_ifchg_flag flag) {
-  if (current_ipv4_gw != NULL && if_index == v4gw_tunnel->if_index && flag == IFCHG_IF_ADD) {
-	/* v4 tunnel up again, set route */
-    /* no need to setup tunnel route, already setup by olsr_set_inet_gateway.
-	olsr_os_inetgw_tunnel_route(v4gw_tunnel->if_index, true, true); */
-
-    /* and ip */
-	/* no need to setup ip, already setup by olsr_os_add_ipip_tunnel.
-    olsr_os_ifip(v4gw_tunnel->if_index, &olsr_cnf->main_addr, true); */
-  }
-  if (current_ipv6_gw != NULL && if_index == v6gw_tunnel->if_index && flag == IFCHG_IF_ADD) {
-	/* v6 status changed, set route */
-    /* no need to setup tunnel route, already setup by olsr_set_inet_gateway.
-	olsr_os_inetgw_tunnel_route(v6gw_tunnel->if_index, false, true); */
-
-    /* and ip */

(Continue reading)

Ferry Huberts | 6 Dec 2011 10:14

[PATCH 1/4] smart gateway: fix spelling of 'lazy'

From: Ferry Huberts <ferry.huberts <at> pelagic.nl>

Signed-off-by: Ferry Huberts <ferry.huberts <at> pelagic.nl>
---
 src/gateway_default_handler.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gateway_default_handler.c b/src/gateway_default_handler.c
index d484d73..a18dba8 100644
--- a/src/gateway_default_handler.c
+++ b/src/gateway_default_handler.c
 <at>  <at>  -84,7 +84,7  <at>  <at>  static void gw_default_choose_gateway(void) {
   }
 }

-/* timer for laze gateway selection */
+/* timer for lazy gateway selection */
 static void gw_default_timer(void *unused __attribute__ ((unused))) {
   /* accept a 10% increase without trigger a stablecount reset */
   if (tc_tree.count * 10 <= gw_def_nodecount * 11) {
-- 
1.7.7.3

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev

Ferry Huberts | 6 Dec 2011 10:14

[PATCH 3/4] smart gateway: remove duplicated calls

From: Ferry Huberts <f.huberts <at> mindef.nl>

Signed-off-by: Ferry Huberts <ferry.huberts <at> pelagic.nl>
---
 src/gateway.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/gateway.c b/src/gateway.c
index eab8785..31a63ab 100644
--- a/src/gateway.c
+++ b/src/gateway.c
 <at>  <at>  -83,18 +83,22  <at>  <at>  serialize_gw_speed(uint32_t speed) {
 static void smartgw_tunnel_monitor (int if_index,
     struct interface *ifh __attribute__ ((unused)), enum olsr_ifchg_flag flag) {
   if (current_ipv4_gw != NULL && if_index == v4gw_tunnel->if_index && flag == IFCHG_IF_ADD) {
-    /* v4 tunnel up again, set route */
-    olsr_os_inetgw_tunnel_route(v4gw_tunnel->if_index, true, true);
+	/* v4 tunnel up again, set route */
+    /* no need to setup tunnel route, already setup by olsr_set_inet_gateway.
+	olsr_os_inetgw_tunnel_route(v4gw_tunnel->if_index, true, true); */

     /* and ip */
-    olsr_os_ifip(v4gw_tunnel->if_index, &olsr_cnf->main_addr, true);
+	/* no need to setup ip, already setup by olsr_os_add_ipip_tunnel.
+    olsr_os_ifip(v4gw_tunnel->if_index, &olsr_cnf->main_addr, true); */
   }
   if (current_ipv6_gw != NULL && if_index == v6gw_tunnel->if_index && flag == IFCHG_IF_ADD) {
-    /* v6 status changed, set route */
-    olsr_os_inetgw_tunnel_route(v6gw_tunnel->if_index, false, true);
+	/* v6 status changed, set route */

(Continue reading)

Ferry Huberts | 6 Dec 2011 10:14

[PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

From: Ferry Huberts <ferry.huberts <at> pelagic.nl>

Signed-off-by: Ferry Huberts <ferry.huberts <at> pelagic.nl>
---
 src/gateway_default_handler.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/src/gateway_default_handler.c b/src/gateway_default_handler.c
index a18dba8..50986b3 100644
--- a/src/gateway_default_handler.c
+++ b/src/gateway_default_handler.c
 <at>  <at>  -76,12 +76,6  <at>  <at>  static void gw_default_choose_gateway(void) {
   if (inet_ipv6 && !dual) {
     olsr_set_inet_gateway(&inet_ipv6->originator, false, true, false);
   }
-
-  /* finished ? */
-  if (gw_def_finished_ipv4 && gw_def_finished_ipv6) {
-    olsr_stop_timer(gw_def_timer);
-    gw_def_timer = NULL;
-  }
 }

 /* timer for lazy gateway selection */
-- 
1.7.7.3

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org

(Continue reading)

Ferry Huberts | 6 Dec 2011 10:14

[PATCH 0/4] SmartGateway fixes

From: Ferry Huberts <f.huberts <at> mindef.nl>

This patch series aims to fix some smart gateway issues we're experiencing.

Please review carefully; we have too little insight into the smart gateway
code and its design decisions to know for sure whether our changes are 100%
right, especially patch 3/4.

Ferry Huberts (4):
  smart gateway: fix spelling of 'lazy'
  smart gateway: do not stop choosing a new (better) gateway
  smart gateway: remove duplicated calls
  smart gateway: remove useless code in smartgw_tunnel_monitor

 src/gateway.c                 |   15 +--------------
 src/gateway_default_handler.c |    8 +-------
 2 files changed, 2 insertions(+), 21 deletions(-)

-- 
1.7.7.3

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev

Henning Rogge | 8 Dec 2011 08:20

Picon

Re: [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

On 12/06/2011 10:14 AM, Ferry Huberts wrote:
> From: Ferry Huberts<ferry.huberts <at> pelagic.nl>
>
> Signed-off-by: Ferry Huberts<ferry.huberts <at> pelagic.nl>
> ---
>   src/gateway_default_handler.c |    6 ------
>   1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/src/gateway_default_handler.c b/src/gateway_default_handler.c
> index a18dba8..50986b3 100644
> --- a/src/gateway_default_handler.c
> +++ b/src/gateway_default_handler.c
>  <at>  <at>  -76,12 +76,6  <at>  <at>  static void gw_default_choose_gateway(void) {
>     if (inet_ipv6&&  !dual) {
>       olsr_set_inet_gateway(&inet_ipv6->originator, false, true, false);
>     }
> -
> -  /* finished ? */
> -  if (gw_def_finished_ipv4&&  gw_def_finished_ipv6) {
> -    olsr_stop_timer(gw_def_timer);
> -    gw_def_timer = NULL;
> -  }
>   }
>
>   /* timer for lazy gateway selection */

Have to look at this more closely. The idea behind the "default" gateway 
selector is to select a gateway and stick with it until its gone. Maybe 
"gone" is a bit too late, but if we start choosing another gateway too 
early, we might get gateway-flapping again.

(Continue reading)

Ferry Huberts | 8 Dec 2011 08:44

Re: [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

On 12/08/2011 08:20 AM, Henning Rogge wrote:
> On 12/06/2011 10:14 AM, Ferry Huberts wrote:
>> From: Ferry Huberts<ferry.huberts <at> pelagic.nl>
>>
>> Signed-off-by: Ferry Huberts<ferry.huberts <at> pelagic.nl>
>> ---
>>   src/gateway_default_handler.c |    6 ------
>>   1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/src/gateway_default_handler.c
>> b/src/gateway_default_handler.c
>> index a18dba8..50986b3 100644
>> --- a/src/gateway_default_handler.c
>> +++ b/src/gateway_default_handler.c
>>  <at>  <at>  -76,12 +76,6  <at>  <at>  static void gw_default_choose_gateway(void) {
>>     if (inet_ipv6&&  !dual) {
>>       olsr_set_inet_gateway(&inet_ipv6->originator, false, true, false);
>>     }
>> -
>> -  /* finished ? */
>> -  if (gw_def_finished_ipv4&&  gw_def_finished_ipv6) {
>> -    olsr_stop_timer(gw_def_timer);
>> -    gw_def_timer = NULL;
>> -  }
>>   }
>>
>>   /* timer for lazy gateway selection */
> 
> Have to look at this more closely. The idea behind the "default" gateway
> selector is to select a gateway and stick with it until its gone. Maybe

(Continue reading)

Henning Rogge | 8 Dec 2011 08:51

Picon

Re: [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

On 12/08/2011 08:44 AM, Ferry Huberts wrote:
>> Have to look at this more closely. The idea behind the "default" gateway
>> selector is to select a gateway and stick with it until its gone. Maybe
>> "gone" is a bit too late, but if we start choosing another gateway too
>> early, we might get gateway-flapping again.
>>
>
> Agree.
>
> However, in our highly mobile networks we have to do something.
> This is a short term solution to make it work, and sending out the
> patches was also meant to start a discussion on the best solution 
>
> The usual solution is to use some form of hysteresis. We might do
> something like 'if there is a better gateway for at least x seconds,
> then switch to it'.
>
> What do you think?
I think there should be some API calls to overwrite the gateway selector 
from a plugin, so maybe we could put your selector into one so users can 
choose between them.

At least that was the plan when I designed the code, I don't think 
anyone has ever wrote a Smart-GW plugin.

Henning

--

-- 
Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
Kommunikation, Informationsverarbeitung und Ergonomie FKIE

(Continue reading)

Ferry Huberts | 8 Dec 2011 13:50

Re: [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

On 12/08/2011 08:51 AM, Henning Rogge wrote:
> On 12/08/2011 08:44 AM, Ferry Huberts wrote:
>>> Have to look at this more closely. The idea behind the "default" gateway
>>> selector is to select a gateway and stick with it until its gone. Maybe
>>> "gone" is a bit too late, but if we start choosing another gateway too
>>> early, we might get gateway-flapping again.
>>>
>>
>> Agree.
>>
>> However, in our highly mobile networks we have to do something.
>> This is a short term solution to make it work, and sending out the
>> patches was also meant to start a discussion on the best solution 
>>
>> The usual solution is to use some form of hysteresis. We might do
>> something like 'if there is a better gateway for at least x seconds,
>> then switch to it'.
>>
>> What do you think?
> I think there should be some API calls to overwrite the gateway selector
> from a plugin, so maybe we could put your selector into one so users can
> choose between them.
> 
> At least that was the plan when I designed the code, I don't think
> anyone has ever wrote a Smart-GW plugin.
> 

so how do you propose we continue this?

--

--

(Continue reading)

Teco Boot | 8 Dec 2011 14:12

Picon

Re: [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

I saw a "bug" in old behavior. When first selected SGW was lost, no new SGW was selected. The patch in default
SGW code should check current tunnel, and set up new one if it was lost.

A more advanced SGW would switch when a far better SGW is available, e.g. < 70% of current SGW costs (70% would
be a parameter, similar to NAT-Threshold). < 0% would disable switchover, this could be the default.

Even more advanced: set up multiple SGW tunnels, use best SGW for new connections and keep using these for
those connections. How to do this needs more thoughts.

Thanks, Teco

Op 8 dec. 2011, om 13:50 heeft Ferry Huberts het volgende geschreven:

> On 12/08/2011 08:51 AM, Henning Rogge wrote:
>> On 12/08/2011 08:44 AM, Ferry Huberts wrote:
>>>> Have to look at this more closely. The idea behind the "default" gateway
>>>> selector is to select a gateway and stick with it until its gone. Maybe
>>>> "gone" is a bit too late, but if we start choosing another gateway too
>>>> early, we might get gateway-flapping again.
>>>> 
>>> 
>>> Agree.
>>> 
>>> However, in our highly mobile networks we have to do something.
>>> This is a short term solution to make it work, and sending out the
>>> patches was also meant to start a discussion on the best solution 
>>> 
>>> The usual solution is to use some form of hysteresis. We might do
>>> something like 'if there is a better gateway for at least x seconds,
>>> then switch to it'.

(Continue reading)

Group

gmane.network.olsr.devel.

Project Web Page

OSLR development (code, porting, etc.)

Search Archive

Page

1 | 2 | 3 | 4 | 5

Articles in period: 47

December 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Test the official Android Adhoc mode! (2 May 2013)
coordinating test infrastructure (28 Apr 2013)
missing arproaming-plugin (27 Apr 2013)
[PATCH] fix function olsrd_write_plparam() in olsrd.init (26 Apr 2013)
OBAMP (25 Apr 2013)
[PATCH] fix olsr.init script function olsrd_write_plparam() as it wron (25 Apr 2013)
[PATCH] fix olsr.init script function olsrd_write_plparam() as it wron (25 Apr 2013)
config files will move after the 0.6.6 release (24 Apr 2013)
[PATCH 1/1] Fix setsockopt for setting Traffic Class in IPv6 (19 Apr 2013)
Handle the two /1 IPv4 prefixes in a different table (9 Apr 2013)
Integration of multicast plugins (1 Apr 2013)
Olsrd 0.6.5.2 is freezing at start (27 Mar 2013)
Olsrd 0.6.5.2 is freezing at start (27 Mar 2013)
Olsrd 0.6.5.2 is freezing at start (27 Mar 2013)
release branches being merged into master? (26 Mar 2013)
backoff timer for routing table calculation (19 Mar 2013)
problem in olsr_tc_update_edge (for hysteresis setting) (19 Mar 2013)
[Commotion-dev] Can't talk between desktop OLSRd and Commotion OpenWRT (14 Mar 2013)
strange log message when received netlink error (28 Feb 2013)
Kernel which supports wireless extensions (28 Feb 2013)
reduce OLSR bandwidth by tuning emission intervals (26 Feb 2013)

Archives

3	May 2013
54	April 2013
62	March 2013
143	February 2013
24	January 2013
65	December 2012
81	November 2012
175	October 2012
22	September 2012
131	August 2012
276	July 2012
440	June 2012
320	May 2012
56	April 2012
30	March 2012
48	February 2012
35	January 2012
47	December 2011
30	November 2011
21	October 2011
28	September 2011
46	August 2011
38	July 2011
97	June 2011
26	May 2011
20	April 2011
46	March 2011
35	February 2011
37	January 2011
55	December 2010
72	November 2010
32	October 2010
35	September 2010
36	August 2010
29	July 2010
113	June 2010
26	May 2010
152	April 2010
131	March 2010
78	February 2010
57	January 2010
17	December 2009
42	November 2009
46	October 2009
81	September 2009
67	August 2009
44	July 2009
36	June 2009
22	May 2009
40	April 2009
107	March 2009
56	February 2009
71	January 2009
139	December 2008
129	November 2008
42	October 2008
67	September 2008
41	August 2008
100	July 2008
176	June 2008
148	May 2008
87	April 2008
52	March 2008
119	February 2008
81	January 2008
102	December 2007
83	November 2007
102	October 2007
84	September 2007
104	August 2007
85	July 2007
15	June 2007
50	May 2007
83	April 2007
34	March 2007
45	February 2007
28	January 2007
29	December 2006
33	November 2006
53	October 2006
4	September 2006
5	August 2006
19	July 2006
26	June 2006
9	May 2006
38	April 2006
42	March 2006
32	February 2006
41	January 2006
33	December 2005
42	November 2005
4	October 2005
2	September 2005
5	August 2005
16	July 2005
18	June 2005
23	May 2005
36	April 2005
27	March 2005
60	February 2005
24	January 2005
58	December 2004
69	November 2004
10	October 2004
5	September 2004

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template