Ferry Huberts | 13 Nov 23:14 2014

Re: [OLSRd 0000047]: memory leak on one remote end of point to point link

Taking the bug onto the dev mailing list...

You are running an olsrd with a git sha that is not in our tree...
We can't reasonably support that since we don't know what you are running.

Having said that, we need to at least see the olsrd config file.
Also, smart gateway is complaining about kmod_ipip so it appears you 
turned it on?

On 13/11/14 23:05, Mantis Bug Tracker wrote:
>
> The following issue has been SUBMITTED.
> ======================================================================
> http://olsr.org/bugs/view.php?id=47
> ======================================================================
> Reported By:                valentt
> Assigned To:
> ======================================================================
> Project:                    OLSRd
> Issue ID:                   47
> Category:                   Core
> Reproducibility:            always
> Severity:                   major
> Priority:                   normal
> Status:                     new
> ======================================================================
> Date Submitted:             2014-11-13 23:05 CET
> Last Modified:              2014-11-13 23:05 CET
> ======================================================================
> Summary:                    memory leak on one remote end of point to point link
(Continue reading)

Conrad Lara | 10 Nov 18:56 2014
Picon
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

It was Waldek with the compile issue for IPV6_V6ONLY 

My setup compiled clean with just the the first patch removing the reference to IPV6_TCLASS (which I
actually did weeks ago)

Explains why I didn't see the IPV6_V6ONLY issue however as 7.09 has 2.4.34 for the kernel base.

As I suggested, I recommend a policy decision on minimum supported versions (kernel, GCC, etc) and
anything outside those specs is "unsupported" vs polluting the code base with lines that no one is
maintaining.  This is why I never brought the issue forward when I hit it as I figured it was probably old
enough not to be a worry.

I've already hit my share of issue in olsrd related to code rot, more lines of code isn't always a good thing.

Sent from my iPhone

> On Nov 10, 2014, at 5:58 AM, Ferry Huberts <mailings <at> hupie.com> wrote:
> 
>  <at> Conrad:
> 
> This means that the only thing you have to do is to upgrade your kernel to at least 2.4.21 and you can use IPV6_V6ONLY
> 
> 
>> On 10/11/14 14:56, Ferry Huberts wrote:
>> 
>> 
>>> On 10/11/14 14:03, Henning Rogge wrote:
>>> The patches look reasonable, they should not be a problem with the
>>> current kernels.
>>> 
(Continue reading)

Henning Rogge | 10 Nov 14:15 2014
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

On Mon, Nov 10, 2014 at 1:56 PM, Waldek SPdwaONG <sp2ong <at> gmail.com> wrote:
> Hi,
>
> One big problem for old devices UBNT like NS2 (not NS Mx models) where we
> use AirMAX OS SDK which have kernel 2.4.x and if we want to use latest olsr
> we have problem with compile (but after apply patch now OK).
> I have try use OpenWRT Attitude Adjustment on NS2 but is is not enough space
> to load olsrd with plugins

I think that depends on the amount of features you built into your router.

> and  it is very slow WEB interface compare to original AirMAX OS.

I am not sure that should be a big concern... how often do you use the
web interface of your router? Compared to the lack of a few years of
updates for your kernel and userspace tools.

> One way with NS2 NS5 etc UBNT is use Backfire 10.03.1
> but WEB interface is slowly to compare AirMAX OS for this reason we can only
> use AirMAX SDK with kernel 2.4 or Backfire OpenWRT.

I don't think I agree with this reasoning... but you should be aware
that support for your software platform of choice is somewhere between
"bad" and "not existing" in the future.

Henning Rogge

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
(Continue reading)

Henning Rogge | 10 Nov 14:03 2014
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

The patches look reasonable, they should not be a problem with the
current kernels.

Ferry, do you see a problem with these changes?

Hennig

On Mon, Nov 10, 2014 at 1:56 PM, Waldek SPdwaONG <sp2ong <at> gmail.com> wrote:
> Hi,
>
> One big problem for old devices UBNT like NS2 (not NS Mx models) where we
> use AirMAX OS SDK which have kernel 2.4.x and if we want to use latest olsr
> we have problem with compile (but after apply patch now OK).
> I have try use OpenWRT Attitude Adjustment on NS2 but is is not enough space
> to load olsrd with plugins and  it is very slow WEB interface compare to
> original AirMAX OS. One way with NS2 NS5 etc UBNT is use Backfire 10.03.1
> but WEB interface is slowly to compare AirMAX OS for this reason we can only
> use AirMAX SDK with kernel 2.4 or Backfire OpenWRT.
> This patch is necessary for unix/iface.c
> and lib/txtinfo/src/olsrd_txtinfo.c, lib/jsoninfo/src/olsrd_jsoninfo.c to
> problem with "IPV6_V6ONLY"
>
> I have apply (it is work but I am not sure that iti is correct place):
>
> #if defined linux
>     if (jsoninfo_ipv6_only && olsr_cnf->ip_version == AF_INET6) {
> #ifdef IPV6_V6ONLY
>       if (setsockopt(ipc_socket, IPPROTO_IPV6, IPV6_V6ONLY, (char *)&yes,
> sizeof(yes)) < 0) {
>         perror("IPV6_V6ONLY failed");
(Continue reading)

Conrad Lara | 10 Nov 12:23 2014
Picon
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

Ultimately I'm a fan of a published   minimum system requirements.

I don't have an opinion on what kernel level is supported, but whatever it is any code coming in should be
required to run on the minimum supported version.

This applies equally to OLSRD and OLSRD2.  Only way to do that is to set a policy (again haven't seen one
published in any readme)

This also equally applies to any code that may be BSD based, MAC based, etc.

After that it's a different subject of do you bother to accept code for older versions. I would generally say
not to as at that point your adding extra code for an unsupported system base and it's that persons
responsibility who's compiling for an unsupported install base to make it work.

Sent from my iPhone

> On Nov 10, 2014, at 2:55 AM, Ferry Huberts <mailings <at> hupie.com> wrote:
> 
> I can say that I have zero interest in supporting 2.4 kernels.
> Personally I don't even care about 2.6 but I can see that there are people out there using it.
> 
> AFAIC any 2.4 maintenance has to be done by someone else.
> And any patches to that purpose must be non-invasive and well documented :-)
> 
> 
> I'm in the process of adding the last big piece to olsrd v1; the missing piece of the multi-smart-gateway functionality.
> After that olsrd will go into maintenance mode.
> 
> New development should (probably) be done on olsrd v2.
> 
(Continue reading)

Conrad Lara | 10 Nov 11:37 2014
Picon
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

Just tested on 0.6.7 and 0.6.7.1 patch supplied allows full compile under a OpenWRT 7.09 with a 2.4x series kernel.

Bigger question is:
Should a system requirement exist that it must be a minimal 2.6 kernel? Sounds like you would be in favor of
such a requirement based on your earlier comment about not usually supporting something as old as 2.4.

Otherwise It would seem to me reports are legitimate to make and code being submitted for new fixes should be
making sure to go back to 2.4 kernel for testing.

In my case I just figured it was old enough of an operating system and wasn't going to trouble the dev here but I
never did see a system requirement list posted anywhere unless I missed it ?

Side note:
A Reason for the 2.4 kernel limit on Nanostations is that Ubiquiti has pulled their SDK, as I understand it
they even withdrew the right to use it any more. They are not updating it so users trying to work with the
official OS are kind of stuck.

They still publish the required GPL code(to my knowledge) but w/o the same version kernel you can't load the
binary blob drivers etc if you want to keep AirOS.

Not an issue for me as I flash all mine to openwrt, but is a tad annoyance for those who enjoyed the AirOS.

Sent from my iPhone

>> On Nov 10, 2014, at 1:11 AM, Henning Rogge <hrogge <at> gmail.com> wrote:
>> 
>> On Sun, Nov 9, 2014 at 9:07 PM,  <sp2ong <at> wp.pl> wrote:
>> Sorry for asking this but I have use (and others ) Nanostation 2 which we
>> can use only old kernel 2.4.x.
> 
(Continue reading)

Conrad Lara | 9 Nov 20:02 2014
Picon
Picon

Re: Problem with compile olsrd on SDK AirmaxOS

I hit the same thing on an OLD OpenWRT (7.09) build.

I believe it's related to a new kernel deceleration that doesn't exist in 2.4 kernel series 

This particular line of code in OLSRD was added to to work with QOS parameter settings according to the
commit message in olsrd database.

In my case since I don't use ipv6 on the network this went out to I just commented the line as a quick fix. I
haven't had time to trace it further 

IPv6 does exist in 2.4 kernel but I couldn't find any IPV6_TCLASS in 2.4.

Sent from my iPhone

> On Nov 9, 2014, at 10:53 AM, Henning Rogge <hrogge <at> gmail.com> wrote:
> 
> Could it be that your build-environment does not support IPv6?
> 
> Henning Rogge
> 
>> On Sun, Nov 9, 2014 at 7:48 PM,  <sp2ong <at> wp.pl> wrote:
>> Hello,
>> 
>> I have try to update olsrd from 0.6.4.1 to other new on SDK AirMAXOS UBNT
>> (mips version with linux kernel v2.4.15) but from olsrd version 0.6.5.2 to
>> latest I have always problem
>> 
>> [CC] src/unix/ifnet.c
>> src/unix/ifnet.c: In function `chk_if_up':
>> src/unix/ifnet.c:793: error: `IPV6_TCLASS' undeclared (first use in this
(Continue reading)

sp2ong | 9 Nov 19:48 2014
Picon

Problem with compile olsrd on SDK AirmaxOS

Hello,

I have try to update olsrd from 0.6.4.1 to other new on SDK AirMAXOS UBNT (mips version with linux kernel v2.4.15) but from olsrd version 0.6.5.2 to latest I have always problem

[CC] src/unix/ifnet.c
src/unix/ifnet.c: In function `chk_if_up':
src/unix/ifnet.c:793: error: `IPV6_TCLASS' undeclared (first use in this function)
src/unix/ifnet.c:793: error: (Each undeclared identifier is reported only once
src/unix/ifnet.c:793: error: for each function it appears in.)
make[3]: *** [src/unix/ifnet.o] error 1

I don't know how to fix this problem to get possibility update olsr on my WIFI Nanostation device

Bets regards
Waldek
--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev
Henning Rogge | 8 Nov 12:33 2014
Picon

Olsrd2 (OONF) Release v.0.6.0

Hello everyone,

after a lot of coding this week I released version 0.6.0 of the new
routing agent... which changed A LOT of things.

I finally managed to unify the code in the three repositories
(oonf_api, olsrd2, dlep_app) and put them together into a new
repository called oonf.git (OLSR.org Network Framework).

Important changes:
* plugins can now have dependencies to other plugins.
* all former subsystems are now plugins, no "you need them all" anymore.
* RFC5444 parser/generator API has been integrated into the oonf_rfc5444 plugin.
* the dynamic build is working, so the three remaining APIs (common,
config, core) can be used as shared libraries.
* two new build targets (make static, make dynamic) allow you only to
build the static-linked or dynamic linked executable.
* Openwrt build should be faster now (it doesn't build the shared
libraries anymore)

(of course the v0.6.0 contains a lot of bugfixes that were done before
the unification work).

The old repositories are still there for reference, but you should
clone the new one... having everything in one repository simplifies a
lot of things.

see http://olsr.org/git/?p=oonf.git;a=summary for details.

There is still some cleanup to be done and some Doxygen comments are
missing, but I will add them over the next week.

Henning Rogge

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev

cholin | 24 Oct 11:33 2014
Picon

Re: [PATCH] dyn gw plugin - add PingCmd parameter

I merged your fixups. See [1] for the whole patch.

Regards
Nico

[1]
https://github.com/cholin/olsrd/commit/d0e46ec52e83ecc2811072e9bf6d553e48163704.patch

Am 07.10.2014 um 10:46 schrieb Ferry Huberts:
> From d04ee8dd44b4a0c8cca80d85c3d76eccc9fba6e7 Mon Sep 17 00:00:00 2001
> From: Ferry Huberts <ferry.huberts <at> pelagic.nl>
> Date: Tue, 7 Oct 2014 10:40:09 +0200
> Subject: [PATCH] fixups
> 
> ---
>  lib/dyn_gw/src/olsrd_dyn_gw.c | 9 +++------
>  lib/dyn_gw/src/olsrd_dyn_gw.h | 4 ++--
>  2 files changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/dyn_gw/src/olsrd_dyn_gw.c b/lib/dyn_gw/src/olsrd_dyn_gw.c
> index e283d71..d5883d9 100644
> --- a/lib/dyn_gw/src/olsrd_dyn_gw.c
> +++ b/lib/dyn_gw/src/olsrd_dyn_gw.c
>  <at>  <at>  -129,7 +129,7  <at>  <at>  static bool check_gw(union olsr_ip_addr *, uint8_t, struct ping_list *);
>  
>  static int ping_is_possible(struct ping_list *);
>  
> -static char ping_cmd[PING_CMD_MAX_LEN] = { DEFAULT_PING_CHECK_INTERVAL };
> +static char ping_cmd[PING_CMD_MAX_LEN] = { DEFAULT_PING_CMD };
>  
>  /* Event function to register with the scheduler */
>  static void olsr_event_doing_hna(void *);
>  <at>  <at>  -214,13 +214,10  <at>  <at>  set_plugin_cmd(const char *value, void *data __attribute__ ((unused)), set_plugi
>    size_t len = strlen(value);
>  
>    if (len < PING_CMD_MAX_LEN) {
> -    memcpy(ping_cmd, value, len);
> -    OLSR_PRINTF(2, "Set ping command to: %s\n", ping_cmd);
> +    strncpy(ping_cmd, value, sizeof(ping_cmd));
>      return 0;
>    }
>  
> -  OLSR_PRINTF(0, "Ping command exceed max length: %d > %zu", PING_CMD_MAX_LEN, len);
> -
>    return 1;
>  }
>  
>  <at>  <at>  -556,7 +553,7  <at>  <at>  ping_is_possible(struct ping_list *the_ping_list)
>  {
>    struct ping_list *list;
>    for (list = the_ping_list; list; list = list->next) {
> -    char ping_command[96];
> +    char ping_command[sizeof(ping_cmd) + INET6_ADDRSTRLEN];
>      snprintf(ping_command, sizeof(ping_command), ping_cmd, list->ping_address);
>      olsr_printf(1, "\nDo ping on (%s) %s ...\n", ping_cmd, list->ping_address);
>      if (system(ping_command) == 0) {
> diff --git a/lib/dyn_gw/src/olsrd_dyn_gw.h b/lib/dyn_gw/src/olsrd_dyn_gw.h
> index bdca978..5174c63 100644
> --- a/lib/dyn_gw/src/olsrd_dyn_gw.h
> +++ b/lib/dyn_gw/src/olsrd_dyn_gw.h
>  <at>  <at>  -54,8 +54,8  <at>  <at> 
>  
>  #define DEFAULT_HNA_CHECK_INTERVAL	1000
>  #define DEFAULT_PING_CHECK_INTERVAL	5
> -#define DEFAULT_PING_CMD                "ping -c 1 -q %s"
> -#define PING_CMD_MAX_LEN                64
> +#define DEFAULT_PING_CMD            "ping -c 1 -q %s"
> +#define PING_CMD_MAX_LEN            64
>  
>  int olsrd_plugin_init(void);
>  
> 

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev
cholin | 23 Oct 09:21 2014
Picon

jsoninfo ipv6only flag

Hey.

I'm trying to use this new ipv6only flag (olsr
0.6.7-git_cebcd32-hash_f8ec804d1566d5a03fca9ae3c290546) for jsoninfo
with openwrt. When I set "option ipv6only 'true'" for jsoninfo in
/etc/config/olsrd6 and only start olsrd6, it seems jsoninfo is also
listening on ipv4.
I can netcat on 127.0.0.1 9090. Generated config for jsoninfo plugin
looks like the following:

LoadPlugin "olsrd_jsoninfo.so.0.0"
{
	PlParam "accept" "::"
	PlParam "ipv6only" "true"
}

Am I misunderstanding this option or what am I doing wrong here?

Regards
Nico

--

-- 
Olsr-dev mailing list
Olsr-dev <at> lists.olsr.org
https://lists.olsr.org/mailman/listinfo/olsr-dev

Gmane