Discussion of Netatalk development and bugs

Frank Lahm | 1 Mar 2010 07:02

Re: test426

2010/2/28 didier <dgautheron <at> magic.fr>:
> Hi,
> Le samedi 27 février 2010 à 10:47 +0100, Frank Lahm a écrit :
>> Hi Didier,
>>
>> test426 fails in FPOpenFork(symlink) because it calls with OPENACC_WR
>> which we deny in ad_open.
>> I'm not patching this myself because I'm not sure why you possibly
>> wanted to achieve here.
>
> Nothing but it's not an error with Mac OSX, move it to failed?

No, I guess afpd (ie ad_open) is right in preventing OPENACC_WR for
symlinks. I've checked another nettrace and indeed, nomatter what you
do, the client itself _never_ call FPOpen for a symlink with
OPENACC_WR.
So in the end the test should have to be modified:
- test that server returns AFPERR_PARAM for FPOpen with OPENACC_WR

Cheers, Frank

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Netatalk-devel mailing list
Netatalk-devel <at> lists.sourceforge.net

(Continue reading)

Frank Lahm | 1 Mar 2010 07:11

Re: [Netatalk-cvs] test-suite/test T2_FPOpenFork.c, 1.12, 1.13

2010/3/1 didier gautheron <didg <at> users.sourceforge.net>:
> Update of /cvsroot/netatalk/test-suite/test
> In directory sfp-cvsdas-3.v30.ch3.sourceforge.com:/tmp/cvs-serv20824
>
> Modified Files:
>        T2_FPOpenFork.c
> Log Message:
> test411: opening read-only a file without adouble resource fork doesn't create one
>
> Index: T2_FPOpenFork.c
> ===================================================================
> RCS file: /cvsroot/netatalk/test-suite/test/T2_FPOpenFork.c,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -C2 -d -r1.12 -r1.13
> *** T2_FPOpenFork.c     9 Feb 2010 08:57:43 -0000       1.12
> --- T2_FPOpenFork.c     28 Feb 2010 23:20:22 -0000      1.13
> ***************
> *** 823,826 ****
> --- 823,884 ----
>
>  /* ------------------------- */
> + STATIC void test411()
> + {
> + char *name = "t411 folder";
> + char *file = "t411 file.txt";
> + u_int16_t bitmap = 0;
> + int fork;
> + u_int16_t vol = VolID;
> + int dir;

(Continue reading)

Frank Lahm | 1 Mar 2010 07:43

Re: [Netatalk-cvs] netatalk/libatalk/util unix.c, 1.5, 1.6

2010/2/28 didier gautheron <didg <at> users.sourceforge.net>:
> Update of /cvsroot/netatalk/netatalk/libatalk/util
> In directory sfp-cvsdas-3.v30.ch3.sourceforge.com:/tmp/cvs-serv5300/libatalk/util
>
> Modified Files:
>        unix.c
> Log Message:
> previous commit 'lchdir: use chdir + getcwd' was only testing for symlink outside the volume's root
directory, hopefully this one is correct
>
> Index: unix.c
> ===================================================================
> RCS file: /cvsroot/netatalk/netatalk/libatalk/util/unix.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -C2 -d -r1.5 -r1.6
> *** unix.c      28 Feb 2010 17:02:49 -0000      1.5
> --- unix.c      28 Feb 2010 22:29:16 -0000      1.6
> ***************
> *** 37,41 ****
>  #include <atalk/afp.h>
>  #include <atalk/logger.h>
> - #include <atalk/volume.h>
>  #include <atalk/vfs.h>
>  #include <atalk/util.h>
> --- 37,40 ----
> ***************
> *** 65,72 ****
>   *  <at> returns 1 if a path element is a symlink, 0 otherwise, -1 on syserror
>   */

(Continue reading)

didier | 1 Mar 2010 16:31

Picon

Re: [Netatalk-cvs] netatalk/libatalk/util unix.c, 1.5, 1.6

Hi,
Le lundi 01 mars 2010 à 07:43 +0100, Frank Lahm a écrit :

> 
> Hm, this version now doesn't really do what's still in the spec for
> the function:
> 
>    " * Only chdirs to dir if it doesn't contain symlinks."
I have to update it.
> 
> That might be ok though, but it burdens the error handling on the
> callers _and_ the callers cwd is, well, changed. Shouldn't lchdir in
> case it detects a symlink try to chdir back? It therefor should
> open(".",O_RDONLY) before chdir to the requested path. And again, in
The pb is that we can chdir in a directory without read access and in
this case open(".",O_RDONLY) fail.

Create a folder rwx-wx--- and as a group member mount the volume, afpd
will chdir in it on client requests.

Switching to a known directory in lchdir is an option but we can't
guarantee that it will be able to switch back and there's the global
variable curdir to update.

Currently there's two users of lchdir, catsearch and movecwd.

On error catsearch doesn't care about the current directory.

I'm not sure that changing cwd to a directory which is not the requested
one in movecwd is a good idea, on the other hand the sentence:

(Continue reading)

didier | 1 Mar 2010 21:35

Picon

Re: [Netatalk-cvs] test-suite/test T2_FPOpenFork.c, 1.12, 1.13

Hi,
Le lundi 01 mars 2010 à 07:11 +0100, Frank Lahm a écrit :
> 2010/3/1 didier gautheron <didg <at> users.sourceforge.net>:
> > Update of /cvsroot/netatalk/test-suite/test
> > In directory sfp-cvsdas-3.v30.ch3.sourceforge.com:/tmp/cvs-serv20824
> >
> > Modified Files:
> >        T2_FPOpenFork.c
> > Log Message:
> > test411: opening read-only a file without adouble resource fork doesn't create one
> >
> > Index: T2_FPOpenFork.c
> > ===================================================================
> > RCS file: /cvsroot/netatalk/test-suite/test/T2_FPOpenFork.c,v
> > retrieving revision 1.12
> > retrieving revision 1.13
> > diff -C2 -d -r1.12 -r1.13
> > *** T2_FPOpenFork.c     9 Feb 2010 08:57:43 -0000       1.12
> > --- T2_FPOpenFork.c     28 Feb 2010 23:20:22 -0000      1.13
> > ***************
> > *** 823,826 ****
> > --- 823,884 ----
> >
> >  /* ------------------------- */
> > + STATIC void test411()
> > + {
> > + char *name = "t411 folder";
> > + char *file = "t411 file.txt";
> > + u_int16_t bitmap = 0;
> > + int fork;

(Continue reading)

Andrew Morgan | 1 Mar 2010 21:40

Re: Mediawiki

On Sun, 28 Feb 2010, Frank Lahm wrote:

> I've activated Mediawiki so we can evaluate it and see if we like it:
> <https://sourceforge.net/apps/mediawiki/netatalk/index.php?title=Main_Page>
>
> I've migrated some pages from the old wiki (eg parts of the FAQ) to
> it. After some struggling with the formatting syntax I now think it'll
> be quite ok.
>
> What do you guys think about it?

I'm always in favor of using standard tools provided by Sourceforge 
instead of tools we have to install and maintain ourselves.

 	Andy

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Frank Lahm | 2 Mar 2010 07:21

Re: Mediawiki

2010/3/1 Andrew Morgan <morgan <at> orst.edu>:
> On Sun, 28 Feb 2010, Frank Lahm wrote:
>
>> I've activated Mediawiki so we can evaluate it and see if we like it:
>>
>> <https://sourceforge.net/apps/mediawiki/netatalk/index.php?title=Main_Page>
>>
>> I've migrated some pages from the old wiki (eg parts of the FAQ) to
>> it. After some struggling with the formatting syntax I now think it'll
>> be quite ok.
>>
>> What do you guys think about it?
>
> I'm always in favor of using standard tools provided by Sourceforge instead
> of tools we have to install and maintain ourselves.

Ok.

Meanwhile I've completed the migration of all stil relevant content
from the old wiki to the new one. I've acticated a htaccess redirect
that redirects the [faq] link from the header navigation at
netatalk.sf.net to the new wiki. This so, until the static pages and a
new manual are online where I'd change [faq] for [wiki] linking
directly then of course. Any objections ?

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.

(Continue reading)

Frank Lahm | 3 Mar 2010 11:38

Re: test426

2010/3/1 Frank Lahm <franklahm <at> googlemail.com>:
> 2010/2/28 didier <dgautheron <at> magic.fr>:
>> Hi,
>> Le samedi 27 février 2010 à 10:47 +0100, Frank Lahm a écrit :
>>> Hi Didier,
>>>
>>> test426 fails in FPOpenFork(symlink) because it calls with OPENACC_WR
>>> which we deny in ad_open.
>>> I'm not patching this myself because I'm not sure why you possibly
>>> wanted to achieve here.
>>
>> Nothing but it's not an error with Mac OSX, move it to failed?
>
> No, I guess afpd (ie ad_open) is right in preventing OPENACC_WR for
> symlinks. I've checked another nettrace and indeed, nomatter what you
> do, the client itself _never_ call FPOpen for a symlink with
> OPENACC_WR.
> So in the end the test should have to be modified:
> - test that server returns AFPERR_PARAM for FPOpen with OPENACC_WR

*ping*

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Netatalk-devel mailing list

(Continue reading)

AndrewL733 | 5 Mar 2010 03:07

Picon

Symlinks and Netatalk 2.1

Hello,

I have been using older versions of Netatalk (i.e., 2.0.3 and 2.0.4) for 
quite some time.  I just compiled 2.1 beta 1 and noticed that Linux file 
and directory symlinks are now conveyed to the Mac client as symlinks, 
versus in the past they just looked like regular files and folders.

My questions are:

1)  is there a run-time netatalk configuration option to get the OLD 
behavior?

2)  If not, can you point me to what code has to be removed from the 
current netatalk source so that host-side symlinks are just conveyed to 
the client as regular files and directories?    Has somebody already 
made a patch to modify the current source back to the old behavior?

Thanks in advance,
Andrew

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

Frank Lahm | 5 Mar 2010 07:09

Re: Symlinks and Netatalk 2.1

2010/3/5 AndrewL733 <AndrewL733 <at> aol.com>:
> Hello,
>
> I have been using older versions of Netatalk (i.e., 2.0.3 and 2.0.4) for
> quite some time.  I just compiled 2.1 beta 1 and noticed that Linux file
> and directory symlinks are now conveyed to the Mac client as symlinks,
> versus in the past they just looked like regular files and folders.

What's the problem with it?

> My questions are:
>
> 1)  is there a run-time netatalk configuration option to get the OLD
> behavior?

No. Also not planned.

> 2)  If not, can you point me to what code has to be removed from the
> current netatalk source so that host-side symlinks are just conveyed to
> the client as regular files and directories?    Has somebody already
> made a patch to modify the current source back to the old behavior?

No. The code is not even finished. There are stll some necessary fixes
in the pipe.

Cheers, Frank

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs

(Continue reading)

Group

gmane.network.netatalk.devel.

Project Web Page

Discussion of Netatalk development and bugs

Search Archive

Page

1 | 2 | 3 | 4 | 5

Articles in period: 45

March 2010

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

HEADS UP: Docbook documentation (14 May 2013)
Restrict network interfaces by name (9 May 2013)
tracker and tracker-miner (12 Apr 2013)
Solaris 11.1 (30 Mar 2013)
Netatalk 3.0.3 is available (26 Mar 2013)
new option --with-init-dir (22 Mar 2013)
3.0.3 release date (22 Mar 2013)
afpstats don't show MacOS 9 (8 Mar 2013)
{afpstats.c:93} (E:AFPDaemon) (4 Mar 2013)
ACL mapping, request for review and feedback (28 Feb 2013)
Development branches (26 Feb 2013)
Spotlight Technology Preview 4 is available (25 Feb 2013)
dbus support (21 Feb 2013)
systemd service file (7 Feb 2013)
[PATCH] 3.0.2: getvolbypath() assumes that the user home directory has (6 Feb 2013)
Netatalk 3.0.2 is available (22 Jan 2013)
Coverity (was: 3.0.2 release planning) (19 Jan 2013)
extmap.conf does not work (16 Jan 2013)
[Patch V2] typo in afp.conf.5.tmpl. Re: [PATCH] typo in afp.conf.5.tmp (11 Jan 2013)
[PATCH] typo in afp.conf.5.tmpl. (11 Jan 2013)
[suggestion] logging level in libatalk/acl/ldap_config.c (11 Jan 2013)

Archives

4	May 2013
6	April 2013
29	March 2013
20	February 2013
28	January 2013
11	December 2012
13	November 2012
22	October 2012
20	September 2012
52	August 2012
7	July 2012
26	June 2012
41	May 2012
19	April 2012
147	March 2012
45	February 2012
39	January 2012
33	December 2011
17	November 2011
9	October 2011
24	September 2011
18	August 2011
48	July 2011
4	June 2011
6	May 2011
7	April 2011
33	March 2011
4	February 2011
59	January 2011
2	December 2010
18	November 2010
9	October 2010
2	September 2010
7	August 2010
12	July 2010
76	June 2010
45	May 2010
107	April 2010
45	March 2010
92	February 2010
162	January 2010
113	December 2009
169	November 2009
67	October 2009
66	September 2009
41	August 2009
70	July 2009
98	June 2009
98	May 2009
81	April 2009
55	March 2009
51	February 2009
57	January 2009
21	December 2008
13	November 2008
3	October 2008
3	September 2008
18	August 2008
4	July 2008
12	June 2008
30	May 2008
30	April 2008
44	March 2008
7	February 2008
1	January 2008
1	December 2007
10	October 2007
9	August 2007
2	June 2007
1	May 2007
2	April 2007
1	February 2007
1	January 2007
4	November 2006
7	October 2006
29	September 2006
14	August 2006
11	July 2006
12	June 2006
4	May 2006
13	March 2006
11	February 2006
6	January 2006
4	November 2005
6	October 2005
18	September 2005
26	August 2005
12	July 2005
15	June 2005
24	May 2005
20	April 2005
7	March 2005
22	February 2005
25	January 2005
9	December 2004
73	November 2004
33	October 2004
45	September 2004
124	August 2004
52	July 2004
63	June 2004
43	May 2004
111	April 2004
53	March 2004
49	February 2004
57	January 2004
22	December 2003
56	November 2003
33	October 2003
78	September 2003
35	August 2003
42	July 2003
45	June 2003
61	May 2003
78	April 2003
88	March 2003
198	February 2003
168	January 2003
153	December 2002
155	November 2002
166	October 2002
178	September 2002
173	August 2002
184	July 2002
120	June 2002
293	May 2002
227	April 2002
340	March 2002
408	February 2002
373	January 2002
436	December 2001
595	November 2001
409	October 2001
197	September 2001
237	August 2001
119	July 2001
231	June 2001
128	May 2001
129	April 2001
200	March 2001
58	February 2001
38	January 2001
36	December 2000
40	November 2000
48	October 2000
68	September 2000
116	August 2000
3	July 2000

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template