headers
daniel | 8 Aug 2008 12:01
Picon

[task #8478] mail subject is too long


URL:
  <http://savannah.nongnu.org/task/?8478>

                 Summary: mail subject is too long
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: eydaimon
            Submitted on: Friday 08/08/2008 at 10:01
                Category: Core
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Should Start On: Friday 08/08/2008 at 00:00
   Should be Finished on: Friday 08/08/2008 at 00:00

    _______________________________________________________

Details:

Adding the sender mail (which isn't even a real email) to the subject is
unnecessary and consumes much of the subject.

Current subject:

[mldonkey <at> whatever.hostname.you.run.mldonkey.on] file received -
Somefilename_or_something.rar

How about shortening it to?:
(Continue reading)

Permalink | Reply | 501 comments |
headers
spiralvoice | 8 Aug 2008 13:42
Picon

[task #8478] mail subject is too long


Follow-up Comment #1, task #8478 (project mldonkey):

IMHO it makes sense to see the hostname MLDonkey is running on in the commit
mail because people may run MLDonkey on several machines. Without that
information its difficult (by reading mail headers) to judge on which machine
the finished file awaits further action.

If such information should be part of the subject or be part of the body is
another question, for me both is ok.

Small note: You could have attached your patch to this task, now they are
seperate tracker entries.

Copied patch from https://savannah.nongnu.org/patch/?6600#comment0

Index: src/daemon/common/commonInteractive.ml
===================================================================
RCS file:
/sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
< Printf.sprintf "[mldonkey <at> %s] file received - %s" (Unix.gethostname ())
(file_best_name file)
---

> Printf.sprintf "mldonkey - %s complete." (file_best_name file)

348c348
(Continue reading)

Permalink | Reply | 502 comments |
headers
daniel | 8 Aug 2008 15:27
Picon

[task #8478] mail subject is too long


Follow-up Comment #2, task #8478 (project mldonkey):

Agreed. And as you suggest, I would find that information more suitable in
the body of the message, and the most common scenario is a single instance, so
no need to put it in every subject.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?8478>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/
Permalink | Reply | 2 comments |
headers
daniel | 8 Aug 2008 16:30
Picon

[task #8478] mail subject is too long


Follow-up Comment #3, task #8478 (project mldonkey):

Here's a patch with the host in the body instead.

FYI, I didn't submit the original patch with the task because I hadn't
actually planned making one ;)

Index: commonInteractive.ml
===================================================================
RCS file:
/sources/mldonkey/mldonkey/src/daemon/common/commonInteractive.ml,v
retrieving revision 1.105
diff -r1.105 commonInteractive.ml
346c346
<         Printf.sprintf "[mldonkey <at> %s] file received - %s" (Unix.gethostname
()) (file_best_name file)
---
>         Printf.sprintf "mldonkey - %s complete." (file_best_name file)
348c348
<         Printf.sprintf "mldonkey <at> %s, file received" (Unix.gethostname ())
---
>         Printf.sprintf "mldonkey - download complete."
368c368
<       Printf.sprintf "rnUser/Group: %s:%srn" (file_owner file).user_name
(user2_print_group (file_group file))
---
>       Printf.sprintf "rnUser/Group: %s:%s" (file_owner file).user_name
(user2_print_group (file_group file))
370c370,374
(Continue reading)

Permalink | Reply | 1 comment |

Gmane