[bug #18584] Wrong file path in notification mail
spiralvoice <INVALID.NOREPLY <at> gnu.org>
2007-01-09 22:42:14 GMT
Update of bug #18584 (project mldonkey):
Status: None => Ready For Test
Follow-up Comment #1:
Current code does this:
- a file is finished 100%
- its moved from the download list to done_files (the list of files to be
committed) and the notification mail is sent. This takes place without
considering user_commit_dir, your observation is correct. Attached patch
changes this, please test.
- at a later time file commit is initiated, manually or automatically does
- the directory where the file should be moved to is computed now, here
user_commit_dir is taken in account. This setting can be changed between the
time the mail is sent and the commit is initiated, so even if sending the
mail with user_commit_dir it can provide wrong information...
Solving this would require to change the time the mail is sent, this would
lead to the fact that users do not get notified of finished downloads when
auto_commit is false, not a good idea IMHO.
Any suggestions? IMHO the above case that user_commit_dir is changed between
sending mail and commit is most unlikely, considering this case is not