Piotr Piastucki | 1 Feb 10:22 2007
Picon

Re: status icons

Hi,

> On 1/31/07, *Josef Kučera* <jokusoftware <at> gmail.com 
> <mailto:jokusoftware <at> gmail.com>> wrote:
> 
>     
>     Hello all,
>     the idea of MICON reminded me something - what about this concept: a
>     plugin will get HICON, it will ask Icolib whether it is managed by
>     it and if yes, call "iconlib_add_ref"... and when no longer needed
>     just call IconLib_ReleaseIcon()... The situation when HICON is not
>     managed by icolib can be handled by copying the HICON and Destroying
>     it when no longer needed - This sounds to me like the cleanest
>     solution, but it includes some overhead...
>      
>     Joe  <at>  Whale

This is similar to what I did in scriver. I am just making a copy of an 
icon and then call DestroyIcon() on the copy instead of the original 
icon. However, this approach will create redundant GDI objects when 
IcoLib is not used.

 > From: borkra

 > I do disagree that this is the best way to deal with destroying icons.
 > Because if plugin decided to change the icon there is a period where
 > old icon is invalid and new icon is not there yet which will create
 > problems and possibly crashes. The other issue when one thread is
 > deleting icon while the other thread trying to draw it. (plugins are
 > not synchronized so there is no say who will do what). This situation
(Continue reading)

Piotr Piastucki | 1 Feb 10:27 2007
Picon

Re: status icons

Hi,

> On 1/31/07, *Josef Kučera* <jokusoftware <at> gmail.com 
> <mailto:jokusoftware <at> gmail.com>> wrote:
> 
>     
>     Hello all,
>     the idea of MICON reminded me something - what about this concept: a
>     plugin will get HICON, it will ask Icolib whether it is managed by
>     it and if yes, call "iconlib_add_ref"... and when no longer needed
>     just call IconLib_ReleaseIcon()... The situation when HICON is not
>     managed by icolib can be handled by copying the HICON and Destroying
>     it when no longer needed - This sounds to me like the cleanest
>     solution, but it includes some overhead...
>      
>     Joe  <at>  Whale

This is similar to what I did in scriver. I am just making a copy of an 
icon and then call DestroyIcon() on the copy instead of the original 
icon. However, this approach will create redundant GDI objects when 
IcoLib is not used.

 > From: borkra

 > I do disagree that this is the best way to deal with destroying icons.
 > Because if plugin decided to change the icon there is a period where
 > old icon is invalid and new icon is not there yet which will create
 > problems and possibly crashes. The other issue when one thread is
 > deleting icon while the other thread trying to draw it. (plugins are
 > not synchronized so there is no say who will do what). This situation
(Continue reading)

borkra | 1 Feb 14:41 2007
Picon

Re: status icons


> It would not cause any troubles if we required a new icon to be set before
the old one may be destroyed which sounds logical IMO. Basically, you create
a new icon, call MODIFY_ICON service and then destroy the old one. No sync
issues should occur between plugins.

And at shutdown it would require plugin remove icon first. No plugin does it
even now.
It seems to me we are putting in place rule which very few people will
follow. So we will get stuck with problems. 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
李 敏榆 | 1 Feb 16:59 2007
Picon

bug report for db3x

in function DatabaseCorruption, we will try to hold mutex csDbAccess, but 
in many situations we already held it, for exmaple in DBWrite. Maybe we 
need another one!

_________________________________________________________________
享用世界上最大的电子邮件系统— MSN Hotmail。  http://www.hotmail.com  

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Miranda-Develop mailing list
Miranda-Develop@...
https://lists.sourceforge.net/lists/listinfo/miranda-develop
Piotr Piastucki | 1 Feb 18:48 2007
Picon

Re: status icons

borkra wrote:
>  
> 
>> It would not cause any troubles if we required a new icon to be set before
> the old one may be destroyed which sounds logical IMO. Basically, you create
> a new icon, call MODIFY_ICON service and then destroy the old one. No sync
> issues should occur between plugins.
> 
> And at shutdown it would require plugin remove icon first. No plugin does it
> even now.
> It seems to me we are putting in place rule which very few people will
> follow. So we will get stuck with problems. 
> 

Boris,

This is exactly the way it works currently. If the plugin does not 
remove the icon at shutdown SRMM may crash! Scriver will not crash, 
because it keeps its own copy of the icon. But this makes the API 
inconsistent among SRMM-like plugins and that is why I raised the issue 
here. The inconsistent API causes minor resource leaks in Scriver. You 
found the leaks and suggested fixing them by removing DuplicateIcon() 
from Scriver. But then again it makes the plugin vulnerable to crashes 
as mentioned above.
I hope this discussion will lead to finding the best solution. So far, 
Joe's proposal seems to be the best idea.

Cheers,
Piotr

(Continue reading)

Robert Rainwater | 1 Feb 21:20 2007

Re: [Miranda-Commits] SF.net SVN: miranda: [4709] trunk/miranda/src/modules/utils/path.c

Hi,

This should be fixed in svn now.

Robert

Martin Afanasjew wrote:
> Hi,
> 
> i just want to mention that the commit below broke the path functions in
> the sense that only the ANSI version was modified, i.e. ANSI and Unicode
> versions now return different things in certain cases.
> 
> Regards,
> Martin (aka SloMo)
> 
> 
>> Revision: 4709

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
borkra | 1 Feb 22:41 2007
Picon

Re: status icons

1. I disagree that it does make vulnerable, because other plugins currently make a copy of the icon and give to Scriver to own. This is the way it is today, but it inconsistent.
 
2. I do agree that Joe's approach is better but it require core API changes as well as other 2 plugins. 

 
On 2/1/07, Piotr Piastucki <the_leech-5tc4TXWwyLM@public.gmane.org> wrote:
borkra wrote:
>
>
>> It would not cause any troubles if we required a new icon to be set before
> the old one may be destroyed which sounds logical IMO. Basically, you create
> a new icon, call MODIFY_ICON service and then destroy the old one. No sync
> issues should occur between plugins.
>
> And at shutdown it would require plugin remove icon first. No plugin does it
> even now.
> It seems to me we are putting in place rule which very few people will
> follow. So we will get stuck with problems.
>

Boris,

This is exactly the way it works currently. If the plugin does not
remove the icon at shutdown SRMM may crash! Scriver will not crash,
because it keeps its own copy of the icon. But this makes the API
inconsistent among SRMM-like plugins and that is why I raised the issue
here. The inconsistent API causes minor resource leaks in Scriver. You
found the leaks and suggested fixing them by removing DuplicateIcon()
from Scriver. But then again it makes the plugin vulnerable to crashes
as mentioned above.
I hope this discussion will lead to finding the best solution. So far,
Joe's proposal seems to be the best idea.

Cheers,
Piotr


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Miranda-Develop mailing list
Miranda-Develop-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/miranda-develop

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Miranda-Develop mailing list
Miranda-Develop@...
https://lists.sourceforge.net/lists/listinfo/miranda-develop
George Hazan | 2 Feb 11:16 2007
X-Face
Picon

Re: bug report for db3x

   Hello, 李!
   Thu, 01 Feb 2007 23:59:53 +0800 you wrote:

李敏> in function DatabaseCorruption, we will try to hold mutex csDbAccess,
李敏> but in many situations we already held it, for exmaple in DBWrite. 
Maybe
李敏> we need another one!

In the same thread you can always enter the same crit sec as many times as 
you want. You should only check that you release it as many times as you 
have entered it.

--

-- 
WMBR, George Hazan (ghazan@...) 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Miranda-Develop mailing list
Miranda-Develop@...
https://lists.sourceforge.net/lists/listinfo/miranda-develop
Enno Rehling | 2 Feb 21:44 2007
Picon

Scriver bugs?

Hi,

I've been lurking for a long time, but decided to check out the current
svn today. Instead of srmm, I got scriver as the default messaging
plugin, and promptly found a small bug in it. Where are those reported,
the bug tracker doesn't seem to have a section for that?

For now, the bug is in msgdialog.c:1139:
  if (dat->splitterPos == -1)
At this point, splitterPos has not been initialized. The bug is only in
scriver and not in srmm, because that has a DBGetContactSettingDword
line taking care of this variable.

If someone tells me where to put it, I'll submit it properly.

Enno.
--

-- 
Nothing great has ever been accomplished without passion.
       (Georg Wilhelm Friedrich Hegel, 1770-1831)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
Nowotny | 2 Feb 22:04 2007
Picon

Re: Scriver bugs?

Scriver has it's own bugtracker:

http://developer.berlios.de/bugs/?group_id=3292

--

-- 
nowotny

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Gmane