Erik Ekman | 28 May 15:24 2015
Picon

[patch #8678] Remove warnings in unit tests

URL:
  <http://savannah.nongnu.org/patch/?8678>

                 Summary: Remove warnings in unit tests
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: yarrick
            Submitted on: Thu 28 May 2015 01:24:12 PM GMT
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

This is a set of patches to fix warnings seen when compiling the unit tests.

With the patches I get no warnings:

$ make clean; make check
Running suite(s): UDP
 TCP
 TCP_OOS
 MEM
(Continue reading)

Erik Ekman | 28 May 13:36 2015
Picon

[patch #8677] Unit test fails to compile after DHCP states renamed

URL:
  <http://savannah.nongnu.org/patch/?8677>

                 Summary: Unit test fails to compile after DHCP states renamed
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: yarrick
            Submitted on: Thu 28 May 2015 11:36:39 AM GMT
                Category: DHCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Fix build of DHCP tests.

    _______________________________________________________

File Attachments:

-------------------------------------------------------
Date: Thu 28 May 2015 11:36:39 AM GMT  Name: dhcp-test.patch  Size: 1kB   By:
yarrick
(Continue reading)

Ivan Delamer | 27 May 18:45 2015

Re: Adding a static route table in LwIP

> Date: Tue, 26 May 2015 17:06:48 -0700
> From: pradip de <pradip.de <at> gmail.com>
> To: lwip-devel <at> nongnu.org
> Subject: Re: [lwip-devel] Adding a static route table in LwIP
> Message-ID:
> 	<CACwO0gvdSN5nk1kOCCgo1qcFOXawJwVDumLd63t4S3A_FNvTog <at> mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
> 
> Hi Ivan,
> 
> Thanks again for the suggestion.
> 
> The LWIP_HOOK_IP6_ROUTE seems like a callback to higher level
> implementation of a routing function. Sure it could be used for a 
> static
> route check as well. However, the purpose of this hook is only to 
> return an
> outgoing netif, correct?
> 
> But what if the static route entry has a gateway that needs to be 
> picked up
> during selection of a next hop. There needs to be logic in 
> nd6_get_next_hop
> code that looks up the static route table to fetch the gateway as the
> neighbor to send to.
> 
> For some reason it seems to me that a static route table is a basic 
> feature
> and could be a separate part(albeit within conditional compilation 
> flags)
(Continue reading)

Ivan Delamer | 25 May 20:25 2015

Re: Adding a static route table in LwIP

Hi,

A hook is the way to go. Check master branch, you can define 
LWIP_HOOK_IP6_ROUTE for this purpose.

This will allow you to choose the proper netif based on your own static 
routing. The stack will then select the correct source address. In your 
netif->output_ip6 function you would then resolve your router MAC 
address, either through ND6 or through the static table (or a mixed 
approach, however you implement it).

Cheers
Ivan

> Date: Fri, 22 May 2015 16:14:27 -0300
> From: Daniel Gutson <daniel.gutson <at> tallertechnologies.com>
> To: lwip-devel <lwip-devel <at> nongnu.org>
> Subject: Re: [lwip-devel] Adding a static route table in LwIP
> Message-ID:
> 	<CAF5HaEUB3jLmyffYW32zxnDtT7M65147sAxzq+qqx-x5q6WJ_g <at> mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
> 
> El 22/5/2015 16:07, "Russ Dill" <russ.dill <at> gmail.com> escribi?:
>> 
>> On Fri, May 22, 2015 at 9:52 AM, Daniel Gutson
>> <daniel.gutson <at> tallertechnologies.com> wrote:
>>> On Thu, May 21, 2015 at 12:59 PM, Ivan Delamer 
>>> <delamer <at> inicotech.com>
> wrote:
>>>> Hi Pradip,
(Continue reading)

Ivan Delamer | 21 May 17:59 2015

Adding a static route table in LwIP

Hi Pradip,

I think a static IPv6 route table is a nice feature to have. I think 
some people have implemented something similar for IPv4. Also someone 
has implemented a NAT.

I would recommend that you implement this in a separate file than nd6, 
instead of using lots of conditional blocks.

neighbour discovery is usually called from netif->output_ip6, what you 
can do is: in your implementation of this function, before calling nd6 
you can check with your static routing table for the next hop.

You might have to hack ip6_route() like you propose if you need to use 
a static router.

But all of this seems really similar to me to the current routing 
system, except we don't have an API for adding static entries. What I 
would do is simply expose some of the nd6 methods (make them non-static) 
and add your routers and next-hop entries. You might have to 
periodically refresh your routers' invalidation timers, but that is 
anyways a good idea.

This is how I do it in a project where I manually enter the router 
address.

Cheers
Ivan

> Date: Wed, 20 May 2015 17:20:08 -0700
(Continue reading)

Dipl. Ing. Bernhard Weber | 21 May 14:06 2015
Picon

[bug #45161] tcp.c / tcp_abandon / pcb->local_port set to zero but needed later for tcp_rst

URL:
  <http://savannah.nongnu.org/bugs/?45161>

                 Summary: tcp.c / tcp_abandon / pcb->local_port set to zero
but needed later for tcp_rst
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: weberbe1
            Submitted on: Thu 21 May 2015 12:06:56 GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: Change Request
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

In routine tcp_abandon in tcp.c pcb block will be freed with
TCP_PCB_REMOVE_ACTIVE. In this routine local_port will be set to zero.
But when it is necessary to call tcp_rst later on, local port will be zero. 

Therfore local_port must be stored locally before calling
TCP_PCB_REMOVE_ACTIVE or TCP_RMV and for tcp_rst the local copy of local_port
must be used.
(Continue reading)

Roberto Barbieri Carrera | 21 May 11:23 2015
Picon

[bug #45159] Is this part of do_writemore() in api_msg.c correct?

URL:
  <http://savannah.nongnu.org/bugs/?45159>

                 Summary: Is this part of do_writemore() in api_msg.c correct?
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: sebulain
            Submitted on: Thu 21 May 2015 09:23:53 AM GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.1

    _______________________________________________________

Details:

Hello

Trying to solve some problems that I'm having with TCP retransmissions (still
not clear enough to report), I run into the following piece of code.

File api_msg.c, function do_writemore(), line 1274:
      if (dontblock && (len < conn->current_msg->msg.w.len)) {

(Continue reading)

pradip de | 21 May 02:20 2015
Picon

Adding a static route table in LwIP

Hi,
As part of my current project, I am working on an LwIP enhancement of adding a static route table and wanted to share in this forum and get feedback. 

The static route table entry would have a prefix, a netif and an optional gateway. 
The APIs would look something like:

1) s8_t ip6_add_route_entry (struct ip6_prefix *ip6_prefix, struct netif *netif, ip6_addr_t *gateway);

2) err_t ip6_remove_route_entry (struct ip6_prefix *ip6_prefix);

3) s8_t ip6_find_route_entry (ip6_addr_t *ip6_dest_addr);

When adding a route entry, if a gateway is passed, then it would be added to the default router list with the neighbor cache netif entry pointing to the netif passed. I believe neighbor discovery performed every second would send router solicitations to fetch the link address for that entry.
A route lookup using ip6_find_route_entry would be invoked from within ip6_route before the check to find a default router. 
Currently, only a netcmp of the entire 64 bit prefix is done for matching prefixes. However, in this enhancement, a prefix match up to a specific prefix byte boundary would be made possible and a longest prefix match performed. 
All of these changes would be encapsulated within a conditional compilation flag.
 
Please let me know if there are any concerns around this feature or any suggestions in this regard.

Thanks,
Pradip
_______________________________________________
lwip-devel mailing list
lwip-devel <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/lwip-devel
Simon Goldschmidt | 19 May 10:48 2015
Picon

[bug #45141] dhcp_coarse_tmr is not reset on stop/release

URL:
  <http://savannah.nongnu.org/bugs/?45141>

                 Summary: dhcp_coarse_tmr is not reset on stop/release
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Di 19 Mai 2015 08:48:01 GMT
                Category: DHCP
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

This has been introduced when fixing bug #38204 (DHCP lease time not handled
correctly) in 03/2015: eventually, the check for "netif->dhcp->lease_used ==
netif->dhcp->t0_timeout" can lead to calling dhcp_release()/dhcp_discover() on
an interface which is not configured for dhcp any more, which implicitly
re-enables dhcp.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45141>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/
Simon Goldschmidt | 19 May 10:43 2015
Picon

[bug #45140] dhcp_release does not check dhcp state

URL:
  <http://savannah.nongnu.org/bugs/?45140>

                 Summary: dhcp_release does not check dhcp state
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Di 19 Mai 2015 08:43:45 GMT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

dhcp_release issues a RELEASE message and resets the netif address even if the
address is not assigned by dhcp

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45140>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/
Jens Nielsen | 18 May 22:05 2015
Picon

[bug #45135] getsockopt SO_SNDTIMEO, SO_RCVTIMEO broken

URL:
  <http://savannah.nongnu.org/bugs/?45135>

                 Summary: getsockopt SO_SNDTIMEO, SO_RCVTIMEO broken
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: deft
            Submitted on: mån 18 maj 2015 20.05.33
                Category: sockets/netconn
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

Tiny but quite significant bug, tv_sec is set to the value that should go into
tv_usec

Just change

((struct timeval *)(optval))->tv_sec = ((loc) % 1000U) * 1000U; }while(0)

into

((struct timeval *)(optval))->tv_usec = ((loc) % 1000U) * 1000U; }while(0)

or apply patch

    _______________________________________________________

File Attachments:

-------------------------------------------------------
Date: mån 18 maj 2015 20.05.33  Name: getsockopt.patch  Size: 674 B   By:
deft

<http://savannah.nongnu.org/bugs/download.php?file_id=34048>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45135>

_______________________________________________
  Meddelandet skickades via/av Savannah
  http://savannah.nongnu.org/

_______________________________________________
lwip-devel mailing list
lwip-devel <at> nongnu.org
https://lists.nongnu.org/mailman/listinfo/lwip-devel

Gmane