headers
Donovan Baarda | 9 Sep 2004 05:20
Picon
Picon
Gravatar

Re: [librsync-commits] librsync configure.ac,1.10,1.11

On Thu, 2004-09-09 at 12:30, Martin Pool wrote:
> Update of /cvsroot/librsync/librsync
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6571
> 
> Modified Files:
> 	configure.ac 
> Log Message:
> We seem to need AM_CONFIG_HEADER for autoconf2.53/automake1.4p6.

Which is why README says to use automake1.7 or higher, which deprecated
AM_CONFIG_HEADER in favor of AC_CONFIG_HEADER.

However, since AM_CONFIG_HEADER still works, I'm happy to leave it this
way for now.

--

-- 
Donovan Baarda <abo <at> minkirri.apana.org.au>
http://minkirri.apana.org.au/~abo/

-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
Permalink | Reply | 1 comment |
headers
Martin Pool | 9 Sep 2004 07:13
Favicon
Gravatar

Re: Re: [librsync-commits] librsync configure.ac,1.10,1.11

On  9 Sep 2004, Donovan Baarda <abo <at> minkirri.apana.org.au> wrote:
> On Thu, 2004-09-09 at 12:30, Martin Pool wrote:
> > Update of /cvsroot/librsync/librsync
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6571
> > 
> > Modified Files:
> > 	configure.ac 
> > Log Message:
> > We seem to need AM_CONFIG_HEADER for autoconf2.53/automake1.4p6.
> 
> Which is why README says to use automake1.7 or higher, which deprecated
> AM_CONFIG_HEADER in favor of AC_CONFIG_HEADER.
> 
> However, since AM_CONFIG_HEADER still works, I'm happy to leave it this
> way for now.

Oh, ok.  I got confused by the Debian automake autodetection.

--

-- 
Martin

-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
Permalink | Reply | 0 comments |
headers
Martin Pool | 10 Sep 2004 03:48
Favicon
Gravatar

"inline"?

Can we count on having 'inline' everywhere?  I wouldn't have thought
so, but it looks like delta.c already does...

--

-- 
Martin 

linux.conf.au 2005   -  http://linux.conf.au/  -  Call For Papers now open!
April 18th to 23rd   -   Canberra, Australia   -        closes on October 5
Permalink | Reply | 1 comment |
headers
Donovan Baarda | 10 Sep 2004 10:12
Picon
Picon
Gravatar

Re: [librsync-commits] librsync emit.c,1.46,1.47

G'day,

nice to see work on librsync again... 

On Fri, Sep 10, 2004 at 01:10:01AM +0000, Martin Pool wrote:
[...]
> Problem: rs_emit_copy_cmd used to use the RS_OP_COPY_N4_N4 format by
> default, but this causes integer truncation when one of the operands
> is over 32 bits.
> 
> Fix: Use the right encoding for any operand sizes.
[...]
> Index: emit.c
> ===================================================================
> RCS file: /cvsroot/librsync/librsync/emit.c,v
[...]
> ***************
> *** 104,119 ****
>       int            cmd;
>       rs_stats_t     *stats = &job->stats;
> !     int where_bytes = rs_int_len(where);
> !     int len_bytes   = rs_int_len(len);
>   
> !     switch (10 * where_bytes + len_bytes) {
> !         case 88 :   cmd = RS_OP_COPY_N8_N8; break;
> !         case 84 :   cmd = RS_OP_COPY_N8_N4; break;
> !         case 48 :   cmd = RS_OP_COPY_N4_N8; break;
> !         default :   cmd = RS_OP_COPY_N4_N4; 
> !                     where_bytes = 4; 
> !                     len_bytes   = 4;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Donovan Baarda | 12 Sep 2004 02:53
Picon
Picon
Gravatar

Re: "inline"?

G'day,

 that would have been me introducing it with the delta refactor.

I'm not sure if we can rely on it to be everywhere... I don't really have
much knowledge of C portability. I typically use macro's for most small
stuff, but avoid them for anything that gets too big or complex. I would
have added "inlines" to functions that I thought could benefit from it, but
didn't want to re-write as macros because it would have complicated things.

If we can't rely on "inline" simply remove them. Perhaps a autoconf check
for it?

----------------------------------------------------------------
Donovan Baarda                http://minkirri.apana.org.au/~abo/
----------------------------------------------------------------

-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
Permalink | Reply | 0 comments |

Gmane