Re: lftp 3.5.2

On Mon, Jul 31, 2006 at 11:58:56PM +0200, Pascal Bleser wrote:
> Caused by a minor typo in src/Makefile.am
> 
> Attached patch solves the issue.

Applied. Thanks!

--

-- 
   Alexander..

[PATCH] --with-modules and --with-socksdante=/usr results in link failure

Socks libraries are missing from liblftp-tasks

./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man
--infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib
--sysconfdir=/etc/lftp --with-modules --disable-nls --without-openssl --with-socksdante=/usr --build=i686-pc-linux-gnu

make
.......

/bin/sh ../libtool --silent --tag=CXX --mode=link 
i686-pc-linux-gnu-gcc  -ggdb3 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions
-fno-rtti -fno-implement-inlines -Winline  -Wl,--as-needed -L/usr/lib -o 
example2  example2.o liblftp-tasks.la -lutil -lcurses -lresolv -ldl -lsupc++
/bin/sh ../libtool --silent --tag=CXX --mode=link 
i686-pc-linux-gnu-gcc  -ggdb3 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions
-fno-rtti -fno-implement-inlines -Winline  -Wl,--as-needed -L/usr/lib -o 
liblftp-jobs.la -rpath /usr/lib  Job.lo CmdExec.lo commands.lo mgetJob.lo 
SysCmdJob.lo rmJob.lo parsecmd.lo mvJob.lo alias.lo CatJob.lo GetJob.lo 
ColumnOutput.lo FileSetOutput.lo mkdirJob.lo pgetJob.lo FileFeeder.lo 
QueueFeeder.lo history.lo FindJob.lo FindJobDu.lo ChmodJob.lo TreatFileJob.lo 
CopyJob.lo echoJob.lo OutputJob.lo FileCopyOutputJob.lo buffer_std.lo  
liblftp-tasks.la -lutil -lcurses -lresolv -ldl -lsupc++
example1.o: In function `main':
/var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2/src/example1.cc:43: undefined 
reference to `Rwrite'
./.libs/liblftp-tasks.so: undefined reference to `Rselect'
./.libs/liblftp-tasks.so: undefined reference to `Rread'
collect2: ld returned 1 exit status
make[1]: *** [example1] Error 1
make[1]: *** Waiting for unfinished jobs....

Re: [PATCH] --with-modules and --with-socksdante=/usr results in link failure

On Wed, Aug 02, 2006 at 02:07:05PM +1000, Daniel Black wrote:
> Socks libraries are missing from liblftp-tasks

Patch applied. Thanks!

--

-- 
   Alexander..

lftp-3.5.2 queue bug

Normally, when you run:

queue mirror -c dir1
queue mirror -c dir2

It puts them all into the same queue.

With lftp-3.5.2, after about 5-10 "queue mirror -c dir" commands, it 
creates a NEW queue and starts downloading with another connection for a 
maximum of 2 downloads, if you run another 5-10 "queue mirror -c dir" 
commands, it will start a THIRD queue and proceed to open a third 
connection to download.

Why is this?

Justin.

Re: lftp-3.5.2 queue bug

On Wed, Aug 02, 2006 at 08:04:59AM -0400, Justin Piszcz wrote:
> Normally, when you run:
> 
> queue mirror -c dir1
> queue mirror -c dir2
> 
> It puts them all into the same queue.
> 
> With lftp-3.5.2, after about 5-10 "queue mirror -c dir" commands, it 
> creates a NEW queue and starts downloading with another connection for a 

Cannot reproduce it yet:

lftp ftp:/> j -v
[0] queue (ftp://ftp)
        ftp://ftp/
        Now executing: [1] mirror -c pub
        Commands queued:
            cd /
         1. mir -c pub
         2. mir -c pub
         3. mir -c pub
...
        64. mir -c pub

--

-- 
   Alexander.

Re: lftp-3.5.2 queue bug

Probably this patch will fix the bug. Please try.

--
   Alexander.

Index: CmdExec.cc
===================================================================
RCS file: /home/lav/cvsroot/lftp/src/CmdExec.cc,v
retrieving revision 1.122
diff -u -p -r1.122 CmdExec.cc
--- CmdExec.cc	24 May 2006 07:30:21 -0000	1.122
+++ CmdExec.cc	2 Aug 2006 13:14:34 -0000
 <at>  <at>  -1311,19 +1311,21  <at>  <at>  void CmdExec::FeedArgV(const ArgV *args,
    xfree(cmd);
 }

-bool CmdExec::SameQueueParameters(CmdExec *scan)
+bool CmdExec::SameQueueParameters(CmdExec *scan,const char *this_url)
 {
-   return !strcmp(this->session->GetConnectURL(FA::NO_PATH),
-	          scan->session->GetConnectURL(FA::NO_PATH))
+   return !strcmp(this_url,scan->session->GetConnectURL(FA::NO_PATH))
       && !xstrcmp(this->slot,scan->slot);
 }

 /* return the CmdExec containing a queue feeder; create if necessary */
 CmdExec  *CmdExec::GetQueue(bool create)
 {
+   const char *this_url=session->GetConnectURL(FA::NO_PATH);

lftp-3.5.2 segfaults with gnutls-1.4.1 + gnutls-1.2.11

As reported by José Valentín Gutiérrez Boquete in 
https://bugs.gentoo.org/show_bug.cgi?id=142405

$ gdb --args lftp -u daniel,black -p 1337 nicoHQ.org.
GNU gdb 6.4
Copyright 2005 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...Using host libthread_db 
library "/lib/libthread_db.so.1".

(gdb) run
Starting program: /usr/bin/lftp -u daniel,black -p 1337 nicoHQ.org.
shell-init: error retrieving current directory: getcwd: cannot access parent 
directories: No such file or directory
lftp daniel <at> nicoHQ.org.:~> ls
`ls' at 0 [Receiving data/TLS]
Program received signal SIGSEGV, Segmentation fault.
0xb7a36976 in gnutls_certificate_free_keys (sc=0x0) at gnutls_cert.c:61
61      gnutls_cert.c: No such file or directory.
        in gnutls_cert.c
Current language:  auto; currently c
(gdb) directory /var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2
Warning: /var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2: Permission denied.
Source directories searched: /var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2:
$cdir:$cwd
(gdb) directory /var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2/src
Warning: /var/tmp/portage/lftp-3.5.2/work/lftp-3.5.2/src: Permission denied.

[PATCH] optional disableing of flags

Bug #1 (fixed by attached patch)
Inspired by José Valentín Gutiérrez Boquete (again) in 
https://bugs.gentoo.org/show_bug.cgi?id=142435 highlighted some difficulty the 
automated setting of {C,CXX,LD}FLAGS. In this case the binary was stripped 
because no LDFLAGS were set.

The attached patch adds a configure option to disables most of the automated 
settings so a user who sets CFLAGS=-g and builds the program using gentoo 
ebuilds, doesn't get the program stripped at the end. Gentoo ebuilds, and 
probably BSD ports, allow the user to set {C,CXX,L}FLAGS and and the ebuild 
control the rest of the compile/installation process. As such 
the --with-debug are not accessable.

The patch is non-intrusive as the existing defaults are maintained.

Patch derived from:
http://www.onlamp.com/pub/a/onlamp/2005/03/31/packaging.html?page=2

Related Bug #2 FYI the --with-debug will not disable the automated stripping 
of modules. (unfixed by attached patch)

(no more emails for today - I'm sure I'm over quota 
Thanks for applying the last patch and for a great product in general.

--

-- 
Daniel Black <dragonheart <at> gentoo.org>
Gentoo Crypto/dev-embedded/Forensics/NetMon

Re: [PATCH] optional disableing of flags

On Thu, Aug 03, 2006 at 12:26:37AM +1000, Daniel Black wrote:
> Bug #1 (fixed by attached patch)
> Inspired by José Valentín Gutiérrez Boquete (again) in
> https://bugs.gentoo.org/show_bug.cgi?id=142435 highlighted some difficulty the
> automated setting of {C,CXX,LD}FLAGS. In this case the binary was stripped
> because no LDFLAGS were set.

Ok, patch applied. Thanks!

> Related Bug #2 FYI the --with-debug will not disable the automated stripping
> of modules. (unfixed by attached patch)

Hmm. But src/Makefile checks LDFLAGS for -s before stripping of modules.
Doesn't it work correctly?

--
   Alexander.

Re: lftp-3.5.2 segfaults with gnutls-1.4.1 + gnutls-1.2.11

On Thu, Aug 03, 2006 at 12:09:55AM +1000, Daniel Black wrote:
> As reported by José Valentín Gutiérrez Boquete in
> https://bugs.gentoo.org/show_bug.cgi?id=142405
>
> #0  0xb7a36976 in gnutls_certificate_free_keys (sc=0x0) at gnutls_cert.c:61
> #1  0xb7a36b60 in gnutls_certificate_free_credentials (sc=0x0) at
> gnutls_cert.c:187
> #2  0xb7ef0e74 in ~lftp_ssl_gnutls (this=0x808ae60) at lftp_ssl.cc:314

Attached patch should fix it.

--
   Alexander.

Index: lftp_ssl.cc
===================================================================
RCS file: /home/lav/cvsroot/lftp/src/lftp_ssl.cc,v
retrieving revision 1.30
diff -u -p -r1.30 lftp_ssl.cc
--- lftp_ssl.cc	6 Jul 2006 13:52:02 -0000	1.30
+++ lftp_ssl.cc	2 Aug 2006 14:23:08 -0000
 <at>  <at>  -311,7 +311,8  <at>  <at>  lftp_ssl_gnutls::~lftp_ssl_gnutls()
    if(handshake_done)
       gnutls_bye(session,GNUTLS_SHUT_RDWR);  // FIXME - E_AGAIN
 #endif
-   gnutls_certificate_free_credentials(cred);
+   if(cred)
+      gnutls_certificate_free_credentials(cred);
    gnutls_deinit(session);