Michał Jazłowiecki | 1 Dec 2006 07:10
Picon

[BUG] Nasty memory leak in Psi for Windows

Hello,

I believe that we have a nasty memory leak somewhere in Psi-0.11 for 
Windows. Psi uses about 30 MiB of private bytes when started, but after 
few hours uses about 100 MiB of private bytes, being able to reach over 
650 MiB (over 1.5 GiB virtual size!) after 3 or 4 days.

I know that many other Psi-0.11/Windows users have the same problem 
running both vanilla Psi-0.11-Darcs builds and Psi-0.11-Daisy builds 
(the difference between those two is in WinAmp support (patch sent to 
Psi-Devel), Windows recognition code and enabled plugin support in 
Psi-0.11-Daisy).

Regards,

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author

Michał Jazłowiecki | 1 Dec 2006 07:13
Picon

Re: [PATCH] Windows recognition

Kevin Smith wrote:
> I committed the rather more simple two-liner fix using Qt's support.
> This patch was certainly more advanced than Qt's support, but over  
> four hundred lines of code (433) seems overkill for a Jabber client  
> to tell which platform it's running on :)

I've reported the incorrect Windows recognition to Trolltech:
http://www.trolltech.com/developer/task-tracker/index_html?id=140732&method=entry

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author

Remko Tronçon | 1 Dec 2006 09:29
Picon
Favicon
Gravatar

Re: [BUG] Nasty memory leak in Psi for Windows

> I believe that we have a nasty memory leak somewhere in Psi-0.11 for
> Windows. Psi uses about 30 MiB of private bytes when started, but after
> few hours uses about 100 MiB of private bytes, being able to reach over
> 650 MiB (over 1.5 GiB virtual size!) after 3 or 4 days.

When did you start having this problem ?

cheers,
Remko
Michał Jazłowiecki | 1 Dec 2006 19:56
Picon

Re: [BUG] Nasty memory leak in Psi for Windows

Remko Tronçon wrote:
>> I believe that we have a nasty memory leak somewhere in Psi-0.11 for
>> Windows. Psi uses about 30 MiB of private bytes when started, but after
>> few hours uses about 100 MiB of private bytes, being able to reach over
>> 650 MiB (over 1.5 GiB virtual size!) after 3 or 4 days.
> 
> When did you start having this problem ?

I've noticed it about 3 weeks ago, when I was dealing with STARTTLS and 
HTTP Connect proxy issues, just few days after aspell support was added 
to Psi. And as one Psi user had reported that (current) Psi does not 
leak memory when he does not use aspell (I don't know whether he had his 
dictionaries removed or the Psi|Options|Advanced|Check spelling option 
turned off), this might lead to an idea that the memory leaks come from 
aspell support code.

Cheers,

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author

bubblboy | 2 Dec 2006 14:54
Picon

comment about grouping of MUC participants list

Hi,

First off; this is my first time using a mailing-list, so I'm sorry if 
I'm doing something stupid here.. Anyway, I wanted to say something 
about the way participants of a MUC are grouped by "moderators", 
"visitors" and "participants". Those grouping-headers remain visible, 
even when there are no visitors, for example. Isn't it an idea to hide 
them once there are no participants with the according affiliation?

Greetings,
bb.
Remko Tronçon | 2 Dec 2006 15:06
Picon
Favicon
Gravatar

Re: comment about grouping of MUC participants list

> First off; this is my first time using a mailing-list, so I'm sorry if
> I'm doing something stupid here.. Anyway, I wanted to say something
> about the way participants of a MUC are grouped by "moderators",
> "visitors" and "participants". Those grouping-headers remain visible,
> even when there are no visitors, for example. Isn't it an idea to hide
> them once there are no participants with the according affiliation?

Sure, that could be done. It's not really an urgent matter (you can
only have a maximum of 2 redundant groups), so we'll leave the
possibility of adding that feature to later versions of Psi, when the
MUC dialog uses the improved general contactlist classes.

cheers,
Remko
Norman Rasmussen | 2 Dec 2006 16:04
Picon
Favicon
Gravatar

Re: comment about grouping of MUC participants list

On 12/2/06, Remko Tronçon <remko@...> wrote:
> > First off; this is my first time using a mailing-list, so I'm sorry if
> > I'm doing something stupid here.. Anyway, I wanted to say something
> > about the way participants of a MUC are grouped by "moderators",
> > "visitors" and "participants". Those grouping-headers remain visible,
> > even when there are no visitors, for example. Isn't it an idea to hide
> > them once there are no participants with the according affiliation?
> Sure, that could be done. It's not really an urgent matter (you can
> only have a maximum of 2 redundant groups), so we'll leave the
> possibility of adding that feature to later versions of Psi, when the
> MUC dialog uses the improved general contactlist classes.

Also if you're an admin/owner, then you could drag-'n-drop people into
the other groups to change their affiliation :-)

Sounds like a button for 'Show Empty Groups' is needed.  'Show Offline
Contacts sort of does that in the roster.  I guess you can't have an
empty group in the roster.

--

-- 
- Norman Rasmussen
 - Email: norman@...
 - Home page: http://norman.rasmussen.co.za/
Michał Jazłowiecki | 2 Dec 2006 16:42
Picon

Re: comment about grouping of MUC participants list

Norman Rasmussen wrote:

> I guess you can't have an
> empty group in the roster.

Correct. Group (name of a group, to be exact) is a (multiple) property 
of a contact, so a group cannot exist on its own (without a contact), 
thus there are no empty groups in roster.

Q.E.D.

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author

Michał Jazłowiecki | 3 Dec 2006 15:03
Picon

[BUG?] Disabled custom shortcuts for send message and close tab

Hi,

Is there any particular reason behind disabling setting custom shortcuts 
for send message in chat dialogs? Ie. only default ones (Enter or 
Return) work, but even though I set different one(s) either in 
options.xml or via Psi|Options|Shortcuts, they are ignored.

I know the direct reason for that situaltion - the shortcuts are 
disabled in src/chatdlg.cpp, line 442 (ChatDlg::setShortcuts() method).

Other manual shortcuts that don't work (for the same direct reason) are 
those for closing tabs (if tabbed chat dialogs are used).
BTW: What happened to close tab button (either on each of the tabs or 
single one for current tab)?

Cheers,

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author

Michał Jazłowiecki | 3 Dec 2006 15:03
Picon

[BUG?] Disabled custom shortcuts for send message and close tab

Hi,

Is there any particular reason behind disabling setting custom shortcuts 
for send message in chat dialogs? Ie. only default ones (Enter or 
Return) work, but even though I set different one(s) either in 
options.xml or via Psi|Options|Shortcuts, they are ignored.

I know the direct reason for that situation - the shortcuts are disabled 
in src/chatdlg.cpp, line 442 (ChatDlg::setShortcuts() method).

Other manual shortcuts that don't work (for the same direct reason) are 
those for closing tabs (if tabbed chat dialogs are used).
BTW: What happened to close tab button (either on each of the tabs or 
single one for current tab)?

Cheers,

--

-- 
Michał Jazłowiecki (michalj)
Psi Forum & Wiki Moderator :: Psi-Daisy Author


Gmane