Julien ÉLIE | 14 Apr 2013 22:41
Favicon

Adding new gcc warnings

Hi all,

As gcc 4.4.x is currently used for the daily generation of snapshots,
maybe we could add new warnings for "make warnings" builds.

I suggest the following flags:
-Wformat-y2k
-Winit-self
-Wold-style-definition
-Wmissing-declarations
-Wnormalized=nfc
-Wpacked
-Winline
-Wsync-nand
-Wvla

Should -Wswitch-default be added?  It implies that all switch statements
are required to have a default case, even though all possible cases
are correctly handled.

Should -Wfloat-equal be added?  Errors like these ones appear, and
I wonder whether a fix is needed.
In innd/status.c, size is a float:
  if (!size) size = 1; /* avoid divide by zero here too */

In innfeed/host.c:
  if (h->params->dynBacklogFilter != oldBacklogFilter)

-Wunreachable-code, -Wstrict-overflow=2, -Wtraditional-conversion and
-Wlogical-op give false positives, so I believe adding them is not wise.
(Continue reading)

Florian Schlichting | 10 Apr 2013 12:14
Picon
Picon

double 'ctlinnd flushlogs' deletes news, errlog

Hi Julien,

I just noticed a critical flaw in your recent commit to flush process /
exploder channels. You introduced a second call to 'ctlinnd flushlogs'
in scanlogs. Unfortunately, when 'ctlinnd flushlogs' is called, innd
doesn't just flush its logs, it also rotates (moves) its log and errlog
to news.old and errlog.old, overwriting what's already there. So the
second call effectively destroys both logs. This happens in
innd/innd.c:ReopenLog().

From ctlinnd(8):

   flushlogs
       Close the news and error log files and rename them to add ".old" to
       the file name, then open fresh news and error logs.  

Perhaps innd should stop do the .old rotation and restrict itself to
flushing, and scanlogs should mv to .old rather than cp, and not just
"in case innd is down", and the then the first invocation of 'ctlinnd
flushlogs' can be deleted?

Florian

Attachment (smime.p7s): application/x-pkcs7-signature, 5565 bytes
Hi Julien,

I just noticed a critical flaw in your recent commit to flush process /
exploder channels. You introduced a second call to 'ctlinnd flushlogs'
(Continue reading)

Karl Oman | 28 Mar 2013 15:01
Picon

incompréhension totale,

je ne comprends toujours pas comment INN server peut poser autant de problèmes d'installation, de paramétrage  

et de gestion ?!

sous Ubuntu et processeur 64 bits, il est inutile de vouloir installer l'INN2 proposé dans la logithèque.

pour moi INN devrait être encore plus facile à installer qu'Emacs !!! 

alors les programmeurs d'ISC, on se remue les méninges..

fff.

 
<div>
<p>je ne comprends toujours pas comment INN server peut poser autant de probl&egrave;mes d'installation, de param&eacute;trage &nbsp;</p>
<div>et de gestion ?!<div><br></div>
<div>sous Ubuntu et processeur 64 bits, il est inutile de vouloir installer l'INN2 propos&eacute; dans la logith&egrave;que.</div>
<div><br></div>
<div>pour moi INN devrait &ecirc;tre encore plus facile &agrave; installer qu'Emacs !!!&nbsp;</div>
<div><br></div>
<div>alors les programmeurs d'ISC, on se remue les m&eacute;ninges..</div>
<div><br></div>
<div>fff.<br><div><br></div>
<div>&nbsp;</div>
</div>
</div>
</div>
The Doctor | 28 Mar 2013 11:42
Picon
Picon
Favicon

innfeed issue

You might want to look again at can.canet.stats to see
if the problem is solved.
--

-- 
Member - Liberal International	This is doctor <at> nl2k.ab.ca Ici doctor <at> nl2k.ab.ca
God,Queen and country!Never Satan President Republic!Beware AntiChrist rising! 
http://www.fullyfollow.me/rootnl2k  Look at Psalms 14 amnd 53 on Atheism
I am a New World Order Enemy - I am an enemy of totalitarians and dictators.
Jesse Rehmer | 27 Mar 2013 23:14

Using patterns in incoming.conf for exclusion?

I was wondering if anyone was using the "patterns" directive in incoming.conf to limit newsgroups accepted by remote peers?  I've got a need to exclude *.sex.* and *.sex newsgroups.  While I'm working with my peers to exclude these on their end I found that the patterns directive in incoming.conf should be able to do this as well. 

I've got the following configured in incoming.conf:

peer neva.ru {
        hostname:            newsfeed.neva.ru
        patterns: "*,!*.sex.*,!*.sex"
}

However, I'm still seeing articles coming in from that peer that match the exclude pattern.  Can you not use exclusions with the patterns key in incoming.conf?


$ grephistory '51536dbd$0$9626$6c495a8a <at> news.tweak-news.eu'| sm -H
X-Received: by 10.180.98.103 with SMTP id eh7mr2425428wib.3.1364422078652;
        Wed, 27 Mar 2013 15:07:58 -0700 (PDT)
MIME-Version: 1.0
Path: usenet.blueworldhosting.com!goblin1!goblin.stu.neva.ru!yt3no10497887wib.0!news-out.google.com!p18ni21607wiv.0!nntp.google.com!feeder1.cambriumusenet.nl!feed.tweaknews.nl!82.197.221.133.MISMATCH!posting.tweaknews.nl!not-for-mail
From: gellebn <at> hotmail.com
Newsgroups: alt.sex.fetish.feet


Cheers,
Jesse
<div>
<div><span>I 
was wondering if anyone was using the "patterns" directive in 
incoming.conf to limit newsgroups accepted by remote peers?&nbsp; I've got a 
need to exclude *.sex.* and *.sex newsgroups.&nbsp; While I'm working with my
 peers to exclude these on their end I found that the patterns directive
 in incoming.conf should be able to do this as well.&nbsp; <br><br>I've got 
the following configured in incoming.conf:<br><br>peer neva.ru {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 hostname:&nbsp;&nbsp;&nbsp; &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; newsfeed.neva.ru<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; patterns: 
"*,!*.sex.*,!*.sex"<br>}<br><br>However, I'm still seeing articles 
coming in from that peer that match the exclude pattern.&nbsp; Can you not 
use exclusions with the patterns key in incoming.conf?<br><br><br>$ 
grephistory '<a class="moz-txt-link-abbreviated" href="mailto:51536dbd%240%249626%246c495a8a <at> news.tweak-news.eu">51536dbd$0$9626$6c495a8a <at> news.tweak-news.eu</a>'| sm -H<br>X-Received:
 by 10.180.98.103 with SMTP id eh7mr2425428wib.3.1364422078652;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 Wed, 27 Mar 2013 15:07:58 -0700 (PDT)<br>MIME-Version: 1.0<br>Path: 
usenet.blueworldhosting.com!goblin1!goblin.stu.neva.ru!yt3no10497887wib.0!news-out.google.com!p18ni21607wiv.0!nntp.google.com!feeder1.cambriumusenet.nl!feed.tweaknews.nl!82.197.221.133.MISMATCH!posting.tweaknews.nl!not-for-mail<br>From:
 <a class="moz-txt-link-abbreviated" href="mailto:gellebn <at> hotmail.com">gellebn <at> hotmail.com</a><br>Newsgroups: alt.sex.fetish.feet<br><br><br>Cheers,<br>Jesse<br></span></div>
</div>
Florian Schlichting | 22 Mar 2013 15:57
Picon
Picon

Re: INN commit: branches/2.5 (3 files)

Hi Julien,

On Mon, Mar 18, 2013 at 11:48:18AM -0700, INN Commit wrote:
>     Date: Monday, March 18, 2013  <at>  11:48:18
>   Author: iulius
> Revision: 9464

this commit introduced a POD error:

> --- doc/pod/news.pod	2013-03-18 18:47:27 UTC (rev 9463)
> +++ doc/pod/news.pod	2013-03-18 18:48:18 UTC (rev 9464)
>  <at>  <at>  -1,3 +1,15  <at>  <at> 
> +=head1 Changes in 2.5.4
> +
> +=item *
> +
> +When using funnel feeds, B<innfeed> log files were open forever, which
> +resulted in empty log files, once rotated by B<scanlogs>.  Exploder and
...

It lacks an =over 2 between the =head1 and =item, which leads to an
ugly warning at the bottom of the NEWS file. This should fix it:

--- a/doc/pod/news.pod
+++ b/doc/pod/news.pod
 <at>  <at>  -1,5 +1,7  <at>  <at> 
 =head1 Changes in 2.5.4

+=over 2
+
 =item *

 When using funnel feeds, B<innfeed> log files were open forever, which

Florian
Attachment (smime.p7s): application/x-pkcs7-signature, 5565 bytes
Hi Julien,

On Mon, Mar 18, 2013 at 11:48:18AM -0700, INN Commit wrote:
>     Date: Monday, March 18, 2013  <at>  11:48:18
>   Author: iulius
> Revision: 9464

this commit introduced a POD error:

> --- doc/pod/news.pod	2013-03-18 18:47:27 UTC (rev 9463)
> +++ doc/pod/news.pod	2013-03-18 18:48:18 UTC (rev 9464)
>  <at>  <at>  -1,3 +1,15  <at>  <at> 
> +=head1 Changes in 2.5.4
> +
> +=item *
> +
> +When using funnel feeds, B<innfeed> log files were open forever, which
> +resulted in empty log files, once rotated by B<scanlogs>.  Exploder and
...

It lacks an =over 2 between the =head1 and =item, which leads to an
ugly warning at the bottom of the NEWS file. This should fix it:

--- a/doc/pod/news.pod
+++ b/doc/pod/news.pod
 <at>  <at>  -1,5 +1,7  <at>  <at> 
 =head1 Changes in 2.5.4

+=over 2
+
 =item *

 When using funnel feeds, B<innfeed> log files were open forever, which

Florian
Julien ÉLIE | 18 Mar 2013 20:12
Favicon

Fwd: Multiple innfeed processes

Hi Jesse,

I do not see why innfeed does not properly shut down.  It definitively should stop when innd closes its pipe to
innfeed upon reloading.
Maybe people in the inn-workers mailing-list will have ideas for that.

-- 
Julien

-------- Message original --------
Sujet: 	Multiple innfeed processes
Date : 	Fri, 08 Mar 2013 12:10:43 -0600
De : 	Jesse Rehmer
Pour : 	Julien ÉLIE

Julien,

I sorted out all of the weird CNFS issues I was having previously.  Turned out to be an issue on the SAN which
caused a lot of strange server level issues on the reader machine.  I do have an issue on my feeder machine
that I'm having trouble diagnosing/resolving.  I'm seeing multiple innfeed processes running after INN
has been up for more than a day or so.  Seems to happen when I'm reloading configurations such as newsfeeds or
incoming.conf.  The new innfeed process starts fine but the old one never seems to die on its own.  It also
doesn't stop using standard signals via kill.  I have to kill -9 the process in order for it to quit running.

Here is what it ends up looking like at the process level (if I leave this alone for a few days there will be 4 or 5
innfeed processes running):

news       561  1.4  0.8 172104 34912 ?        Ss   00:58   9:39 /usr/local/news/bin/innd
news      7403  0.3  0.0  12504  3004 ?        S    08:13   0:54  \_ /usr/local/news/bin/innfeed
news     10971  0.1  0.2 148316 11984 ?        S    12:02   0:00  \_ controlchan
news     10972  0.4  0.0  11432  1804 ?        S    12:02   0:00  \_ /usr/local/news/bin/innfeed
news     10973  0.0  0.0   4580  1052 ?        S    12:02   0:00  \_ /usr/local/news/bin/ninpaths -p -d /usr/local/news/log/path/inpaths.%d

When I do a strace on the old innfeed process I see the following:

[news <at> usenet ~]$ strace -p 7403
Process 7403 attached - interrupt to quit
select(17, [16], [], [], {7, 37802})    = 0 (Timeout)
select(17, [16], [], [], {30, 0})       = 0 (Timeout)
select(17, [16], [], [], {29, 0})       = 1 (in [16], left {21, 446303})
readv(16, [{"503 time out\r\njfrl2le8023d97mmcu"..., 256}], 1) = 14
sendto(3, "<61>Mar  8 12:07:34 innfeed[7403"..., 143, MSG_NOSIGNAL, NULL, 0) = 143
sendto(3, "<61>Mar  8 12:07:34 innfeed[7403"..., 138, MSG_NOSIGNAL, NULL, 0) = 138
close(16)                               = 0
select(0, [], [], [], {21, 0}

When this first started I thought it was happening due to certain configuration parameters that I had
tweaked, but I have since reverted those back to defaults with no effect.  I tried hunting around to see if
anyone had run into this before but came up empty.  Have you ever seen this behavior?

Regards,
Jesse Rehmer

The Doctor | 13 Mar 2013 13:46
Picon
Picon
Favicon

Log Rotation

Can the innfeed also be included?  That one can grow 
very hugely.

--

-- 
Member - Liberal International	This is doctor <at> nl2k.ab.ca Ici doctor <at> nl2k.ab.ca
God,Queen and country!Never Satan President Republic!Beware AntiChrist rising! 
http://www.fullyfollow.me/rootnl2k  Look at Psalms 14 amnd 53 on Atheism
I am a New World Order Enemy - I am an enemy of totalitarians and dictators.
Julien ÉLIE | 25 Feb 2013 22:23
Favicon

Re: cnfsstat issue?

Hi Jesse,

> I'm seeing an issue with cnfsstat that I do not understand.  Perhaps
> there is something I'm missing, but when running cnfsstat with and
> without the -a flag I see different results for the newest article.

That's pretty strange.  I do not see why the result would be different.
At least, I have just tested again on my news server and do not see any 
difference.

> For instance without the -a flag, notice the Newest date:
>
> [news <at> nnrp ~]$ cnfsstat
> Class bins for groups matching "alt.bin*"
>   Buffer bin01, size:  4.00 GBytes, position:  3.27 GBytes  1.82 cycles
> Newest: 2013-02-25  9:50:50,    0 days,  5:08:16 ago
>
> With the -a flag:
>
> [news <at> nnrp ~]$ cnfsstat -a
> Class bins for groups matching "alt.bin*"
>   Buffer bin01, size:  4.00 GBytes, position: 3.27 GBytes  1.82 cycles
>    Newest: 2013-02-25 14:48:39,    0 days, 0:11:05 ago
>    Oldest: 2013-02-25  9:19:25,    0 days,  5:40:19 ago

What is the version of INN you are running?
Yet I do not see recent changes that would have modified this behaviour. 
  :-/

--

-- 
Julien ÉLIE

« – Chef ! On vient !
   – On se met en carré ?
   – Non ! En bosquet ! » (Astérix)
Julien ÉLIE | 24 Feb 2013 22:33
Favicon

Re: Fwd: [bugzilla <at> redhat.com: [Bug 913539] inn : Conflicts with libxradius]

Hi Jochen,

> as a co-maintainer of the inn package in Fedora, I have got the following
> message from out bug reporting system.
> 
> => mod_auth_xradius-0.4.6-17.fc19.src.rpm
> => libxradius-0.4.6-17.fc19.i686 in fedora-development-i386
>    File conflict with: inn-2.5.3-8.fc19.i686
>       /usr/share/man/man5/radius.conf.5.gz
>
> It's seems, that it's not a good idea to use 'radius' or
> 'radius.conf' as a file names, because there is another package
> which will use this file names.
> 
> So I would to like for a hint how we can fix this issue.

According to
    https://fedoraproject.org/wiki/Packaging:Conflicts#Man_Page_Name_Conflicts
two usual solutions are suggested:
 * Rename the man pages to slightly alter the suffix of the man page (e.g man1/check.1.gz and man1/check.1foo.gz)
 * Rename the man pages to include a prefix of the providing package (e.g. foo-check.1.gz and bar-check.1.gz)

Couldn't it be possible to rename the radius.conf(5) man page shipped with INN
to inn-radius.conf.5.gz?
Same thing for inn-radius.8.gz?

Perhaps other man pages can also cause problems like history(5), inews(1), ident(8), domain(8),
expire(8)... ?

--

-- 
Julien ÉLIE

« Tout est dans tout, et réciproquement. » (Pierre Dac)
Richard Kettlewell | 23 Feb 2013 15:36
Picon

Patches: improve innconf.h, remove obsolete docs

Attached are a couple of suggested patches to INN to improve the 
experience of external programs that use /usr/include/inn and 
/usr/lib/libinn.a.

HAVE_SSL.diff makes the layout of the innconf structure independent of 
INN's build options.  External programs have no idea how INN was built 
and it's (at best) tedious for them to have to work it out.

HeaderFind.diff removes some long-obsolete documentation.

ttfn/rjk
Attachment (HAVE_SSL.diff): text/x-patch, 1110 bytes
Attachment (HeaderFind.diff): text/x-patch, 1270 bytes
Attached are a couple of suggested patches to INN to improve the 
experience of external programs that use /usr/include/inn and 
/usr/lib/libinn.a.

HAVE_SSL.diff makes the layout of the innconf structure independent of 
INN's build options.  External programs have no idea how INN was built 
and it's (at best) tedious for them to have to work it out.

HeaderFind.diff removes some long-obsolete documentation.

ttfn/rjk

Gmane