Re: [freenet-cvs] r20868 - in trunk/freenet/src/freenet: client/async support/io

* bombe@...
<bombe@...> [2008-06-29 17:03:08]:

> Author: bombe
> Date: 2008-06-29 17:03:08 +0000 (Sun, 29 Jun 2008)
> New Revision: 20868
> 
> Modified:
>    trunk/freenet/src/freenet/client/async/SingleFileInserter.java
>    trunk/freenet/src/freenet/support/io/BucketChainBucket.java
>    trunk/freenet/src/freenet/support/io/BucketChainBucketFactory.java
>    trunk/freenet/src/freenet/support/io/BucketTools.java
> Log:
> fix backport of BucketChainBucket
> 

As far as I can see you have restored the old behaviour bypassing the
non-working code... but that's hardly a fix :)

> Modified: trunk/freenet/src/freenet/client/async/SingleFileInserter.java
> ===================================================================
> --- trunk/freenet/src/freenet/client/async/SingleFileInserter.java	2008-06-29 16:23:27 UTC
(rev 20867)
> +++ trunk/freenet/src/freenet/client/async/SingleFileInserter.java	2008-06-29 17:03:08 UTC
(rev 20868)
>  <at>  <at>  -14,7 +14,6  <at>  <at> 
>  import freenet.keys.BaseClientKey;
>  import freenet.keys.CHKBlock;
>  import freenet.keys.FreenetURI;
> - import freenet.keys.NodeCHK;

Re: Bug submission

* Ian Clarke <ian.clarke@...> [2008-06-22 10:33:09]:

> I was surprised to read this on https://bugs.freenetproject.org/ :-
> 
> "The first step in filing a bug report is a post to the support
> mailing list. You must subscribe to post. If you get told it's a bug,
> then come back here and file a bug report. When filing, please include
> a URL into the mailing list archives so we can easily locate the
> original conversations.  This process greatly helps us to help you.
> Many "bugs" are actually configuration or comprehension issues that
> can be easily and more quickly resolved through the users mailing
> list."
> 
> I don't agree with this, and its creating a significant hurdle for
> people filing bugs.  Its basically using a mailing list as a
> first-line bug tracker, something mailing lists aren't optomised for.
> We should be using the bugtracker as our bugtracker.
> 
> If people are repeatedly running into the same "configuration or
> comprehension" issue, then that means there is a usability bug, and it
> should absolutely be filed as a bug in Mantis.
> 
> If people submit an invalid bug then its as easy as anything to mark
> it as invalid in the bugtracker.  Requiring that they post to support
> first isn't making life easier for anyone, and it is probably
> discouraging quite a few entirely legitimate bug reports.
> 
> Ian.

I wish we could rely on users to use mantis properly... but experience has

Re: [freenet-cvs] r20868 - in trunk/freenet/src/freenet: client/async support/io

On Tuesday 01 July 2008 07:41, NextGen$ wrote:
> * bombe@...
<bombe@...> [2008-06-29 17:03:08]:
> 
> > Author: bombe
> > Date: 2008-06-29 17:03:08 +0000 (Sun, 29 Jun 2008)
> > New Revision: 20868
> > 
> > Modified:
> >    trunk/freenet/src/freenet/client/async/SingleFileInserter.java
> >    trunk/freenet/src/freenet/support/io/BucketChainBucket.java
> >    trunk/freenet/src/freenet/support/io/BucketChainBucketFactory.java
> >    trunk/freenet/src/freenet/support/io/BucketTools.java
> > Log:
> > fix backport of BucketChainBucket
> > 
> 
> As far as I can see you have restored the old behaviour bypassing the
> non-working code... but that's hardly a fix :)
> 
> > Modified: trunk/freenet/src/freenet/client/async/SingleFileInserter.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/client/async/SingleFileInserter.java	
2008-06-29 16:23:27 UTC (rev 20867)
> > +++ trunk/freenet/src/freenet/client/async/SingleFileInserter.java	
2008-06-29 17:03:08 UTC (rev 20868)
> >  <at>  <at>  -14,7 +14,6  <at>  <at> 
> >  import freenet.keys.BaseClientKey;
> >  import freenet.keys.CHKBlock;
> >  import freenet.keys.FreenetURI;

Re: [freenet-cvs] r20750 - branches/db4o/freenet/src/freenet/client/async

On Sunday 29 June 2008 15:10, Daniel Cheng wrote:
> On Thu, Jun 26, 2008 at 11:43 PM,  <toad@...> wrote:
> > Author: toad
> > Date: 2008-06-26 15:43:14 +0000 (Thu, 26 Jun 2008)
> > New Revision: 20750
> >
> > Modified:
> >   
branches/db4o/freenet/src/freenet/client/async/SplitFileInserterSegment.java
> > Log:
> > Don't activate and deactivate parent here
> >
> 
> activate() is very cheap on already activated object..

Yes but deactivating the parent and then returning to them would cause 
problems.
> 
> 
> > Modified: 
branches/db4o/freenet/src/freenet/client/async/SplitFileInserterSegment.java
> > ===================================================================
> > --- 
branches/db4o/freenet/src/freenet/client/async/SplitFileInserterSegment.java        
2008-06-26 15:33:10 UTC (rev 20749)
> > +++ 
branches/db4o/freenet/src/freenet/client/async/SplitFileInserterSegment.java        
2008-06-26 15:43:14 UTC (rev 20750)
> >  <at>  <at>  -401,8 +401,8  <at>  <at> 
> >        }

Re: [freenet-cvs] r20796 - branches/db4o/freenet/src/freenet/keys

On Sunday 29 June 2008 15:02, Daniel Cheng wrote:
> On Fri, Jun 27, 2008 at 6:54 AM,  <toad@...> wrote:
> > Author: toad
> > Date: 2008-06-26 22:54:01 +0000 (Thu, 26 Jun 2008)
> > New Revision: 20796
> >
> > Modified:
> >   branches/db4o/freenet/src/freenet/keys/FreenetURI.java
> > Log:
> > Hopefully prevent NPE in logging
> >
> 
> > Modified: branches/db4o/freenet/src/freenet/keys/FreenetURI.java
> > ===================================================================
> > --- branches/db4o/freenet/src/freenet/keys/FreenetURI.java      2008-06-26 
22:48:25 UTC (rev 20795)
> > +++ branches/db4o/freenet/src/freenet/keys/FreenetURI.java      2008-06-26 
22:54:01 UTC (rev 20796)
> >  <at>  <at>  -540,6 +540,10  <at>  <at> 
> >        }
> >
> >        public String toString(boolean prefix, boolean pureAscii) {
> > +               if(keyType == null) {
> > +                       // Not activated or something...
> 
> Log a minor/debug message  here?

Probably a good idea. Done.
> 
> > +                       return null;

Re: [freenet-cvs] r20845 - branches/db4o/freenet/src/freenet/support/io

On Sunday 29 June 2008 14:52, Daniel Cheng wrote:
> On Sat, Jun 28, 2008 at 10:49 PM,  <toad@...> wrote:
> > Author: toad
> > Date: 2008-06-28 14:49:23 +0000 (Sat, 28 Jun 2008)
> > New Revision: 20845
> >
> > Modified:
> >   
branches/db4o/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
> > Log:
> > Don't store the RNG here. Just store a seed created on startup.
> >
> 
> If we restarted the node twice... The PRNG will be seeded with the
> same seed in the two times...  -- Is this behavior expected?

The PRNG is only instantiated when we need it for padding... what's the 
problem?
> 
> IMO, make Node a static field would make the code much simpler in most
> code -- we can refer to the node object when we need a prng, database,
> etc.... For "many node in a jvm", we can use some ClassLoader
> hacks....

Yay God Object. :)

When we have many node in a jvm, we want to be able to deal with them 
easily... e.g. in the simulation code. Not to have to go through 10 layers of 
indirection because of the hacks we're using.

Re: [freenet-cvs] r20865 - branches/db4o/freenet/src/freenet/node/fcp

On Sunday 29 June 2008 14:37, Daniel Cheng wrote:
> On Sun, Jun 29, 2008 at 5:33 AM,  <toad@...> wrote:
> > Author: toad
> > Date: 2008-06-28 21:33:39 +0000 (Sat, 28 Jun 2008)
> > New Revision: 20865
> >
> > Modified:
> >   branches/db4o/freenet/src/freenet/node/fcp/FCPServer.java
> > Log:
> > Fix renaming
> >
> 
> Should we use FileUtil#renameTo() ?

No, that's mostly useful for renaming-over-a-file or renaming between 
directories.

_______________________________________________
Devl mailing list
Devl@...
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: l10n update jun13-08

On Friday 13 June 2008 14:24, Luke771 wrote:
> Updated to 1152 r20268
> - Translated new strings about Java 1.4 => 1.5
> - a couple of typos and minor rewordings.
> 
Has this been applied to trunk?

_______________________________________________
Devl mailing list
Devl@...
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

Re: l10n update jun13-08

* Matthew Toseland <toad@...> [2008-07-01 13:40:39]:

> On Friday 13 June 2008 14:24, Luke771 wrote:
> > Updated to 1152 r20268
> > - Translated new strings about Java 1.4 => 1.5
> > - a couple of typos and minor rewordings.
> > 
> Has this been applied to trunk?

No.

Re: [freenet-cvs] r20845 - branches/db4o/freenet/src/freenet/support/io

On Tue, Jul 1, 2008 at 8:33 PM, Matthew Toseland
<toad@...> wrote:
> On Sunday 29 June 2008 14:52, Daniel Cheng wrote:
>> On Sat, Jun 28, 2008 at 10:49 PM,  <toad@...> wrote:
>> > Author: toad
>> > Date: 2008-06-28 14:49:23 +0000 (Sat, 28 Jun 2008)
>> > New Revision: 20845
>> >
>> > Modified:
>> >
> branches/db4o/freenet/src/freenet/support/io/PaddedEphemerallyEncryptedBucket.java
>> > Log:
>> > Don't store the RNG here. Just store a seed created on startup.
>> >
>>
>> If we restarted the node twice... The PRNG will be seeded with the
>> same seed in the two times...  -- Is this behavior expected?
>
> The PRNG is only instantiated when we need it for padding... what's the
> problem?
>>
>> IMO, make Node a static field would make the code much simpler in most
>> code -- we can refer to the node object when we need a prng, database,
>> etc.... For "many node in a jvm", we can use some ClassLoader
>> hacks....
>
> Yay God Object. :)
>
> When we have many node in a jvm, we want to be able to deal with them
> easily... e.g. in the simulation code. Not to have to go through 10 layers of