(Resent) Some small patches for the cvs.

I'm resending this to the list as the moderator hasn't let my last
message (from december 1st) through. If you read this, please dismiss
all my pending messages to this list.
The cxml-patch has been updated to contain Markus small enhancement to
make the code more robust.

Here is some patches that I've used for the Fedora Core 3-rpms that I
distribute on the forums. 

Two of the patches is based on patches others made, so all credits to
them (markus and apoikos on the dc-gui/valknut-forums). They fixes a
problem with libxml2-2.6.16 and a problem with unicode-recoding;

libxml2-2.6.16;
http://dcgui.berlios.de/forum/viewtopic.php?t=2668
http://dcgui.berlios.de/forum/viewtopic.php?t=2678

unicode-problem;
http://dcgui.berlios.de/forum/viewtopic.php?t=2588

Then it is one patch to change the default-speed to 28.8k modem as the
speed "Modem" is known to cause problems with some hubs.

The two last patches is just a small cleanups. One removes some
redundant code in dcwidget in a highly used function, and the other
removes some annoying debug-messages from czlib.

All five has been tested in my packages for a while without any known
troubles.

Subject: falling down of my client

Hey,
I have succesfully installed dcguigui 0.3.3 on my Mandrake 10.0. Everthing is 
running fine and I can download whatever I want but after some time, my gui 
client stops working and that leads either to force shutdown of the 
computer(I can see the cursor of the mouse running, but no applications can 
be maximized) or to "force" quit of the dcgui client.
I think Im not first who writes this, so please if you can give me a council 
how to repair or how to avoid this problem, let me know.
Thank you very much
Dedek

Does not work

i have just upgraded my KDE to 3.3.2 version and tried as always to 
compile valknut from CVS. everything went fine when it started for the 
first time, but after clicking save in options  and starting it for the 
second time it was minimalized and without toolbar. I have checked the 
options i set before and these are emty. every option is emty :(.

can you help me, what to do?

i have also tried the older CVS, but it also does not work :(
while starting in the console i get this
------------------------------------------------
Can't resolve path for 'valknut'
Checking xml version ...
Compiled for '20614' using '20616'
Checking dclib version ...
Using '0.3.4cvs20041210'
Checking Qt (TM) version ...
Compiled for '3.3.3' using '3.3.3'
Checking Qt (TM) privates ...
private test ok !
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 5

Re: Does not work

It's a known bug with libxml2-2.6.16. 
If you want to compile cvs before the patch is in cvs (or libxml2) you
should use the cxml-patch I posted some time ago on this list;
https://lists.berlios.de/pipermail/dcgui-common/2004-
December/000180.html

If you are running Fedora Core 3 you could use my fc3-rpms instead. They
are from latest cvs and have all the patches I posted in the mail above.

Sincerely
Henning

On Fri, 2004-12-10 at 02:41 +0100, Rafal Prasal wrote:
> i have just upgraded my KDE to 3.3.2 version and tried as always to 
> compile valknut from CVS. everything went fine when it started for the 
> first time, but after clicking save in options  and starting it for the 
> second time it was minimalized and without toolbar. I have checked the 
> options i set before and these are emty. every option is emty :(.
> 
> can you help me, what to do?
> 
> i have also tried the older CVS, but it also does not work :(
> while starting in the console i get this
> ------------------------------------------------
> Can't resolve path for 'valknut'
> Checking xml version ...
> Compiled for '20614' using '20616'
> Checking dclib version ...
> Using '0.3.4cvs20041210'
> Checking Qt (TM) version ...

Re: Does not work

Excuse me for missing to write where my fc3-rpms are...  

http://www.ludat.lth.se/~dat03hen/valknut/

Sincerely
Henning

Valknut ignoring connection requests (patch included)

This is a problem I noticed a while ago and have now found time to dig
into. After Valknut has been running for a while I start getting
complaints from people that they can't download from me. I usually then
try connecting to them (checking client version or downloading
filelist), after which they can connect to me okay again. However,
there's going to be plenty of people who don't complain and still can't
connect. 

After switching on some debug messages I found that Valknut was
receiving the ConnectToMe requests but ignoring them. Following up on
this I see this happening: 
        - Valknut receives the ConnectToMe request. 
        - It checks a TransferWaitList to see whether there's already a
          request from the user in there.
        - If so, it resets the timeout and does nothing further. 
        - If not, it adds them to the list and attempts to connect.

This is all well and good except that entries are only removed from the
list during the connection handshake, so if a connection times out then
the user is effectively blacklisted until either a client restart or
until you connect to them. 

The attached patch makes Valknut attempt a connection whether the user is
already in the list or not.

Cheers,
        Robin
--

-- 
     ___        
    ( ' }     |       Robin Hill        <robin <at> robinhill.me.uk> |

problem connecting to other clients

Hi, I'd like to report a problem I have with valknut and dclib 3.3.0
which I compiled myself on a debian ustable.
Here it goes: I cannot connect to most of clients, and I think I've
found the cause of that. In the search tab most of the results have an
ip instead of a hub name. To those clients that have a hub name I CAN
connect, to all others I CANNOT. And 90% of the results have IP numbers
and not names. 
Here is a piece of log showing a connection attempt with a client that
has an IP as hub name:
[14:10:42] [some_name] Client: DC++ (0.401)
[14:10:42] [some_name] Warning: remote want to upload a file !
[14:10:42] [some_name] Warning no more free slots
[14:10:42] [some_name] Disconnected from 83.226.49.8:10576

The user HAD open slots.

This is happening for some time now...

Thanx for the time, valknut is great, I'd like to use it again.
--

-- 
tudor tatar <tudor.tatar <at> tin.it>

Re: Does not work

Użytkownik Henning Noren wyrezał w kamieniu:

>Excuse me for missing to write where my fc3-rpms are...  
>
>http://www.ludat.lth.se/~dat03hen/valknut/
>  
>
this patch makes dclib work with older version of libxml and also with 
the newest one ;)

152c152
< 	else if ( res == 0 )
---
> 	else if ( res >= 0 )
183c183
< 	else if ( res == 0 )
---
> 	else if ( res >= 0 )

Re: Does not work

Użytkownik Henning Noren wyrezał w kamieniu:
 > [...]

apply this to

dclib/dclib/core/cxml.cpp

152c152
< 	else if ( res == 0 )
---
> 	else if ( res >= 0 )
183c183
< 	else if ( res == 0 )
---
> 	else if ( res >= 0 )

Questions about submitting a patch

Hi everyone

This is my first time submitting a patch for OSS, so bear with me while 
I ask a few questions (couldn't find anything on the site).

First Question: Is Valknut still being actively maintained? I've seen 
some activity here on the mailing list via the archives, and it looks 
like that UTF8 issue got resolved in CVS, but just checking :)

Second Question: How should I note my code changes? Looking at code in 
the Linux kernel, people there will say who submitted the change, their 
e-mail, when they made the change and what the change does in comments. 
Should I go just as far?

Third Question:  I noted the generic C++ documentation (the stuff in the 
/** */ style comments) was missing in most cases in the source. The 
changes I've made have this documentation for the methods, should I keep 
this documentation when I submit a patch?

Fourth Question: i18n. I'm not really familiar with this. I noticed 
there's a lot of language translations for Valknut. My total changes to 
the UI involve a whopping three words, without much of a grammatical 
construct at all. I can go to online dictionaries and grab "close 
enough" translations. Should I grab translations and update the 
translation files?

Fifth Question:  How should I make and submit my patches? I haven't 
worked that in depth with CVS or patch/diff before. Could somebody 
spoon-feed me a way to generate appropriate patch files for the changes 
I've made to the Valknut module? Also, when I've genereated these