11 Jun 2008 14:03
Duplicate log entries (1.25)
Francesco Vertova <vertova <at> tsd.unifi.it>
2008-06-11 12:03:44 GMT
2008-06-11 12:03:44 GMT
Hi all, I've just moved glst from pre-data to post-rcpt and noticed that every rejection generates two entries in the smtp log: a spurious DATA=EFILTER followed by RCPT=EFILTER. I've tried patching SMTPSvr.cpp in 1.26 pre-01 (moving the log statement from SMTPRunFilters to SMTPHandleCmd_DATA) and this apparently removes the spurious line. Any opinion? ======================================================================= --- SMTPSvr.cpp 2008-05-14 02:50:24.000000000 +0200 +++ SMTPSvr.cpp.nodup 2008-06-11 12:43:22.750000000 +0200 <at> <at> -1838,10 +1838,6 <at> <at> fclose(pFiltFile); RLckUnlockSH(hResLock); - if (SMTPLogEnabled(SMTPS.pThCfg->hThShb, SMTPS.pSMTPCfg)) - SMTPLogSession(SMTPS, SMTPS.pszFrom, SMTPS.pszRcpt, - "DATA=EFILTER", 0); - pszError = SMTPGetFilterRejMessage(SMTPS.szMsgFile); ErrSetErrorCode(ERR_FILTERED_MESSAGE); <at> <at> -1917,6 +1913,10 <at> <at> ErrorPush(); SMTPResetSession(SMTPS); + if (SMTPLogEnabled(SMTPS.pThCfg->hThShb, SMTPS.pSMTPCfg)) + SMTPLogSession(SMTPS, SMTPS.pszFrom, SMTPS.pszRcpt, + "DATA=EFILTER", 0);(Continue reading)
RSS Feed