[sylpheed:22170] PATCH: Verify URL (version 2)

I recently submitted a simple patch to pop-up a message box and let you verify a url before sending it to your
browser.  I subsequently found that some spammers are representing the actual, underlying url with
encoded characters (ie, they are full of %xx where xx is a 2-digit hexadecimal value).  This makes the url's
hard to read (probably so we might be fooled into clicking on it anyway).  The recent PayPal scam is a good
example where the underlying url used encoded characters to try and make it look more legitimate.

This 2nd version of my little patch decodes the url so that it can be easily read.  The PayPal-scam url leaps
out as obviously not a real PayPal url when you see it in decoded form.

Again, this patch is for evaluation.  It would have to be more tightly integrated into Sylpheed (eg, as an
option in the preferences) if it were to become a standard feature.

And, again, a mouse roll-over that pop's up the decoded url in a tool-tip would certainly be a more elegant
and less intrusive solution.

Regards,
Bill

--------- Patch to src/textview.c for Sylpheed 0.9.8a ----------

/src/sylpheed-0.9.8a/src# diff -u textview.c-original textview.c
--- textview.c-original Fri Dec 26 12:13:42 2003
+++ textview.c  Thu Jan  1 12:12:38 2004
 <at>  <at>  -47,6 +47,7  <at>  <at> 
 #include "html.h"
 #include "compose.h"
 #include "displayheader.h"
+#include "alertpanel.h"

 typedef struct _RemoteURI      RemoteURI;

[sylpheed:22171] Re: PATCH: Verify URL (version 2)

On Thu, 01 Jan 2004 12:40:18 +0000
Bill Trenker <mlwtrenker <at> yahoo.ca> wrote:

> I recently submitted a simple patch to pop-up a message box and let
> you verify a url before sending it to your browser.  I subsequently
> found that some spammers are representing the actual, underlying url
> with encoded characters (ie, they are full of %xx where xx is a
> 2-digit hexadecimal value).  This makes the url's hard to read
> (probably so we might be fooled into clicking on it anyway).  The
> recent PayPal scam is a good example where the underlying url used
> encoded characters to try and make it look more legitimate.

Is this a patch to apply over the previous patch, or should this be
applied directly?

-Dennis

[sylpheed:22172] Re: PATCH: Verify URL (version 2)

Dennis Carr wrote:

> Is this a patch to apply over the previous patch, or should this be
> applied directly?

It is to be applied directly to the original 0.9.8a textview.c file.  I should have explained that.  

Thanks,
Bill

[sylpheed:22173] Re: PATCH: Verify URL (version 2)

Bill Trenker <mlwtrenker <at> yahoo.ca> wrote:

> This 2nd version of my little patch decodes the url so that it can be
> easily read.  The PayPal-scam url leaps out as obviously not a real
> PayPal url when you see it in decoded form.
> 
> Again, this patch is for evaluation.  It would have to be more tightly
> integrated into Sylpheed (eg, as an option in the preferences) if it
> were to become a standard feature.
> 
> And, again, a mouse roll-over that pop's up the decoded url in a
> tool-tip would certainly be a more elegant and less intrusive
> solution.

In Claws, I added the following function which currently handles this
problem. It will produce a prompt only:
1) if the real URL is different from the displayed URL
 AND
2) the displayed URL actually looks like a URL (starts with http: or
www.)

This means it is usually very unobtrusive, and so doesn't need an
option.  It shows both URLs to the user so they can decide what to do. 
It doesn't decode the URL like yours does, that would be a good
improvement to add.  

(I'm afraid I haven't bothered to put together a proper patch, this is
just so you can see what is in Claws already)

Luke

[sylpheed:22174] Re: PATCH: Verify URL (version 2)

Great!, I tried to apply this changes to sylpheed0.9.8a and it seems to
work very well! The only thing I needed to change was that the function
is called in textview_button_pressed() and not in
textview_button_released(). I send a patch for sylpheed version 0.9.8a
in attachment. 
ThanX

Alberto

On Sat, 3 Jan 2004 14:32:23 +0000
Luke Plant <lukeplant <at> softhome.net> wrote:

> Bill Trenker <mlwtrenker <at> yahoo.ca> wrote:
> 
> > This 2nd version of my little patch decodes the url so that it can
> > be easily read.  The PayPal-scam url leaps out as obviously not a
> > real PayPal url when you see it in decoded form.
> > 
> > Again, this patch is for evaluation.  It would have to be more
> > tightly integrated into Sylpheed (eg, as an option in the
> > preferences) if it were to become a standard feature.
> > 
> > And, again, a mouse roll-over that pop's up the decoded url in a
> > tool-tip would certainly be a more elegant and less intrusive
> > solution.
> 
> In Claws, I added the following function which currently handles this
> problem. It will produce a prompt only:
> 1) if the real URL is different from the displayed URL
>  AND

[sylpheed:22175] Re: PATCH: Verify URL (version 2)

Hi,

If I remember correctly main doesn't do this, but claws 
will display the actual url in the statusbar for any link 
clicked once.

--

-- 
"Thanks to his green candle, the 'Pataphysician can
 lighten our darkness."

[sylpheed:22176] Re: PATCH: Verify URL (version 2)

On Sat, 3 Jan 2004 14:32:23 +0000
Luke Plant <lukeplant <at> softhome.net> wrote:

> It doesn't decode the URL like yours does, that would be a good
> improvement to add.  

I previously send a patch for sylpheed 0.9.8a made applying the code
(from Claws) you posted. As you suggested, adding URL decoding ability,
as in patch posted by Bill Trenker, would be a good improvement to your
code.
In attachment is included a patch similar to that I already posted, but
improved with code for URL decoding.

--

-- 

  Alberto Ferrarini

  email: a_ferrarini <at> katamail.com
         albertoferrarini <at> interfree.it

  Registered Linux User #340389

*** textview.c.original	2004-01-03 20:46:23.000000000 +0100
--- textview.c	2004-01-03 20:51:51.000000000 +0100
***************
*** 47,52 ****
--- 47,53 ----
  #include "html.h"

[sylpheed:22177] problem with accountrc file and parsing methods

Hi,

I'm a sylpheed user since a long time and I now programming
a Python script to configure automatically sylpheed's accountrc file
from others configuration file.
But I had a small problem, sylpheed discriminate the option by order.
So something like:
	name=Bla Bla
	foo=toc toc
differ from:
	foo=toc toc
	name=Bla Bla

Could you explain me how to avoid this problem
or if you could patch sylpheed to do not make distinction

PS: With the derivated ConfifParser from Python
I could'nt put the options in the place
where they were...

Thanks,
Bader

[sylpheed:22178] Will expiring foilders happen

I belong to several major lists which mean that I get a lot of mail. Will it be an option in the future to auto
expire mail after a few days depening on user settings, or is there anuther way to do it

Sean
--

-- 
 GPG Key Id 120A02FB ICQ: 679813  Jabber: tcobone <at> jabber.org
            TCOB1.net hosting service now availble

[sylpheed:22179] Re: Will expiring foilders happen

On Sun, 04 Jan 2004 17:42:09 +0000
Sean Rima <sean <at> tcob1.net> wrote:

> I belong to several major lists which mean that I get a lot of mail.
> Will it be an option in the future to auto expire mail after a few
> days depening on user settings, or is there anuther way to do it

  In Claws <http://claws.sylpheed.org> messages can be moved to
another folder after certain amount of days have passed using folder
processing rules: right click on folder, processing, define an
"age_greater XX move FF" rule, where XX are days for expiring, and FF
is the folder where you want the expired messages (in your case
probably Trash folder).

  Another possibility is request this feature in Sylpheed or better
provide the patch yourself 
--  
  Ricardo Mones Lastra - mones <at> aic.uniovi.es
  Centro de Inteligencia Artificial, Universidad de Oviedo en Gijon
  33271 Asturias, SPAIN. - http://www.aic.uniovi.es/mones