sup-mail crash

attached is the exception log

-- 
"A mouse is a device used to point at the xterm you want to type in"
                -- A.S.R.

--- IOError from thread: load threads for thread-index-mode
IO Error occured at <except.c>:93 in xraise
Error occured in fs_store.c:293 - fsi_seek_i
	seeking pos 377228: <Bad file descriptor>

/usr/lib/ruby/1.8/sup/index.rb:362:in `default'
/usr/lib/ruby/1.8/sup/index.rb:362:in `[]'
/usr/lib/ruby/1.8/sup/index.rb:362:in `build_message'
/usr/lib/ruby/1.8/sup/index.rb:342:in `each_message_in_thread_for'
/usr/lib/ruby/1.8/sup/thread.rb:341:in `call'
/usr/lib/ruby/1.8/sup/thread.rb:341:in `load_thread_for_message'
/usr/lib/ruby/1.8/sup/index.rb:354:in `each_message_in_thread_for'
/usr/lib/ruby/1.8/sup/index.rb:354:in `each'
/usr/lib/ruby/1.8/sup/index.rb:354:in `each_message_in_thread_for'
/usr/lib/ruby/1.8/sup/thread.rb:339:in `load_thread_for_message'
/usr/lib/ruby/1.8/sup/thread.rb:331:in `load_n_threads'
/usr/lib/ruby/1.8/sup/index.rb:263:in `each_id_by_date'
/usr/lib/ruby/1.8/sup/index.rb:263:in `each'
/usr/lib/ruby/1.8/sup/index.rb:263:in `each_id_by_date'
/usr/lib/ruby/1.8/sup/thread.rb:326:in `load_n_threads'
/usr/lib/ruby/1.8/sup/modes/thread-index-mode.rb:499:in `__unprotected_load_n_threads'
(eval):12:in `load_n_threads'

Re: sup-mail crash

Search the ML archives. This looks similar to other crash reports and
might be the same issue.
*t

On 2/6/2009, "Simon Raven" <simon.raven <at> gmail.com> wrote:

>attached is the exception log
> ...
> IO Error occured at <except.c>:93 in xraise
> Error occured in fs_store.c:293 - fsi_seek_i
>	seeking pos 377228: <Bad file descriptor>

Re: sup-mail crash

Reformatted excerpts from Tomas Pospisek Mailing Lists's message of 2009-02-09:
> Search the ML archives. This looks similar to other crash reports and
> might be the same issue.

In particular I'm pretty sure this is fixed in git, which I'll be
releasing "any day now".
--

-- 
William <wmorgan-sup <at> masanjin.net>

Re: sup-mail crash

On 9.2.2009, William Morgan wrote:
> In particular I'm pretty sure this is fixed in git, which I'll be
> releasing "any day now".

I've not been able to track sup git on my work machine for a while
because something introduced between 0.6 and latest head has borked
the mbox code. I get an odd hash error about the hash changing whilst
being read or something. Not sure how to track down what causes it
though.

I can probably update and get stack trace if its any use.

Marcus

Re: sup-mail crash

On 2/10/2009, "William Morgan" <wmorgan-sup <at> masanjin.net> wrote:

>Reformatted excerpts from Tomas Pospisek Mailing Lists's message of 2009-02-09:
>> Search the ML archives. This looks similar to other crash reports and
>> might be the same issue.
>
>In particular I'm pretty sure this is fixed in git, which I'll be
>releasing "any day now".

Wow. That would be fantastic. I quite liked sup, but it wasn't stable.
And being stable at runtime is about the number #1 feature for any SW
for me.
*t, waiting the day X

Re: sup-mail crash

Reformatted excerpts from Marcus Williams's message of 2009-02-10:
> I can probably update and get stack trace if its any use.

Yeah, I'd be interested in this. There are definite mbox problems but I
don't think they are new ones, and they don't involve anything with
hashes AFAIK.
--

-- 
William <wmorgan-sup <at> masanjin.net>

Re: [PATCH] sup-mail crash

On Thu, 2009-02-12 at 13:58 -0800, William Morgan wrote:
> Reformatted excerpts from Marcus Williams's message of 2009-02-10:
> > I can probably update and get stack trace if its any use.
> 
> Yeah, I'd be interested in this. There are definite mbox problems but I
> don't think they are new ones, and they don't involve anything with
> hashes AFAIK.

Resending since it looks like I only replied to wmorgan originally ...

I've had this problem occassionally about a "hash modified during
iteration" and I use maildir rather than mbox.

Attached is a patch to fix that problem.

--

-- 
Rick
rick.tessner <at> gmail.com

_______________________________________________
sup-talk mailing list
sup-talk <at> rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-talk

(no subject)

>From 61a256d09ec8091e5ab44cc4e0e5c9c24c81a4cf Mon Sep 17 00:00:00 2001
From: Mike Stipicevic <stipim <at> rpi.edu>
Date: Mon, 16 Feb 2009 00:40:39 -0500
Subject: [PATCH] Added undo for archive

---
 lib/sup/modes/inbox-mode.rb        |   35 +++++++++++++++++++++++++++++++++++
 lib/sup/modes/thread-index-mode.rb |   21 +++++++++++++++++++--
 2 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/lib/sup/modes/inbox-mode.rb b/lib/sup/modes/inbox-mode.rb
index 559892d..21eb9ac 100644
--- a/lib/sup/modes/inbox-mode.rb
+++ b/lib/sup/modes/inbox-mode.rb
 <at>  <at>  -26,12 +26,28  <at>  <at>  class InboxMode < ThreadIndexMode

   def archive
     return unless cursor_thread
+    thread = cursor_thread # to make sure lambda only knows about 'old' cursor_thread
+
+    undo = lambda {
+      thread.apply_label :inbox
+      add_or_unhide thread.first
+    }
+    UndoManager.register("archiving thread #{thread.first.id}", undo)
+
     cursor_thread.remove_label :inbox
     hide_thread cursor_thread
     regen_text
   end

(no subject)

>From 9b863d8c86226b3d148e56060092556e2b13a5df Mon Sep 17 00:00:00 2001
From: Mike Stipicevic <stipim <at> rpi.edu>
Date: Mon, 16 Feb 2009 00:39:50 -0500
Subject: [PATCH] Added UndoManager class

The UndoManager keeps a list of lambdas that undo actions. It's designed to be used by keypress hooks. It is
initialized in the main sup thread along with UpdateManager, etc.
---
 lib/sup.rb                         |    2 +
 lib/sup/modes/thread-index-mode.rb |    6 +++++
 lib/sup/undo.rb                    |   42 ++++++++++++++++++++++++++++++++++++
 3 files changed, 50 insertions(+), 0 deletions(-)
 create mode 100644 lib/sup/undo.rb

diff --git a/lib/sup.rb b/lib/sup.rb
index 93369a5..eda673b 100644
--- a/lib/sup.rb
+++ b/lib/sup.rb
 <at>  <at>  -125,6 +125,7  <at>  <at>  module Redwood
     Redwood::PollManager.new
     Redwood::SuicideManager.new Redwood::SUICIDE_FN
     Redwood::CryptoManager.new
+    Redwood::UndoManager.new
   end

   def finish
 <at>  <at>  -281,6 +282,7  <at>  <at>  require "sup/tagger"
 require "sup/draft"
 require "sup/poll"
 require "sup/crypto"

(no subject)

>From 31bb0fd8f6e701107ce79ad2dbd9d42da4635742 Mon Sep 17 00:00:00 2001
From: Mike Stipicevic <stipim <at> rpi.edu>
Date: Mon, 16 Feb 2009 00:06:36 -0500
Subject: [PATCH] Added undo for spam

---
 lib/sup/modes/thread-index-mode.rb |   22 ++++++++++++++++++----
 1 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 62fdb85..1e02b5b 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
 <at>  <at>  -300,13 +300,28  <at>  <at>  EOS
   end

   def actually_toggle_spammed t
+    thread = t
     if t.has_label? :spam
+      undo = lambda {
+        thread.apply_label :spam
+        self.hide_thread thread
+        UpdateManager.relay self,:spammed, thread.first
+      }
       t.remove_label :spam
+      add_or_unhide t.first
       UpdateManager.relay self, :unspammed, t.first
     else
+      undo = lambda {
+        thread.remove_label :spam