Weather_uk 0.5 - Done
David Newcomb <david.newcomb <at> bigsoft.co.uk>
2005-07-05 13:52:31 GMT
Paul, Rob,
Thanks for you comments Paul.
I have spent some quality time sorting out all the points
you mentioned below.
I have written some brief notes and put a screenshot of the
options page at:
http://www.bigsoft.co.uk/projects/squirrelmail_plugins/weather_uk/
I feel that this version is much better than my previous version,
and also much better than Rob's (sorry Rob - previously I did not
care but having revamped it, I think you will agree).
This the second time I have sent the email but have not had
any response. I attach a copy of the weather plugin for you convience.
Interested in thoughts and comments.
Regards,
David
---------------------------------------
Managing Director
BigSoft Limited
Reading, UK
http://www.bigsoft.co.uk/
Paul Lesneiwski said:
> All,
>
> Sorry, this one has been really confusing to me having three
> interested parties responding (and not) at different junctures... :)
Whose version is the most up to date? Have any of you worked to merge
all fixes into one tarball yet?
>
> Comments on David's code:
> - version file names the plugin wrong
> - missing version function in setup.php
> - you should probably give credit to nicholas in the README :) - we
prefer that you have an INSTALL file
> - please remove all code from setup.php
> - missing bindtextdomain calls and .pot file
> - please use include_once instead of require_once
>
> Comments on Rob's code:
> - I don't see any bindtextdomain calls...?
> - Also missing translation file
> - Otherwise, seems clean and about ready to go
>
> All comments are meant to be constructive, and you can get more info
> about them by reading doc/plugin.txt - pay special attention to the
requirements/specs section near the bottom of that document.
>
> It seems like Rob has the most complete version as far as code that
> I've seen -- David, have you worked with Rob at all to see if your
changes are/can be included in his version perhaps? Nicholas, have you
seen Rob's code? What is the state of yours? I am attaching Rob's.
>
> Thanks all,
>
> Paul
>
>
> Rob Jervis wrote:
>> Hello all,
>>
>> I have taken a look at this plugin.
>> (http://www.bigsoft.co.uk/projects/squirrelmail_plugins/weather_uk-0.5.tar.gz)
As Paul said, I have also done a bit of work on it myself. David,
maybe you could take a look at the attached, that's how far I had got
with things. (I was ready for it to be released, but then wondered if
we could make the plugin further backwards compatible)
>>
>> I wrote the updates in July and then added a few more after talking to
Paul in December.
>>
>> v0.5 - 11/12/2004 - Rob Jervis
>> ----
>> NOTE: This plugin died on me in February, I have fixed the problem & done
>> some development. Hope it works for you all! Rob
>>
>> - The Met Office moved their images AGAIN fixed that, Second Time Now
- Changed main page to: Menu + Today's Weather
>> - Kept old weather page as "Brief 3-Day Forecast"
>> - Added "Detailed 3-Day Forecast" inc. Weather, Wind, Temp. & Solar
UV - Added "Regional Forecasts" containing: Weather, Wind & Temp. -
Regional Forecasts cover all the UK & Each is a 3-Day Forecast -
functions.php file added
>> - INSTALL file added
>> - PluginStandards - Small Setup.php - Now Compliant
>> - PluginStandards - Version Reporting - Now Compliant
>> - PluginStandards - include_once - Now Compliant
>> - Fixed version file (Thanks Paul)
>> - Removed redundant includes in all affected files (Thanks Paul) -
Made files spambot proof
>> - Updated Instructions etc. in README file
>> - Updated README, version & setup.php files, to Cover Additions &
Fixs - Face Lift on Version Log & To-do in README file
>> - All tested OK with SM v1.4.3a it requires SM v1.4.x
>> - Hope you like the changes! (Fingers Crossed)
>>
>>
>> Let me know what you think.
>>
>> Rob
>>
>>
>>
>> ----- Original Message ----- From: "Paul Lesneiwski"
>> <paul <at> squirrelmail.org>
>> To: "David Newcomb" <david.newcomb <at> bigsoft.co.uk>;
>> <rob <at> robertjervis.co.uk>; <lists-squirrelmail <at> no-spam.co.uk>
>> Sent: Thursday, March 24, 2005 10:48 PM
>> Subject: Re: Weather_uk 0.5
>>
>>
>>> David,
>>>
>>> I found that "someone else" I was thinking of (Rob). Please see the
>>> attached message. If Rob and David can agree on a final version (Rob,
David's is linked below), we'll get it posted ASAP.
>>>
>>> Thanks all,
>>>
>>> Paul
>>>
>>>
>>> David Newcomb wrote:
>>>
>>>> Paul,
>>>>
>>>> Has he replied yet?
>>>>
>>>> Cheers,
>>>> David.
>>>>
>>>> p dont think said:
>>>>
>>>>> I seem to remember someone else recently fixing it, and I just can't
remember what the author had to say about it (if anything). I am
cc'ing
>>>>> him here... let's wait to see if he responds.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Paul
>>>>>
>>>>>
>>>>> David Newcomb wrote:
>>>>>
>>>>>> Jimmy, Paul,
>>>>>>
>>>>>> The current version of the weather_uk 0.4 is broken - none of the
graphics links work.
>>>>>>
>>>>>> I have given the plugin a bit of a revamp and placed it on my
webserver. I would appreicate it if you would include it in the
plugin section of the SquirrelMail website as the new 0.5.
>>>>>>
>>>>>> This plugin was built out of 0.4 but contains an extra regional
parameter to allow the user to get regional weather.
>>>>>>
>>>>>> Feel free to change any aspect of the documentation, but I
>>>>>> would like a mention in the changelog.
>>>>>>
>>>>>> http://www.bigsoft.co.uk/projects/squirrelmail_plugins/weather_uk-0.5.html
>>>>>>
>>>>>>
>>>>>>
>>>>>> Best Regards,
>>>>>> David
>>>>>> ---------------------------------------
>>>>>> Managing Director
>>>>>> +44 (0) 7866 262 398
>>>>>> BigSoft Limited
>>>>>> Reading, UK
>>>>>> http://www.bigsoft.co.uk/
>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> :wq
>>>>> ^ESC
>>>>> :w!
>>>>> what's wrong with this damn thing?
>>>>>
>>>>
>>>>
>>>>
>>>> Regards,
>>>> David
>>>> ---------------------------------------
>>>> Managing Director
>>>> +44 (0) 7866 262 398
>>>> BigSoft Limited
>>>> Reading, UK
>>>> http://www.bigsoft.co.uk/
>>>>
>>>>
>>>
>>>
>>> --
>>>
>>> Open Guild, LLC
>>> http://openguild.net/
>>> Software.Systems.Solutions
>>>
>
> --
>
> Open Guild, LLC
> http://openguild.net/
> Software.Systems.Solutions
>
RSS Feed