Undelete button missing from 1.4.20 [SVN] when $auto_expunge is false

I made the following change to functions/mailbox_display.php to fix it.

echo getButton('SUBMIT', 'delete',_("Delete")) ." \n";
+if (!$auto_expunge) {
+    echo getButton('SUBMIT', 'undeleteButton',_("Undelete")) . "\n";
+}

--

-- 
Michael

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel <at> lists.sourceforge.net
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[1.4.20RC2] case exact match in decodeheader

Hi,

my acquaintance find there is a case exact match in processing
decoding encoded header.

This problem still exists in 1.4.20RC2 and affects replying/forwarding
a mail.

Attached patch fix the problem.  Case of "q|b" part has changed to the
same as other regular expressions.

Best regards.

--

-- 
Takahiro Kambe <taca <at> back-street.net>

--- functions/i18n.php.orig	2009-07-29 11:21:06.000000000 +0900
+++ functions/i18n.php	2009-10-04 10:17:48.000000000 +0900
 <at>  <at>  -675,7 +675,7  <at>  <at> 
             break;
         case 'decodeheader':
             $ret = str_replace("\t", "", $ret);
-            if (preg_match('/=\?([^?]+)\?(q|b)\?([^?]+)\?=/', $ret))
+            if (preg_match('/=\?([^?]+)\?(Q|B)\?([^?]+)\?=/Ui', $ret))
                 $ret =  <at> mb_decode_mimeheader($ret);
             $ret =  <at> mb_convert_encoding($ret, 'EUC-JP', 'AUTO');
             break;

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA

Re: [1.4.20RC2] case exact match in decodeheader

On Sat, Oct 3, 2009 at 7:35 PM, Takahiro Kambe <taca <at> back-street.net> wrote:
> Hi,
>
> my acquaintance find there is a case exact match in processing
> decoding encoded header.
>
> This problem still exists in 1.4.20RC2 and affects replying/forwarding
> a mail.
>
> Attached patch fix the problem.  Case of "q|b" part has changed to the
> same as other regular expressions.

> -            if (preg_match('/=\?([^?]+)\?(q|b)\?([^?]+)\?=/', $ret))
> +            if (preg_match('/=\?([^?]+)\?(Q|B)\?([^?]+)\?=/Ui', $ret))

Kanbe-san, thank you.  Looks like I forgot to add the i modifier in a
couple places where eregi() was being replaced.  However, unless you
can prove otherwise, I believe the U modifier does nothing here, so it
is being left out.  This has been committed.  Thank you.

--

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 

Re: [1.4.20RC2] case exact match in decodeheader

Hi,

In message <58191e420910032210ob8e1c12s275f2bed213191f <at> mail.gmail.com>
	on Sat, 3 Oct 2009 22:10:44 -0700,
	Paul Lesniewski <paul <at> squirrelmail.org> wrote:
>> -            if (preg_match('/=\?([^?]+)\?(q|b)\?([^?]+)\?=/', $ret))
>> +            if (preg_match('/=\?([^?]+)\?(Q|B)\?([^?]+)\?=/Ui', $ret))
The patch was provided by obache at NetBSD.org.

> Kanbe-san, thank you.  Looks like I forgot to add the i modifier in a
> couple places where eregi() was being replaced.  However, unless you
> can prove otherwise, I believe the U modifier does nothing here, so it
Yes, I think that U modifier isn't needed unless the string is really
correctly encoded and I don't have such a wrong case.  Probably, U
modified was added as other lines which make matching to MIME B/Q
encoding.

> is being left out.  This has been committed.  Thank you.
Thanks for your quick action!

-- 
Takahiro Kambe <taca <at> back-street.net>

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
-----

Allowing anchors when displaying HTML messages

All,

  https://sourceforge.net/tracker/index.php?func=detail&aid=2864736&group_id=311&atid=100311

  Anchors to another part of any HTML message are replaced with
blank.png, because SM thinks there is no valid URL in the href.

  The attached patch is a quick hack to allow anchors through,
although it has not been evaluated for abuse potential and the anchor
still opens up in a new window (which would be much more involved to
fix, as the whole Magic HTML code seems to assume that's the only
option you'd ever want).

  If anyone can comment or improve upon this, that would be nice.

-Paul

--

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 

chech_referrer not working

Hello:

I'm testing new check_referrer functionality. It doesn't work for me. I 
think the problem is that

1. the global var $check_referrer is modify inside is_logged_in() 
function, and
2. is_logged_in() is called twice in webmail.php: one in the included 
validate.php and another one in webmail.php itself.

I attach a patch that address 1.

And I think the call to is_logged_in() inside webmail.php must be 
removed because is_logged_in() is already called in the included 
validate.php.

Regards,
Fernando.

--- functions/auth.original.php	2009-10-12 13:09:46.088235997 +0200
+++ functions/auth.php	2009-10-12 13:34:37.235967000 +0200
 <at>  <at>  -62,15 +62,15  <at>  <at>  function is_logged_in() {
     global $check_referrer, $domain;
     if ($check_referrer == '###DOMAIN###') $check_referrer = $domain;
     if (!empty($check_referrer)) {
-        $ssl_check_referrer = 'https://' . $check_referrer;
-        $check_referrer = 'http://' . $check_referrer;
+        $ssl_chk_ref = 'https://' . $check_referrer;
+        $chk_ref = 'http://' . $check_referrer;

Re: chech_referrer not working

On Mon, Oct 12, 2009 at 12:13 PM, Fernando Gozalo <fgozalo <at> csi.uned.es> wrote:
> Hello:
>
> I'm testing new check_referrer functionality. It doesn't work for me. I
> think the problem is that
>
> 1. the global var $check_referrer is modify inside is_logged_in() function,
> and
> 2. is_logged_in() is called twice in webmail.php: one in the included
> validate.php and another one in webmail.php itself.
>
> I attach a patch that address 1.
>
> And I think the call to is_logged_in() inside webmail.php must be removed
> because is_logged_in() is already called in the included validate.php.

Thank you for your testing.  I believe the main problem is the second
one.  I have fixed this in CVS, thanks to you.  This makes the changes
in number one above unnecessary, but I think they are also a good
suggestion, so I'll probably add them.

Cheers,

Paul

--

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Error message on reply

Hi,

I think I discovered a bug in squirrelmail. I´m using it with dovecot,
and most features work ok.

However, I encounter an error message everytime I reply to a mail. The
short error is: "Could not append message to Sent. Server responded:
RED)".

This doesn´t happen when creating a new mail, only in responding. I changed
functions/imap_general.php to get the full response from server, what is:

* FLAGS (\Answered \Flagged \Deleted \Seen \Draft $MDNSent KMAILFORWARDED
KMAILTODO KMAILWATCHED KMAILIGNORED $FORWARDED $TODO $WATCHED $IGNORED)

Obviously, the "NO" from "IGNORED" / "KMAILIGNORED" makes the term
<preg_match("/(.*)(BAD|NO)(.*)$/"> to fail.

Think there should be a \b before and after the (BAD|NO):

"/(.*)\b(BAD|NO)\b(.*)$/"

This way it only fails when "NO"/"BAD" is on a word boundary, not within
other words.

Thanks,
Sebastian

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA