Samuel Graenacher | 1 Apr 2005 08:51

Re: New addressbook backend (and sorting problem)

Hi,

> Can you display it as three different address books?
>
> Personal, Shared, Global.

The problem would be mostly the same, the sorting would be mixing up the
contacts originating from different folders. Let me give a few example
nicks that could appear in this backend:

apersonalcontact
someothercontact
user/annasecretary/companyxyz
user/peterboss/sales
user/peterboss/marketing
shared/ITAdministrators/somecontact
shared/ITDepartment/somecontact

(Note that the "user/" and "shared/" prefixes can be changed by a setting
should the need arise.)

So basically this would mean that I'd somehow need to find a way to
spawn/emulate an addressbook on the fly for each "prefix/source" pair to
get the sorting right. And things will prolly start to get messy for the
users aswell. Example: To create an entry in say..
"shared/BrandNewSharedFolder/..." they'd need to tell Squirrel to actually
create it in an existing (selectable) addressbook, only to have it appear
under a new different addressbook once it's read in. A tad confusing to
the enduser I think.

(Continue reading)

Tomas Kuliavas | 1 Apr 2005 11:46
Picon
Gravatar

Re: New addressbook backend (and sorting problem)

>> Can you display it as three different address books?
>>
>>
>> Personal, Shared, Global.
>>
>
> The problem would be mostly the same, the sorting would be mixing up the
> contacts originating from different folders. Let me give a few example
> nicks that could appear in this backend:
>
> apersonalcontact someothercontact user/annasecretary/companyxyz
> user/peterboss/sales user/peterboss/marketing
> shared/ITAdministrators/somecontact shared/ITDepartment/somecontact
>
> (Note that the "user/" and "shared/" prefixes can be changed by a setting
>  should the need arise.)
>
> So basically this would mean that I'd somehow need to find a way to
> spawn/emulate an addressbook on the fly for each "prefix/source" pair to
> get the sorting right. And things will prolly start to get messy for the
> users aswell. Example: To create an entry in say..
> "shared/BrandNewSharedFolder/..." they'd need to tell Squirrel to
> actually create it in an existing (selectable) addressbook, only to have
> it appear under a new different addressbook once it's read in. A tad
> confusing to the enduser I think.

call folder 'a group' and patch squirrelmail address book backends to
support groups. 6th field in file based backend, group field in db
backend, ou attribute in ldap backend.

(Continue reading)

Marczisovszky Daniel | 1 Apr 2005 12:18

Re[2]: New addressbook backend (and sorting problem)

Hi,

>> Since we still use 1.4.4 here I'll see if I can get the hooks backported
>> (IIRC someone else already made a patch for this) and adjust my backend to
>>  make use of them as good as possible.

TK> IIRC somebody wrote sample address book plugin that does nothing useful
TK> and it was downloaded 1763 times. :)

TK> Patch consist of four lines added in the right places + comments.

Soon I'll send the updated (for version 1.4.4) patched, as the plugin
contains a patch which is almost a year old.

Hopefully I'll upload today my LDAP based personal Address Book, so it
may also help for PAB developers ;)

Bye,
Daniel

-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/info/Sentarus/hamr30
--
squirrelmail-devel mailing list
Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
(Continue reading)

Samuel Graenacher | 1 Apr 2005 13:07

Re: New addressbook backend (and sorting problem)

> call folder 'a group' and patch squirrelmail address book backends to
> support groups. 6th field in file based backend, group field in db
> backend, ou attribute in ldap backend.

That sounds like a good allround solution. I'll see if I can change the
Addressbook class to support an optional group field in its sorting.

> There is no need to do that. abook_init hook controls entire $abook object
> excluding remote backends. You should be able to replace local backend
> with own one. Hook that adds custom localbackend would be nice, but not
> necessary. Option that turns off local backend would be nice, but
> dangerous without plugin actually adding local backend.

Hmm, ok. I'll just have the hook function throw out every localbackend if
the user enabled a certain plugin option.

> Patch consist of four lines added in the right places + comments.

Great.

Thanks for all the hints.

-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/info/Sentarus/hamr30
--
squirrelmail-devel mailing list
Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
(Continue reading)

Joolz | 2 Apr 2005 15:29
Picon

patch to control if empty subjects should be allowed

Hi,

I'm new at this, so please bear with me :)

My company has been running squirrelmail for some time now and we
made some small mods that may be useful. Here's one that will give
you control over whether or not to allow empty subject lines. I made
it because my users were beginning to act like hotmail users :) I
made the default to not accept empty subjects, but that's of course
open for discussion.

The diff is attached, hope that's ok.
Attachment (empty_password.diff): text/x-patch, 2703 bytes
Nick | 2 Apr 2005 18:44

[Fwd: bug causes wrong messages to be deleted]

Can anyone confirm this?

It is hard to believe that no one cares about a bug that deletes messages
the user didn't select.

---------------------------- Original Message ----------------------------
Subject: [SM-DEVEL] bug causes wrong messages to be deleted
From:    "Nick" <newsgroups <at> 2thebatcave.com>
Date:    Thu, March 24, 2005 7:06 am
To:      squirrelmail-devel <at> lists.sourceforge.net
--------------------------------------------------------------------------

It appears I have found a bug.

When I am in a folder that has multiple pages of messages, and sort by the
'From' field, and go to a page greater than 1, messages that I try to
delete do not always get deleted, and sometimes they delete the wrong
messages.

I tried a test case with a new folder, and noticed the same results.

To reproduce you can create a folder with multiple pages, go to a page
other than one, sort by from, and then try to delete a message on that
page.

Note that sometimes the message does get deleted (this may just be when it
is the last message), but most of the time it does not.

I know that sometimes messages that were not selected can be deleted,
because I had a folder with 70 pages, and when I selected an entire page
(Continue reading)

Paul Lesneiwski | 2 Apr 2005 23:05
Favicon

Re: patch to control if empty subjects should be allowed

> My company has been running squirrelmail for some time now and we
> made some small mods that may be useful. Here's one that will give
> you control over whether or not to allow empty subject lines. I made
> it because my users were beginning to act like hotmail users :) I
> made the default to not accept empty subjects, but that's of course
> open for discussion.
> 
> The diff is attached, hope that's ok.

Please use diff -u.  Also, this can be done as a plugin.  Read 
doc/plugin.txt and we'll be very happy to host the plugin when you're 
finished!

Thanks much!

  -paul

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
--
squirrelmail-devel mailing list
Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

(Continue reading)

Joolz | 2 Apr 2005 23:24
Picon

Re: patch to control if empty subjects should be allowed

Joolz zei:
> Hi,
>
> I'm new at this, so please bear with me :)
<snip>

This is completely off topic, but do sf mailinglists normally
replace single quotes with double ones? That's what it did in the
online archive, imo it is /weird/

If someone should decide to use the patch in squirrelmail, please
let me know, I'll mail it directly (with correct quoting :)

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
--
squirrelmail-devel mailing list
Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

Joolz | 2 Apr 2005 23:29
Picon

Re: patch to control if empty subjects should be allowed

Paul Lesneiwski zei:
>> My company has been running squirrelmail for some time now and we
>> made some small mods that may be useful. Here's one that will give
>> you control over whether or not to allow empty subject lines. I
>> made
>> it because my users were beginning to act like hotmail users :) I
>> made the default to not accept empty subjects, but that's of
>> course
>> open for discussion.
>>
>> The diff is attached, hope that's ok.
>
> Please use diff -u.  Also, this can be done as a plugin.  Read
> doc/plugin.txt and we'll be very happy to host the plugin when
> you're
> finished!

I will have a look at it in a few days. Glad I can make a
contribution! :)

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
--
squirrelmail-devel mailing list
Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.devel
(Continue reading)

javier wilson | 3 Apr 2005 14:50
Picon

Re: [Fwd: bug causes wrong messages to be deleted]

On Apr 2, 2005 10:44 AM, Nick <newsgroups <at> 2thebatcave.com> wrote:
> Can anyone confirm this?

i have tried to reprodeuce the error in cvs1.5.1 and cyrus-imapd as
backend but was unable to. i tried several times, but nothing... no
mistakes, no wrong message deleted.

javier

 
> It is hard to believe that no one cares about a bug that deletes messages
> the user didn't select.
> 
> ---------------------------- Original Message ----------------------------
> Subject: [SM-DEVEL] bug causes wrong messages to be deleted
> From:    "Nick" <newsgroups <at> 2thebatcave.com>
> Date:    Thu, March 24, 2005 7:06 am
> To:      squirrelmail-devel <at> lists.sourceforge.net
> --------------------------------------------------------------------------
> 
> It appears I have found a bug.
> 
> When I am in a folder that has multiple pages of messages, and sort by the
> 'From' field, and go to a page greater than 1, messages that I try to
> delete do not always get deleted, and sometimes they delete the wrong
> messages.
> 
> I tried a test case with a new folder, and noticed the same results.
> 
> To reproduce you can create a folder with multiple pages, go to a page
(Continue reading)


Gmane