headers
Thijs Kinkhorst | 1 Jul 2004 14:54

Add configtest to stable?

Hello devs,

For over a year now the file configtest.php has been present in the devel
branch and in that time no big problems have arosen from it. So I was
thinking it might be backported into the stable release, because of the
following reasons:

- The file has good use in helping admins track common problems (saves time)
  and reduces support requests to the mailinglists.
- It will take a long time before the current DEVEL branch will become
  STABLE so it can pay off to backport this feature now in stead of waiting.
- It has been without problems for a long time in devel.
- It can be easily backported without major (any??) modifications.
- If there turns out to be some problem with it, this will not affect any
  other part of SquirrelMail since nothing depends on or uses this file.

Please let me know if someone (esp. stable admins) object this move.

Thijs

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
(Continue reading)

Permalink | Reply | 1 comment |
headers
Chris Hilts | 1 Jul 2004 15:11
Favicon

Re: Add configtest to stable?

> For over a year now the file configtest.php has been present in the devel
>  branch and in that time no big problems have arosen from it. So I was 
> thinking it might be backported into the stable release, because of the 

No objection here.  Go for it.

--

-- 
Chris Hilts
tassium <at> squirrelmail.org

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_idq39
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Permalink | Reply | 0 comments |
headers
Maurice Makaay | 1 Jul 2004 17:07
Favicon

Request for implementing a new hook: internal_link_path

Hello,

Could the hook 'internal_link_path' please be implemented in SM?
In functions/page_header.inc:

    function makeInternalLink($path, $text, $target='') {
	sqgetGlobalVar('base_uri', $base_uri, SQ_SESSION);
	if ($target != '') {
	    $target = " target=\"$target\"";
	}
+	$origtext = $text;
	$hooktext = do_hook_function('internal_link',$text);
	if ($hooktext != '')
	    $text = $hooktext;

+	$hookpath = do_hook_function('internal_link_path', $origtext);
+	if ($hookpath != '')
+	    $path = $hookpath;
+       else
+           $path = $base_uri . $path;

!	return '<a href="'.$path.'"'.$target.'>'.$text.'</a>';
    }

This makes it possible to redirect an internal link to a custom page.
We want to use this for implementing a completely custom addressbook.
With the internal_link hook it's also possible but the resulting
code isn't really clean (close the opened <a> tag and start a new one):

    function the_hook ($text) {
(Continue reading)

Permalink | Reply | 16 comments |
headers
Kelly Byrd | 1 Jul 2004 18:41

Re: Warning: Invalid argument supplied for foreach() in /usr/share/squirrelmail/functions/imap_general.php on line 157

> 

> After futher debugging, it looks like the pipelined imap commands aren't
> working for me, when getting STATUS (UNSEEN) on all the mailboxes, Only the
> first two work. This propogates up into an empty results array leading the
> the error message in the subject of this post.
> 
> I tried turning chunksize down to 1, but no effect
> 
> 
This is clearly a courier-imap problem now. It's debatable whether
squirrelmail should gracefully handle not getting STATUS (and just
not show it), or do what it currently does and show spew errors.

KB

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Permalink | Reply | 0 comments |
headers
vzmule | 1 Jul 2004 22:13

Forward Bug

Using devel zip, forward when viewing a message works fine, but when
checking off a message from the inbox and clicking on the forward button,
you get the following warnings/errors:

Warning: fopen("../config/$data_dir/GxNXnNSW1ATCmlNz61znAupPnPRElgvQ",
"wb") - No such file or directory in
/usr/share/squirrelmail/src/move_messages.php on line 78

Warning: fwrite(): supplied argument is not a valid File-Handle resource
in /usr/share/squirrelmail/src/move_messages.php on line 79

Warning: fclose(): supplied argument is not a valid File-Handle resource
in /usr/share/squirrelmail/src/move_messages.php on line 80

Warning: Cannot add header information - headers already sent by (output
started at /usr/share/squirrelmail/src/move_messages.php:78) in
/usr/share/squirrelmail/src/move_messages.php on line 238

*Note: Using forward with the message open works fine.

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
(Continue reading)

Permalink | Reply | 3 comments |
headers
p dont think | 2 Jul 2004 03:54

Re: Request for implementing a new hook: internal_link_path

> Could the hook 'internal_link_path' please be implemented in SM?
> In functions/page_header.inc:
> 
>     function makeInternalLink($path, $text, $target='') {
> 	sqgetGlobalVar('base_uri', $base_uri, SQ_SESSION);
> 	if ($target != '') {
> 	    $target = " target=\"$target\"";
> 	}
> +	$origtext = $text;
> 	$hooktext = do_hook_function('internal_link',$text);
> 	if ($hooktext != '')
> 	    $text = $hooktext;
> 
> +	$hookpath = do_hook_function('internal_link_path', $origtext);
> +	if ($hookpath != '')
> +	    $path = $hookpath;
> +       else
> +           $path = $base_uri . $path;
> 
> !	return '<a href="'.$path.'"'.$target.'>'.$text.'</a>';
>     }
> 
> This makes it possible to redirect an internal link to a custom page.
> We want to use this for implementing a completely custom addressbook.
> With the internal_link hook it's also possible but the resulting
> code isn't really clean (close the opened <a> tag and start a new one):

1) I have been threatening for months that the "internal_link" hook 
should be removed.  IIRC, it is currently only used for graphical tweaks 
which will be obsolete with templating and is too costly to keep around
(Continue reading)

Permalink | Reply | 3 comments |
headers
p dont think | 2 Jul 2004 03:54

Re: Request for implementing a new hook: internal_link_path

> Could the hook 'internal_link_path' please be implemented in SM?
> In functions/page_header.inc:
> 
>     function makeInternalLink($path, $text, $target='') {
> 	sqgetGlobalVar('base_uri', $base_uri, SQ_SESSION);
> 	if ($target != '') {
> 	    $target = " target=\"$target\"";
> 	}
> +	$origtext = $text;
> 	$hooktext = do_hook_function('internal_link',$text);
> 	if ($hooktext != '')
> 	    $text = $hooktext;
> 
> +	$hookpath = do_hook_function('internal_link_path', $origtext);
> +	if ($hookpath != '')
> +	    $path = $hookpath;
> +       else
> +           $path = $base_uri . $path;
> 
> !	return '<a href="'.$path.'"'.$target.'>'.$text.'</a>';
>     }
> 
> This makes it possible to redirect an internal link to a custom page.
> We want to use this for implementing a completely custom addressbook.
> With the internal_link hook it's also possible but the resulting
> code isn't really clean (close the opened <a> tag and start a new one):

1) I have been threatening for months that the "internal_link" hook 
should be removed.  IIRC, it is currently only used for graphical tweaks 
which will be obsolete with templating and is too costly to keep around
(Continue reading)

Permalink | Reply | 0 comments |
headers
p dont think | 2 Jul 2004 04:05

Re: Forward Bug


> Using devel zip, forward when viewing a message works fine, but when
> checking off a message from the inbox and clicking on the forward button,
> you get the following warnings/errors:
> 
> Warning: fopen("../config/$data_dir/GxNXnNSW1ATCmlNz61znAupPnPRElgvQ",
> "wb") - No such file or directory in
> /usr/share/squirrelmail/src/move_messages.php on line 78

Does it *REALLY* say "$data_dir" with the dollar sign and all?  What did 
you configure your data directory as?  Include snippet from 
config/config.php.  Or maybe more likely is that your attachments 
directroy setting is wrong.  Again, include more info so we can make 
good recommendations.

  -Paul

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Permalink | Reply | 2 comments |
headers
vzmule | 2 Jul 2004 06:18

Re: Forward Bug

Yes, that's a cut and paste of the exact warnings & error messages.

Data dir is /data and again forward works fine if done with the message open.

>
>> Using devel zip, forward when viewing a message works fine, but when
>> checking off a message from the inbox and clicking on the forward
>> button,
>> you get the following warnings/errors:
>>
>> Warning: fopen("../config/$data_dir/GxNXnNSW1ATCmlNz61znAupPnPRElgvQ",
>> "wb") - No such file or directory in
>> /usr/share/squirrelmail/src/move_messages.php on line 78
>
> Does it *REALLY* say "$data_dir" with the dollar sign and all?  What did
> you configure your data directory as?  Include snippet from
> config/config.php.  Or maybe more likely is that your attachments
> directroy setting is wrong.  Again, include more info so we can make
> good recommendations.
>
>   -Paul
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by Black Hat Briefings & Training.
> Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
> digital self defense, top technical experts, no vendor pitches,
> unmatched networking opportunities. Visit www.blackhat.com
> --
> squirrelmail-devel mailing list
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tomas Kuliavas | 2 Jul 2004 08:54
Picon
Gravatar

Re: Request for implementing a new hook: internal_link_path

> Hello,
> 
> 
> Could the hook 'internal_link_path' please be implemented in SM?
> In functions/page_header.inc:
...
> This makes it possible to redirect an internal link to a custom page.
> We want to use this for implementing a completely custom addressbook.

addressbook page is also accessed in compose windows. Use hooks available in squirrelmail 1.5.1cvs and
insert your addressbook into existing address book structures.

--

-- 
Tomas

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Permalink | Reply | 6 comments |

Gmane