headers
Marc Groot Koerkamp | 1 Sep 2003 19:14
Favicon

Re: Extended Addressbook - VCards

Jimmy Conner said:
> For the last few days I have been doing a little work on the addressbook
> and have successfully gotten it to read/write Vcards (VCFs).
>

Well done Jimmy !

> The addressbook works much in the same way it always did, except now when
> you click on the nickname while in the addressbook, it displays the user's
> info (phone, address, company, birthday, ect..)  It allows you to modify,
> add, delete, any of the information and export it to a VCF file if you
> wish.  This new format requires a new addressbook file ($username.vcf) but
> it detects your old addressbook and converts it for you on the fly
> (possibly remove this later to a plugin).

Tested it and it works :)

A few comments:
* The conversation works great except that default all vCard fields are
added (empty fields included). New vCards do not contain the empty fields
introduced with the conversion. Is it an idea to leave the empty non
required fields out of the vCard?

* When I want to add a new address the new vCard interface doesn't show
up. I only see the vCard interface on editing existing addresses.

* When I'm inside compose and I do a search or list-all in the addressbook
then a few warnings are displayed (error reporting E_ALL)

> Be sure to backup the overridden files first, and to backup
(Continue reading)

Permalink | Reply | 4 comments |
headers
Alex Lemaresquier | 1 Sep 2003 22:18
Picon

[Fwd: [ squirrelmail-Patches-792745 ] non-ascii in folder names]

Hello everybody,
the following patch should be closed for now IMHO, keeping in mind we need
to decide what to do for configuring (conf.pl) special folders requiring
utf7 encoding. I'd vote for storing utf7 encoded folder names in
config.php, for performance issues. The problem is to port squirrelmail
utf7 php code to perl if we want consistency, or use some perl module
which I'm sure already exists somewhere ;) but will probably not handle
every case Tomas has done already. We also could replace conf.pl with php
code I guess, but that's another story...

Another possibility would be to do something like this:
(in load_prefs.php)
$load_sent_folder = getPref($data_dir, $username, 'sent_folder');
if (($load_sent_folder == '') && ($move_to_sent)) {
    require_once(SM_PATH . 'functions/imap_utf7_local.php');
    $sent_folder = $folder_prefix . imap_utf7_encode_local($sent_folder);
    setPref($data_dir, $username, 'sent_folder', $sent_folder);
} else {
    $sent_folder = $load_sent_folder;
}

that way, performance will suffer a little bit but once/folder for all.

Alex.

----------------------------------------------------------------------

Patches item #792745, was opened at 2003-08-21 23:19
Message generated for change (Comment added) made by mabengts
You can respond by visiting:
(Continue reading)

Permalink | Reply | 0 comments |
headers
Brad J. Donison | 2 Sep 2003 04:43
Picon

image_buttons plugins

p dont think said:
[snip]
> Indeed.  Image_buttons is one of those plugins that has been driving us
> crazy.  Brad, if you can really clean it up (preferably a re-write),
> we'd love to have you take that one too, although this one is a plugin
> that I'd personally rather drop altogether...

I have been looking and cleaning a bit. A couple of questions comes to mind
though as this is not a standard plugin anyways. Actually I have found a few
plugins that are more like specific patches to the core code to provide some
extra functionality. Anyways, my questions are:

Will templates ultimately serve this plugin much better than patching core
files like page_header.php and others?

Are there beta templates code / examples out there? I see some code in
functions/html.php that looks like it could be pre-templates code...

Who is working the templates code and are there any vague notions of when
we'll see something working?

I wonder if this would be a good test plugin for templates driven squirrelmail.

Thx,

Brad
--
require_once ('legalese.php');
require_once ('email_EULA.php');
require_once ('standard_disclaimer');
(Continue reading)

Permalink | Reply | 28 comments |
headers
Jonathan Angliss | 2 Sep 2003 05:53
Favicon

Re: Extended Addressbook - VCards

Hello Jimmy,
On Sunday, August 31, 2003, Jimmy Conner wrote...

>>> For the last few days I have been doing a little work on the addressbook
>>> and have successfully gotten it to read/write Vcards (VCFs).
>>
>> The alterations you have made could easily be adapted to make it an
>> "add-on" to the existing system instead of a complete replacement,
>> offering the administrator the option for a simple addressbook, an
>> extended (vcf), or a database.

> Yes, I would very much like it to make it an option instead of a
> drop in. In fact I'm already working on it.

Excellent.  I'd love to see the final code.

> The changes are mostly minor and should be simple to implement.

I had noticed when I did a diff that you changed only a handful of
lines, so making it optional isn't going to be that difficult I'd have
thought.

> I am also going ahead and implementing Groups into it, as I did a
> while back but not got around to committing. That was another
> requested and important feature.

Excellent... that'd be great. Groups is a big thing from what I've
seen, and having it implemented into vCards as well would be great.

> The main question I have now is whether to implement a MySQL version
(Continue reading)

Permalink | Reply | 0 comments |
headers
p dont think | 2 Sep 2003 06:48

RE: [SM-PLUGINS] image_buttons plugins

> > Indeed.  Image_buttons is one of those plugins that has been driving
us
> > crazy.  Brad, if you can really clean it up (preferably a re-write),
> > we'd love to have you take that one too, although this one is a
plugin
> > that I'd personally rather drop altogether...
> 
> I have been looking and cleaning a bit. A couple of questions comes to
mind
> though as this is not a standard plugin anyways. Actually I have found
a few
> plugins that are more like specific patches to the core code to
provide some
> extra functionality. Anyways, my questions are:
> 
> Will templates ultimately serve this plugin much better than patching
core
> files like page_header.php and others?

YES!  That is the general idea.

> Are there beta templates code / examples out there? I see some code in
> functions/html.php that looks like it could be pre-templates code...

Some people have submitted examples they've hacked together on the
mailing lists (usually devel)... there's nothing official yet, though,
so you'll just have to look into one of the many threads about templates
in the archives

> Who is working the templates code and are there any vague notions of
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bradley Donison | 2 Sep 2003 09:05
Picon

hook call for compose button skipped in strings.php

Hi folx,

I was working on the ldifimport plugin, which lead me to fixing the
image_buttons plugin which lead me to finding out that the
functions/strings.php file didn't have a hook call for the compose link, if
javascript was on and compose was set to be done in a new window.

So here is a short few line patch that adds the internal_link hook for the
compose link. Once this is patched, then my new rendition of image_buttons
will work. And with image_buttons now working the ldif_import will work with
SM version 1.2 as well as 1.3 and above. I'll release those later after a bit
more sleep;-)

Watch the possible long line splits on the patch below. This is porbably too
late for inclusion into SM 1.4.2 I presume.

Brad

*** strings.php.orig    2003-07-29 15:29:38.000000000 -0600
--- strings.php 2003-09-02 00:52:04.000000000 -0600
***************
*** 434,439 ****
--- 434,444 ----
      /* if we can use JS, use the fancy window, else just open a new one
HTML-style */
      if($javascript_on) {
          sqgetGlobalVar('base_uri', $base_uri, SQ_SESSION);
+         if ((preg_match('/\/compose\.php/', $base_uri.$url)) &&
(!preg_match('/passed_id=/', $base_uri.$url))) {
+            $hooktext = do_hook_function('internal_link',$text);
(Continue reading)

Permalink | Reply | 23 comments |
headers
Bradley Donison | 2 Sep 2003 09:25
Picon

extra hook calls in page_header.php

Bradley Donison a scris:
> Hi folx,
>
> I was working on the ldifimport plugin, which lead me to fixing the
> image_buttons plugin which lead me to finding out that the
> functions/strings.php file didn't have a hook call for the compose link, if
> javascript was on and compose was set to be done in a new window.
>
> So here is a short few line patch that adds the internal_link hook for the
> compose link. Once this is patched, then my new rendition of image_buttons
> will work. And with image_buttons now working the ldif_import will work with
> SM version 1.2 as well as 1.3 and above. I'll release those later after a bit
> more sleep;-)
>
> Watch the possible long line splits on the patch below. This is porbably too
> late for inclusion into SM 1.4.2 I presume.

And here's the second part of the story. It seems as though there were
unnecessary calls for the hook internal_link in functions/page_header.php

It would call the hook for the compose links on the right side of the frame of
a message read window, but not any of the other links such as message list,
delete, etc... So for consistancy I removed the calls to those hooks for the
links: Forward, Forward as attachment, Reply, Reply All

Now am I mistaken that these were extra unneeded calls or did my changes just
break something else in my install, or potentially break something in my
install. I removed those so that the new image_buttons plugin would look more
consistant and show the images only on the top menu, without this patch it
shows the images on the top menu, PLUS half of the buttons on the read message
(Continue reading)

Permalink | Reply | 6 comments |
headers
Alexandros Vellis | 2 Sep 2003 15:18
X-Face
Picon

Squirrelmail EudoraWeb screenshots

Previously Tomas had posted a request for tests with the minimal_bw
theme for handheld screens etc.... I've tested how Squirrel looks in a
Palm screen, using EudoraWeb (http://www.eudora.com/internetsuite/).

It turns out, in the end the color scheme/chosen theme does not affect
appearance at all, since these browsers usually do not take colors under
consideration at all.

I've used POSE with PalmOS 4 in a PalmIIIxe because that's what I
actually own. :) (Of course I only use it for offline reading, with the
excellent program Plucker, but tha'ts another story).

Take a look:

http://email.uoa.gr/download/misc/squirrel_palm_screenshots/screenshots.html

Main problems or things that could be fixed:

* Table flow sometimes does not follow logical flow. In minimal browsers
such as Lynx, the options screen looks like this: "Personal Preferences
- Display Preferences - Description of personal preferences -
Description of Display preferences".

* Perhaps the frameset can be enhanced to display nicer links, for
instance "Go to Folders List", "Go to INBOX", instead of "frame 1" -
"frame 2". (I'll dig into w3.org/TR and remember how to do it properly,
and might supply a patch).

--

-- 
Alexandros Vellis       University of Athens
(Continue reading)

Permalink | Reply | 2 comments |
headers
Bradley Donison | 2 Sep 2003 16:43
Picon

Re: extra hook calls in page_header.php

Bradley Donison said:

[snip]

> And here's the second part of the story. It seems as though there were
> unnecessary calls for the hook internal_link in functions/page_header.php
>
> It would call the hook for the compose links on the right side of the frame of
> a message read window, but not any of the other links such as message list,
> delete, etc... So for consistancy I removed the calls to those hooks for the
> links: Forward, Forward as attachment, Reply, Reply All
>
> Now am I mistaken that these were extra unneeded calls or did my changes just
> break something else in my install, or potentially break something in my
> install. I removed those so that the new image_buttons plugin would look more
> consistant and show the images only on the top menu, without this patch it
> shows the images on the top menu, PLUS half of the buttons on the read message
> frame as well. The other option would have the hook called for ALL of those
> links, but some of them were placed there via other plugins. Here's the patch
> for functions/page_header.php

If the preferred option is to have the hook called for every link (i.e. call
to makeInternalLink) and not try to filter anything out, then would it hurt to
pass along the $path in the function makeInternalLink? I'm starting to lean
more towards doing the hook for every call to makeInternalLink, and passing
the path so filtering can be done by the plugin. Something like the
do_hook_function call below:

function makeInternalLink($path, $text, $target='') {
    sqgetGlobalVar('base_uri', $base_uri, SQ_SESSION);
(Continue reading)

Permalink | Reply | 4 comments |
headers
Tomas Kuliavas | 2 Sep 2003 19:36
Picon
Gravatar

Re: extra hook calls in page_header.php

> Bradley Donison said:
>
...
> Thoughts, comments, ...

Just suggestion.

Maybe you can also add gd freetype functions (imagettftext) support for
image_buttons plugin while fixing it. gd internal fonts are useless in
i18n environment.
--

-- 
Tomas

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
--
squirrelmail-devel mailing list
List Address: squirrelmail-devel <at> lists.sourceforge.net
List Archives: http://sourceforge.net/mailarchive/forum.php?forum_id=7139
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
Permalink | Reply | 1 comment |

Gmane