jervfors | 1 Jul 2008 09:43
Picon

SF.net SVN: squirrelmail: [13203] trunk/documentation

Revision: 13203
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13203&view=rev
Author:   jervfors
Date:     2008-07-01 00:43:43 -0700 (Tue, 01 Jul 2008)

Log Message:
-----------
Updating copyright.

Modified Paths:
--------------
    trunk/documentation/admin/Makefile
    trunk/documentation/admin/admin.sgml
    trunk/documentation/devel/Makefile
    trunk/documentation/devel/devel.sgml
    trunk/documentation/translator/Makefile
    trunk/documentation/translator/translator.sgml
    trunk/documentation/user/Makefile
    trunk/documentation/user/user.sgml

Modified: trunk/documentation/admin/Makefile
===================================================================
--- trunk/documentation/admin/Makefile	2008-06-30 15:31:04 UTC (rev 13202)
+++ trunk/documentation/admin/Makefile	2008-07-01 07:43:43 UTC (rev 13203)
 <at>  <at>  -1,7 +1,7  <at>  <at> 
 #! /bin/make -f
 # $Id$
 #
-# Copyright (c) 2005-2006 The SquirrelMail Project Team
+# Copyright (c) 2005-2008 The SquirrelMail Project Team
(Continue reading)

pdontthink | 2 Jul 2008 05:30
Picon

SF.net SVN: squirrelmail: [13204] trunk/squirrelmail/functions/ abook_database.php

Revision: 13204
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13204&view=rev
Author:   pdontthink
Date:     2008-07-01 20:30:03 -0700 (Tue, 01 Jul 2008)

Log Message:
-----------
Add error handling to abook db lookups

Modified Paths:
--------------
    trunk/squirrelmail/functions/abook_database.php

Modified: trunk/squirrelmail/functions/abook_database.php
===================================================================
--- trunk/squirrelmail/functions/abook_database.php	2008-07-01 07:43:43 UTC (rev 13203)
+++ trunk/squirrelmail/functions/abook_database.php	2008-07-02 03:30:03 UTC (rev 13204)
 <at>  <at>  -316,8 +316,13  <at>  <at> 
             return false;
         }

+        $db_field = $this->get_field_name($field);
+        if ($db_field == 'ERROR') {
+            return $this->set_error(sprintf(_("Unknown field name: %s"), $field));
+        }
+
         $query = sprintf("SELECT * FROM %s WHERE owner = '%s' AND LOWER(%s) = '%s'",
-                         $this->table, $this->owner, $this->get_field_name($field), 
+                         $this->table, $this->owner, $db_field, 
                          $this->dbh->quoteString($value));
(Continue reading)

pdontthink | 2 Jul 2008 09:33
Picon

SF.net SVN: squirrelmail: [13205] trunk/squirrelmail/functions/ abook_ldap_server.php

Revision: 13205
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13205&view=rev
Author:   pdontthink
Date:     2008-07-02 00:33:27 -0700 (Wed, 02 Jul 2008)

Log Message:
-----------
Add ability to lookup entries based on fields other than nickname.  Thanks to David Hardeman.

Modified Paths:
--------------
    trunk/squirrelmail/functions/abook_ldap_server.php

Modified: trunk/squirrelmail/functions/abook_ldap_server.php
===================================================================
--- trunk/squirrelmail/functions/abook_ldap_server.php	2008-07-02 03:30:03 UTC (rev 13204)
+++ trunk/squirrelmail/functions/abook_ldap_server.php	2008-07-02 07:33:27 UTC (rev 13205)
 <at>  <at>  -12,7 +12,7  <at>  <at> 
  * StartTLS code by John Lane
  *   <starfry at users.sourceforge.net> (#1197703)
  * Code for remove, add, modify, lookup by David Härdeman
- *   <david at 2gen.com> (#1495763)
+ *   <david at hardeman.nu> (#1495763)
  *
  * This backend uses LDAP person (RFC2256), organizationalPerson (RFC2256)
  * and inetOrgPerson (RFC2798) objects and dn, description, sn, givenname,
 <at>  <at>  -424,7 +424,7  <at>  <at> 
             return false;
         }

(Continue reading)

jervfors | 2 Jul 2008 14:17
Picon

SF.net SVN: squirrelmail: [13206] trunk/documentation/admin/admin.sgml

Revision: 13206
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13206&view=rev
Author:   jervfors
Date:     2008-07-02 05:17:16 -0700 (Wed, 02 Jul 2008)

Log Message:
-----------
Removing empty headlines.

Modified Paths:
--------------
    trunk/documentation/admin/admin.sgml

Modified: trunk/documentation/admin/admin.sgml
===================================================================
--- trunk/documentation/admin/admin.sgml	2008-07-02 07:33:27 UTC (rev 13205)
+++ trunk/documentation/admin/admin.sgml	2008-07-02 12:17:16 UTC (rev 13206)
 <at>  <at>  -447,13 +447,13  <at>  <at> 
 You will need:
 <itemize>
   <item>Apache - <url url="http://httpd.apache.org/download.cgi"
-  name="http://httpd.apache.org/download.cgi">
+        name="http://httpd.apache.org/download.cgi">
   <item>PHP - <url url="http://php.net/downloads.php"
-  name="http://php.net/downloads.php">
+        name="http://php.net/downloads.php">
   <item>UW IMAP - <url url="http://www.washington.edu/imap/"
-  name="http://www.washington.edu/imap/">
+        name="http://www.washington.edu/imap/">
   <item>SquirrelMail - <url url="http://squirrelmail.org/download.php"
(Continue reading)

pdontthink | 3 Jul 2008 03:08
Picon

SF.net SVN: squirrelmail: [13207] trunk/squirrelmail/include/init.php

Revision: 13207
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13207&view=rev
Author:   pdontthink
Date:     2008-07-02 18:08:25 -0700 (Wed, 02 Jul 2008)

Log Message:
-----------
Fix prefs_backend hook and remove config_override hook - plugin authors take note

Modified Paths:
--------------
    trunk/squirrelmail/include/init.php

Modified: trunk/squirrelmail/include/init.php
===================================================================
--- trunk/squirrelmail/include/init.php	2008-07-02 12:17:16 UTC (rev 13206)
+++ trunk/squirrelmail/include/init.php	2008-07-03 01:08:25 UTC (rev 13207)
 <at>  <at>  -335,17 +335,7  <at>  <at> 
 /* load prefs system; even when user not logged in, should be OK to do this here */
 require(SM_PATH . 'functions/prefs.php');

-// FIXME: config/plugin_hooks.php has not yet been loaded (see a few lines below); so this hook call
should I think not be working -- has anyone actually tested it?  Is there any reason we cannot move this prefs
code block down below "MAIN PLUGIN LOADING CODE HERE" (see below)?  Reading the code, I *think* it should be
OK, but....   Also, note that this code would then be placed immediately next to the config_override hook,
and since it makes little sense to execute two hooks in a row, I will propose removing config_override
(although sadly, it is less clear to plugin authors that they should use the prefs_backend hook to do any
configuration override work in their plugin)
-$prefs_backend = do_hook('prefs_backend', $null);
-if (isset($prefs_backend) && !empty($prefs_backend) && file_exists(SM_PATH . $prefs_backend)) {
(Continue reading)

pdontthink | 3 Jul 2008 03:39
Picon

SF.net SVN: squirrelmail: [13208] trunk/squirrelmail/src/configtest.php

Revision: 13208
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13208&view=rev
Author:   pdontthink
Date:     2008-07-02 18:39:41 -0700 (Wed, 02 Jul 2008)

Log Message:
-----------
Allow plugin configtest more functionality by including the Compatibility plugin; More precise details
about what plugin has broken setup/config files; Check that plugin updates have been correctly
registered in the static hooks file

Modified Paths:
--------------
    trunk/squirrelmail/src/configtest.php

Modified: trunk/squirrelmail/src/configtest.php
===================================================================
--- trunk/squirrelmail/src/configtest.php	2008-07-03 01:08:25 UTC (rev 13207)
+++ trunk/squirrelmail/src/configtest.php	2008-07-03 01:39:41 UTC (rev 13208)
 <at>  <at>  -116,6 +116,12  <at>  <at> 
     require(SM_PATH . 'config/config_local.php');
 }

+/**
+ * Include Compatibility plugin if available.
+ */
+if (!$disable_plugins && file_exists(SM_PATH . 'plugins/compatibility/functions.php'))
+    include_once(SM_PATH . 'plugins/compatibility/functions.php');
+
 /** Load plugins */
(Continue reading)

kink | 3 Jul 2008 15:48
Picon

SF.net SVN: squirrelmail: [13209] trunk/squirrelmail

Revision: 13209
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13209&view=rev
Author:   kink
Date:     2008-07-03 06:48:39 -0700 (Thu, 03 Jul 2008)

Log Message:
-----------
add style to the hr entity separator

Modified Paths:
--------------
    trunk/squirrelmail/src/read_body.php
    trunk/squirrelmail/templates/default/css/default.css

Modified: trunk/squirrelmail/src/read_body.php
===================================================================
--- trunk/squirrelmail/src/read_body.php	2008-07-03 01:39:41 UTC (rev 13208)
+++ trunk/squirrelmail/src/read_body.php	2008-07-03 13:48:39 UTC (rev 13209)
 <at>  <at>  -961,7 +961,7  <at>  <at> 
 for ($i = 0; $i < $cnt; $i++) {
    $messagebody .= formatBody($imapConnection, $message, $color, $wrap_at, $ent_ar[$i], $passed_id, $mailbox);
    if ($i != $cnt-1) {
-       $messagebody .= '<hr />';
+       $messagebody .= '<hr class="entity_sep" />';
    }
 }

Modified: trunk/squirrelmail/templates/default/css/default.css
===================================================================
--- trunk/squirrelmail/templates/default/css/default.css	2008-07-03 01:39:41 UTC (rev 13208)
(Continue reading)

Paul Lesniewski | 3 Jul 2008 19:35
Favicon

Re: SF.net SVN: squirrelmail: [13209] trunk/squirrelmail

On Thu, Jul 3, 2008 at 6:48 AM,  <kink@...> wrote:
> Revision: 13209
>          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13209&view=rev
> Author:   kink
> Date:     2008-07-03 06:48:39 -0700 (Thu, 03 Jul 2008)
>
> Log Message:
> -----------
> add style to the hr entity separator
>
> Modified Paths:
> --------------
>    trunk/squirrelmail/src/read_body.php
>    trunk/squirrelmail/templates/default/css/default.css
>
> Modified: trunk/squirrelmail/src/read_body.php
> ===================================================================
> --- trunk/squirrelmail/src/read_body.php        2008-07-03 01:39:41 UTC (rev 13208)
> +++ trunk/squirrelmail/src/read_body.php        2008-07-03 13:48:39 UTC (rev 13209)
>  <at>  <at>  -961,7 +961,7  <at>  <at> 
>  for ($i = 0; $i < $cnt; $i++) {
>    $messagebody .= formatBody($imapConnection, $message, $color, $wrap_at, $ent_ar[$i], $passed_id, $mailbox);
>    if ($i != $cnt-1) {
> -       $messagebody .= '<hr />';
> +       $messagebody .= '<hr class="entity_sep" />';

Instead, you might have removed this HTML from the core.  :-)  At the
least, you should put in a FIXME reminder to do so.  This location
seems to be a situation where we just need a separate template for the
horizontal rule tag.  I can take care of it.
(Continue reading)

pdontthink | 3 Jul 2008 19:36
Picon

SF.net SVN: squirrelmail: [13210] trunk/squirrelmail/templates/default

Revision: 13210
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13210&view=rev
Author:   pdontthink
Date:     2008-07-03 10:36:18 -0700 (Thu, 03 Jul 2008)

Log Message:
-----------
Add horizontal rule template and update line break to handle attributes

Modified Paths:
--------------
    trunk/squirrelmail/templates/default/line_break.tpl

Added Paths:
-----------
    trunk/squirrelmail/templates/default/horizontal_rule.tpl

Added: trunk/squirrelmail/templates/default/horizontal_rule.tpl
===================================================================
--- trunk/squirrelmail/templates/default/horizontal_rule.tpl	                        (rev 0)
+++ trunk/squirrelmail/templates/default/horizontal_rule.tpl	2008-07-03 17:36:18 UTC (rev 13210)
 <at>  <at>  -0,0 +1,28  <at>  <at> 
+<?php
+
+/**
+  * horizontal_rule.tpl
+  *
+  * Template for constructing a horizontal rule.
+  *
+  * The following variables are available in this template:
(Continue reading)

pdontthink | 3 Jul 2008 19:42
Picon

SF.net SVN: squirrelmail: [13211] trunk/squirrelmail/src/read_body.php

Revision: 13211
          http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=13211&view=rev
Author:   pdontthink
Date:     2008-07-03 10:42:57 -0700 (Thu, 03 Jul 2008)

Log Message:
-----------
Remove HTML from core (please test)

Modified Paths:
--------------
    trunk/squirrelmail/src/read_body.php

Modified: trunk/squirrelmail/src/read_body.php
===================================================================
--- trunk/squirrelmail/src/read_body.php	2008-07-03 17:36:18 UTC (rev 13210)
+++ trunk/squirrelmail/src/read_body.php	2008-07-03 17:42:57 UTC (rev 13211)
 <at>  <at>  -950,6 +950,8  <at>  <at> 
 /* End of block for handling incoming url vars */
 /***********************************************/

+$oTemplate->assign('aAttribs', array('class' => 'entity_sep'));
+$hr = $oTemplate->fetch('horizontal_rule.tpl');
 $messagebody = '';
 do_hook('read_body_top', $null);
 if ($show_html_default == 1) {
 <at>  <at>  -961,7 +963,7  <at>  <at> 
 for ($i = 0; $i < $cnt; $i++) {
    $messagebody .= formatBody($imapConnection, $message, $color, $wrap_at, $ent_ar[$i], $passed_id, $mailbox);
    if ($i != $cnt-1) {
(Continue reading)


Gmane