pdontthink | 28 Jan 05:45 2015
Picon
Picon

SF.net SVN: squirrelmail:[14499] trunk/squirrelmail/src/configtest.php

Revision: 14499
          http://sourceforge.net/p/squirrelmail/code/14499
Author:   pdontthink
Date:     2015-01-28 04:45:04 +0000 (Wed, 28 Jan 2015)
Log Message:
-----------
Fix uninitialized client IP address.  Thanks to Wuerr Marcus

Modified Paths:
--------------
    trunk/squirrelmail/src/configtest.php

Modified: trunk/squirrelmail/src/configtest.php
===================================================================
--- trunk/squirrelmail/src/configtest.php	2015-01-26 19:57:10 UTC (rev 14498)
+++ trunk/squirrelmail/src/configtest.php	2015-01-28 04:45:04 UTC (rev 14499)
 <at>  <at>  -120,6 +120,9  <at>  <at> 
     require(SM_PATH . 'config/config_local.php');
 }

+sqGetGlobalVar('REMOTE_ADDR',$client_ip,SQ_SERVER);
+sqGetGlobalVar('SERVER_ADDR',$server_ip,SQ_SERVER);
+
 /**
  * Include Compatibility plugin if available.
  */
 <at>  <at>  -175,8 +178,6  <at>  <at> 

 /* Block remote use of script */
 if (! $allow_remote_configtest) {
(Continue reading)

pdontthink | 26 Jan 20:57 2015
Picon
Picon

SF.net SVN: squirrelmail:[14498] branches/SM-1_4-STABLE/squirrelmail/src/ printer_friendly_main.php

Revision: 14498
          http://sourceforge.net/p/squirrelmail/code/14498
Author:   pdontthink
Date:     2015-01-26 19:57:10 +0000 (Mon, 26 Jan 2015)
Log Message:
-----------
Remove unused parameter. Thanks to Juergen Nickelsen

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/printer_friendly_main.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/printer_friendly_main.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/printer_friendly_main.php	2015-01-26 19:54:01 UTC
(rev 14497)
+++ branches/SM-1_4-STABLE/squirrelmail/src/printer_friendly_main.php	2015-01-26 19:57:10 UTC
(rev 14498)
 <at>  <at>  -32,7 +32,7  <at>  <at> 
     $passed_id= (int) $passed_id;
     $view_unsafe_images = (bool) $_GET['view_unsafe_images'];
 /* end globals */
-    displayHtmlHeader( _("Printer Friendly"), '', false, true );
+    displayHtmlHeader( _("Printer Friendly"), '', false );
     echo '<frameset rows="60, *">' . "\n";
     echo '<frame src="printer_friendly_top.php" name="top_frame" '
         . 'scrolling="no" noresize="noresize" frameborder="0" />' . "\n";
 <at>  <at>  -44,4 +44,4  <at>  <at> 
     echo "</frameset>\n";
 }
(Continue reading)

pdontthink | 26 Jan 20:54 2015
Picon
Picon

SF.net SVN: squirrelmail:[14497] branches/SM-1_4-STABLE/squirrelmail/ functions/page_header.php

Revision: 14497
          http://sourceforge.net/p/squirrelmail/code/14497
Author:   pdontthink
Date:     2015-01-26 19:54:01 +0000 (Mon, 26 Jan 2015)
Log Message:
-----------
Add some documentation

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/page_header.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/page_header.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/page_header.php	2015-01-25 01:42:38 UTC (rev 14496)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/page_header.php	2015-01-26 19:54:01 UTC (rev 14497)
 <at>  <at>  -19,7 +19,15  <at>  <at> 

 /* Always set up the language before calling these functions */
 /**
- *  <at> param array $script_libs_param A list of strings, which each point to
+ *  <at> param string $title This is placed directly in the HTML <title> tag,
+ *                      so should be sanitized and ready to go
+ *  <at> param boolean $xtra_param Any additional HTML code that should be
+ *                            included in the <head> tag - this is also
+ *                            sent to the browser as-is, so should be pre-
+ *                            sanitized
+ *  <at> param boolean $do_hook When TRUE, the "generic_header" hook is fired
+ *                         herein.
+ *  <at> param array $script_libs_param A list of strings which each point to
(Continue reading)

pdontthink | 25 Jan 02:42 2015
Picon
Picon

SF.net SVN: squirrelmail:[14496] branches/SM-1_4-STABLE/squirrelmail/ functions/mailbox_display.php

Revision: 14496
          http://sourceforge.net/p/squirrelmail/code/14496
Author:   pdontthink
Date:     2015-01-25 01:42:38 +0000 (Sun, 25 Jan 2015)
Log Message:
-----------
Back out last change; looks like larger - or unrelated - issue

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php	2015-01-19 19:51:09 UTC
(rev 14495)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php	2015-01-25 01:42:38 UTC
(rev 14496)
 <at>  <at>  -204,7 +204,7  <at>  <at> 
     if (!isset($hlt_color)) {
         $hlt_color = $color_string;
     }
-    if ($checkall == 1 || (isset($msg['ID']) && in_array($msg['ID'], $preselected)))
+    if ($checkall == 1 || in_array($msg['ID'], $preselected))
         $checked = ' checked="checked"';
     else
         $checked = '';

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.
(Continue reading)

pdontthink | 19 Jan 20:51 2015
Picon
Picon

SF.net SVN: squirrelmail:[14495] branches/SM-1_4-STABLE/squirrelmail/ functions/mailbox_display.php

Revision: 14495
          http://sourceforge.net/p/squirrelmail/code/14495
Author:   pdontthink
Date:     2015-01-19 19:51:09 +0000 (Mon, 19 Jan 2015)
Log Message:
-----------
Prevent PHP notices

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php	2015-01-19 18:27:15 UTC
(rev 14494)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/mailbox_display.php	2015-01-19 19:51:09 UTC
(rev 14495)
 <at>  <at>  -204,13 +204,12  <at>  <at> 
     if (!isset($hlt_color)) {
         $hlt_color = $color_string;
     }
-    if ($checkall == 1 || in_array($msg['ID'], $preselected))
+    if ($checkall == 1 || (isset($msg['ID']) && in_array($msg['ID'], $preselected)))
         $checked = ' checked="checked"';
     else
         $checked = '';
     $col = 0;
     $msg['SUBJECT'] = decodeHeader($msg['SUBJECT']);
-//    $subject = processSubject($msg['SUBJECT'], $indent_array[$msg['ID']]);
(Continue reading)

pdontthink | 19 Jan 19:27 2015
Picon
Picon

SF.net SVN: squirrelmail:[14494] trunk/squirrelmail/functions/addressbook. php

Revision: 14494
          http://sourceforge.net/p/squirrelmail/code/14494
Author:   pdontthink
Date:     2015-01-19 18:27:15 +0000 (Mon, 19 Jan 2015)
Log Message:
-----------
Fix PHP notice - this function is called statically, so needs to be declared as such.  Thanks to Juergen
Nickelsen for reporting

Modified Paths:
--------------
    trunk/squirrelmail/functions/addressbook.php

Modified: trunk/squirrelmail/functions/addressbook.php
===================================================================
--- trunk/squirrelmail/functions/addressbook.php	2015-01-19 18:22:19 UTC (rev 14493)
+++ trunk/squirrelmail/functions/addressbook.php	2015-01-19 18:27:15 UTC (rev 14494)
 <at>  <at>  -514,7 +514,7  <at>  <at> 
      *  <at> param array $row address book entry
      *  <at> return string email address with real name prepended
      */
-    function full_address($row) {
+    static function full_address($row) {
         global $data_dir, $username, $addrsrch_fullname;

         // allow multiple addresses in one row (poor person's grouping - bah)

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.

(Continue reading)

pdontthink | 19 Jan 19:22 2015
Picon
Picon

SF.net SVN: squirrelmail:[14493] branches/SM-1_4-STABLE/squirrelmail/ functions/addressbook.php

Revision: 14493
          http://sourceforge.net/p/squirrelmail/code/14493
Author:   pdontthink
Date:     2015-01-19 18:22:19 +0000 (Mon, 19 Jan 2015)
Log Message:
-----------
Fix PHP notice - this function is called statically, so needs to be declared as such.  Thanks to Juergen
Nickelsen for reporting

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php	2015-01-09 07:24:26 UTC (rev 14492)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php	2015-01-19 18:22:19 UTC (rev 14493)
 <at>  <at>  -350,7 +350,7  <at>  <at> 
      * nickname optionally prepended.
      */

-    function full_address($row) {
+    static function full_address($row) {
         global $data_dir, $username;
         $addrsrch_fullname = getPref($data_dir, $username, 'addrsrch_fullname', 'fullname');

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.

------------------------------------------------------------------------------
(Continue reading)

pdontthink | 9 Jan 08:24 2015
Picon
Picon

SF.net SVN: squirrelmail:[14491] branches/SM-1_4-STABLE/squirrelmail/ plugins/listcommands

Revision: 14491
          http://sourceforge.net/p/squirrelmail/code/14491
Author:   pdontthink
Date:     2015-01-09 07:24:03 +0000 (Fri, 09 Jan 2015)
Log Message:
-----------
Make sure the correct identity is used for list command mailto actions

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/mailout.php
    branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/setup.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/mailout.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/mailout.php	2015-01-09 06:10:11
UTC (rev 14490)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/mailout.php	2015-01-09 07:24:03
UTC (rev 14491)
 <at>  <at>  -27,6 +27,7  <at>  <at> 
 sqgetGlobalVar('subject', $subject, SQ_GET);
 sqgetGlobalVar('body',    $body,    SQ_GET);
 sqgetGlobalVar('action',  $action,  SQ_GET);
+sqgetGlobalVar('identity',  $identity,  SQ_GET);

 switch ( $action ) {
 case 'help':
 <at>  <at>  -64,8 +65,10  <at>  <at> 
 if (count($idents) > 1) {
     echo '<select name="identity">';
(Continue reading)

pdontthink | 9 Jan 08:24 2015
Picon
Picon

SF.net SVN: squirrelmail:[14492] trunk/squirrelmail/plugins/listcommands

Revision: 14492
          http://sourceforge.net/p/squirrelmail/code/14492
Author:   pdontthink
Date:     2015-01-09 07:24:26 +0000 (Fri, 09 Jan 2015)
Log Message:
-----------
Make sure the correct identity is used for list command mailto actions

Modified Paths:
--------------
    trunk/squirrelmail/plugins/listcommands/functions.php
    trunk/squirrelmail/plugins/listcommands/mailout.php
    trunk/squirrelmail/plugins/listcommands/templates/default/mailout.tpl

Modified: trunk/squirrelmail/plugins/listcommands/functions.php
===================================================================
--- trunk/squirrelmail/plugins/listcommands/functions.php	2015-01-09 07:24:03 UTC (rev 14491)
+++ trunk/squirrelmail/plugins/listcommands/functions.php	2015-01-09 07:24:26 UTC (rev 14492)
 <at>  <at>  -90,20 +90,39  <at>  <at> 

         if ($proto == 'mailto') {

+            $identity = '';
+
             if (($cmd == 'post') || ($cmd == 'owner')) {
                 $url = 'src/compose.php?'.
                     (isset($startMessage)?'startMessage='.$startMessage.'&amp;':'');
             } else {
                 $url = "plugins/listcommands/mailout.php?action=$cmd&amp;";
+
(Continue reading)

pdontthink | 9 Jan 07:10 2015
Picon
Picon

SF.net SVN: squirrelmail:[14490] trunk/squirrelmail/plugins/listcommands/ functions.php

Revision: 14490
          http://sourceforge.net/p/squirrelmail/code/14490
Author:   pdontthink
Date:     2015-01-09 06:10:11 +0000 (Fri, 09 Jan 2015)
Log Message:
-----------
Ah, I see - the stuff after the ? needs to be handed to src/compose.php as-is, no encoding.

Modified Paths:
--------------
    trunk/squirrelmail/plugins/listcommands/functions.php

Modified: trunk/squirrelmail/plugins/listcommands/functions.php
===================================================================
--- trunk/squirrelmail/plugins/listcommands/functions.php	2015-01-09 06:08:55 UTC (rev 14489)
+++ trunk/squirrelmail/plugins/listcommands/functions.php	2015-01-09 06:10:11 UTC (rev 14490)
 <at>  <at>  -84,6 +84,7  <at>  <at> 

         /* proto = {mailto,href} */
         $aActions = array_keys($actions);
+        // note that we only use the first cmd/action, ignore the rest
         $proto = array_shift($aActions);
         $act   = array_shift($actions);

 <at>  <at>  -95,8 +96,18  <at>  <at> 
             } else {
                 $url = "plugins/listcommands/mailout.php?action=$cmd&amp;";
             }
-            $url .= 'send_to=' . urlencode($act);

(Continue reading)

pdontthink | 9 Jan 07:08 2015
Picon
Picon

SF.net SVN: squirrelmail:[14489] branches/SM-1_4-STABLE/squirrelmail/ plugins/listcommands/setup.php

Revision: 14489
          http://sourceforge.net/p/squirrelmail/code/14489
Author:   pdontthink
Date:     2015-01-09 06:08:55 +0000 (Fri, 09 Jan 2015)
Log Message:
-----------
Ah, I see - the stuff after the ? needs to be handed to src/compose.php as-is, no encoding.

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/setup.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/setup.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/setup.php	2015-01-09 05:21:57
UTC (rev 14488)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/listcommands/setup.php	2015-01-09 06:08:55
UTC (rev 14489)
 <at>  <at>  -48,6 +48,7  <at>  <at> 

         /* proto = {mailto,href} */
         $aActionKeys = array_keys($actions);
+        // note that we only use the first cmd/action, ignore the rest
         $proto = array_shift($aActionKeys);
         $act   = array_shift($actions);

 <at>  <at>  -59,8 +60,18  <at>  <at> 
             } else {
                 $url = "plugins/listcommands/mailout.php?action=$cmd&amp;";
             }
(Continue reading)


Gmane