pdontthink | 1 Aug 04:28 2014
Picon
Picon

SF.net SVN: squirrelmail:[14474] trunk/squirrelmail

Revision: 14474
          http://sourceforge.net/p/squirrelmail/code/14474
Author:   pdontthink
Date:     2014-08-01 02:28:12 +0000 (Fri, 01 Aug 2014)
Log Message:
-----------
Prevent session lock-up caused by filters plugin trying to move messages in an account that is over quota

Modified Paths:
--------------
    trunk/squirrelmail/doc/ChangeLog
    trunk/squirrelmail/plugins/filters/filters.php

Modified: trunk/squirrelmail/doc/ChangeLog
===================================================================
--- trunk/squirrelmail/doc/ChangeLog	2014-08-01 02:27:37 UTC (rev 14473)
+++ trunk/squirrelmail/doc/ChangeLog	2014-08-01 02:28:12 UTC (rev 14474)
 <at>  <at>  -393,6 +393,8  <at>  <at> 
     file or "4.  General Options ==> 21. Display login error from IMAP" 
     in the configuration tool.
   - Configuration tool now shows the SquirrelMail version
+  - Prevent session lock-up caused by filters plugin trying to move
+    messages in an account that is over quota.

 Version 1.5.1 (branched on 2006-02-12)
 --------------------------------------

Modified: trunk/squirrelmail/plugins/filters/filters.php
===================================================================
--- trunk/squirrelmail/plugins/filters/filters.php	2014-08-01 02:27:37 UTC (rev 14473)
(Continue reading)

pdontthink | 1 Aug 04:27 2014
Picon
Picon

SF.net SVN: squirrelmail:[14473] branches/SM-1_4-STABLE/squirrelmail

Revision: 14473
          http://sourceforge.net/p/squirrelmail/code/14473
Author:   pdontthink
Date:     2014-08-01 02:27:37 +0000 (Fri, 01 Aug 2014)
Log Message:
-----------
Prevent session lock-up caused by filters plugin trying to move messages in an account that is over quota

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
    branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php

Modified: branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2014-08-01 02:26:11 UTC (rev 14472)
+++ branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2014-08-01 02:27:37 UTC (rev 14473)
 <at>  <at>  -79,6 +79,8  <at>  <at> 
   - When resuming a draft, correct (from) identity is now pre-selected
   - Removed overly-restrictive character limitations on address book
     nicknames
+  - Prevent session lock-up caused by filters plugin trying to move
+    messages in an account that is over quota

 Version 1.4.22 - 12 July 2011
 -----------------------------

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php	2014-08-01 02:26:11 UTC
(Continue reading)

pdontthink | 1 Aug 04:26 2014
Picon
Picon

SF.net SVN: squirrelmail:[14472] trunk/squirrelmail/functions/imap_general. php

Revision: 14472
          http://sourceforge.net/p/squirrelmail/code/14472
Author:   pdontthink
Date:     2014-08-01 02:26:11 +0000 (Fri, 01 Aug 2014)
Log Message:
-----------
Add session variables that store information about most recent fatal IMAP error

Modified Paths:
--------------
    trunk/squirrelmail/functions/imap_general.php

Modified: trunk/squirrelmail/functions/imap_general.php
===================================================================
--- trunk/squirrelmail/functions/imap_general.php	2014-08-01 02:24:02 UTC (rev 14471)
+++ trunk/squirrelmail/functions/imap_general.php	2014-08-01 02:26:11 UTC (rev 14472)
 <at>  <at>  -616,22 +616,34  <at>  <at> 
     case 'NO':
         /* ignore this error from M$ exchange, it is not fatal (aka bug) */
         if (strstr($message[$tag], 'command resulted in') === false) {
+            sqsession_register('NO', 'IMAP_FATAL_ERROR_TYPE');
+            sqsession_register($query, 'IMAP_FATAL_ERROR_QUERY');
+            sqsession_register($message[$tag], 'IMAP_FATAL_ERROR_MESSAGE');
             sqimap_error_box(_("ERROR: Could not complete request."), $query, _("Reason Given:") . ' ', $message[$tag]);
             echo '</body></html>';
             exit;
         }
         break;
     case 'BAD':
+        sqsession_register('BAD', 'IMAP_FATAL_ERROR_TYPE');
(Continue reading)

pdontthink | 1 Aug 04:24 2014
Picon
Picon

SF.net SVN: squirrelmail:[14471] branches/SM-1_4-STABLE/squirrelmail/ functions/imap_general.php

Revision: 14471
          http://sourceforge.net/p/squirrelmail/code/14471
Author:   pdontthink
Date:     2014-08-01 02:24:02 +0000 (Fri, 01 Aug 2014)
Log Message:
-----------
Add session variables that store information about most recent fatal IMAP error

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/imap_general.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/imap_general.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/imap_general.php	2014-07-01 03:16:14 UTC
(rev 14470)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/imap_general.php	2014-08-01 02:24:02 UTC
(rev 14471)
 <at>  <at>  -393,6 +393,9  <at>  <at> 
     case 'NO':
         /* ignore this error from M$ exchange, it is not fatal (aka bug) */
         if (strstr($message, 'command resulted in') === false) {
+            sqsession_register('NO', 'IMAP_FATAL_ERROR_TYPE');
+            sqsession_register($query, 'IMAP_FATAL_ERROR_QUERY');
+            sqsession_register($message, 'IMAP_FATAL_ERROR_MESSAGE');
             set_up_language($squirrelmail_language);
             require_once(SM_PATH . 'functions/display_messages.php');
             $string = "<b><font color=\"$color[2]\">\n" .
 <at>  <at>  -408,6 +411,9  <at>  <at> 
         }
(Continue reading)

pdontthink | 1 Jul 05:16 2014
Picon
Picon

SF.net SVN: squirrelmail:[14470] branches/SM-1_4-STABLE/squirrelmail/ plugins/filters/filters.php

Revision: 14470
          http://sourceforge.net/p/squirrelmail/code/14470
Author:   pdontthink
Date:     2014-07-01 03:16:14 +0000 (Tue, 01 Jul 2014)
Log Message:
-----------
Small change to error text

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php	2014-07-01 03:15:53 UTC
(rev 14469)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php	2014-07-01 03:16:14 UTC
(rev 14470)
 <at>  <at>  -370,7 +370,7  <at>  <at> 
                     // if errors occurred, don't try to filter again during this session
                     sqsession_register(TRUE, 'filters_error');
                     global $color;
-                    error_box(_("A problem occurred filtering messages. Check filter folders and account quota if
applicable. Filtering is disabled for the remainder of this login session."), $color);
+                    error_box(_("A problem occurred filtering messages. Check filter settings and account quota if
applicable. Filtering is disabled for the remainder of this login session."), $color);
                     // we stil return info about what was successfully
                     // filtered before this error occurred
                     return $del_id;

(Continue reading)

pdontthink | 1 Jul 05:15 2014
Picon
Picon

SF.net SVN: squirrelmail:[14469] trunk/squirrelmail/plugins/filters/filters .php

Revision: 14469
          http://sourceforge.net/p/squirrelmail/code/14469
Author:   pdontthink
Date:     2014-07-01 03:15:53 +0000 (Tue, 01 Jul 2014)
Log Message:
-----------
If filtering fails, say due to account quota issues, disable for remaineder of login session.  This plugin
appears to have a more serious issue that corrupts folder cache in subfolders of INBOX

Modified Paths:
--------------
    trunk/squirrelmail/plugins/filters/filters.php

Modified: trunk/squirrelmail/plugins/filters/filters.php
===================================================================
--- trunk/squirrelmail/plugins/filters/filters.php	2014-07-01 01:52:00 UTC (rev 14468)
+++ trunk/squirrelmail/plugins/filters/filters.php	2014-07-01 03:15:53 UTC (rev 14469)
 <at>  <at>  -10,6 +10,7  <at>  <at> 
  *  <at> subpackage filters
  */

+// TODO: This plugin has an issue that seems to corrupt folder cache for subfolders of INBOX
 /**
  * do not allow to call this file directly
  */
 <at>  <at>  -194,6 +195,12  <at>  <at> 
            $imapConnection, $UseSeparateImapConnection, $AllowSpamFilters,
            $filter_inbox_count, $username;

+    // if there were filtering errors previously during
(Continue reading)

pdontthink | 1 Jul 03:52 2014
Picon
Picon

SF.net SVN: squirrelmail:[14468] branches/SM-1_4-STABLE/squirrelmail/ plugins/filters/filters.php

Revision: 14468
          http://sourceforge.net/p/squirrelmail/code/14468
Author:   pdontthink
Date:     2014-07-01 01:52:00 +0000 (Tue, 01 Jul 2014)
Log Message:
-----------
If filtering fails, say due to account quota issues, disable for remaineder of login session

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php	2014-07-01 01:50:42 UTC
(rev 14467)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php	2014-07-01 01:52:00 UTC
(rev 14468)
 <at>  <at>  -184,6 +184,12  <at>  <at> 
            $imap_general, $filters, $imap_stream, $imapConnection,
            $UseSeparateImapConnection, $AllowSpamFilters;

+    // if there were filtering errors previously during
+    // this login session, we won't try again
+    sqgetGlobalVar('filters_error', $filters_error, SQ_SESSION, FALSE);
+    if ($filters_error)
+        return;
+
     sqgetGlobalVar('username', $username, SQ_SESSION);
     sqgetGlobalVar('key',      $key,      SQ_COOKIE);
(Continue reading)

pdontthink | 1 Jul 03:50 2014
Picon
Picon

SF.net SVN: squirrelmail:[14467] branches/SM-1_4-STABLE/squirrelmail/ functions/imap_messages.php

Revision: 14467
          http://sourceforge.net/p/squirrelmail/code/14467
Author:   pdontthink
Date:     2014-07-01 01:50:42 +0000 (Tue, 01 Jul 2014)
Log Message:
-----------
Someone didn't check that sqimap_toggle_flag() wasn't returning anything before using its return value

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/imap_messages.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/imap_messages.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/imap_messages.php	2014-06-16 07:27:02 UTC
(rev 14466)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/imap_messages.php	2014-07-01 01:50:42 UTC
(rev 14467)
 <at>  <at>  -44,7 +44,7  <at>  <at> 
  * Moves a set of messages ($id) to another mailbox ($mailbox)
  * 
  *  <at> param int    $imap_stream   The resource ID for the IMAP socket
- *  <at> param mixed  $id            A string or array of messages to copy
+ *  <at> param mixed  $id            A string or array of messages to move
  *  <at> param string $mailbox       The destination mailbox
  *  <at> param bool   $handle_errors Show error messages in case of a NO, BAD, or BYE response
  *
 <at>  <at>  -1176,7 +1176,7  <at>  <at> 
     global $uid_support;
     $msgs_id = sqimap_message_list_squisher($id);
(Continue reading)

pdontthink | 16 Jun 09:27 2014
Picon
Picon

SF.net SVN: squirrelmail:[14466] branches/SM-1_4-STABLE/squirrelmail

Revision: 14466
          http://sourceforge.net/p/squirrelmail/code/14466
Author:   pdontthink
Date:     2014-06-16 07:27:02 +0000 (Mon, 16 Jun 2014)
Log Message:
-----------
Remove senseless restrictions on abook nicknames - this appears to be a remnant from SM version 1.0 where
the local-file backend didn't sanitize anything, although why it didn't also test values for the other
fields is beyond me.  These days the two standard backends quote all their values.

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
    branches/SM-1_4-STABLE/squirrelmail/functions/abook_database.php
    branches/SM-1_4-STABLE/squirrelmail/functions/abook_local_file.php
    branches/SM-1_4-STABLE/squirrelmail/functions/addressbook.php

Modified: branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2014-05-15 20:04:51 UTC (rev 14465)
+++ branches/SM-1_4-STABLE/squirrelmail/doc/ChangeLog	2014-06-16 07:27:02 UTC (rev 14466)
 <at>  <at>  -77,6 +77,8  <at>  <at> 
   - Configuration tool now shows the SquirrelMail version
   - Added new attachments_top hook to src/read_body.php
   - When resuming a draft, correct (from) identity is now pre-selected
+  - Removed overly-restrictive character limitations on address book
+    nicknames

 Version 1.4.22 - 12 July 2011
 -----------------------------
(Continue reading)

pdontthink | 15 May 22:04 2014
Picon
Picon

SF.net SVN: squirrelmail:[14465] branches/SM-1_4-STABLE/squirrelmail/ scripts/reload_page.js

Revision: 14465
          http://sourceforge.net/p/squirrelmail/code/14465
Author:   pdontthink
Date:     2014-05-15 20:04:51 +0000 (Thu, 15 May 2014)
Log Message:
-----------
Make sure folder list refresh gets non-empty response

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/scripts/reload_page.js

Modified: branches/SM-1_4-STABLE/squirrelmail/scripts/reload_page.js
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/scripts/reload_page.js	2014-05-15 20:02:48 UTC (rev 14464)
+++ branches/SM-1_4-STABLE/squirrelmail/scripts/reload_page.js	2014-05-15 20:04:51 UTC (rev 14465)
 <at>  <at>  -76,10 +76,11  <at>  <at> 
 {
    if (use_advanced_page_reload)
       sm_send_request("GET", window.location.href, "", "replace_document", false,
-                      reload_request_timeout, "server_or_connect_error", false, "", false);
+                      reload_request_timeout, 1000, "server_or_connect_error", false, "", false);
    else
+      // images/spacer.png is exactly 68 bytes in size
       sm_send_request("GET", base_uri + "images/spacer.png", "", "reload_now", false,
-                      reload_request_timeout, "server_or_connect_error", false, "", true);
+                      reload_request_timeout, 68, "server_or_connect_error", false, "", true);
 }

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
(Continue reading)

pdontthink | 15 May 22:02 2014
Picon
Picon

SF.net SVN: squirrelmail:[14464] branches/SM-1_4-STABLE/squirrelmail/ scripts/remote_request.js

Revision: 14464
          http://sourceforge.net/p/squirrelmail/code/14464
Author:   pdontthink
Date:     2014-05-15 20:02:48 +0000 (Thu, 15 May 2014)
Log Message:
-----------
Allow caller to specify a minimum required response size

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/scripts/remote_request.js

Modified: branches/SM-1_4-STABLE/squirrelmail/scripts/remote_request.js
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/scripts/remote_request.js	2014-05-15 18:48:55 UTC (rev 14463)
+++ branches/SM-1_4-STABLE/squirrelmail/scripts/remote_request.js	2014-05-15 20:02:48 UTC (rev 14464)
 <at>  <at>  -136,6 +136,9  <at>  <at> 
   *  <at> param int  max_wait  If the request should time out (cancel itself) after a certain
   *                       time, this is the desired number of seconds (set to zero not to
   *                       use this functionality)
+  *  <at> param int  minimum_response_size  When set to anything greater than zero, the
+  *                                    response size must be equal to or greater than this,
+  *                                    otherwise an error will be triggered (code 599)
   *  <at> param string  error_function  The name of the function that will be called if any
   *                                error occurs (beside timeout). It will be called with
   *                                two parameters: the error code and error message (note
 <at>  <at>  -153,8 +156,9  <at>  <at> 
   *
   */
 function sm_send_request(method, uri, content, result_function, result_in_xml,
(Continue reading)


Gmane