pdontthink | 30 May 10:15 2016
Picon
Picon

SF.net SVN: squirrelmail:[14556] trunk/squirrelmail/src/compose.php

Revision: 14556
          http://sourceforge.net/p/squirrelmail/code/14556
Author:   pdontthink
Date:     2016-05-30 08:15:26 +0000 (Mon, 30 May 2016)
Log Message:
-----------
Allow priority and identity selections to be given by callers. Looks to have been intended to work this way,
but never tested.

Modified Paths:
--------------
    trunk/squirrelmail/src/compose.php

Modified: trunk/squirrelmail/src/compose.php
===================================================================
--- trunk/squirrelmail/src/compose.php	2016-05-30 08:14:48 UTC (rev 14555)
+++ trunk/squirrelmail/src/compose.php	2016-05-30 08:15:26 UTC (rev 14556)
 <at>  <at>  -73,6 +73,7  <at>  <at> 
 }
 sqgetGlobalVar('session',$session, $SQ_GLOBAL);
 sqgetGlobalVar('mailbox',$mailbox, $SQ_GLOBAL);
+sqgetGlobalVar('identity',$orig_identity, $SQ_GLOBAL);
 if(!sqgetGlobalVar('identity',$identity, $SQ_GLOBAL)) {
     $identity=0;
 }
 <at>  <at>  -753,6 +754,12  <at>  <at> 
     if (isset($subject)) {
         $values['subject'] = $subject;
     }
+    if (isset($mailprio)) {
(Continue reading)

pdontthink | 30 May 10:14 2016
Picon
Picon

SF.net SVN: squirrelmail:[14555] branches/SM-1_4-STABLE/squirrelmail/src/ compose.php

Revision: 14555
          http://sourceforge.net/p/squirrelmail/code/14555
Author:   pdontthink
Date:     2016-05-30 08:14:48 +0000 (Mon, 30 May 2016)
Log Message:
-----------
Allow priority and identity selections to be given by callers. Looks to have been intended to work this way,
but never tested.

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/compose.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/compose.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/compose.php	2016-05-07 03:21:38 UTC (rev 14554)
+++ branches/SM-1_4-STABLE/squirrelmail/src/compose.php	2016-05-30 08:14:48 UTC (rev 14555)
 <at>  <at>  -72,6 +72,7  <at>  <at> 
 }
 sqgetGlobalVar('session',$session, $SQ_GLOBAL);
 sqgetGlobalVar('mailbox',$mailbox, $SQ_GLOBAL);
+sqgetGlobalVar('identity',$orig_identity, $SQ_GLOBAL);
 if ( !sqgetGlobalVar('identity',$identity, $SQ_GLOBAL) ) {
     $identity = 0;
 }
 <at>  <at>  -679,6 +680,12  <at>  <at> 
     if (isset($subject)) {
         $values['subject'] = $subject;
     }
+    if (isset($mailprio)) {
(Continue reading)

pdontthink | 7 May 05:21 2016
Picon
Picon

SF.net SVN: squirrelmail:[14554] branches/SM-1_4-STABLE/squirrelmail/ functions/options.php

Revision: 14554
          http://sourceforge.net/p/squirrelmail/code/14554
Author:   pdontthink
Date:     2016-05-07 03:21:38 +0000 (Sat, 07 May 2016)
Log Message:
-----------
Allow option widget trailing text to be rendered smaller

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/options.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/options.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/options.php	2016-05-06 20:12:50 UTC (rev 14553)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/options.php	2016-05-07 03:21:38 UTC (rev 14554)
 <at>  <at>  -83,6 +83,7  <at>  <at> 
     var $script;
     var $post_script;
     var $trailing_text;
+    var $trailing_text_small;
     var $yes_text;
     var $no_text;
     var $use_add_widget;
 <at>  <at>  -116,6 +117,7  <at>  <at> 
         $this->script = '';
         $this->post_script = '';
         $this->trailing_text = '';
+        $this->trailing_text_small = FALSE;
         $this->yes_text = '';
(Continue reading)

pdontthink | 6 May 22:12 2016
Picon
Picon

SF.net SVN: squirrelmail:[14553] branches/SM-1_4-STABLE/squirrelmail/ functions/options.php

Revision: 14553
          http://sourceforge.net/p/squirrelmail/code/14553
Author:   pdontthink
Date:     2016-05-06 20:12:50 +0000 (Fri, 06 May 2016)
Log Message:
-----------
Fix spacing

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/options.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/options.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/options.php	2016-04-06 05:33:06 UTC (rev 14552)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/options.php	2016-05-06 20:12:50 UTC (rev 14553)
 <at>  <at>  -475,7 +475,7  <at>  <at> 
         }

         /* Close the select tag and return our happy result. */
-        $result .= '</select>' . sm_encode_html_special_chars($this->trailing_text) . "\n";
+        $result .= '</select> ' . sm_encode_html_special_chars($this->trailing_text) . "\n";
         return $result;
     }

 <at>  <at>  -558,7 +558,7  <at>  <at> 
             $result .= $new_option;
         }
         /* Close the select tag and return our happy result. */
-        $result .= '</select>' . sm_encode_html_special_chars($this->trailing_text) . "\n";
(Continue reading)

pdontthink | 6 Apr 07:33 2016
Picon
Picon

SF.net SVN: squirrelmail:[14552] trunk/squirrelmail/functions/global.php

Revision: 14552
          http://sourceforge.net/p/squirrelmail/code/14552
Author:   pdontthink
Date:     2016-04-06 05:33:06 +0000 (Wed, 06 Apr 2016)
Log Message:
-----------
Per comments in the commit - setting the session cookie over and over can be troublesome, but doing the
obvious and defaulting to *replace* cookies causes logins to fail due to something I don't care to debug -
session cookie is complex through all the pages involved in a login request - instead we use a simple static
cache to prevent useless duplicate cookie headers

Modified Paths:
--------------
    trunk/squirrelmail/functions/global.php

Modified: trunk/squirrelmail/functions/global.php
===================================================================
--- trunk/squirrelmail/functions/global.php	2016-04-06 05:27:52 UTC (rev 14551)
+++ trunk/squirrelmail/functions/global.php	2016-04-06 05:33:06 UTC (rev 14552)
 <at>  <at>  -589,6 +589,21  <at>  <at> 
 function sqsetcookie($sName, $sValue='deleted', $iExpire=0, $sPath="", $sDomain="",
                      $bSecure=false, $bHttpOnly=true, $bReplace=false) {

+    // some environments can get overwhelmed by an excessive
+    // setting of the same cookie over and over (e.g., many
+    // calls to this function via sqsession_is_active() result
+    // in repeated setting of the session cookie when $bReplace
+    // is FALSE, but something odd happens (during login only)
+    // if we change that to default TRUE) ... so we keep our own
+    // naive per-request name/value cache and only set the cookie
(Continue reading)

pdontthink | 6 Apr 07:27 2016
Picon
Picon

SF.net SVN: squirrelmail:[14551] branches/SM-1_4-STABLE/squirrelmail/ functions/global.php

Revision: 14551
          http://sourceforge.net/p/squirrelmail/code/14551
Author:   pdontthink
Date:     2016-04-06 05:27:52 +0000 (Wed, 06 Apr 2016)
Log Message:
-----------
Previous change causes logins to fail, due to something I don't care to debug - session cookie is complex
through all the pages involved in a login request - instead we revert the last commit and use a simple static
cache to prevent useless duplicate cookie headers

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/global.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/global.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/global.php	2016-04-06 04:52:09 UTC (rev 14550)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/global.php	2016-04-06 05:27:52 UTC (rev 14551)
 <at>  <at>  -511,8 +511,23  <at>  <at> 
  *
  */
 function sqsetcookie($sName, $sValue='deleted', $iExpire=0, $sPath="", $sDomain="",
-                     $bSecure=false, $bHttpOnly=true, $bReplace=true) {
+                     $bSecure=false, $bHttpOnly=true, $bReplace=false) {

+    // some environments can get overwhelmed by an excessive
+    // setting of the same cookie over and over (e.g., many
+    // calls to this function via sqsession_is_active() result
+    // in repeated setting of the session cookie when $bReplace
+    // is FALSE, but something odd happens (during login only)
(Continue reading)

pdontthink | 6 Apr 06:52 2016
Picon
Picon

SF.net SVN: squirrelmail:[14550] branches/SM-1_4-STABLE/squirrelmail/ functions/global.php

Revision: 14550
          http://sourceforge.net/p/squirrelmail/code/14550
Author:   pdontthink
Date:     2016-04-06 04:52:09 +0000 (Wed, 06 Apr 2016)
Log Message:
-----------
Why did we default to putting multiple cookie headers for same name? I think this may have been a mistake,
please give heads up if this creates any problems; if it was intentional

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/functions/global.php

Modified: branches/SM-1_4-STABLE/squirrelmail/functions/global.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/functions/global.php	2016-02-01 18:22:40 UTC (rev 14549)
+++ branches/SM-1_4-STABLE/squirrelmail/functions/global.php	2016-04-06 04:52:09 UTC (rev 14550)
 <at>  <at>  -511,7 +511,7  <at>  <at> 
  *
  */
 function sqsetcookie($sName, $sValue='deleted', $iExpire=0, $sPath="", $sDomain="",
-                     $bSecure=false, $bHttpOnly=true, $bReplace=false) {
+                     $bSecure=false, $bHttpOnly=true, $bReplace=true) {

     // if we have a secure connection then limit the cookies to https only.
     global $is_secure_connection;

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.

(Continue reading)

pdontthink | 1 Feb 19:22 2016
Picon
Picon

SF.net SVN: squirrelmail:[14549] branches/SM-1_4-STABLE/squirrelmail/src/ help.php

Revision: 14549
          http://sourceforge.net/p/squirrelmail/code/14549
Author:   pdontthink
Date:     2016-02-01 18:22:40 +0000 (Mon, 01 Feb 2016)
Log Message:
-----------
Add more accurate error reporting

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/help.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/help.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/help.php	2016-02-01 10:36:15 UTC (rev 14548)
+++ branches/SM-1_4-STABLE/squirrelmail/src/help.php	2016-02-01 18:22:40 UTC (rev 14549)
 <at>  <at>  -158,17 +158,27  <at>  <at> 
     // Get the chapter numbers, title and decriptions.
     for ($i=0, $cnt = count($helpdir); $i < $cnt; $i++) {
         if (file_exists("../help/$user_language/$helpdir[$i]")) {
-            // First try the selected language.
-            $doc = file("../help/$user_language/$helpdir[$i]");
-            $help_info = get_info($doc, 0);
-            $toc[] = array($i+1, $help_info[0], $help_info[2]);
+            if (is_readable("../help/$user_language/$helpdir[$i]")) {
+                // First try the selected language.
+                $doc = file("../help/$user_language/$helpdir[$i]");
+                $help_info = get_info($doc, 0);
+                $toc[] = array($i+1, $help_info[0], $help_info[2]);
+            } else {
(Continue reading)

pdontthink | 1 Feb 11:36 2016
Picon
Picon

SF.net SVN: squirrelmail:[14548] branches/SM-1_4-STABLE/squirrelmail/ plugins/mail_fetch/setup.php

Revision: 14548
          http://sourceforge.net/p/squirrelmail/code/14548
Author:   pdontthink
Date:     2016-02-01 10:36:15 +0000 (Mon, 01 Feb 2016)
Log Message:
-----------
Fix spacing issue

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/mail_fetch/setup.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/mail_fetch/setup.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/mail_fetch/setup.php	2016-02-01 04:33:04 UTC
(rev 14547)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/mail_fetch/setup.php	2016-02-01 10:36:15 UTC
(rev 14548)
 <at>  <at>  -31,7 +31,7  <at>  <at> 

 function mail_fetch_link() {
     displayInternalLink('plugins/mail_fetch/fetch.php', _("Fetch"), '');
-    echo '&nbsp;&nbsp;';
+    echo "&nbsp;&nbsp;\n";
 }

 function mail_fetch_load_pref() {

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.
(Continue reading)

pdontthink | 1 Feb 05:33 2016
Picon
Picon

SF.net SVN: squirrelmail:[14547] branches/SM-1_4-STABLE/squirrelmail/ plugins/administrator/defines.php

Revision: 14547
          http://sourceforge.net/p/squirrelmail/code/14547
Author:   pdontthink
Date:     2016-02-01 04:33:04 +0000 (Mon, 01 Feb 2016)
Log Message:
-----------
Fix syntax error

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/plugins/administrator/defines.php

Modified: branches/SM-1_4-STABLE/squirrelmail/plugins/administrator/defines.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/plugins/administrator/defines.php	2016-01-09
19:00:58 UTC (rev 14546)
+++ branches/SM-1_4-STABLE/squirrelmail/plugins/administrator/defines.php	2016-02-01
04:33:04 UTC (rev 14547)
 <at>  <at>  -243,6 +243,7  <at>  <at> 
                  '$edit_identity' => array( 'name' => _("Allow editing of identities"),
                                             'type' => SMOPT_TYPE_BOOLEAN ),
                  '$edit_name' => array( 'name' => _("Allow editing of full name"),
+                                        'type' => SMOPT_TYPE_BOOLEAN ),
                  '$edit_reply_to' => array( 'name' => _("Allow editing of reply-to address"),
                                         'type' => SMOPT_TYPE_BOOLEAN ),
                  '$hide_auth_header' => array( 'name' => _("Remove username from headers"),

This was sent by the SourceForge.net collaborative development platform, the world's largest Open
Source development site.

(Continue reading)

pdontthink | 9 Jan 20:00 2016
Picon
Picon

SF.net SVN: squirrelmail:[14546] branches/SM-1_4-STABLE/squirrelmail/src/ configtest.php

Revision: 14546
          http://sourceforge.net/p/squirrelmail/code/14546
Author:   pdontthink
Date:     2016-01-09 19:00:58 +0000 (Sat, 09 Jan 2016)
Log Message:
-----------
Update checks to reflect recent changes

Modified Paths:
--------------
    branches/SM-1_4-STABLE/squirrelmail/src/configtest.php

Modified: branches/SM-1_4-STABLE/squirrelmail/src/configtest.php
===================================================================
--- branches/SM-1_4-STABLE/squirrelmail/src/configtest.php	2016-01-01 21:30:56 UTC (rev 14545)
+++ branches/SM-1_4-STABLE/squirrelmail/src/configtest.php	2016-01-09 19:00:58 UTC (rev 14546)
 <at>  <at>  -359,9 +359,10  <at>  <at> 
     "</tt> (location base " . (empty($config_location_base) ? 'autodetected' : 'set to <tt>' .
     sm_encode_html_special_chars($config_location_base)."</tt>") . ")<br />\n";

-/* check outgoing mail */
+/* check minimal requirements for other security options */

-if($use_smtp_tls || $use_imap_tls) {
+/* imaps or ssmtp */
+if($use_smtp_tls == 1 || $use_imap_tls == 1) {
     if(!check_php_version(4,3,0)) {
         do_err('You need at least PHP 4.3.0 for SMTP/IMAP TLS!');
     }
 <at>  <at>  -369,7 +370,21  <at>  <at> 
(Continue reading)


Gmane