Patch formatting

Hi

Please check (now updated)

http://notmuchmail.org/patchformatting/

page.

Anything that can me used to improve the content (even furtner!)
are greatly appreciated.

Tomi

Re: Patch formatting

Hi

On 2011-09-01, Tomi Ollila <tomi.ollila <at> iki.fi> wrote:
> Hi
> 
> Please check (now updated)
> 
> http://notmuchmail.org/patchformatting/
> 
> page.
> 
> 
> Anything that can me used to improve the content (even furtner!)
> are greatly appreciated.

A few minor suggestions:

* Insert a link for the text "Software Release Practice HOWTO"
  http://tldp.org/HOWTO/Software-Release-Practice-HOWTO/
* s/If you're made/If you've made/
* s/and you'll get/and you get/
* Also replace:
    git format patch commit-sha1(-prefix)
  by
    git format patch <commit-sha1(-prefix)>
* s/to To: field/into To: field/

I also suggest that you insert at the beginning a simple use case:

    # Please commit clean changes (see details in section "Committing")

Re: [PATCH] Skip dot files in `notmuch new`

On Tue, 23 Aug 2011 20:11:53 -0400, James Vasile
<james@...> wrote:
> No known mail client or fetch tool stores mail in dot files, because
> files that start with '.' are usually used to store metadata
> (i.e. state or configuration) as opposed to subject-matter data.

Dovecot stores folders in directories starting with . though.

  Tom

Re: [PATCH] Skip dot files in `notmuch new`

On Fri 02 Sep 2011 03:52, Tom Prince <tom.prince@...> writes:

> On Tue, 23 Aug 2011 20:11:53 -0400, James Vasile
<james@...> wrote:
>> No known mail client or fetch tool stores mail in dot files, because
>> files that start with '.' are usually used to store metadata
>> (i.e. state or configuration) as opposed to subject-matter data.
>
> Dovecot stores folders in directories starting with . though.

Just yesterday on irc I saw someone using ~/.mail/.sent/ though.

>   Tom

Tomi

[PATCH] emacs: Sort saved searches

Display saved searches sorted, like tags are displayed.

This only affects the display of the saved searches, not the order in which
they are stored in .emacs.

Signed-off-by: Jani Nikula <jani@...>
---
 emacs/notmuch-hello.el |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 65fde75..13758e5 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
 <at>  <at>  -440,6 +440,9  <at>  <at>  Complete list of currently available key bindings:
 	     (widest (max saved-widest alltags-widest)))

 	(when saved-alist
+	  ;; Sort saved searches.
+	  (setq saved-alist
+		(sort saved-alist (lambda (a b) (string< (car a) (car b)))))
 	  (widget-insert "\nSaved searches: ")
 	  (widget-create 'push-button
 			 :notify (lambda (&rest ignore)
--

-- 
1.7.1

Re: [PATCH] emacs: Sort saved searches

On Fri 02 Sep 2011 15:28, Jani Nikula <jani@...> writes:

> Display saved searches sorted, like tags are displayed.
>
> This only affects the display of the saved searches, not the order in which
> they are stored in .emacs.
>
> Signed-off-by: Jani Nikula <jani@...>
> ---

Fun! I reveresed the sorting order so I got 'unread' first ;). Well, I
prefer to sort the value of the (customizable) variable
'notmuch-saved-searches' myself (unless there is another variable which
also provides 'saved searches' into notmuch-hello buffer)... 

Tomi

>  emacs/notmuch-hello.el |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 65fde75..13758e5 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
>  <at>  <at>  -440,6 +440,9  <at>  <at>  Complete list of currently available key bindings:
>  	     (widest (max saved-widest alltags-widest)))
>  
>  	(when saved-alist
> +	  ;; Sort saved searches.
> +	  (setq saved-alist

Re: [PATCH] emacs: Sort saved searches

On Sat, 03 Sep 2011 14:56:09 +0300, Tomi Ollila <tomi.ollila@...> wrote:
> On Fri 02 Sep 2011 15:28, Jani Nikula <jani@...> writes:
> 
> > Display saved searches sorted, like tags are displayed.
> >
> > This only affects the display of the saved searches, not the order in which
> > they are stored in .emacs.
> >
> > Signed-off-by: Jani Nikula <jani@...>
> > ---
> 
> Fun! I reveresed the sorting order so I got 'unread' first ;). Well, I
> prefer to sort the value of the (customizable) variable
> 'notmuch-saved-searches' myself (unless there is another variable which
> also provides 'saved searches' into notmuch-hello buffer)... 

Well, this is obviously easy to customize... and indeed I've got a ready
patch to do just that... but I've been told before to avoid
customization and prefer sane defaults instead. So which do we want,
really? If you want sorting customizable, then I'll also include a patch
to make saving new saved searches append vs. prepend customizable too,
as that's important if you don't want sorting.

It's fine for me either way, really, with or without customization, as
long as one of these ways is upstreamed and I don't have to carry the
patches for myself...

BR,
Jani.

Re: [PATCH] emacs: Sort saved searches

On Sun, 04 Sep 2011 01:02:03 +0300, Jani Nikula <jani@...> wrote:
> Well, this is obviously easy to customize... and indeed I've got a ready
> patch to do just that... but I've been told before to avoid
> customization and prefer sane defaults instead. So which do we want,
> really? If you want sorting customizable, then I'll also include a patch
> to make saving new saved searches append vs. prepend customizable too,
> as that's important if you don't want sorting.
> 
> It's fine for me either way, really, with or without customization, as
> long as one of these ways is upstreamed and I don't have to carry the
> patches for myself...

I personally think it's nice the way it is, such that the entry order in
the customization variable is the display order.  Users can then set the
order however they prefer.

But I honestly don't use notmuch-hello enough to really care one way or
the other.

jamie.

On Sun, 04 Sep 2011 01:02:03 +0300, Jani Nikula <jani@...> wrote:
> Well, this is obviously easy to customize... and indeed I've got a ready
> patch to do just that... but I've been told before to avoid
> customization and prefer sane defaults instead. So which do we want,
> really? If you want sorting customizable, then I'll also include a patch
> to make saving new saved searches append vs. prepend customizable too,
> as that's important if you don't want sorting.
> 

SlackBuild package for notmuch 0.7

I have made a SlackBuild package for notmuch version 0.7 that makes it 
easy to install it the correct way in Slackware 13.37:

http://slackbuilds.org/repository/13.37/office/notmuch/

Jostein

Re: [PATCH] emacs: Sort saved searches

On Sun, 04 Sep 2011 00:57:26 -0700, Jameson Graef Rollins
<jrollins@...> wrote:
> I personally think it's nice the way it is, such that the entry order in
> the customization variable is the display order.  Users can then set the
> order however they prefer.

Hmm. Let's look at this from another perspective: do you know if there's
a reasonable way to make ordering of the customized saved searches
easier? It's not exactly user friendly to move items up and down in the
list. Or to sort them.

On the other hand, the tags are sorted. Saved searches are not. Should
it be possible to display tags in user defined order...?

I know I can twist this the way I want and carry my own modifications,
but I'd like to make notmuch user friendly for people who don't know
elisp.

BR,
Jani.