Rocco Rutte | 12 May 2009 13:02
Picon

[PATCH] Reset atime when leaving mbox/mmdf with new mail

Hi,

the attached patch is supposed to set atime=mtime-1 for mbox and mmdf
folders if they contain new mail upon sync as we do for other folder
types. This only works if $check_mbox_size is unset.

See also ticket #1362.

I think the patch is okay. But I don't know why the old code does
restore atime+mtime for the folder (and so I removed the update).

Anyone?

Rocco

diff --git a/mbox.c b/mbox.c
--- a/mbox.c
+++ b/mbox.c
 <at>  <at>  -679,6 +679,26  <at>  <at>  int mbox_check_mailbox (CONTEXT *ctx, in
   return (-1);
 }

+/* if mailbox has at least 1 new message, sets mtime > atime of mailbox
+ * so buffy check reports new mail */
+static void reset_atime (CONTEXT *ctx)
+{
+  struct utimbuf utimebuf;
+  int i;
+  time_t now;
+
(Continue reading)

Brendan Cully | 13 May 2009 09:00
Gravatar

mutt: 2 new changesets

2 new changesets in mutt:

http://dev.mutt.org/hg/mutt/rev/06e318bfe8f2
changeset:   5799:06e318bfe8f2
branch:      HEAD
tag:         tip
user:        Rocco Rutte <pdmef <at> gmx.net>
date:        Tue May 12 16:26:00 2009 +0200
summary:     Backout errorneously commited mbox atime fix

http://dev.mutt.org/hg/mutt/rev/644cfc8070f7
changeset:   5798:644cfc8070f7
branch:      HEAD
user:        Rocco Rutte <pdmef <at> gmx.net>
date:        Tue May 12 15:21:16 2009 +0200
summary:     Fix description for <save-message>

--

-- 
Repository URL: http://dev.mutt.org/hg/mutt

Mutt | 13 May 2009 12:33

Re: [Mutt] #2725: Bug#375530: index weirdness if mailbox is emptied

#2725: Bug#375530: index weirdness if mailbox is emptied while inside the pager
-------------------------------------------+--------------------------------
  Reporter:  Christoph Berg <cb <at> df7cb.de>  |       Owner:  mutt-dev
      Type:  defect                        |      Status:  closed  
  Priority:  minor                         |   Milestone:          
 Component:  mutt                          |     Version:          
Resolution:  fixed                         |    Keywords:          
-------------------------------------------+--------------------------------
Changes (by Rocco Rutte <pdmef <at> gmx.net>):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 (In [ce0e5c895032]) Actually reopen mbox/mmdf files in case we find
 modifications. Closes #2725.

 Since the file is changed while we have it open in ctx->fp, we likely
 get wrong information when parsing the mailbox. Now we explicitely close
 and (re)open it.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/2725#comment:2>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Mutt | 13 May 2009 12:53

Re: [Mutt] #2875: group-reply with empty address group should prune

#2875: group-reply with empty address group should prune address group
--------------------------+-------------------------------------------------
  Reporter:  dgc          |       Owner:  mutt-dev         
      Type:  enhancement  |      Status:  closed           
  Priority:  minor        |   Milestone:  1.6              
 Component:  mutt         |     Version:                   
Resolution:  fixed        |    Keywords:  group reply patch
--------------------------+-------------------------------------------------
Changes (by Rocco Rutte <pdmef <at> gmx.net>):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 (In [19e62bd1549b]) Prune empty address groups when preparing replies.
 Closes #2875.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/2875#comment:4>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Mutt | 13 May 2009 14:21

Re: [Mutt] #2044: don't mark as answered if no in-reply-to

#2044: don't mark as answered if no in-reply-to
---------------------------+------------------------------------------------
  Reporter:  ossi <at> kde.org  |       Owner:  mutt-dev
      Type:  enhancement   |      Status:  closed  
  Priority:  trivial       |   Milestone:          
 Component:  mutt          |     Version:          
Resolution:  fixed         |    Keywords:          
---------------------------+------------------------------------------------
Changes (by Rocco Rutte <pdmef <at> gmx.net>):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 (In [f96a176bb14c]) Don't set 'replied' flag if user changes
 References/IRT. Closes #2044.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/2044#comment:2>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Mutt | 13 May 2009 18:04

Re: [Mutt] #3156: failed attachment saving hides error message

#3156: failed attachment saving hides error message
-------------------------------+--------------------------------------------
  Reporter:  antonio <at> dyne.org  |       Owner:  mutt-dev
      Type:  defect            |      Status:  closed  
  Priority:  minor             |   Milestone:          
 Component:  mutt              |     Version:  1.5.18  
Resolution:  fixed             |    Keywords:          
-------------------------------+--------------------------------------------
Changes (by Rocco Rutte <pdmef <at> gmx.net>):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 (In [0563c88ad6f0]) Don't loose error message when attachment saving
 fails. Closes #3156.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/3156#comment:1>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Mutt | 13 May 2009 23:17

[Mutt] #3225: new mail notifications are lost too easily

#3225: new mail notifications are lost too easily
-------------------------+--------------------------------------------------
 Reporter:  vinc17       |       Owner:  mutt-dev
     Type:  enhancement  |      Status:  new     
 Priority:  minor        |   Milestone:          
Component:  mutt         |     Version:  1.5.19  
 Keywords:               |  
-------------------------+--------------------------------------------------
 A "new mail" notification may appear when typing something, but will
 disappear as soon as a second key is typed. For instance, if one wants to
 move the cursor to some message by typing the up-arrow key several times,
 the notification disappears almost instantly.

 IMHO, the notification should be kept on screen until something else
 appears in the command line.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/3225>
Mutt <http://www.mutt.org/>
The Mutt mail user agent

Gary Johnson | 14 May 2009 00:00

Re: [Mutt] #3225: new mail notifications are lost too easily

On 2009-05-13, Mutt <fleas <at> mutt.org> wrote:
> #3225: new mail notifications are lost too easily
> -------------------------+--------------------------------------------------
>  Reporter:  vinc17       |       Owner:  mutt-dev
>      Type:  enhancement  |      Status:  new     
>  Priority:  minor        |   Milestone:          
> Component:  mutt         |     Version:  1.5.19  
>  Keywords:               |  
> -------------------------+--------------------------------------------------
>  A "new mail" notification may appear when typing something, but will
>  disappear as soon as a second key is typed. For instance, if one wants to
>  move the cursor to some message by typing the up-arrow key several times,
>  the notification disappears almost instantly.
> 
>  IMHO, the notification should be kept on screen until something else
>  appears in the command line.

I disagree.  I often (too often) glance at that line in the two
instances of mutt I have running most of the time on my desktop to
see if any new mail has arrived.  If I'm not interested in those
particular messages at the time, but I want to know if any further
new mail arrives, I simply move the cursor to clear the message.

I also like that the message disappears automatically after I
perform some action in mutt.  In that way I'm sure that any
new-message notification in that line has occurred after the last
time I did something in mutt.

Regards,
Gary
(Continue reading)

Mutt | 14 May 2009 00:01

Re: [Mutt] #3225: new mail notifications are lost too easily

#3225: new mail notifications are lost too easily
--------------------------+-------------------------------------------------
  Reporter:  vinc17       |       Owner:  mutt-dev
      Type:  enhancement  |      Status:  new     
  Priority:  minor        |   Milestone:          
 Component:  mutt         |     Version:  1.5.19  
Resolution:               |    Keywords:          
--------------------------+-------------------------------------------------

Comment(by Gary Johnson):

 {{{
 On 2009-05-13, Mutt <fleas <at> mutt.org> wrote:

 I disagree.  I often (too often) glance at that line in the two
 instances of mutt I have running most of the time on my desktop to
 see if any new mail has arrived.  If I'm not interested in those
 particular messages at the time, but I want to know if any further
 new mail arrives, I simply move the cursor to clear the message.

 I also like that the message disappears automatically after I
 perform some action in mutt.  In that way I'm sure that any
 new-message notification in that line has occurred after the last
 time I did something in mutt.

 Regards,
 Gary
 }}}

--

-- 
(Continue reading)

Mutt | 14 May 2009 00:36

Re: [Mutt] #3225: new mail notifications are lost too easily

#3225: new mail notifications are lost too easily
--------------------------+-------------------------------------------------
  Reporter:  vinc17       |       Owner:  mutt-dev
      Type:  enhancement  |      Status:  new     
  Priority:  minor        |   Milestone:          
 Component:  mutt         |     Version:  1.5.19  
Resolution:               |    Keywords:          
--------------------------+-------------------------------------------------

Comment(by vinc17):

 Then perhaps there should be a variable saying after how many seconds the
 message can disappear upon a user action. When this variable is set to 0,
 one would obtain the current behavior.

--

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/3225#comment:2>
Mutt <http://www.mutt.org/>
The Mutt mail user agent


Gmane