Bill Wohler | 1 Jun 2008 22:17
Picon
Picon
Gravatar

Re: use dotted syntax for package version info

John Paul Wallington <jpw <at> pobox.com> wrote:

> How about using dotted syntax for package version info throughout for
> consistency's sake?
> 
> 2008-05-31  John Paul Wallington  <jpw <at> pobox.com>
> 
> 	* mh-e.el (mh-path, mh-variant): Use dotted syntax for
> 	`package-version' info.
> 
> Index: lisp/mh-e/mh-e.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/mh-e/mh-e.el,v
> retrieving revision 1.123
> diff -u -r1.123 mh-e.el
> --- lisp/mh-e/mh-e.el	27 May 2008 00:00:22 -0000	1.123
> +++ lisp/mh-e/mh-e.el	31 May 2008 18:20:48 -0000
>  <at>  <at>  -714,7 +714,7  <at>  <at> 
>  See `mh-variant'."
>    :group 'mh-e
>    :type '(repeat (directory))
> -  :package-version '(MH-E "8.0"))
> +  :package-version '(MH-E . "8.0"))
>  
>  (defun mh-variants ()
>    "Return a list of installed variants of MH on the system.
>  <at>  <at>  -949,7 +949,7  <at>  <at> 
>           (set-default symbol value)     ;Done in mh-variant-set-variant!
>           (mh-variant-set value))
>    :group 'mh-e
(Continue reading)

John Paul Wallington | 1 Jun 2008 23:45
Picon

emacs/lisp/mh-e mh-e.el

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	John Paul Wallington <jpw>	08/06/01 21:45:51

Modified files:
	lisp/mh-e      : mh-e.el 

Log message:
	(mh-path, mh-variant): Use dotted syntax for `package-version' info.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mh-e/mh-e.el?cvsroot=emacs&r1=1.123&r2=1.124

Patches:
Index: mh-e.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/mh-e.el,v
retrieving revision 1.123
retrieving revision 1.124
diff -u -b -r1.123 -r1.124
--- mh-e.el	27 May 2008 00:00:22 -0000	1.123
+++ mh-e.el	1 Jun 2008 21:45:51 -0000	1.124
 <at>  <at>  -714,7 +714,7  <at>  <at> 
 See `mh-variant'."
   :group 'mh-e
   :type '(repeat (directory))
-  :package-version '(MH-E "8.0"))
+  :package-version '(MH-E . "8.0"))

 (defun mh-variants ()
(Continue reading)

John Paul Wallington | 1 Jun 2008 23:46
Picon

emacs/lisp/mh-e ChangeLog

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	John Paul Wallington <jpw>	08/06/01 21:46:11

Modified files:
	lisp/mh-e      : ChangeLog 

Log message:
	*** empty log message ***

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mh-e/ChangeLog?cvsroot=emacs&r1=1.279&r2=1.280

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/ChangeLog,v
retrieving revision 1.279
retrieving revision 1.280
diff -u -b -r1.279 -r1.280
--- ChangeLog	27 May 2008 00:00:23 -0000	1.279
+++ ChangeLog	1 Jun 2008 21:46:11 -0000	1.280
 <at>  <at>  -1,3 +1,8  <at>  <at> 
+2008-05-31  John Paul Wallington  <jpw <at> pobox.com>
+
+	* mh-e.el (mh-path, mh-variant): Use dotted syntax for
+	`package-version' info.
+
 2008-05-26  Jeffrey C Honig  <jch <at> honig.net>

(Continue reading)

John Paul Wallington | 1 Jun 2008 23:47
Picon
Favicon

Re: use dotted syntax for package version info

On 1 Jun 2008, at 21:17, Bill Wohler wrote:

> John Paul Wallington <jpw <at> pobox.com> wrote:
>
>> How about using dotted syntax for package version info throughout for
>> consistency's sake?
>>
>> 2008-05-31  John Paul Wallington  <jpw <at> pobox.com>
>>
>> 	* mh-e.el (mh-path, mh-variant): Use dotted syntax for
>> 	`package-version' info.
[...]
>
> I agree. Thanks very much for catching that detail. Can you check this
> in?

Okie-dokie.  Installed.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
John Paul Wallington | 1 Jun 2008 23:48
Picon

emacs/lisp/mh-e ChangeLog

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	John Paul Wallington <jpw>	08/06/01 21:48:58

Modified files:
	lisp/mh-e      : ChangeLog 

Log message:
	*** empty log message ***

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mh-e/ChangeLog?cvsroot=emacs&r1=1.280&r2=1.281

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/ChangeLog,v
retrieving revision 1.280
retrieving revision 1.281
diff -u -b -r1.280 -r1.281
--- ChangeLog	1 Jun 2008 21:46:11 -0000	1.280
+++ ChangeLog	1 Jun 2008 21:48:58 -0000	1.281
 <at>  <at>  -1,4 +1,4  <at>  <at> 
-2008-05-31  John Paul Wallington  <jpw <at> pobox.com>
+2008-06-01  John Paul Wallington  <jpw <at> pobox.com>

 	* mh-e.el (mh-path, mh-variant): Use dotted syntax for
 	`package-version' info.
 <at>  <at>  -12,7 +12,7  <at>  <at> 

(Continue reading)

John Paul Wallington | 2 Jun 2008 22:08
X-Face
Picon
Favicon

custom-type fix for `mh-sortm-args'

How about this fix?  I was originally going to suggest a choice of
`string' or `nil', but then noticed that the documentation suggests a
list of strings.  AFAICT, either a string or a list of strings work.  I
think offering both a string and a list of strings as choices would be
confusing.  I suppose changing the type will cause the custom interface
to whinge about a user's existing string value being of the wrong type
though.

2008-06-02  John Paul Wallington  <jpw <at> pobox.com>

	* mh-e.el (mh-sortm-args): Fix custom type.

--- mh-e.el.~1.124.~	2008-05-31 18:54:46.000000000 +0100
+++ mh-e.el	2008-06-02 21:04:09.000000000 +0100
 <at>  <at>  -1333,7 +1333,8  <at>  <at> 
 specified in the MH profile. This option may be used to provide
 an alternate view. For example, \"'(\"-nolimit\" \"-textfield\"
 \"subject\")\" is a useful setting."
-  :type 'string
+  :type '(choice (const :tag "No arguments" nil)
+                 (repeat :tag "Arguments" (string :tag "Argument")))
   :group 'mh-folder
   :package-version '(MH-E . "8.0"))

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
John Paul Wallington | 2 Jun 2008 22:09
Picon

emacs/lisp/mh-e mh-e.el

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	John Paul Wallington <jpw>	08/06/02 20:09:57

Modified files:
	lisp/mh-e      : mh-e.el 

Log message:
	(mh-exec-cmd-env-daemon): Doc fix.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mh-e/mh-e.el?cvsroot=emacs&r1=1.124&r2=1.125

Patches:
Index: mh-e.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/mh-e.el,v
retrieving revision 1.124
retrieving revision 1.125
diff -u -b -r1.124 -r1.125
--- mh-e.el	1 Jun 2008 21:45:51 -0000	1.124
+++ mh-e.el	2 Jun 2008 20:09:57 -0000	1.125
 <at>  <at>  -554,7 +554,7  <at>  <at> 
     process))

 (defun mh-exec-cmd-env-daemon (env command filter &rest args)
-  "In ennvironment ENV, execute mh-command COMMAND in the background.
+  "In environment ENV, execute mh-command COMMAND in the background.

 ENV is nil or a string of space-separated \"var=value\" elements.
(Continue reading)

John Paul Wallington | 2 Jun 2008 22:10
Picon

emacs/lisp/mh-e ChangeLog

CVSROOT:	/sources/emacs
Module name:	emacs
Changes by:	John Paul Wallington <jpw>	08/06/02 20:10:25

Modified files:
	lisp/mh-e      : ChangeLog 

Log message:
	*** empty log message ***

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/mh-e/ChangeLog?cvsroot=emacs&r1=1.281&r2=1.282

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/ChangeLog,v
retrieving revision 1.281
retrieving revision 1.282
diff -u -b -r1.281 -r1.282
--- ChangeLog	1 Jun 2008 21:48:58 -0000	1.281
+++ ChangeLog	2 Jun 2008 20:10:25 -0000	1.282
 <at>  <at>  -1,3 +1,7  <at>  <at> 
+2008-06-02  John Paul Wallington  <jpw <at> pobox.com>
+
+	* mh-e.el (mh-exec-cmd-env-daemon): Doc fix.
+
 2008-06-01  John Paul Wallington  <jpw <at> pobox.com>

 	* mh-e.el (mh-path, mh-variant): Use dotted syntax for
(Continue reading)

John Paul Wallington | 3 Jun 2008 02:10
X-Face
Picon
Favicon

minor nits

Is it okay to install the following minor changes?

2008-06-03  John Paul Wallington  <jpw <at> pobox.com>

	* mh-acros.el (toplevel): Put `doc-string-elt' properties on
	`defun-mh' and `defmacro-mh'.

	* mh-alias.el (mh-alias-read-address-map): Define within defvar.

	* mh-comp.el (mh-letter-mode-syntax-table): Define within defvar.

	* mh-letter.el (mh-complete-word): Doc fix.

Index: mh-acros.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mh-e/mh-acros.el,v
retrieving revision 1.25
diff -u -r1.25 mh-acros.el
--- mh-acros.el	6 May 2008 03:56:45 -0000	1.25
+++ mh-acros.el	2 Jun 2008 23:39:52 -0000
 <at>  <at>  -91,6 +91,7  <at>  <at> 
         `(defalias ',name ',function)
       `(defun ,name ,arg-list , <at> body))))
 (put 'defun-mh 'lisp-indent-function 'defun)
+(put 'defun-mh 'doc-string-elt 4)

 ;;;###mh-autoload
 (defmacro defmacro-mh (name macro arg-list &rest body)
 <at>  <at>  -102,6 +103,7  <at>  <at> 
         `(defalias ',name ',macro)
(Continue reading)

Bill Wohler | 4 Jun 2008 07:41
Picon
Picon
Gravatar

Re: minor nits

John Paul Wallington <jpw <at> pobox.com> wrote:

> Is it okay to install the following minor changes?

Probably :-).

> Index: mh-acros.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/mh-e/mh-acros.el,v
> retrieving revision 1.25
> diff -u -r1.25 mh-acros.el
> --- mh-acros.el	6 May 2008 03:56:45 -0000	1.25
> +++ mh-acros.el	2 Jun 2008 23:39:52 -0000
>  <at>  <at>  -91,6 +91,7  <at>  <at> 
>          `(defalias ',name ',function)
>        `(defun ,name ,arg-list , <at> body))))
>  (put 'defun-mh 'lisp-indent-function 'defun)
> +(put 'defun-mh 'doc-string-elt 4)

Can you explain what this does?

> Index: mh-alias.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/mh-e/mh-alias.el,v
> retrieving revision 1.36
> diff -u -r1.36 mh-alias.el
> --- mh-alias.el	6 May 2008 03:56:45 -0000	1.36
> +++ mh-alias.el	2 Jun 2008 23:43:09 -0000
>  <at>  <at>  -43,13 +43,11  <at>  <at> 
>    "Alist of aliases extracted from passwd file and their expansions.")
(Continue reading)


Gmane