headers
Mark D. Baushke | 1 Jan 2006 01:54
X-Face
Picon

Re: mh-folder-cur-msg-number face inherit from mh-folder-msg-number?


Bill Wohler <wohler <at> newt.com> writes:

> The face mh-folder-cur-msg-number is currently defined like this:
> 
>   (defface mh-folder-cur-msg-number
>     (mh-defface-compat
>      '((((class color) (min-colors 88) (background light))
> 	(:foreground "Purple"))
>        (((class color) (min-colors 88) (background dark))
> 	(:foreground "Cyan"))
>        (((class color))
> 	(:foreground "cyan" :weight bold))
>        (((class grayscale) (background light))
> 	(:foreground "LightGray" :bold t))
>        (((class grayscale) (background dark))
> 	(:foreground "DimGray" :bold t))
>        (t
> 	(:bold t))))
>     "Current message number face in MH-Folder buffers."
>     :group 'mh-faces
>     :group 'mh-folder)
> 
> Emboldening mh-folder-msg-number seems like a simpler, more elegant
> solution to me.
> 
>   (defface mh-folder-cur-msg-number
>     '((t
>        (:inherit mh-folder-msg-number :bold t)))
>     "Current message number face in MH-Folder buffers."
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jan 2006 02:20
Picon
Picon
Gravatar

Re: Rename mh-scan-format-regexp

Thanks, Mark.

Mark D. Baushke <mdb <at> gnu.org> wrote:

> Bill Wohler <wohler <at> newt.com> writes:
> 
> It is only really used in the mh-folder-font-lock-keywords at present to
> provide fonts to BOTH the DATE and USERNAME.
>  
> > So names that come to mind include:
> > 
> >   mh-scan-sent-to-me-regexp (doesn't emphasize that we're highlighting sender)
> >   mh-scan-sent-to-me-sender-regexp (long, but good)
> >   mh-scan-sender-regexp (we're not using it to highlight every sender)
> >   mh-scan-special-sender-regexp (vague. what's "special?")
> >   
> > I'd like to get confirmation from at least one of you that renaming is
> > OK. The longest one, mh-scan-sent-to-me-sender-regexp, seems the most
> > accurate so I'll go with that unless you have a better suggestion.
> 
> Your suggestions are also misleading. I would guess that something like
> this: mh-scan-date-user-for-fontlock-regexp is closer.

I think that the inclusion of the date is incidental; it isn't even used
in mh-folder-font-lock-keywords. I think the original reason for this
regexp and face was to emphasize messages that were sent directly to us.
Now that you point it out, it might be a good idea not to parenthesize
the date. Once that is done, would you agree that
mh-scan-sent-to-me-sender-regexp makes is no longer misleading?
(Continue reading)

Permalink | Reply | 2 comments |
headers
Mark D. Baushke | 1 Jan 2006 02:28
X-Face
Picon

Re: Rename mh-scan-format-regexp


Bill Wohler <wohler <at> newt.com> writes:

> I think that the inclusion of the date is incidental; it isn't even used
> in mh-folder-font-lock-keywords. 

Are we using the same code? At present the search is made for
mh-scan-date-regexp either alone, or as a part of the
mh-folder-scan-format-regexp

I have this:

| (defvar mh-folder-font-lock-keywords
|   (list
|    ;; Folders when displaying index buffer
|    (list "^\\+.*"
|          '(0 mh-index-folder-face))
|    ;; Marked for deletion
|    (list (concat mh-scan-deleted-msg-regexp ".*")
|          '(0 mh-folder-deleted-face))
|    ;; Marked for refile
|    (list (concat mh-scan-refiled-msg-regexp ".*")
|          '(0 mh-folder-refiled-face))
|    ;;after subj
|    (list mh-scan-body-regexp '(1 mh-folder-body-face nil t))
|    '(mh-folder-font-lock-subject
|      (1 mh-folder-followup-face append t)
|      (2 mh-folder-subject-face append t))
|    ;;current msg
|    (list mh-scan-cur-msg-number-regexp
(Continue reading)

Permalink | Reply | 1 comment |
headers
Mark D. Baushke | 1 Jan 2006 02:35
X-Face
Picon

Re: Deemphasizing face mh-folder-body


Bill Wohler <wohler <at> newt.com> writes:

> I have a feeling I'm opening up Pandora's box by discussing something as
> subjective as faces, but hopefully you'll be gentle with me ;-). I also
> think this will be the last email in this series--I'm getting ready to
> wrap up the new text on faces in the manual.

Heh.

> The current setting of mh-folder-body is as follows:
> 
>   (defface mh-folder-body 
>     (mh-defface-compat
>      '((((class color) (min-colors 88) (background light))
> 	(:foreground "RosyBrown"))
>        (((class color) (min-colors 88) (background dark))
> 	(:foreground "LightSalmon"))
>        (((class color))
> 	(:foreground "green"))
>        (((class grayscale) (background light))
> 	(:foreground "DimGray" :italic t))
>        (((class grayscale) (background dark))
> 	(:foreground "LightGray" :italic t))
>        (t
> 	(:italic t))))
>     "Body text face in MH-Folder buffers."
>     :group 'mh-faces
>     :group 'mh-folder)
(Continue reading)

Permalink | Reply | 5 comments |
headers
Bill Wohler | 1 Jan 2006 03:26
Picon
Picon
Gravatar

Re: Rename mh-scan-format-regexp

Mark D. Baushke <mdb <at> gnu.org> wrote:

> Bill Wohler <wohler <at> newt.com> writes:
> 
> > I think that the inclusion of the date is incidental; it isn't even used
> > in mh-folder-font-lock-keywords. 
> 
> Are we using the same code?

;-)

> |    (list mh-scan-rcpt-regexp
> |          '(1 mh-folder-to-face) ;; To:
> |          '(2 mh-folder-address-face)) ;; address
> |    ;; scan font-lock name
> |    (list mh-scan-format-regexp
> |          '(1 mh-folder-date-face)
> |          '(3 mh-folder-scan-format-face)))
> 
> Date face used above...

The face is, yes, but it's not for the date! Note that the first
parenthesized expression for mh-scan-format-regexp is for the
fontification hint. The second one is for the date which you notice is
absent.

> > Now that you point it out, it might be a good idea not to parenthesize
> > the date. 
> 
> Doing so would make the regexp less confusing. Off-hand, I don't know if
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jan 2006 03:48
Picon
Picon
Gravatar

Re: Deemphasizing face mh-folder-body

Mark D. Baushke <mdb <at> gnu.org> wrote:

> I'll need to try it on a few other monitors and get back to you...

Thank you.

> Hmmm... it may be desirable for you to write a series of
> (custom-set-faces ...) s-expressions for us to toggle between your
> desired change to the defaults and the current defaults so we can more
> easily see the differences.

If it's OK with you, it would be easier for me to just check in what I
have and for those who are interested to look at the old and new
versions side by side. If there are issues, then we can edit the defface
entries accordingly.

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
Permalink | Reply | 4 comments |
headers
Mark D. Baushke | 1 Jan 2006 03:54
X-Face
Picon

Re: Deemphasizing face mh-folder-body


Bill Wohler <wohler <at> newt.com> writes:

> Mark D. Baushke <mdb <at> gnu.org> wrote:
> 
> > I'll need to try it on a few other monitors and get back to you...
> 
> Thank you.
> 
> > Hmmm... it may be desirable for you to write a series of
> > (custom-set-faces ...) s-expressions for us to toggle between your
> > desired change to the defaults and the current defaults so we can more
> > easily see the differences.
> 
> If it's OK with you, it would be easier for me to just check in what I
> have and for those who are interested to look at the old and new
> versions side by side. If there are issues, then we can edit the defface
> entries accordingly.

Being able to toggle between the two sets of defaults is desirable...

	-- Mark
Permalink | Reply | 3 comments |
headers
Bill Wohler | 1 Jan 2006 05:41
Picon
Picon
Gravatar

Re: Deemphasizing face mh-folder-body

Mark D. Baushke <mdb <at> gnu.org> wrote:

> Bill Wohler <wohler <at> newt.com> writes:
> 
> > Mark D. Baushke <mdb <at> gnu.org> wrote:
> > 
> > > I'll need to try it on a few other monitors and get back to you...
> > 
> > Thank you.
> > 
> > > Hmmm... it may be desirable for you to write a series of
> > > (custom-set-faces ...) s-expressions for us to toggle between your
> > > desired change to the defaults and the current defaults so we can more
> > > easily see the differences.
> > 
> > If it's OK with you, it would be easier for me to just check in what I
> > have and for those who are interested to look at the old and new
> > versions side by side. If there are issues, then we can edit the defface
> > entries accordingly.
> 
> Being able to toggle between the two sets of defaults is desirable...

OK.

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

-------------------------------------------------------
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jan 2006 18:53
Picon
Picon
Gravatar

Re: Deemphasizing face mh-folder-body

Mark D. Baushke <mdb <at> gnu.org> wrote:

> Bill Wohler <wohler <at> newt.com> writes:
> 
> > Mark D. Baushke <mdb <at> gnu.org> wrote:
> > 
> > > I'll need to try it on a few other monitors and get back to you...
> > 
> > Thank you.
> > 
> > > Hmmm... it may be desirable for you to write a series of
> > > (custom-set-faces ...) s-expressions for us to toggle between your
> > > desired change to the defaults and the current defaults so we can more
> > > easily see the differences.
> > 
> > If it's OK with you, it would be easier for me to just check in what I
> > have and for those who are interested to look at the old and new
> > versions side by side. If there are issues, then we can edit the defface
> > entries accordingly.
> 
> Being able to toggle between the two sets of defaults is desirable...

I've got the functions to toggle back and forth, except that it isn't
working. Neither a call to defface, nor calling, for example, (put
'mh-folder-body 'face-defface-spec ...) is having an effect on the face.
How can I update a face using the original spec (rather than going
through the tedium of figuring out the current type of terminal and
calling set-face-attribute appropriately).

--

--
(Continue reading)

Permalink | Reply | 1 comment |
headers
Bill Wohler | 1 Jan 2006 19:16
Picon
Picon
Gravatar

Re: Deemphasizing face mh-folder-body

Bill Wohler <wohler <at> olgas.newt.com> wrote:

> Mark D. Baushke <mdb <at> gnu.org> wrote:
> 
> > Bill Wohler <wohler <at> newt.com> writes:
> > 
> > > Mark D. Baushke <mdb <at> gnu.org> wrote:
> > > 
> > > > I'll need to try it on a few other monitors and get back to you...
> > > 
> > > Thank you.
> > > 
> > > > Hmmm... it may be desirable for you to write a series of
> > > > (custom-set-faces ...) s-expressions for us to toggle between your
> > > > desired change to the defaults and the current defaults so we can more
> > > > easily see the differences.
> > > 
> > > If it's OK with you, it would be easier for me to just check in what I
> > > have and for those who are interested to look at the old and new
> > > versions side by side. If there are issues, then we can edit the defface
> > > entries accordingly.
> > 
> > Being able to toggle between the two sets of defaults is desirable...
> 
> I've got the functions to toggle back and forth, except that it isn't
> working. Neither a call to defface, nor calling, for example, (put
> 'mh-folder-body 'face-defface-spec ...) is having an effect on the face.
> How can I update a face using the original spec (rather than going
> through the tedium of figuring out the current type of terminal and
> calling set-face-attribute appropriately).
(Continue reading)

Permalink | Reply | 0 comments |

Gmane