headers
SourceForge.net | 1 Jun 2005 05:51
Picon
Favicon

[ mh-e-Bugs-827203 ] mh-forward hard-codes '-mime' switch on nmh

Bugs item #827203, was opened at 2003-10-20 16:19
Message generated for change (Comment added) made by wohler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=113357&aid=827203&group_id=13357

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: Documentation
>Group: mh-e-7.4.4
Status: Open
>Resolution: Fixed
Priority: 6
Submitted By: Davor Cubranic (cubranic)
Assigned to: Bill Wohler (wohler)
Summary: mh-forward hard-codes '-mime' switch on nmh

Initial Comment:
In mh-comp:
                       (mh-exec-cmd "forw" "-build"
                                    (if (mh-variant-p
'nmh) "-mime")
                                    mh-current-folder

(mh-coalesce-msg-list msgs))

Normally, I prefer to be able to directly include the
whole message so I can edit it as necessary, but this
leaves only a '#forw' mhn directive in my buffer. It
would be preferable to include '-mime' filter depending
(Continue reading)

Permalink | Reply | 0 comments |
headers
Richard Stallman | 1 Jun 2005 11:39
Picon
Picon

Re: The MH-E repository

    My two big questions are: 1) Is anyone against this, and why?

I am in favor of it.

								  2) Would
    the Emacs maintainers mind having the extra files mentioned previously
    in the lisp/mh-e directory or would they prefer any files associated
    with MH-E's life outside of Emacs to be kept outside of Emacs?

It's not the most important of issues, but but if you're planning to
keep a repository elsewhere, why not leave those three additional
files there rather than in Emacs?  It would be cleanest for the Emacs
repository to contain only the files that belong in Emacs.
Permalink | Reply | 0 comments |
headers
Peter S Galbraith | 1 Jun 2005 15:47
Favicon

Re: The MH-E repository

Bill Wohler <wohler <at> newt.com> wrote:

> My two big questions are: 1) Is anyone against this, and why?

My only concern is having more people affected by broken code.  I don't
know how Emacs developers works because I don't track their daily work,
so maybe this isn't a relevant issue...

Sometimes in the past, a MH-E developer would _try_ something, possibly
a new way of handling something.  He would check the new code into CVS
and it might break the codebase a little while it was being finalized,
but it was checked in so other developers could try it out and give
feedback.  I wouldn't feel comfortable doing this anymore knowing that
I'm affecting Emacs for a far greater number of users.  I prefer that we
check in released version of MH-E that are known to work.

--

-- 
Peter S. Galbraith, MH-E developer  <p.galbraith <at> globetrotter.net>
GPG key 1024/D2A913A1 - 97CE 866F F579 96EE  6E68 8170 35FF 799E
6623'rd GNU/Linux user at the Counter - http://counter.li.org/
Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jun 2005 16:27
Picon
Picon
Gravatar

Re: The MH-E repository

Peter S Galbraith <p.galbraith <at> globetrotter.net> wrote:

> Bill Wohler <wohler <at> newt.com> wrote:
> 
> > My two big questions are: 1) Is anyone against this, and why?
> 
> Sometimes in the past, a MH-E developer would _try_ something, possibly
> a new way of handling something.  He would check the new code into CVS
> and it might break the codebase a little while it was being finalized,
> but it was checked in so other developers could try it out and give
> feedback.  I wouldn't feel comfortable doing this anymore knowing that
> I'm affecting Emacs for a far greater number of users.

Good observation. Note that we are not affecting Emacs users who do not
use MH-E. Perhaps the Emacs developers and users who check out CVS Emacs
who use MH-E are also comfortable with this. It is extremely rare.

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.
Permalink | Reply | 0 comments |
headers
Stefan Monnier | 1 Jun 2005 17:31
Picon

Re: The MH-E repository

> Sometimes in the past, a MH-E developer would _try_ something, possibly
> a new way of handling something.  He would check the new code into CVS
> and it might break the codebase a little while it was being finalized,
> but it was checked in so other developers could try it out and give
> feedback.  I wouldn't feel comfortable doing this anymore knowing that
> I'm affecting Emacs for a far greater number of users.  I prefer that we
> check in released version of MH-E that are known to work.

The Emacs CVS trunk is also broken every once in a while.
That's just normal.  People who use code from a CVS repository can be
assumed to know that (maybe because they learned it the hard way).
So I don't think it's a problem.

        Stefan

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jun 2005 18:31
Picon
Picon
Gravatar

Re: src mh-mime.el,1.171,1.172 ChangeLog,1.1252,1.1253

Bill Wohler <wohler <at> users.sourceforge.net> wrote:

> (mh-compose-forward): Only use mh-sent-from-msg as a default message
> if it's a number (as is done elsewhere). Otherwise, an error is thrown
> if this function is called from a draft created by mh-forward since
> this variable is a list.

[Bill thinking aloud.]

I see a bunch of places where a message number is only used if (numberp
message-number) is true. I'm wondering if we should create a function
that always returns a valid integral message number:

1. If the variable is a number, return it
2. If the variable is a list, return the first item, unless
3. If the variable or first item is a sequence, return the first message in
   the sequence
4. Return the value of cur if it is non-nil
5. Return the value of pseq
6. Return the first (or perhaps last) message in the folder.

[Bill wonders what the other folks think.]

For example, if you copy a message from one folder to another and then
rescan that other folder to see the message, you are taken to the first
message--far, far away from where you want to be--because MH unsets cur.
However, MH does set pseq to the message that was copied in (hence my
rationale for step 5 above) so a rescan should show it.

--

--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Bill Wohler | 1 Jun 2005 18:16
Picon

src mh-mime.el,1.171,1.172 ChangeLog,1.1252,1.1253

Update of /cvsroot/mh-e/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22336

Modified Files:
	mh-mime.el ChangeLog 
Log Message:
(mh-compose-forward): Only use mh-sent-from-msg as a default message
if it's a number (as is done elsewhere). Otherwise, an error is thrown
if this function is called from a draft created by mh-forward since
this variable is a list. Also added a space after the "Messages [%s]:"
prompt.

Index: mh-mime.el
===================================================================
RCS file: /cvsroot/mh-e/src/mh-mime.el,v
retrieving revision 1.171
retrieving revision 1.172
diff -u -d -r1.171 -r1.172
--- mh-mime.el	31 May 2005 02:01:32 -0000	1.171
+++ mh-mime.el	1 Jun 2005 16:16:31 -0000	1.172
 <at>  <at>  -79,19 +79,24  <at>  <at> 
 Optional argument MESSAGES is the range of messages to forward.
 If any of the optional arguments are absent, they are prompted for."
   (interactive (let*
-		((description (read-string "Forw Content-description: "))
-		 (folder (mh-prompt-for-folder "Message from" mh-sent-from-folder nil))
-		 (messages (let ((default-message
-				   (if (equal folder mh-sent-from-folder)
-				       mh-sent-from-msg
-				     (nth 0 (mh-translate-range folder "cur")))))
(Continue reading)

Permalink | Reply | 2 comments |
headers
Bill Wohler | 1 Jun 2005 18:38
Picon
Picon
Gravatar

Re: The MH-E repository

Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> > (Stefan, you may consider this my request to have you add my 'mdb'
> > userid to the emacs project.)
> 
> Such request should be made online at the Emacs project page on savannah.

Hey folks, the actual place to go is
https://savannah.gnu.org/my/groups.php. Please go there and request to
join the Emacs project. If RMS doesn't give you all permission, then we
cannot proceed.

Thanks for your patience. This may or may not pan out, but if it does
I'll try to make it as painless for you all as possible ;-).

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 1 comment |
headers
Bill Wohler | 1 Jun 2005 18:50
Picon
Picon
Gravatar

Re: The MH-E repository

I just thought of a potentially big issue. Or not.

If this switch comes to pass, would the Emacs developers mind if I added
the following line to CVSROOT/loginfo?

 lisp/mh-e $CVSROOT/CVSROOT/syncmail -u %{sVv} mh-e-devel <at> lists.sourceforge.net

I'd also add the syncmail script to the CVSROOT directory. It's a script
that sends a diff of the checkin to the given address. See
http://syncmail.sourceforge.net/.

This is how the MH-E team performs code reviews.

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.
Permalink | Reply | 0 comments |
headers
Jeffrey C Honig | 1 Jun 2005 19:06
Face

Re: The MH-E repository

Bill Wohler <wohler <at> newt.com> wrote:

> Hey folks, the actual place to go is
> https://savannah.gnu.org/my/groups.php. Please go there and request to
> join the Emacs project. If RMS doesn't give you all permission, then we
> cannot proceed.

Applied.

Thanks.

Jeff

--

-- 
Jeffrey C. Honig <jch <at> honig.net>
http://www.honig.net/jch
GnuPG ID:14E29E13 <http://www.honig.net/jch/key.shtml>

-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
Permalink | Reply | 0 comments |

Gmane