Peter S Galbraith | 1 May 2002 05:05
Favicon

Re: X-Face and mh-invisible-headers

Satyaki Das <satyakid <at> stanford.edu> wrote:

>                                      Whether I use "," or "."
> the x-face picture is shown in the From: header. So I have
> changed my modified mh-display-msg function to show the
> picture only with ".".
> 
> Other changes in the new mh-ext.el include having the same
> keymap in the show buffer as in the folder buffer. Also there
> are some minor bug-fixes.

I briefly tried your code this evening (without first uninstalling
x-face-el so I'm not sure your package was actually handling that part
yet).

There's some very neat MIME handling!  Nice work!

Some quick comments in Emacs21:

- Putting the mouse over a MIME part, e.g. "[1. stuff]...", triggered a
  mouse-over highlight, but there were no mouse buttons active.

- It then displayed help about pressing RET or other keys to display the
  attachment, but in reality you have to first click the mouse such that
  point is moved there before you can press those keys.

- Using `i' to insert an image actually inserts the raw binary file,
  instead of displaying the image.  Weird.

- We should be able to display even large images inline.  (I noticed
(Continue reading)

Satyaki Das | 2 May 2002 03:18
X-Face
Picon
Favicon

Re: X-Face and mh-invisible-headers

,---- Peter S Galbraith <p.galbraith <at> globetrotter.net> writes:
| Satyaki Das <satyakid <at> stanford.edu> wrote:
| 
| >                                      Whether I use "," or "."
| > the x-face picture is shown in the From: header. So I have
| > changed my modified mh-display-msg function to show the
| > picture only with ".".
| > 
| > Other changes in the new mh-ext.el include having the same
| > keymap in the show buffer as in the folder buffer. Also there
| > are some minor bug-fixes.
| 
| I briefly tried your code this evening (without first uninstalling
| x-face-el so I'm not sure your package was actually handling that part
| yet).
`----

My code does show X-Face in Emacs21 with Oort GNUS (not with
the usual GNUS that comes with emacs).

,----
| 
| There's some very neat MIME handling!  Nice work!
| 
| Some quick comments in Emacs21:
| 
| - Putting the mouse over a MIME part, e.g. "[1. stuff]...", triggered a
|   mouse-over highlight, but there were no mouse buttons active.
| 
`----
(Continue reading)

Peter S Galbraith | 2 May 2002 04:15
Favicon

Re: X-Face and mh-invisible-headers

Satyaki Das <satyakid <at> stanford.edu> wrote:

> ,----
> | Still, it's _very_ interesting work!  Would you be interested in signing
> | the copyright assignment papers for the FSF?
> | 
> `----
> 
> Sure, I can do that.

That's great!  It mean we can really integrate this stuff into mh-e
proper.   :-)

Satyaki Das | 2 May 2002 07:45
X-Face
Picon
Favicon

New version of mh-ext.el


This is the latest version of the MIME viewing extensions for
mh-e. Now you can use the mouse to control the buttons and
some of the bugs that Peter mentioned are fixed.

Satyaki
Attachment (mh-ext.el): application/emacs-lisp, 33 KiB
Peter S Galbraith | 2 May 2002 15:46
Picon
Favicon

Re: New version of mh-ext.el

> This is the latest version of the MIME viewing extensions for
> mh-e. Now you can use the mouse to control the buttons and
> some of the bugs that Peter mentioned are fixed.

Great, I'll try it this evening.
Just a few more comments about your comments.  :-)

> ;;; (add-hook 'mh-show-letter-mode-hook 'goto-address)

See variable mh-show-use-goto-addr

> ;;; ;; To bind "/" in folder-buffer to modify buffer
> ;;; (define-key mh-folder-mode-map "/" 'mh-modify)

Bill objected to my using the / key for something else on the grounds
that it's usually used for 'search' in pagers.  He's right.  We'll have
to come up with a good key sequence.

> ;;; Message modification:
> ;;; ---------------------
> ;;;    After modification is done press C-c C-c to revert to show mode (it
> ;;;    will ask you to save the buffer).
> ;;;
> ;;;    Show mode is read-only and most of the folder commands are available
> ;;;    in the message buffer itself. The macro define-in-mh-folder-buffer
> ;;;    converts a folder buffer function to a show buffer function.

When we were discussing an implementation of MIME handling, we suggested
using a read-only buffer in show-mode that has MIME attachments
converted (as Satyaki has done) and being able to edit the raw message
(Continue reading)

Bill Wohler | 2 May 2002 17:25
X-Face
Picon
Picon
Gravatar

Re: X-Face and mh-invisible-headers

Satyaki Das <satyakid <at> stanford.edu> writes:
> ,----
> | Still, it's _very_ interesting work!  Would you be interested in signing
> | the copyright assignment papers for the FSF?
> | 
> `----
> 
> Sure, I can do that.

  Thanks very much. I've added some specific instructions on doing this
  in:

    http://mh-e.sourceforge.net/doc/devguide.html#SEC3

  Feel free to browse the rest of the document. If you have some
  interest in continuing as an mh-e developer, please consider getting a
  SourceForge account and letting me know.

  Much as I'd like to lead the MIME development, I might have to trust
  my eager colleagues who have a little more time at present than I do
  ;-). Thanks all.

--
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/  GnuPG ID:610BD9AD
Maintainer of comp.mail.mh FAQ and mh-e. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.

Satyaki Das | 2 May 2002 20:00
X-Face
Picon
Favicon

Re: New version of mh-ext.el

,---- Peter S Galbraith <GalbraithP <at> dfo-mpo.gc.ca> writes:
|  
| > ;;; (add-hook 'mh-show-letter-mode-hook 'goto-address)
| 
| See variable mh-show-use-goto-addr
`----

The next version will respect the value of this variable.

,----
| 
| > ;;; ;; To bind "/" in folder-buffer to modify buffer
| > ;;; (define-key mh-folder-mode-map "/" 'mh-modify)
| 
| Bill objected to my using the / key for something else on the grounds
| that it's usually used for 'search' in pagers.  He's right.  We'll have
| to come up with a good key sequence.
`----

Indeed / is usually used for searching not only in pagers but
also in other editors. So something else should be used.

,----
| When we were discussing an implementation of MIME handling, we suggested
| using a read-only buffer in show-mode that has MIME attachments
| converted (as Satyaki has done) and being able to edit the raw message
| when pressing "," instead of ".".
| 
| What Satyaki has done maintains the current difference between "," and
| ".", affecting only the header display.  If you want to edit, you
(Continue reading)

Satyaki Das | 2 May 2002 20:05
X-Face
Picon
Favicon

Re: X-Face and mh-invisible-headers

,---- Bill Wohler <wohler <at> newt.com> writes:
|   Thanks very much. I've added some specific instructions on doing this
|   in:
| 
|     http://mh-e.sourceforge.net/doc/devguide.html#SEC3
| 
|   Feel free to browse the rest of the document. If you have some
|   interest in continuing as an mh-e developer, please consider getting a
|   SourceForge account and letting me know.
`----

I will read the doc and sign up for a sourceforge account.

,----
| 
|   Much as I'd like to lead the MIME development, I might have to trust
|   my eager colleagues who have a little more time at present than I do
|   ;-). Thanks all.
`----

That reminds me that I should be doing real work. Tinkering
with emacs is so much nicer than writing your dissertation :-).

Satyaki

Satyaki Das | 2 May 2002 20:09
X-Face
Picon
Favicon

Re: X-Face and mh-invisible-headers

,---- chad <y <at> mit.edu> writes:
| 
| I have a great personal dislike for graphical smileys (I see them screw
| up inline code examples too often, among other things), so I suggest the
| following simple patch.  I won't object to a different default, and I'm
| sure that we'll eventually want to use defcustom for all of these...
`----

OK, I will add the patch.

Satyaki

Peter S Galbraith | 2 May 2002 20:24
Picon
Favicon

Re: New version of mh-ext.el

> ,---- Peter S Galbraith <GalbraithP <at> dfo-mpo.gc.ca> writes:
> |  
> | > ;;; (add-hook 'mh-show-letter-mode-hook 'goto-address)
> | 
> | See variable mh-show-use-goto-addr
> `----
> 
> The next version will respect the value of this variable.

What I meant is that mh-show-mode already handles it so your hook is no
longer neccessary. It was a comment mostly for your information.

> ,----
> | When we were discussing an implementation of MIME handling, we suggested
> | using a read-only buffer in show-mode that has MIME attachments
> | converted (as Satyaki has done) and being able to edit the raw message
> | when pressing "," instead of ".".
> | 
> | What Satyaki has done maintains the current difference between "," and
> | ".", affecting only the header display.  If you want to edit, you
> | instead go into an editing mode with 'mh-modify and leave it with 
> | C-c C-c.
> `----
> 
> I kind of like current action of seeing full headers with
> ",". I don't feel too strongly about it and wouldn't mind
> if it calls mh-modify instead.

I like the way you have chosen to do it.

(Continue reading)


Gmane